Commit Graph

12714 Commits

Author SHA1 Message Date
Vadim Tryshev 4416c0e95b Merge "Removing unused tracing" into sc-v2-dev am: 72da449f8a am: 502772ad25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15800620

Change-Id: Ic39116b7c3fdb2d2149285194332eb36324f5703
2021-09-15 03:10:01 +00:00
Vadim Tryshev 72da449f8a Merge "Removing unused tracing" into sc-v2-dev 2021-09-15 02:35:04 +00:00
Tony Wickham 48d91ce7ac Reset RecentsView#mNextPage when swiping to home am: d552132d0b am: 46192d288a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15828992

Change-Id: Icd5e85956959c120744b81d7ba57ff586ef0adad
2021-09-15 00:43:30 +00:00
Tony Wickham d552132d0b Reset RecentsView#mNextPage when swiping to home
This ensures that we don't inadvertently update mCurrentPage to be
mNextPage in computeScrollHelper(), which would in turn mess up
calculations such as RecentsView#getHorizontalOffsetSize().

Also removed resetNextPage parameter from forceFinishScroller(), as
resetNextPage was always passed as true anyway.

Test: Swipe up and to the right to home, ensure adjacent page goes all
the way off screen
Fixes: 199927699

Change-Id: Iee1ffac10e5195f0c3a124a23b06d5411ecd7ba2
2021-09-14 14:38:15 -07:00
Vinit Nayak 0b6246f5a0 Merge "Set GroupedTaskView child thumbnails in onMeasure" into sc-v2-dev am: ca549695aa am: 6a976df53e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15822489

Change-Id: Id72a03749351dd6834cb10f4a59fdc02506ccf88
2021-09-14 18:18:12 +00:00
Vinit Nayak ca549695aa Merge "Set GroupedTaskView child thumbnails in onMeasure" into sc-v2-dev 2021-09-14 17:34:52 +00:00
Vinit Nayak e6abfca7ab Set GroupedTaskView child thumbnails in onMeasure
* Also add indicator if split was originally started
in portrait of landscape, so we know which dimension
of the divider bar to use if user goes to overview
and then rotates device (horizontal divider vs
vertical)

Fixes: 199461137
Test: Swipe to overview with staged split
Rotate device with and without live tile
Doesn't overlap with overview actions

Change-Id: I8b7f104f16d5b7265828f1b3d98ba3426b28d44f
2021-09-13 18:07:09 -07:00
TreeHugger Robot adfcd9daea Merge "Introduce haptic when all apps state transition happens." into sc-v2-dev 2021-09-12 22:53:47 +00:00
Hyunyoung Song 862415a142 Introduce haptic when all apps state transition happens.
Bug: 195679234
Test: manual
Change-Id: Id923f1641bb49579c972e3dbb9de094293d00f93
Merged-In: Id923f1641bb49579c972e3dbb9de094293d00f93
2021-09-12 21:48:52 +00:00
Hyunyoung Song eb19a9f7ed Merge "Introduce haptic when all apps state transition happens." 2021-09-12 21:48:10 +00:00
Thiru Ramasamy 8aacb2bf1f Merge "Implement LauncherLayoutSnapshot pulled atom callback." into sc-v2-dev am: 8c8dc56495 am: 70cca3c180
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15685719

Change-Id: I3fa6eec846adafe3df5835491f5f979453d5b197
2021-09-10 23:25:38 +00:00
Thiru Ramasamy 8c8dc56495 Merge "Implement LauncherLayoutSnapshot pulled atom callback." into sc-v2-dev 2021-09-10 22:59:00 +00:00
TreeHugger Robot 55ef1eb76d Merge "Allow restore between TYPE_PHONE AND TYPE_MULTI_DISPLAY in RestoreDbTask" into sc-v2-dev am: f8d4041c84 am: 174d068a11
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15804329

Change-Id: I67c9f4f4754cd2414ebd91e6fc6c1b9759984c4c
2021-09-10 21:23:17 +00:00
TreeHugger Robot f8d4041c84 Merge "Allow restore between TYPE_PHONE AND TYPE_MULTI_DISPLAY in RestoreDbTask" into sc-v2-dev 2021-09-10 20:55:18 +00:00
Thiru Ramasamy d495e8c8b4 Implement LauncherLayoutSnapshot pulled atom callback.
This change will pull only the workspace items but not the launcher settings such as grid layout etc. Future CLs will address it.

Bug: 181703659
Test: Manual-`statsd_testdrive 10108` http://gpaste/4894958784872448
Change-Id: I0e7d7da62034c411edb26ff9205a81b0e2e891a0
2021-09-10 13:29:27 -07:00
TreeHugger Robot d55e248d78 Merge "Explicitly set X and Y values when offsetting split tasks" into sc-v2-dev am: 8b30227f58 am: c36d4c412a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15799376

Change-Id: I02b5f9db5a33391b2d86d93afdafde64a8b8e7d9
2021-09-10 18:41:25 +00:00
TreeHugger Robot 8b30227f58 Merge "Explicitly set X and Y values when offsetting split tasks" into sc-v2-dev 2021-09-10 18:05:18 +00:00
vadimt 4e743887c5 Removing unused tracing
Bug: 181019015
Test: presubmit
Change-Id: I7df032e4345c512ba8eb06a2c4104362e1d51dbd
2021-09-10 10:29:07 -07:00
TreeHugger Robot 0555a36c41 Merge "Fix wrong screenId when committing emptyScreens" into sc-v2-dev am: b94401646d am: 1c0e188171
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15795676

Change-Id: I8accc7c6fe020b2e8ba299cd1f4a57160b8a96d5
2021-09-10 16:12:43 +00:00
TreeHugger Robot b94401646d Merge "Fix wrong screenId when committing emptyScreens" into sc-v2-dev 2021-09-10 15:36:22 +00:00
Alex Chau d63c58d7d1 Allow restore between TYPE_PHONE AND TYPE_MULTI_DISPLAY in RestoreDbTask
- Follow-up of ag/15795679: allow restore in RestoreDbTask as well

Bug: 199407109
Test: manual
Change-Id: I2a8e2d9c28ee777f53a6d3554e31f7318422401f
2021-09-10 15:16:36 +01:00
TreeHugger Robot e6175a210c Merge "Fix two dragging related bugs in Launcher home" into sc-v2-dev am: 81a3e6e7e7 am: 520fb5dc08
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15795684

Change-Id: I62623134ea2cc38d64f51b737db236ab09470373
2021-09-10 14:01:05 +00:00
TreeHugger Robot 81a3e6e7e7 Merge "Fix two dragging related bugs in Launcher home" into sc-v2-dev 2021-09-10 13:39:26 +00:00
Alex Chau 1d5929dd82 Fix wrong screenId when committing emptyScreens
- Need to increment newScreenId whenever the screen is already bound
- Also cleaned up placeholder on w1 as we now have page pairing logic

Bug: 199160559
Bug: 175939730
Fix: 199131780
Test: drag and drop after clear data
Change-Id: Ic42f3bddfa6cf11b8b726d6181ed2477defde19d
2021-09-10 14:36:36 +01:00
Andras Kloczl 9732df1add Fix two dragging related bugs in Launcher home
- accessibility bug: 199394124
- dragging on side bug: http://shortn/_LFBdIllupk

Test: manual
Bug: 199394124
Change-Id: I478e31332119f337bf0f8b6c92926845eb4889c4
2021-09-10 12:16:03 +01:00
Thales Lima eff745a76a Merge "launcher: correct page spacing for multiple panels in RTL" into sc-v2-dev am: 02a5019cf3 am: 5c4e8c1a68
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15795673

Change-Id: I81eb928451631c8be4782cb613bba57d1f362c76
2021-09-10 10:31:03 +00:00
Thales Lima 02a5019cf3 Merge "launcher: correct page spacing for multiple panels in RTL" into sc-v2-dev 2021-09-10 09:53:40 +00:00
Vinit Nayak 6835115c13 Explicitly set X and Y values when offsetting split tasks
* Race condition where DeviceProfile that gets set on
TaskViewSimulator initially has incorrect values
(dp.isLandscape is incorrect)
* The correct one eventually gets set, but in the meantime
we set the split offset assuming in incorrect value in
PagedOrientationHandler#setLeashSplitOffset()
* Once corrected, we weren't removing the old offset
that was set. Now we ensure only either an X or Y offset set.

Bug: 199376724
Test: Enter split, rotate device and quickswitch.
Both tasks should be visible throughout the gesture

Change-Id: I9fa44642ab440a0200c0b0eb9b37574e47b7100d
2021-09-09 16:27:59 -07:00
Tony Wickham 1c12238964 Merge changes I032f7ffc,I384d7af0 into sc-v2-dev am: 94c673c64d am: f5bbbc074e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15788129

Change-Id: I296e5993e25b077cf0c93e1c8345f1cb0f5fe864
2021-09-09 20:53:29 +00:00
Tony Wickham 94c673c64d Merge changes I032f7ffc,I384d7af0 into sc-v2-dev
* changes:
  Add ability to start DeveloperOptionsFragment with filter pre-applied
  Add option to reset Onboarding Flows in Developer Options
2021-09-09 20:09:03 +00:00
TreeHugger Robot 211ddba6a7 Merge "Introduces haptic feedback to launcher overview" into sc-v2-dev am: 8f0de5d711 am: b88bce8bb9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15177217

Change-Id: Ifb0b814f3eddabda54e99f32a5749bdbdd7d919f
2021-09-09 19:57:18 +00:00
Alex Chau c55a64483e Allow restore between TYPE_PHONE AND TYPE_MULTI_DISPLAY am: fef4d0e081 am: f681de8ce3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15795679

Change-Id: Iee98cf89f7c498f0aefdf00ee6be0c8591972af8
2021-09-09 19:57:11 +00:00
TreeHugger Robot 8f0de5d711 Merge "Introduces haptic feedback to launcher overview" into sc-v2-dev 2021-09-09 19:19:26 +00:00
Thales Lima c2a6f6f4ae launcher: correct page spacing for multiple panels in RTL
Fixes 199043583
Test: manual testing in unfolded state in portrait and landscape

Change-Id: Idf5bdabb50742498701681e4654e72260054ab47
2021-09-09 19:13:19 +01:00
Alex Chau fef4d0e081 Allow restore between TYPE_PHONE AND TYPE_MULTI_DISPLAY
Bug: 199407109
Test: manual
Change-Id: I6eb982a79f4130925a9d7e0972faf0f01a6aac20
2021-09-09 18:24:51 +01:00
Lais Andrade cc5c8843df Introduces haptic feedback to launcher overview
Haptics introduced at the key moments:

- Task scroll in overview or quick switch, trigger when a new task comes
to the center of the screen;
- Task scroll in overview when overscroll animation is triggered;
- Task dismissed in overview;

There is also a configured min gap between two scroll haptics set to
20ms to prevent fast scrolls from creating a chain of cancelled effects.

Fix: 182382085
Test: manual
Change-Id: I43c0f8c879a06f317e8a660240dafb7f7abe79f7
2021-09-09 14:08:01 +01:00
Hyunyoung Song 4c63015f46 Introduce haptic when all apps state transition happens.
Bug: 195679234
Test: manual
Change-Id: Id923f1641bb49579c972e3dbb9de094293d00f93
2021-09-09 11:53:07 +00:00
TreeHugger Robot d2eb7705a5 Merge "Slight polish for split screen gesture animation" into sc-v2-dev am: 3f8f61cb40 am: a6d015d41e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15780633

Change-Id: Ie5307ded8aef7e03dc463723ef6602c33477cdeb
2021-09-09 03:48:07 +00:00
TreeHugger Robot 3f8f61cb40 Merge "Slight polish for split screen gesture animation" into sc-v2-dev 2021-09-09 03:17:23 +00:00
Samuel Fufa 86a5fcfc8e Merge "[Work] Fix work apps showing in personal tab" into sc-v2-dev am: 8aecc9ac36 am: 2e4bb875d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15788127

Change-Id: I6f1d81eb6675090941a6028589e0fcb612cbb9db
2021-09-09 01:47:37 +00:00
Samuel Fufa 8aecc9ac36 Merge "[Work] Fix work apps showing in personal tab" into sc-v2-dev 2021-09-09 01:09:01 +00:00
Vinit Nayak d1a70eeb75 Slight polish for split screen gesture animation
* Divider bar dimensions manually calculated since
the leash that is provided has bounds larger than
the space that is visually shown between the two split
apps

Bug: 181704764
Test: Swipe up on large and normal screen,
w/ and w/o home rotation enabled

Change-Id: I1fde053151d47c6ce3e11f16f8ae4a153d273871
2021-09-08 17:39:49 -07:00
TreeHugger Robot 63db45c1d9 Merge "Fix crash when Workspace item is added to two panel home" into sc-v2-dev am: fd744975cc am: 1bde92ca95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15786971

Change-Id: Icc319f23eab7545c196e2b95a5c27e428a63cf7b
2021-09-08 22:31:40 +00:00
TreeHugger Robot fd744975cc Merge "Fix crash when Workspace item is added to two panel home" into sc-v2-dev 2021-09-08 22:09:53 +00:00
Tony Wickham adc40c11fb Don't allow starting DeveloperOptionsFragment on non-debug builds am: a343699760 am: 85435ff751 am: 81aee5e024
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15787659

Change-Id: Ia70df34fcf2715fcb1f8d9459bb7201521542583
2021-09-08 22:03:00 +00:00
Samuel Fufa 564e9ca223 [Work] Fix work apps showing in personal tab
The problem here is that we are tracking hasWorkApps and usingTabs using the same value.
 This leads to work/personal apps showing together when clearing search since mUsingTabs is overridden to false on setLastSearchQuery and later used to determine if tabs should show.
Bug: 198546279
Test: Manual

Change-Id: I7df5d65472703bedcc9dd688847d9ebd146d5f61
2021-09-08 15:02:24 -07:00
Tony Wickham 81aee5e024 Don't allow starting DeveloperOptionsFragment on non-debug builds am: a343699760 am: 85435ff751
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15787659

Change-Id: Ic958cdc3ce8c7e478d6f4eefeec5bb1f87c9ede2
2021-09-08 21:49:46 +00:00
Tony Wickham 9ac2800849 Don't allow starting DeveloperOptionsFragment on non-debug builds am: a343699760
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15787659

Change-Id: I268204c3f0597fb4609437a94efdffcdfdb6b4f0
2021-09-08 21:28:46 +00:00
Tony Wickham 534bd2205b Add ability to start DeveloperOptionsFragment with filter pre-applied
Repurposing EXTRA_FRAGMENT_ARG_KEY to set an initial filter.

Test: adb shell 'am start -n com.google.android.apps.nexuslauncher/com.android.launcher3.settings.SettingsActivity --es ":settings:fragment" "com.android.launcher3.settings.DeveloperOptionsFragment" --es ":settings:fragment_args_key" "Education"'
Bug: 199299382
Change-Id: I032f7ffc373daed51c8d381f3cacf722fb3fb198
2021-09-08 13:51:29 -07:00
Tony Wickham 281786a841 Add option to reset Onboarding Flows in Developer Options
Test: Go to Developer Options, reset Hybrid Hotseat Education, then long press on a predicted hotseat item and ensure edu toast appears
Bug: 199299382
Change-Id: I384d7af08fc8b842bc3a1333b9f8017cca3680e6
2021-09-08 13:51:25 -07:00