Commit Graph

2228 Commits

Author SHA1 Message Date
Ling Wo a83e753c9b Merge "Expose getSearchBox from the HomeAllApps class" into tm-qpr-dev am: 38aa60c38f am: 6dafb0359c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20273481

Change-Id: I75db89675672c9c08a4e48f7ebbc8448aec51a6e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-19 22:44:20 +00:00
Ling Wo 6dafb0359c Merge "Expose getSearchBox from the HomeAllApps class" into tm-qpr-dev am: 38aa60c38f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20273481

Change-Id: Iccad1a308b2c5a022b54013a1750b5db983484d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-19 22:06:55 +00:00
Ling Wo 38aa60c38f Merge "Expose getSearchBox from the HomeAllApps class" into tm-qpr-dev 2023-01-19 21:29:12 +00:00
Sebastián Franco a1707e3007 Merge "Remove unused Throw Throwable from clearHomescreen method" into tm-qpr-dev am: 48651b2109 am: c18a4081d5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20831584

Change-Id: Ie10f728d6e544214f2ac91a209fd500635030a5a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-18 02:29:42 +00:00
Sebastián Franco c18a4081d5 Merge "Remove unused Throw Throwable from clearHomescreen method" into tm-qpr-dev am: 48651b2109
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20831584

Change-Id: I7a3f5ed328fa68a139dd464fd7a672cf910dd36b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-18 01:52:26 +00:00
Sebastián Franco 48651b2109 Merge "Remove unused Throw Throwable from clearHomescreen method" into tm-qpr-dev 2023-01-18 01:12:23 +00:00
Stefan Andonian 6a651e63c9 Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev am: 1eb59d6c6a am: 60e3b74522
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20764866

Change-Id: I7a69b534e3df890034eb897e8d61517e75828702
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-17 19:29:02 +00:00
Stefan Andonian 60e3b74522 Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev am: 1eb59d6c6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20764866

Change-Id: I291aeed8952555e9dd35b4dfe2e1c73db889351a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-17 18:52:00 +00:00
Stefan Andonian 1eb59d6c6a Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev 2023-01-17 18:23:10 +00:00
Sebastián Franco 075bd276ca Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" into tm-qpr-dev am: 519714449f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20838734

Change-Id: Id6707d575fecfeae28b704fd8701c82f4288a9f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-14 01:14:48 +00:00
Stefan Andonian d1b33b311c Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage.
LauncherPrefs will contain Launcher's shared preference functionality.
It controls optimizations and classifications such as restorable vs
non-restorable data, bootaware vs non-bootaware data, and configurations
such as default values  so the calling code doesn't need to and our code
base can have a single source of truth for items that are used in
multiple places.

The old APIs remain in place, but are deprecated and will be removed
after all Shared Preference usage has been gated by LauncherPrefs in
future CLs.

Bug: 261635315
Test: Manually tested themed icon, Workspace configuration, and app
install functionality.

Change-Id: I29fd516468bc93fda393062e95be26b6d55c816e
2023-01-14 00:54:15 +00:00
Sebastian Franco 877088e6c3 Change the access of cellX/Y of CellLayoutLayoutParams to private
Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
Merged-In: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-13 18:25:10 +00:00
Sebastián Franco f55e3690ea Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" 2023-01-12 21:14:23 +00:00
Christophe Pinelli 2acf5a8492 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev am: 3cd6cbe6b4 am: ab2c2d9576
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953789

Change-Id: Iafef3bf70a5dfb0c5a72bf814d23d952cfd7f2f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 20:02:04 +00:00
Christophe Pinelli ab2c2d9576 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev am: 3cd6cbe6b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953789

Change-Id: I251cb1edf4e02cd919225d25c05e2e49f820208d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 19:08:49 +00:00
Sebastian Franco 9db35f7a37 Remove unused Throw Throwable from clearHomescreen method
Test: presubmit
Bug: 263802298
Change-Id: I4b81e044eb4f6a84730fb4d61403cbfcadefd282
2023-01-12 10:41:34 -06:00
Christophe Pinelli 9d46bca1b9 Make mutable PendingIntent explicit
Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.

From a quick analysis, we concluded that the PendingIntent here was only
destined to the test app/to the app, so it was made explicit. Reviewers,
please call out if this is not the case.

Bug: 236704164
Test: atest NexusLauncherTests:com.android.quickstep.DigitalWellBeingToastTest
Test: atest RequestPinItemTest
Change-Id: I81311b0588b7b712c97de6cb016a62bb91c7a77c
2023-01-12 01:51:44 +00:00
Stefan Andonian 53b21fae3b Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev am: fb602d4db7 am: 167d350981
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878611

Change-Id: I7591e1af8af6bcd6b11dea1571668d80ada06201
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:57:55 +00:00
Stefan Andonian 167d350981 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev am: fb602d4db7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878611

Change-Id: I16987862cffc3730518fe14adf61595d62b8faad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:11:16 +00:00
Stefan Andonian 2a58ddb89f Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and
into its own class.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly.

Change-Id: Ifa42dc32f90dfa4fda8df0e52811ddfe20cc5a9b
2023-01-11 19:33:32 +00:00
Treehugger Robot a26bb5cb0f Merge "Assign default bug component for Launcher3" am: e78e42fcf3 am: c72d17fc28 am: fdbf120a04
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2382992

Change-Id: I37e56f95785ba581a1e6e2b198ab097957660a77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 18:17:44 +00:00
Treehugger Robot fdbf120a04 Merge "Assign default bug component for Launcher3" am: e78e42fcf3 am: c72d17fc28
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2382992

Change-Id: Id9dfd686f40cdf673e0fa046d93ae702e859073a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 17:38:11 +00:00
Sebastian Franco a955403ba9 Change the access of cellX/Y of CellLayoutLayoutParams to private
Cherry pick needed for changes on workspace lily

Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-11 15:25:23 +00:00
David Saff c15e2a3a5d Assign default bug component for Launcher3
This is the "Pixel Launcher" component, let me know if another would be more appropriate.

See go/android-codereviews#buganizer-component-links-in-owners for how this is (I believe) used.

Change-Id: I85ff57211616315e08f8e3913707ee34f6055e8a
2023-01-10 19:06:29 +00:00
Thales Lima bdfc07f1f0 Merge "Check kotlin format before uploading" into tm-qpr-dev 2023-01-10 16:41:58 +00:00
Thales Lima 03ac377a34 Check kotlin format before uploading
This uses ktfmt on the PREUPLOAD hook to check file formatting.

Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
Merged-In: I8bdeabd9c1ed571a464707e6912419ad3190a169
2023-01-10 13:24:43 +00:00
Thales Lima 47a40a8bd3 Merge "Check kotlin format before uploading" 2023-01-10 13:23:59 +00:00
Sebastián Franco aeaaef068d Merge "Printing the workspace items to improve flake investigation." into tm-qpr-dev am: b66293e96d am: b1bb6d37d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20680953

Change-Id: I6556acee7b4a44ed4a39aefa749cdfca4f305f26
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-10 00:25:48 +00:00
Sebastian Franco 1328764f1e Removing screen recording for testShortcutIconWithTheme am: 1cf1e3b025 am: 4a1dd0b422
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20913765

Change-Id: Ia76ee43a6ba9c1643f11a12670716b7b4bee5c28
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-10 00:25:14 +00:00
Sebastián Franco b66293e96d Merge "Printing the workspace items to improve flake investigation." into tm-qpr-dev 2023-01-09 23:20:51 +00:00
Sebastian Franco 1cf1e3b025 Removing screen recording for testShortcutIconWithTheme
Bug: 260722220
Test: compiles
Change-Id: I7f5ac09bc7e9deb9af3e90dbd99826bb8c4db11f
2023-01-09 14:19:14 -06:00
Thales Lima 7a3c1e10a7 Check kotlin format before uploading
This uses ktfmt on the PREUPLOAD hook to check file formatting.

Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
2023-01-09 17:45:42 +00:00
TreeHugger Robot 791b4d1962 Merge "Re-enable AddConfigWidgetTest" into tm-qpr-dev am: 2f4a1b9980 am: a64545be52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20683730

Change-Id: I2b5d0a71be067b460aa7aebf546e38130a5d1a47
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-06 22:37:52 +00:00
TreeHugger Robot 2f4a1b9980 Merge "Re-enable AddConfigWidgetTest" into tm-qpr-dev 2023-01-06 21:34:05 +00:00
Sebastian Franco f34f35fddb Printing the workspace items to improve flake investigation.
Recording the screen to investigates flakes on ReorderWidgets
is really useful but it requires changing the code for that and
storing the video and most of the time the useful information
is just the end state so by logging the end state makes resolving
flakes easier

Fix: 261877803
Test: atest ReorderWidgets
Change-Id: If5d9745ebb57826a55b5df9d3599eed56c48298f
2023-01-06 12:29:11 -06:00
TreeHugger Robot f2df42fdca Merge "Revert "Add logging to help debug additional app infos being updated by CacheDataUpdatedTask"" into tm-qpr-dev am: 1973056e40 am: 3c57751362
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20747317

Change-Id: I7c98fa2b687ff8af976b4cffe389afb3d8eb4304
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-05 21:15:58 +00:00
TreeHugger Robot 35f483de1c Merge "Re-enabling testShortcutIconWithTheme" into tm-qpr-dev am: 2825d06382 am: 7e22f8bb79
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20873332

Change-Id: I4bce02d741a462465585d7bb1a297e4c67eae714
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-05 21:15:13 +00:00
TreeHugger Robot 1973056e40 Merge "Revert "Add logging to help debug additional app infos being updated by CacheDataUpdatedTask"" into tm-qpr-dev 2023-01-05 20:04:07 +00:00
TreeHugger Robot 2825d06382 Merge "Re-enabling testShortcutIconWithTheme" into tm-qpr-dev 2023-01-05 19:46:30 +00:00
Sunny Goyal 62ea1f1cb7 Re-enabling testShortcutIconWithTheme
> Updating shortcut id incache the icon cache was the culprit

Bug: 260722220
Test: Verified locally
Change-Id: I0e6bc9b06d1b99e33cb9b1a248647d54bf47dea4
2023-01-04 13:05:42 -08:00
Schneider Victor-tulias 5455b85291 Revert "Add logging to help debug additional app infos being updated by CacheDataUpdatedTask"
This reverts commit 62511de74e.

Reason for revert: bug not reproducing

Fixes: 20747317
Change-Id: I55c1fe8005fee66db53052aab15e152e6d39a34c
2023-01-04 18:27:00 +00:00
vadimt 6dde898959 Ignoring failing out-of-SLO test am: d9ca71b1d9 am: bafcbaa216
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20861031

Change-Id: Icaa5de20e160e4b0decb50cf5773af84b6bb2686
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-04 01:12:43 +00:00
vadimt d9ca71b1d9 Ignoring failing out-of-SLO test
Test: presubmit
Bug: 243855320
Change-Id: I7795bdae6b30cd663fa4e6cbba118d84d57ec96d
2023-01-03 12:46:43 -08:00
Luca Zuccarini b25ea2d33f Add Tapl support for swiping from All Apps to Workspace. am: 55d828b6f5 am: 242eeea4ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20551691

Change-Id: Idff9df5162ef48783beb8eb6662838948b8d2d90
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-27 15:01:14 +00:00
Luca Zuccarini 55d828b6f5 Add Tapl support for swiping from All Apps to Workspace.
This mirrors the way we swipe from Workspace to All Apps, with minor
differences for selecting the start position of the swipe motion.

Bug: 260218332
Test: included
Change-Id: I9fe2284b1c920ebed87a6bab3dfc9c8c29aa2d5d
2022-12-21 15:38:51 +00:00
Vadim Tryshev e896d66fd6 Merge "Not waiting for animations for Launcher clicks" into tm-qpr-dev am: e74238d233 am: 0a2ed6c078
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20790706

Change-Id: I74eb64251c91c37746f32ff4e25920447427a395
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-20 22:28:28 +00:00
Ling Wo 8ba48c1e65 Expose getSearchBox from the HomeAllApps class
Doc: https://docs.google.com/document/d/1OlN-A3Z5_UjWk-QkxC4JaYWesFDNHkHTox94__rLmR0

Bug: b/255390519
Test: local testing
Change-Id: I72410035bbcfd2215815dbf6c3d6bd86d692b8c6
2022-12-20 04:13:59 +00:00
vadimt befcfa40b9 Not waiting for animations for Launcher clicks
Waiting for animations to finish can make the test wait for too long if there is an ongoing animation somewhere, for example, in an app we are trying to swipe from.

Test: presubmit
Bug: 256567004
Change-Id: Ida494128a18342bee3dbdae6d713c854c86912c1
2022-12-19 18:02:07 -08:00
Sihua Ma 45149d9036 Merge "Add QuickstepWidgetHolder for widget handling" into tm-qpr-dev am: 04c89fe38e am: f8ab32a8bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20418248

Change-Id: I8cc2d48f94aaa415fb7b9bd8137502b27de33d5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-19 19:55:49 +00:00
Sihua Ma 04c89fe38e Merge "Add QuickstepWidgetHolder for widget handling" into tm-qpr-dev 2022-12-19 18:22:38 +00:00