Commit Graph

2624 Commits

Author SHA1 Message Date
Sunny Goyal 7b9e28f152 Removing all usage of LauncherProvider
Also fixing a race condition in model when an item update/delete task
gets queued and executed after the model has reloaded (making the old
data obsolete)

Bug: 277345535
Bug: 263079498
Test: Presubmit
Flag: N/A
Change-Id: Ibd4bdbb3eece05b38b73a22a4be5f368df3754f0
2023-06-07 12:57:13 -07:00
TreeHugger Robot 859d0d87e2 Merge "Simplifying some test utility methods" into udc-qpr-dev 2023-06-05 23:10:06 +00:00
Sunny Goyal 6773667e34 Revert "Revert "Adding main thread binder tracing in development..."
Revert submission 23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Reason for revert: Fixed broken build
Reverted changes: /q/submissionid:23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Change-Id: I3e130a780b8641c4a17a5cdf799513f2ba08b16e
2023-06-02 18:14:35 -07:00
TreeHugger Robot 3b7285f61c Merge "Revert "Adding tracing for workspace loading that never finishes"" into udc-dev am: 4ad5ffd0a1 am: ef529447b2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23537958

Change-Id: I774fa87ee58d684ab27114a68354ffd42538077c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 20:26:50 +00:00
TreeHugger Robot 4ad5ffd0a1 Merge "Revert "Adding tracing for workspace loading that never finishes"" into udc-dev 2023-06-02 18:59:47 +00:00
Vadim Tryshev d8b470cf2f Revert "Adding tracing for workspace loading that never finishes"
This reverts commit 80bb8a12da.

Reason for revert: Cleanup after the bug is fixed. Tracing is not necessary anymore.

Change-Id: I1bb2bc59dd5debb51b094f14430cd18a203ed33c
2023-06-02 15:28:18 +00:00
Sunny Goyal ee9740462e Simplifying some test utility methods
Bug: 283821111
Test: Presubmit
Flag: N/A
Change-Id: I7b9690bc0cc53d097d26cd4f0ab2dd36ba88e1cb
2023-06-02 13:30:55 +00:00
Santiago Aboy Solanes 0edac04688 Merge "Revert "Adding main thread binder tracing in development build."" into udc-qpr-dev 2023-06-02 09:06:26 +00:00
Santiago Aboy Solanes ee846feb80 Revert "Adding main thread binder tracing in development build."
Revert submission 23482347-launcher-binder-tracing

Reason for revert: Broken Build 10242119 on git_master on errorprone b/285434612

Reverted changes: /q/submissionid:23482347-launcher-binder-tracing

Change-Id: Id9726474265e839a59d6eb34822e7a86d40f0fc9
2023-06-02 08:59:28 +00:00
Anushree Ganjam 87cb7ad06a Merge "Add UID in AppInfo." into udc-dev am: 9b4f62e681 am: eb9cd7e26e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23331302

Change-Id: I2bfbbf5fd5ec777baca79d89c13204857e600f8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 01:46:38 +00:00
Anushree Ganjam 9b4f62e681 Merge "Add UID in AppInfo." into udc-dev 2023-06-02 01:17:29 +00:00
Anushree Ganjam 97434eea53 Add UID in AppInfo.
Create a reverse hashmap of PackageUserKey to Uid in AllAppsStore for
faster lookup of uid based on packageName and userHandle.

Log Uid in Impression Logging.

Bug: 282849559
Test: Manual. See various usecases documented in http://shortn/_UcvAYOmLIP
Flag: NA

Change-Id: I416426214f6b6efc45f7d4c0433bbbfca9056adf
2023-06-01 22:45:19 +00:00
Sunny Goyal cbb13841f5 Merge "Revert "Add hover state border line to overview task item by usi..."" into udc-qpr-dev 2023-06-01 21:39:15 +00:00
Sunny Goyal 8dbdd3d702 Revert "Add hover state border line to overview task item by usi..."
Revert submission 23378417-cherrypick-overview-border-249859410-786docmioso

Reason for revert: flaky implementation

Reverted changes: /q/submissionid:23378417-cherrypick-overview-border-249859410-786docmioso

Change-Id: I6792fc25dbbd80db24df93ebd7a974b0dc0ba5d5
2023-06-01 21:29:13 +00:00
Sunny Goyal 50c9126cc3 Merge "Adding main thread binder tracing in development build." into udc-qpr-dev 2023-06-01 17:27:21 +00:00
Sunny Goyal 3db98b1152 Adding main thread binder tracing in development build.
> Unifying multiple binder tracing implementations
> Removing wallpaper customization check as it has been rolled out
  few years ago, this avoids additional RPC to check for wallpaper
> Removing RaceConditionReproducer as it is not used anywhere and
  is not integrated with this tracing anymore

Bug: 273718665
Test: Presubmit
Flag: N/A
Change-Id: I801af5d039a9d38d5d39e803723ec6da50a9d59f
2023-06-01 09:39:50 -07:00
Helen Cheuk ed4c2acf58 Merge "Add hover state border line to overview task item by using the same approach used by keyboard focus state" into udc-qpr-dev 2023-06-01 15:45:01 +00:00
Treehugger Robot 77b9c764b8 Merge "Removing memory object checks based on "dumpsys meminfo"" into udc-dev am: c0f24b4e7e am: 243011384c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23421682

Change-Id: I24e31426f5973cd04c6737ee452d45370a3acc80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 00:53:50 +00:00
Treehugger Robot c0f24b4e7e Merge "Removing memory object checks based on "dumpsys meminfo"" into udc-dev 2023-05-31 23:11:53 +00:00
TreeHugger Robot f95fca0f5d Merge "Insert a check that keyguard is invisible into waitForLauncherCondition" into udc-dev am: db7009544e am: 03d0cd83a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23441208

Change-Id: Ib4549e9712251a6c9eb85dfb5229d2d7addc4482
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 21:26:42 +00:00
TreeHugger Robot db7009544e Merge "Insert a check that keyguard is invisible into waitForLauncherCondition" into udc-dev 2023-05-31 20:00:08 +00:00
helencheuk 64975ae992 Add hover state border line to overview task item by using the same approach used by keyboard focus state
Reviewed TAPL DD: https://docs.google.com/document/d/1OmCLgTDw3gFOMXjEvH0W1XoAe0n2J5pPdyMcAHtflMA/edit?resourcekey=0-bXle-rOnQqOR_RJBffRybQ
Fix: 249859410
Test: OverviewTaskImageTest

Change-Id: Ic9ce4e9fe90f38a4bf4be6c7deed302a12a3192a
2023-05-30 21:30:14 +01:00
Stefan Andonian 55d0d21040 Merge "Revert "Keep ViewCaptureRule logic self-contained."" into udc-dev am: 57eaf86f8d am: fc7e8fa4c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23454664

Change-Id: I0da767add8247c3530af0a26e965d6830018ef75
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 19:02:56 +00:00
TreeHugger Robot 7ae39b1bee Merge "Add logs to see if launcher model isn't loaded when work profile app is added" into udc-dev am: 78b6e76486 am: dcf359c459
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23455279

Change-Id: I0409212df4be2e1554a6a489c65453d65e9e78c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 19:02:32 +00:00
Stefan Andonian 4439bec7aa Merge "Use LockedUserState in TouchInteractionService." into udc-qpr-dev 2023-05-30 18:55:02 +00:00
Stefan Andonian 57eaf86f8d Merge "Revert "Keep ViewCaptureRule logic self-contained."" into udc-dev 2023-05-30 17:49:54 +00:00
TreeHugger Robot 78b6e76486 Merge "Add logs to see if launcher model isn't loaded when work profile app is added" into udc-dev 2023-05-30 17:26:53 +00:00
Alex Chau 6565b68168 Merge "Add Portrait/Landscape support for NexusLauncher screenshot tests" into udc-qpr-dev 2023-05-30 15:54:10 +00:00
Vinit Nayak 2c353f29a2 Add logs to see if launcher model isn't loaded when work profile app is added
* Add helper method to avoid checking sDebugTracing when
logging for tests

Bug: 243688989
Flag: None
Change-Id: Id6cc3b286171eb598e593c5a8aaea6f2466aad60
2023-05-26 15:45:42 -07:00
Stefan Andonian 0a8fab01da Revert "Keep ViewCaptureRule logic self-contained."
This reverts commit eec7a9d90f.

Reason for revert: Failing tests.

Change-Id: Idf16453bbd7f0ace17d8e80d3303fae26b50333b
2023-05-26 21:11:41 +00:00
Stefan Andonian cf36a3f3a8 Use LockedUserState in TouchInteractionService.
This change was previously attempted, but failed because of a tricky issue where the LockedUserState singleton object was getting permanently set to a mock context in LockedUserStateTest, and then was failing TaplTests because isUserUnlocked was always false.

This fixes that by avoiding using the singleton LockedUserState instance in the unit tests.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly. Post-submit was tested and this CL passed all previously
failing tests: https://android-build.googleplex.com/builds/abtd/run/L12900000960898179

Change-Id: I045c9f2558a6bdacb4bfa029fbf6a07c3c190fe7
2023-05-26 17:06:09 +00:00
vadimt ee77946a7f Insert a check that keyguard is invisible into waitForLauncherCondition
This will unify diagnostics because otherwise waitForLauncherCondition would fail with a different message if keyguard is present.

Test: presubmit
Bug: 187761685
Flag: N/A
Change-Id: I1a34b4c2ad859b87263733a8a65527b8357e1950
2023-05-25 17:44:34 -07:00
Stefan Andonian 6d8f3bfd61 Merge "Keep ViewCaptureRule logic self-contained." into udc-dev am: 9678d9470c am: 12b89ef14f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23402041

Change-Id: If28ea0288770e9c4ea6e2b84c74a8adb5493e813
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-26 00:43:27 +00:00
Stefan Andonian 9678d9470c Merge "Keep ViewCaptureRule logic self-contained." into udc-dev 2023-05-25 22:53:28 +00:00
Vadim Tryshev ecbad7a0d9 Merge "Adding tracing for workspace loading that never finishes" into udc-dev am: 8cf338148b am: 304ecb6f24
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23414622

Change-Id: I0aedfb1de537ea8bf56ecc69a6920bf649b4b88d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-25 18:41:38 +00:00
Stefan Andonian eec7a9d90f Keep ViewCaptureRule logic self-contained.
This will make it easier for other apps / processes to integrate the
ViewCapture logic into their integrated testing frameworks.

Bug: 270158224
Test: Verified that a zip file was generated properly and was able to be
loaded into go/web-hv properly.

Change-Id: Ib3e4a0b60497937b750126590071884882b22917
2023-05-25 17:59:46 +00:00
Vadim Tryshev 8cf338148b Merge "Adding tracing for workspace loading that never finishes" into udc-dev 2023-05-25 17:17:50 +00:00
Hui Kang 202fcdfeaf Merge changes from topic "Annotate Platinum Test" into udc-dev am: 879d746de7 am: c8222a548e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23404501

Change-Id: I21c07dcef67d73c418229d175267998285293bc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-25 16:49:06 +00:00
Hui Kang 2e5da30386 [4/7]Add PlatinumTest annotation to tests am: 5bde3f8573 am: f4c8a29eac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23395253

Change-Id: I4ae5b30382e745ad6f491525819b3fae3f875c27
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-25 16:49:02 +00:00
Hui Kang f4c8a29eac [4/7]Add PlatinumTest annotation to tests am: 5bde3f8573
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23395253

Change-Id: I7909d9b59e524904f6632fdab92012db3ea49541
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-25 16:33:30 +00:00
Hui Kang 879d746de7 Merge changes from topic "Annotate Platinum Test" into udc-dev
* changes:
  [3/7]Add PlatinumTest annotation to tests
  [4/7]Add PlatinumTest annotation to tests
2023-05-25 16:04:10 +00:00
Jordan Silva aac286af4f Add Portrait/Landscape support for NexusLauncher screenshot tests
Updating @PortraitLandscape annotation to be public to allow its usage by modules implementing Launcher3 and AbstractLauncherUiTest and interop with Kotlin.

Bug: 283751050
Flag: N/A
Test: atest HomeScreenEditStateImageTest
Change-Id: I84e1210c0476a3b3f9b40bbb6ee6b46a44b752ff
2023-05-25 02:25:19 +01:00
vadimt efe75cecad Removing memory object checks based on "dumpsys meminfo"
This "dumpsys meminfo" can return phantom references that we have no control over and that can break all counting.

Given that the removed code haven't found issues in the past, and that we have Launcher activity counting implemented via TestProtocol.REQUEST_GET_ACTIVITIES, removing all "dumpsys meminfo" code.

Test: presubmit
Bug: 260260325
Flag: N/A
Change-Id: Ic80a6145d76d7cddfedad5328cb141a955b1eaf5
2023-05-24 18:06:19 -07:00
vadimt 80bb8a12da Adding tracing for workspace loading that never finishes
Test: presubmit
Bug: 267200150
Flag: N/A
Change-Id: I6cfe6be101412e9d8d9498fc06c70d1d14561441
2023-05-24 10:25:15 -07:00
Hui Kang 0928ab0811 [3/7]Add PlatinumTest annotation to tests
These tests already have IwTest annotation. The IwTest tests will be merged with platinum tests using the PlatinumTest annotation. The IwTest annotation will be deprecated and removed.

Test: make
Bug: 283409062
Change-Id: Idee826a228070bdad26e9520c7b59c4df970f717
2023-05-24 01:21:46 +00:00
Hui Kang 5bde3f8573 [4/7]Add PlatinumTest annotation to tests
These tests are in the audited platinum suite (go/platinum-audit-flake)

Test: make
Bug: 283409062
Change-Id: Id438fde00b2a6e31694bef125d20637af514b9da
2023-05-24 01:17:18 +00:00
Winson Chung fed4662478 Merge "Removing legacy launcher winscope tracing for tests" into udc-dev am: 883871e280 am: 395ed225a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23384355

Change-Id: I235ed03d74f0317a17249dfc19bbdf47fa580416
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-23 19:59:28 +00:00
Thales Lima ec06cd1039 Merge "Create TAPL test for taskbar in overview" into udc-dev am: ac206e1daf am: dd2c541ffe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23155127

Change-Id: Id3659cc04359e2cdf0efca8ab2b5e7ae286696cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-23 19:58:12 +00:00
Winson Chung 883871e280 Merge "Removing legacy launcher winscope tracing for tests" into udc-dev 2023-05-23 18:47:40 +00:00
Thales Lima ac206e1daf Merge "Create TAPL test for taskbar in overview" into udc-dev 2023-05-23 18:32:34 +00:00