Commit Graph

9079 Commits

Author SHA1 Message Date
Fedor Kudasov 41edede1ee Simplify getTaskViewAt call
RecentsView getTaskViewAt method is nullable and is safe
to call for an out of bound index.

Bug: N/A
Test: m LauncherGoResLib
Change-Id: I7709d63ad4490fd756a50caaf42ba70c4fad4d06
2021-11-11 16:55:18 +00:00
Fedor Kudasov 990256cf44 Merge "Annotate AttributeSet with @Nullable" 2021-11-11 08:15:39 +00:00
Vinit Nayak 86f80f4625 Merge "Finish recents animation for app-icon tap" into sc-v2-dev am: 185da72e98 am: f9ed2a09d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16223705

Change-Id: Id54c503718fb06f0b8d1ea6e3956533e9bb7e3a1
2021-11-11 06:33:49 +00:00
Vinit Nayak f9ed2a09d1 Merge "Finish recents animation for app-icon tap" into sc-v2-dev am: 185da72e98
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16223705

Change-Id: Icfaddc538c171f09a65efd0d82bb869228518c44
2021-11-11 06:22:34 +00:00
Vinit Nayak 185da72e98 Merge "Finish recents animation for app-icon tap" into sc-v2-dev 2021-11-11 06:03:47 +00:00
Ryan Lin 29cb975748 Merge "Fix the cutout of magnification border" into sc-v2-dev am: b6e3caeb7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16214743

Change-Id: I8f9abdbee71c100dde4c6403158732922a809c56
2021-11-11 02:01:39 +00:00
Ryan Lin b6e3caeb7a Merge "Fix the cutout of magnification border" into sc-v2-dev 2021-11-11 01:56:21 +00:00
TreeHugger Robot cc4438ac0b Merge "launcher: use a different task menu for foldables" into sc-v2-dev am: 0aadbc6b37 am: 3945fd8f4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16214330

Change-Id: Ife3cc0d3a23a048495d275b8225d64c32af7743b
2021-11-10 20:29:04 +00:00
TreeHugger Robot 3945fd8f4c Merge "launcher: use a different task menu for foldables" into sc-v2-dev am: 0aadbc6b37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16214330

Change-Id: I46f180584f6abb122adbb290e6a128151509c07c
2021-11-10 20:17:36 +00:00
TreeHugger Robot 0aadbc6b37 Merge "launcher: use a different task menu for foldables" into sc-v2-dev 2021-11-10 19:45:36 +00:00
Vinit Nayak 2db58f68ee Finish recents animation for app-icon tap
* There is a layering issue w/ live tile
* Also, order tasks for app-pair when binding

Bug: 205354856
Change-Id: I4fb5b9ed070e96299fd4b58d172ebba93789d009
2021-11-10 10:21:02 -08:00
Winson Chung 62e7536e5a Merge "Support multiple tasks in recentsaninmation onTaskAppeared" into sc-v2-dev am: 7ce4af988b am: 5e48eac33e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16184047

Change-Id: I9439b1874246f2ab75bfcb34babab2bd4d6ea268
2021-11-10 17:40:14 +00:00
Thales Lima c335ad28a2 launcher: use a different task menu for foldables
Foldables use a different menu from phones, positioned either to the
right or left of the app icon, and display an arrow. Since TaskMenuView
is very specific for handhelds, it was cleaner to create another class
to handle foldables case extending from ArrowPopup.

This creates a working menu, the correct style will come in later CLs.

Bug: 193432925
Test: open Overview and tap the app icon

Fixes: 205298731
Test: atest NexusLauncherTests

Change-Id: I7a5c1fb4800a309f40fadb2df0f6c3a4c3f42679
2021-11-10 17:30:13 +00:00
Winson Chung 5e48eac33e Merge "Support multiple tasks in recentsaninmation onTaskAppeared" into sc-v2-dev am: 7ce4af988b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16184047

Change-Id: I5c10d44cd48b423a38893138ff410b68a1816b62
2021-11-10 17:28:05 +00:00
Winson Chung 7ce4af988b Merge "Support multiple tasks in recentsaninmation onTaskAppeared" into sc-v2-dev 2021-11-10 17:05:46 +00:00
Vinit Nayak 0061ab1f4d Merge "Shows AppPairs in previous tasks" into sc-v2-dev am: 524d6b83e9 am: d9d4ef59ac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16134803

Change-Id: Icc5fa4343fa983b5b79c1f421f0410a500082bc7
2021-11-10 17:00:34 +00:00
Vinit Nayak d9d4ef59ac Merge "Shows AppPairs in previous tasks" into sc-v2-dev am: 524d6b83e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16134803

Change-Id: I244d0877336d28d6d76a5c45c78811bfc662755b
2021-11-10 16:46:23 +00:00
Vinit Nayak 524d6b83e9 Merge "Shows AppPairs in previous tasks" into sc-v2-dev 2021-11-10 16:33:50 +00:00
Fedor Kudasov 96f8792c04 Annotate AttributeSet with @Nullable
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: Ib8584e1bbcc7061aef2eb4813a8f6aa41d3c7362
2021-11-10 15:26:08 +00:00
TreeHugger Robot eecaf1f5aa Merge "Don't skip adding stub home task if applyLoadPlan hasn't run" into sc-v2-dev am: e4f6f951da am: d354341d30
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16221737

Change-Id: I50ddb396c9e5545055553cbbd53637cbddec24b7
2021-11-10 10:09:49 +00:00
ryanlwlin 1ee6bd7bb6 Fix the cutout of magnification border
If the window is unmagnifiable, it might cause the cutout of
magnification region.
To fix it, we set the flag when the touchable region is not the
entier window frame.

To fix NexusLauncherTests, we add a flag to avoid updateViewLayout
too frequently that would impact memory test and have the performance
issue.

Bug: 196510717
Test: manual test on gestural and 3-button navigation
      presumbit test pass
      run atest NexusLauncherTests with foldables
Change-Id: Ifef81640fe6c08ee1b0dcd3915227fba3002ea43
Merged-In: Ifef81640fe6c08ee1b0dcd3915227fba3002ea43
(cherry picked from commit c8d588cff6)
2021-11-10 09:51:54 +00:00
TreeHugger Robot d354341d30 Merge "Don't skip adding stub home task if applyLoadPlan hasn't run" into sc-v2-dev am: e4f6f951da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16221737

Change-Id: I1e40e55d97207031c416d1ea99abc6a63d93e466
2021-11-10 09:51:06 +00:00
Ryan Lin e19039cc69 Merge "Fix the cutout of magnification border" 2021-11-10 02:16:39 +00:00
Vinit Nayak 4d57e7091f Shows AppPairs in previous tasks
Fixes: 203006080
Change-Id: I63912a61e7617ec41f229c19cc267dc5a1857bae
2021-11-09 13:47:18 -08:00
Alex Chau 7c4bc7dd74 Don't skip adding stub home task if applyLoadPlan hasn't run
- In FallbackRecentsTest.goToOverviewFromHome, home task gesture starts before applyLoadPlan, causing shouldAddStubTaskView to return false because getTaskViewCount is 0. This falsely avoid home task to be added to RecentsView, causing the animation to be drastically different from what user sees outside the test
- Added a check on whether applyLoadPlan is ever called to solve the problem

Fix: 205580523
Test: FallbackRecentsTest.goToOverviewFromHome
Change-Id: I2e435e56008e916e8f7e1037d3fa3c8177437d13
2021-11-09 19:01:23 +00:00
TreeHugger Robot abc00984f2 Merge "Fix a case that task jump when dismissing" into sc-v2-dev am: 055d9a5f07 am: 690bd9c527
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16194618

Change-Id: I48f8ef4dd29940960a1da80a0e8728603eec9ff7
2021-11-09 16:38:25 +00:00
TreeHugger Robot 690bd9c527 Merge "Fix a case that task jump when dismissing" into sc-v2-dev am: 055d9a5f07
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16194618

Change-Id: Ia76826d79488d3fcf11d100206456a69d09a81e1
2021-11-09 16:16:58 +00:00
TreeHugger Robot 055d9a5f07 Merge "Fix a case that task jump when dismissing" into sc-v2-dev 2021-11-09 16:03:45 +00:00
ryanlwlin c8d588cff6 Fix the cutout of magnification border
If the window is unmagnifiable, it might cause the cutout of
magnification region.
To fix it, we set the flag when the touchable region is not the
entier window frame.

To fix NexusLauncherTests, we add a flag to avoid updateViewLayout
too frequently that would impact memory test and have the performance
issue.

Bug: 196510717
Test: manual test on gestural and 3-button navigation
      presumbit test pass
      run atest NexusLauncherTests with foldables
Change-Id: Ifef81640fe6c08ee1b0dcd3915227fba3002ea43
2021-11-09 14:17:48 +08:00
TreeHugger Robot e93ed69a30 Merge "Fixing allSet page not closed if recentsAnimation takes time to start" into sc-v2-dev am: ef18f8c5a2 am: ff75c4fe78
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16200930

Change-Id: Ia7eabd1f8317146eba56f47f16f40bb43c8a952e
2021-11-09 02:22:22 +00:00
TreeHugger Robot ff75c4fe78 Merge "Fixing allSet page not closed if recentsAnimation takes time to start" into sc-v2-dev am: ef18f8c5a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16200930

Change-Id: Ie168c6b5d955b9839f6d48b3204d9f62ed67cd90
2021-11-09 01:57:46 +00:00
Evan Rosky e4102c6ffe Support multiple tasks in recentsaninmation onTaskAppeared
Needed for app-pairs support

Bug: 204094785
Test: TODO
Change-Id: I3c5f8097b04b4033ba887e3c6d9e5ffd900df80e
2021-11-08 17:40:13 -08:00
TreeHugger Robot ef18f8c5a2 Merge "Fixing allSet page not closed if recentsAnimation takes time to start" into sc-v2-dev 2021-11-09 01:35:48 +00:00
TreeHugger Robot cd17e997f2 Merge "Play fallback animation when overlay is shown." into sc-v2-dev am: 44fcfa5bfd am: c6aa4b006a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16202910

Change-Id: Ia4fd2252ce84dd4a8ebca7c34060a54fa2f1eb57
2021-11-08 21:18:27 +00:00
TreeHugger Robot 06af9641b2 Merge "Add temporary logging to try and debug: b/202414125" into sc-v2-dev am: c010ea2f1b am: 71d7627105
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16200933

Change-Id: I9212815cf8784439a21a7910a6105f650d53baeb
2021-11-08 21:18:11 +00:00
TreeHugger Robot c6aa4b006a Merge "Play fallback animation when overlay is shown." into sc-v2-dev am: 44fcfa5bfd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16202910

Change-Id: I08c3abb11c6c9926b1fd8e4af177e092ad20ec44
2021-11-08 20:57:04 +00:00
TreeHugger Robot 71d7627105 Merge "Add temporary logging to try and debug: b/202414125" into sc-v2-dev am: c010ea2f1b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16200933

Change-Id: I706962ed79c20c10f85f0760faaa3ba60764ce2d
2021-11-08 20:56:56 +00:00
TreeHugger Robot 44fcfa5bfd Merge "Play fallback animation when overlay is shown." into sc-v2-dev 2021-11-08 20:49:58 +00:00
TreeHugger Robot c010ea2f1b Merge "Add temporary logging to try and debug: b/202414125" into sc-v2-dev 2021-11-08 20:33:00 +00:00
TreeHugger Robot 5d6396066a Merge "Add to tapl quickswitch test for testing intermediate carousel." into sc-v2-dev am: 3555ef3b31 am: 6bef61cb68
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16118650

Change-Id: Icc6cd0182ad47616042eb68bf8550e302df20856
2021-11-08 17:28:29 +00:00
Jerry Chang 8489592183 Merge "Accept snapshot list when cancelling recents animation" into sc-v2-dev am: 2e2f49e8a5 am: ccfa6603a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16192191

Change-Id: Iaf49ae6959fcf54e66f8629e668a342e920e30ea
2021-11-08 17:27:16 +00:00
Alex Chau 5885b074dc Fix a case that task jump when dismissing
- Fixed an edge case that RecentsView was not snapped to last tasks, but become snapped to last tasks after dismiss, as last pages' scroll is the position where ClearAllButton is barely invisible, instead of aligned to mLastComputedTaskSize.
- Fixed a case that misclassifed as split select

Fix: 202941373
Test: manual
Change-Id: Ib50dda471189da4325cd8ed57d600cc64907c978
2021-11-08 16:57:38 +00:00
TreeHugger Robot 6bef61cb68 Merge "Add to tapl quickswitch test for testing intermediate carousel." into sc-v2-dev am: 3555ef3b31
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16118650

Change-Id: I1e6a4b81d0c4f8865f84c4252887d0e16ec310af
2021-11-08 13:31:17 +00:00
TreeHugger Robot 8ce34e46fb Merge "Add to tapl quickswitch test for testing intermediate carousel." into sc-v2-dev am: 3555ef3b31
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16118650

Change-Id: I8f216d791f5b39552591f34db06966921db9b7e7
2021-11-08 13:30:34 +00:00
TreeHugger Robot 3555ef3b31 Merge "Add to tapl quickswitch test for testing intermediate carousel." into sc-v2-dev 2021-11-08 13:15:44 +00:00
Pat Manning 04486f19bb Add to tapl quickswitch test for testing intermediate carousel.
Test: TaplTestsQuickstep.java
Fix: 197630182
Change-Id: I5f325995e22b76eee710154ca54a050eaf70b150
2021-11-08 11:32:56 +00:00
Jerry Chang 68f7c965b4 Merge "Accept snapshot list when cancelling recents animation" into sc-v2-dev am: 2e2f49e8a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16192191

Change-Id: I6a316c2378fc10cf0d6a04e258192e174ceeb8bb
2021-11-08 10:39:13 +00:00
Jerry Chang ccfa6603a9 Merge "Accept snapshot list when cancelling recents animation" into sc-v2-dev am: 2e2f49e8a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16192191

Change-Id: I5f8baffb5ef8d7596ea8e20727630b9b17aa871a
2021-11-08 10:39:08 +00:00
Jerry Chang 2e2f49e8a5 Merge "Accept snapshot list when cancelling recents animation" into sc-v2-dev 2021-11-08 10:22:34 +00:00
TreeHugger Robot c2f320703c Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-11-08 02:32:52 +00:00