Commit Graph

760 Commits

Author SHA1 Message Date
Li Lin 4a947f8209 Growth Framework nudge resource changes.
These resources changes will be used in a follow up CL that implement
the nudge view.

Note that most of the values and layout are temporarily placeholder and  subject
to change in follow up CL as the mock is being finalized.

Bug: 398033012
Test: Manual
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: I1d88da404637200b44bd2a3a5719f52d68011fbf
2025-03-25 19:58:52 -07:00
Alex Chau 7034889756 Revert "Remove redundant FrameLayout from task_header_view.xml"
Revert submission 32215257-b/401469907-remove-redundant-headerview-layout

Reason for revert: b/403826044, b/402277471

Reverted changes: /q/submissionid:32215257-b/401469907-remove-redundant-headerview-layout

Change-Id: I5c619179c849f8b65484937ed0c37623612316f8
2025-03-20 11:11:00 +00:00
Priyanka Advani (xWF) 92aef0d99a Revert^3 "Inflate TaskThumbnailViewDeprecated as TaskContentView"
This reverts commit bca368924c.

Reason for revert: Droidmonitor created revert due to b/404894013. Will be verifying through ABTD before submission.

Change-Id: If43e23bca9f7e62f26ee3c977cac643fcda3e3e6
2025-03-19 12:56:55 -07:00
Sam Cackett bca368924c Revert^2 "Inflate TaskThumbnailViewDeprecated as TaskContentView"
This reverts commit 1048b2711c.

Reason for revert: Reland CL with fix

Original message:
Inflate TaskThumbnailViewDeprecated as TaskContentView

If the enableRefactorTaskThumbnail is false, then inflate
TaskThumbnailViewDeprecated as TaskContentView so that the behaviour
matches the previous pre-factor behaviour

Fix: 402277471
Bug: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual. See bug

Change-Id: Ib43331023d99316c7b0c9de2ab81e379db58bb50
2025-03-19 10:05:25 -07:00
Sunny Goyal d7a1c17988 Merge "Moving LauncherAppWidgetHolder to dagger" into main 2025-03-17 10:42:15 -07:00
Mady Mellor 3894947741 Merge "Update dragged elevation to use shared value (at 3dp)" into main 2025-03-14 16:10:01 -07:00
Jagrut Desai 56a8bf548f Merge "Taskbar Icon changes" into main 2025-03-14 14:29:08 -07:00
Sunny Goyal 66916cda10 Moving LauncherAppWidgetHolder to dagger
This would allow customizing the widget holder in LauncherPreview

Bug: 361850561
Test: Updated tests and presubmit
Flag: EXEMPT dagger
Change-Id: I32491169188992453693048986c57cb780fdf1d8
2025-03-14 14:19:29 -07:00
Mady Mellor 609f2b3143 Update dragged elevation to use shared value (at 3dp)
- Had to bump elevation of drop target so need to bumpe elevation
  of dragged views

Flag: com.android.wm.shell.enable_bubble_anything
Test: manual / visual - drag a bubble or drag expanded view and observe
                        the drop targets
Bug: 403276099
Change-Id: I15a1deb055c590b1f46261fcc307120fcb685c08
2025-03-14 13:56:29 -07:00
Jagrut Desai 4fe0b79fde Taskbar Icon changes
Test: Manual
Bug: 379158656
Flag: com.android.wm.shell.enable_gsf
Change-Id: Ic4ec9a7c634231c2592cfcd6ba6c8f8252c2dd98
2025-03-14 09:26:32 -07:00
Treehugger Robot 64927397af Merge "Fix KQS arrow button padding" into main 2025-03-14 08:14:16 -07:00
Toni Barzic 3c07c2156f Fix KQS arrow button padding
The padding values were set to their totals.
They needed to be halved.

Bug: 397975686
Flag: com.android.launcher3.taskbar_overflow
Test: None
Change-Id: Icae56e02fa6082b7f99b9fef265d6220b613d06b
2025-03-14 04:58:38 +00:00
Treehugger Robot 9b577bc9b5 Merge "Mark KQS arrow strings translatable" into main 2025-03-13 12:41:19 -07:00
Toni Barzic 026306b793 Mark KQS arrow strings translatable
Bug: 397975686
Flag: EXEMPT bugfix
Test: None
Change-Id: I3911a7c9b9cd19388934355e684941acc27a1c01
2025-03-13 10:17:31 -07:00
Treehugger Robot 6fcd77c19a Merge "Update KQS task view borders" into main 2025-03-12 12:21:08 -07:00
Treehugger Robot f0e0e8b7ec Merge "Remove redundant FrameLayout from task_header_view.xml" into main 2025-03-12 11:31:52 -07:00
Andy Wickham ccb3a5c25c Adds all_apps_blur flag.
This enables blur both for Taskbar and Launcher, but in slightly
different ways.

For Taskbar All Apps, we apply blur to the overlay window, and
for Launcher All Apps, we utilize the existing DepthController to
blur the wallpaper window. For similicity, we currently fade out
workspace/hotseat to avoid awkward view + window blurs which
don't look that good. This is not the POR, but I think it achieves
most of the effect and will help us get some blur exposure.

Separately I will continue to investigate options such as blurring
workspace in a clever way so it feels blended with the wallpaper,
reusing the Taskbar window and connecting it to LauncherState, or
using a SurfaceView (though I spent quite some time trying this and
it seemed the same as the original issue).

In both cases, we use a 20-30% opacity scrim with a set color, and a
panel that blends 40% opacity of a dark/light color with 10% white.

Also updated some incorrect isTablet checks which really should have
been checking shouldShowAllAppsOnSheet(), which includes the
all_apps_sheet_for_handheld flag.

Demo: https://drive.google.com/file/d/1Ov9Dg3R9YHNfisfxNf97ZIhlDeEA1IWj/view?usp=sharing&resourcekey=0-l_SDpqpS4HtOb10a3b_jNg

Other upcoming improvements: interpolator tweaks, colors of things
inside the app panel (tabs, private space, search results, etc).

Bug: 400827727
Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ic7063cd822f39a5977715b5477f825bf11e57bdf
2025-03-11 23:34:03 +00:00
Toni Barzic 94db320a84 Update KQS task view borders
Updates border color to have more contrast to the background, and adds
2dp padding between the border and the task content view - done by
updating BorderAnimator not to assume the border width and stroke are
the same.

Adding padding between the border and task view content exopsed an issue
where the second thumbnail in a split task's borders were not clipped
correctly when adding a border (it looked like the clip rect was not
properly scaled down). This is addressed by moving the tack view
background (and the outline) from the root KeyboardQuickSwitchTaskViews
to the content views (i.e. moving the outline to the view that does not
get scaled when adding a border, and having the second thumbnail end
edge of the clip rectangle match the clip rectangle of the clipped
ancestor view).

Bug: 398770098
Test: Manual
Flag: EXEMPT (a11y) bug fix

Change-Id: Ie058c932411a6b47815b0abf756f739c55b8342f
2025-03-11 22:00:59 +00:00
samcackett d88fb62c4d Remove redundant FrameLayout from task_header_view.xml
Move feature flag logic to the state mapper

Fix: 401469907
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest
Change-Id: Ic6ee5bef438ae2782816f526b003e1fb91992065
2025-03-11 16:49:52 +00:00
Treehugger Robot a6533ae04b Merge "Improve KQS accessibility" into main 2025-03-10 12:49:00 -07:00
Toni Barzic 394d5e0010 Improve KQS accessibility
Adds accessible pane name, and content description for keyboard quick
switch view. Improves content description for task views, by having it
provide the task position in the task list. Also, sets a task content
description immediately when it gets associated with a task, even if the
task description is not available at the time. Accessibility focus for a
task may be requested as the KQS view is shown, so the task view should
have a meaningful content description from the start.

While here, update KQS to focus first task  by default when opened from
taskbar.

Bug: 399032757
Test: Manual, with Talkback enabled - open KQS via taskbar overflow view,
      and Alt+Tab, and verify Talkback announcements are informative
      (e.g. no "Pixel launcher" utterance).
      Also atest NexusLauncherTests:TaplTestsKeyboardQuickSwitch
Flag: EXEMPT bug fix

Change-Id: I3688954ab383035c1db35c5eb7a0ddf9a39a123f
2025-03-10 17:35:04 +00:00
Brian Isganitis 26f9468db1 Animate changes in Taskbar recents indicators.
Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Fix: 356394053
Test: go/testedequals
Change-Id: Ic018695254bbfea11469c3579e242089b00b90f5
2025-03-07 15:47:48 -05:00
Wen-chien Wang 8444f38c92 Merge "pin-shortcut: Tracks hotseat states and adds unpin option for taskbar" into main 2025-03-03 16:50:48 -08:00
Treehugger Robot 51a3a87b14 Merge "Arrows to scroll recent tasks in KQS" into main 2025-03-03 16:44:25 -08:00
Mykola Podolian c095f8b318 Merge "Added accessibility action to move taskbar icon to the bubble bar" into main 2025-03-03 10:31:03 -08:00
Toni Barzic 8ca3eaa345 Arrows to scroll recent tasks in KQS
Bug: 397878339
Bug: 397975686
Flag: com.android.launcher3.taskbar_overflow
Test: Enter taskbar overflow, and open the overflow view.
    Verify that arrow buttons are present; tapping them scrolls in the
    correct direction; when fully scrolled in a direction, the
    associated arrow button is disabled; verify arrow buttons have hover
    effects.
    Open Alt+Tab view, verify no buttons are present if the view cannot
    be scrolled (and present if the view can be scrolled).

Change-Id: Id1c37a2967a629aeb4b3cc2dc5ff7efb21c90cbe
2025-02-28 19:49:50 +00:00
mpodolian f53e369650 Added accessibility action to move taskbar icon to the bubble bar
Create an accessibility action to create application bubble from the
taskbar icon

Fixes: 394159660
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Trigger "Actions" for the taskbar icon. One of the action
would be "Create application bubble". Activate action for the selected
icon. Observe new bubble is created.

Change-Id: I9b20631e0536e9bef23bed24389a7804bb45a4e2
2025-02-26 14:38:54 -08:00
Wen-Chien Wang f77c3cac2b pin-shortcut: Tracks hotseat states and adds unpin option for taskbar
This cl adds the unpin option by tracking the hotseat/taskbar state. The
option shown is determined by the following conditions:

1. If the target non-predicted item is on the taskbar, shows
   "Unpin from taskbar"
2. If the taskbar is not full, that is, reaching the limit of the
   available spaces, and the target item is anywhere outside of the
   taskbar, including All apps, shows "Pin to taskbar".
3. If the taskbar is full, simply don't show any shortcut option.

This cl also removes the option that will be shown on Launcher
homescreen or hotseat, as further UX alignment is needed.

One note about why the pin shortcut is not implemented in the
getShortcuts(). The reason is that getShortcuts does not have the
ItemInfo of the triggered item, while the SystemShortcut.Factory doesn't
have the hotseat/taskbar information. The simplest way at this point is
to check all the conditions in the controller and then manually add the
shortcut into the list.

Bug: 375648361
Test: Manual, Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: I7d048bcb1b00f78651e909fbfcd911052a4cd4ef
2025-02-25 00:10:59 +00:00
Schneider Victor-Tulias de841f6092 Respect accessibility animation guidelines in AllSetActivity
- Disabling the background animation if the user has opted out
- Allow the user to pause/resume the animation

Flag: EXEMPT bug fix
Fixes: 386743741
Test: launched AllSetActivity with animations on/off; tapped screen in both cases
Change-Id: I2bdbef24d6c582b4229441149fffcb67ba488882
2025-02-24 10:00:32 -08:00
Sunny Goyal 7629bc4dcd Merge "Converting LauncherAppState to Dagger" into main 2025-02-21 10:06:01 -08:00
Sunny Goyal c9f697aeb5 Converting LauncherAppState to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I336a233d2703c23a7e9065474bde471786886144
2025-02-20 19:13:49 -08:00
Jordan Silva 7c1e78acef Fix cropping app chip text with largest display and font size
Bug: 313648249
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Change-Id: I724c09647694214d59713d57269dc9378c01dc96
2025-02-19 16:16:20 +00:00
Pat Manning a82868d7df Add spring animations for neighboring tasks on dismiss cancel
Fix: 389083088
Test: TaplTestsQuickstep#testDismissCancel
Test: TaskGridNavHelperTest
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I1240519eea499b5839d64e537588bde3cb0a424b
2025-02-10 13:24:19 -08:00
minch b39d3015f8 Make AddDesktopButton can be navigated to through keys
Add the focus outline to the button as well.
Same color, ripple effect as the ClearAllButton is applied.

Flag: com.android.window.flags.enable_multiple_desktops_frontend
      com.android.window.flags.enable_multiple_desktops_backend
Bug:391875235
Test: TaskGridNavHelperTest
Change-Id: If93f86a1dce4df8ee6b1c50dfc44092dad2eafab
2025-02-07 18:33:23 +00:00
samcackett 5df5144b45 Add task menu shortcut for closing apps
Fix: 383977717
Test: OverviewMenuImageTest
Flag: EXEMPT bugfix

Change-Id: I24338a821e1ec9be21d22a5d1c4295dd6e28d13d
2025-01-31 08:37:18 -08:00
Jagrut Desai 76545448dd Merge "Remove Forced Taskbar Hidden accessibility announcement and forced accessibility focus" into main 2025-01-24 11:36:52 -08:00
Jagrut Desai defdc6c2d8 Remove Forced Taskbar Hidden accessibility announcement and forced accessibility focus
This cl also removes forced hidden annoucement and focus for Bubble Bar since they are annouced together.
we are keeping the tasksbar show annoucement and focus since it is only way to notify user of taskbar being shown on screen until we figure out proper solution with talkback team.

Test: Manual, Presubmit
Bug: 383928453
Flag: EXEMPT bugfix
Change-Id: I2c32ea393da2509af49e2fce795759a6903b0451
2025-01-24 09:20:07 -08:00
Sunny Goyal a5fef475a5 Revert "Revert "Migrating RecentsAnimationDeviceState and depend..."
Revert submission 31416515-revert-31332401-recents-device-state-LXBUANUQFL

Reason for revert: Fixing build breakage and resubmitting

Reverted changes: /q/submissionid:31416515-revert-31332401-recents-device-state-LXBUANUQFL

Change-Id: I3b89356df57f1e7ff1a9e364c0d766578e23798c
2025-01-22 18:31:06 -08:00
Liana Kazanova (xWF) fa30e3fc0e Revert "Migrating RecentsAnimationDeviceState and dependent obje..."
Revert submission 31332401-recents-device-state

Reason for revert: DroidMonitor: Potential culprit for http://b/391684419 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:31332401-recents-device-state

Change-Id: I3986328ee3aa8ebb822f7ef05b9f80ef68872aef
2025-01-22 13:50:08 -08:00
Sunny Goyal d7bfa76bcc Migrating RecentsAnimationDeviceState and dependent objects to Dagger
Bug: 361850561
Flag: EXEMPT dagger
Test: Presubmit

Change-Id: I2c45ec49a913abb0532e83b09e797012e06eb8c4
2025-01-21 23:53:02 -08:00
Treehugger Robot ae11d4e705 Merge "Update Gesture nav tutorial page title for Talkback support" into main 2025-01-21 20:44:14 -08:00
Schneider Victor-Tulias 596340b329 Update Gesture nav tutorial page title for Talkback support
Flag: EXEMPT bug fix
Fixes: 386688975
Test: opened gesture nav tutorial with talkback on
Change-Id: Ibe1db0788d70acef67a78c314c9d415cb3a42831
2025-01-21 10:53:59 -08:00
minch fb2e514de8 Initial implementation of the AddDesktopButton
Add the AddDesktopButton to the view hierarchy behind the flags.

Flag: com.android.window.flags.enable_multiple_desktops_frontend
      com.android.window.flags.enable_multiple_desktops_backend
Bug: 382057498
Test: Manual
Change-Id: I5748d8c18d8f5204fa1fb0717c4a8098bfde1537
2025-01-15 18:42:18 +00:00
Alex Chau e3b4b66d79 Merge "Support both grid and large tile with gridOnlyOverivew" into main 2025-01-14 12:24:19 -08:00
Mykola Podolian fc8db9afc3 Merge "Shift transient taskbar to ensure 12dp distance with the bubble bar." into main 2025-01-13 12:52:21 -08:00
Xiaoqian (Daisy) Dai 6dbd67ae7d Merge "desktop-exploded-view: Add header to individual windows." into main 2025-01-13 11:40:53 -08:00
Alex Chau 9c85596111 Support both grid and large tile with gridOnlyOverivew
- With the introduction of Desktop windowing, we'll need to supprot grid task and large tile (desktop tile) coexisting
- The previous gridOnlyOverview aimed to have taskSize matches actual grid task size, and introduced another carouselTaskSize for scaling in swipe up carousel
- Now I'm reverting to pre-gridOnlyOverview implementation of having taskSize as both large tile size and carousel task size, and gridTaskSize as only task size in grid

TaskViewSimualtor
- Removed no longer needed carousel translation and related calculations
- mIsGridTask is now determined with DeviceProfile, so when swipeing to Desktop task it won't use grid task size

TaskView
- Removed no longer used nonGridPivotTranslationX

RecentsView
- Make getSelectedTaskBounds / getTaskBounds picks the correct taskSize

Fix: 359573248
Fix: 321697299
Fix: 325606690
Bug: 322816508
Test: Swipe up, quick switch, task launching with grid task and desktop tasks; repeat with RTL, three button, phone
Flag: com.android.launcher3.enable_grid_only_overview
Change-Id: I14648c6682c53a4d06f9c9585d53f28dddef4f8f
2025-01-13 13:31:29 +00:00
Michele Fan 89b039da83 desktop-exploded-view: Add header to individual windows.
The header has an app icon, app title and a close button. Currently
clicking on the close button does nothing. Will address it in a
following CL.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 353965691

Change-Id: I5e0303a02d5f8afd16a5f5f0335a8fa489ff98f2
2025-01-10 22:25:43 +00:00
Treehugger Robot 753229687e Merge "Don't use announceForAccessibility in RecentsView" into main 2025-01-09 05:31:57 -08:00
samcackett 318e9184c8 Don't use announceForAccessibility in RecentsView
According to accessibility guidelines, we shouldn't be using this API and definitely not for notifying a user a task has closed, so just removing this use case altogether.

Fix: 386001961
Test: Enable Talkback.
  Open some apps.
  Go to Overview and dismiss an app.
  Talkback shouldn't announce "Task closed".
Flag: EXEMPT bugfix

Change-Id: I1a55017cbd4825103b9a8b93532b06276f28aef6
2025-01-09 01:09:51 -08:00