Commit Graph

14249 Commits

Author SHA1 Message Date
Schneider Victor-tulias 418b1f8e82 Merge "Allow Taskbar stashing for external tests" into tm-qpr-dev 2022-09-22 17:25:24 +00:00
Hyunyoung Song 64d5e25ab7 Merge "Fix the case of the missing header." into tm-qpr-dev 2022-09-22 15:45:22 +00:00
Federico Baron 06c0f35c4e Merge "Adding 'delightful pagination' to folders, removed old animation and now have regular scrolling for navigating pages." into tm-qpr-dev 2022-09-22 01:10:48 +00:00
Federico Baron f837fd1795 Adding 'delightful pagination' to folders, removed old animation and now have regular scrolling for navigating pages.
Here we add a feature flag for delightful pagination and if the feature flag is on we show a new pagination without the old animation, instead it will show a square that will move on scroll from one page to another.

Bug: 247561880
Test: manual
Change-Id: Ic88b6b2e4c677fd2012bca579407168cbda63785
2022-09-21 17:56:08 -07:00
Andy Wickham 30b87aad7d Fix the case of the missing header.
We should not override the tabs based on the search state now
that they are hidden (but still active) during the animation.

For an explanation of why this fixes the issue, please see
https://b.corp.google.com/issues/247615711#comment15.

Fix: 247615711
Test: Manually with predicted apps being updated every second
(part of the way I found to repro the bug).

Change-Id: I5ba45c42726c34f471a7743c06aecc05c89f6105
2022-09-21 17:04:48 -07:00
Stefan Andonian beccfe5928 Merge "Correctly position the landscape / rtl FloatingIconView's background drawable when swiping back to home." into tm-qpr-dev 2022-09-21 22:48:42 +00:00
Brian Isganitis 4ef5056be8 Merge "Add content description for taskbar all apps button." into tm-qpr-dev 2022-09-21 18:40:42 +00:00
Stefan Andonian d768f73f37 Correctly position the landscape / rtl FloatingIconView's background drawable when swiping back to home.
Bug: 235812580
Test: Verified the correct "Swipe Back to Home" position for the
floating icon view in landscape and portrait (rtl and ltr for both
orientations) with a tablet. There is a screen recording on the bug.

Change-Id: Id06f43e70ef617e39e1b26d0c8b7466147e325d2
2022-09-21 17:54:24 +00:00
Schneider Victor-tulias e64a8cfb20 Allow Taskbar stashing for external tests
Moved Taskbar stashing enabling logic to QuickstepTestInformationHandler to allow external tests to use the Taskbar API

Test: TaplTestsTaskbar
Bug: 240129939
Change-Id: I0ede8e4767cbe068328997a3afd51f9d5df2799a
2022-09-21 10:44:23 -07:00
Andy Wickham a297508c15 Merge "Reduces vertical padding of predicted apps in All Apps." into tm-qpr-dev 2022-09-21 17:25:39 +00:00
Yein Jo 364af1837e Merge "Move OnBackInvoked to BaseActivity." into tm-qpr-dev 2022-09-20 23:21:44 +00:00
Yein Jo 18446d0189 Move OnBackInvoked to BaseActivity.
In order to have all the activities in Launcher get
the same OnBackInvoked behavior, the logic is moved to BaseActivity.

Test: Manual, Tapl
Bug: 238475344
Change-Id: I3f49091397e31fe1f183596f7fba3bf514697468
2022-09-20 16:53:41 +00:00
Jeremy Sim 37f83cf246 Merge "Update animations for TM-QPR: OverviewSplitSelect > Confirmed transition" into tm-qpr-dev 2022-09-20 02:55:46 +00:00
Brian Isganitis d07b1a7c42 Add content description for taskbar all apps button.
Test: Manual
Fix: 221338615
Change-Id: Ic3b6f4e83a1234f1979f9fb4af75e6c893381a13
2022-09-19 16:25:15 -07:00
Sihua Ma 8e66905618 Merge "Showing Toast message when the target package is null for the disabled shortcut" into tm-qpr-dev 2022-09-19 23:20:12 +00:00
Sunny Goyal 59caeb9468 Merge "Fixing nullPointerException is RotationHelper" into tm-qpr-dev 2022-09-19 21:43:23 +00:00
Jeremy Sim 3ad08cd2b8 Merge "Fix issue with Overview thumbnails appearing blank in certain situations" into tm-qpr-dev 2022-09-19 19:56:57 +00:00
Jeremy Sim a4ba516797 Update animations for TM-QPR: OverviewSplitSelect > Confirmed transition
This change updates the animation for confirming a split.

Includes:
- New timings
- A new interface, SplitAnimationTimings, that centralizes timing values for splitscreen animations

Fixes: 241126570
Test: Manual
Change-Id: I61339964a7254618b368b17f00fda8f5efb53de4
2022-09-19 12:04:33 -07:00
Sunny Goyal e41c5b005f Fixing nullPointerException is RotationHelper
Bug: 247055735
Test: Verified on device
Change-Id: Ie73be138bdb616fb9db739b09c12794d61183657
2022-09-19 11:02:04 -07:00
TreeHugger Robot 69c04c21c5 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev 2022-09-19 17:12:40 +00:00
Luca Zuccarini 3fe8d2c9fa Merge "Fix issue with keyboard disappearing too late." into tm-qpr-dev 2022-09-19 15:36:59 +00:00
Jeremy Sim 08a9bcac1f Fix issue with Overview thumbnails appearing blank in certain situations
This CL fixes an issue where canceling any Launcher animation by entering Quick Switch would cause Overview to appear with all thumbnail tiles blank.

The issue occurred because we recently added a reset() to Overview that triggered on all state transition animation cancels. This fixed some issues, but introduced this bug.

Fixed by tailoring the reset() to only fire on animation cancels within BaseRecentsView and FallbackRecentsView.

Fixes: 246232494
Fixes: 243471493
Test: Manual
Change-Id: I175a22d52597a63e164a6f3b9353c62b199b0712
2022-09-17 16:01:46 -07:00
TreeHugger Robot 17c4741432 Merge "Updating the title of the Add to homescreen prompt to the requesting app instead of the Launcher name" into tm-qpr-dev 2022-09-17 01:47:48 +00:00
Holly Jiuyu Sun a6f9b4b76b Merge "Clear the staled mFocusedView when toast surface is closed." into tm-qpr-dev 2022-09-17 01:34:45 +00:00
Pinyao Ting 777c13eb00 Explicit Nullbility in Launcher (Part 5)
This CL addresses the nullbility in LauncherModel and update tasks.

Bug: 242895652
Test: manual
Change-Id: Ied635c944c3656f0d493b295f772aa0329b354b9
2022-09-16 17:17:16 -07:00
TreeHugger Robot 860657a5f2 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev 2022-09-16 23:07:54 +00:00
Sunny Goyal bb5ebb7f2d Updating the title of the Add to homescreen prompt to the requesting app
instead of the Launcher name

Bug: 239055068
Test: Verified on device
Change-Id: I1494d911565ddf3a598f9fbf372b8d784a4276e4
2022-09-16 15:54:53 -07:00
Yein Jo dfaabbb499 Merge "Migrate Launcher to use the new OnBackInvokedCallback" into tm-qpr-dev 2022-09-16 21:44:49 +00:00
Holly Sun 98d6a4027a Clear the staled mFocusedView when toast surface is closed.
Test: manual
Bug: 224756660
Change-Id: Iadce94f9138ee375fa9b6e3ef8fb685847312045
2022-09-16 14:28:23 -07:00
Andy Wickham 455c942fd2 Merge "Pivot search results scale around top of view." into tm-qpr-dev 2022-09-16 21:17:26 +00:00
TreeHugger Robot af2fe7fd12 Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev 2022-09-16 16:50:04 +00:00
Alex Chau fa83199e62 Turn off changing depth in wallpaper picker
Fix: 246845529
Bug: 240580498
Test: manual
Change-Id: Ib8fd624c518fb4c26d2598137d056b196a0ddeb7
2022-09-16 16:39:47 +08:00
TreeHugger Robot 9fb4802a67 Merge "Moving ViewCapture to Quickstep level to use hidden apis." into tm-qpr-dev 2022-09-16 06:23:07 +00:00
Stefan Andonian 5df305fed6 Moving ViewCapture to Quickstep level to use hidden apis.
Bug: 242867462
Test: Compilation succeeded while using private flags.
Change-Id: I9b15967b594963c5573ea1a0000b60f7c705da95
2022-09-16 03:36:15 +00:00
Andy Wickham 889be463f7 Merge "Adds SearchRecyclerView as a notification dot listener." into tm-qpr-dev 2022-09-15 23:47:00 +00:00
Andy Wickham 2d5b049531 Pivot search results scale around top of view.
This way views scale in/out relative to the top of the view,
instead of the center. This is most noticeable on larger views,
like Search Edu card.

Before/after videos: https://drive.google.com/drive/folders/1aXMGD44AQBeu6cLyzpV1DcFeh1Q8Vvmk?resourcekey=0-ShsGtgCTcST5cjUPAGPfwg&usp=sharing

Bug: 234882587
Test: Manual with 10x animation duration.
Change-Id: Ifb02f9dcb14e69b9cf3f9dea55d03d155b720391
2022-09-15 16:41:25 -07:00
Andy Wickham 5429b8fd86 Adds SearchRecyclerView as a notification dot listener.
This way app dots get updated as notifications come in or get
dismissed.

Bug: 246962476
Test: Dismissed notification while Search active.
Change-Id: I41e1b44561fb5ccd43deff342afb722cc5107330
2022-09-15 11:21:04 -07:00
TreeHugger Robot e58e123bd7 Merge "Add metrics sources for split invocation" into tm-qpr-dev 2022-09-15 09:35:12 +00:00
Jeremy Sim 21a5b12b6f Update animations for TM-QPR: Overview > OverviewSplitSelect transition
This change updates the Overview > OverviewSplitSelect animation to the latest spec. This is a re-upload of a previous change, ag/19464657, but no longer will cause the b/241165022 issue.

Includes:
- New timings
- Task thumbnails slide in with an "overshoot" animation
- Icons fade out and fade in appropriately
- SplitInstructionsView has a new compound "unfold" animation

Bug: 236760307
Test: Manual on tablet. Made sure the b/241165022 issue is fixed.
Change-Id: Ia22f6b6d7b9474b782e693fae2320a34a2985b18
2022-09-14 18:06:05 -07:00
Pinyao Ting fc14807d7a Fix launcher crash related to widget updates
LauncherAppWidgetHost fails to cleanup deferred widget when launcher
started binding the widgets in workspace, which leads to a crash because
widgets that was previously attached to the workspace get re-attached to
the workspace.

Bug: 245016152
Test: manual
Change-Id: I4de261e08cfdcee74f210c39bcadf403b98887ab
2022-09-14 13:22:29 -07:00
Yein Jo dc1b3660fe Migrate Launcher to use the new OnBackInvokedCallback
Bug: b/238475344
Test: Tapl & manual
Change-Id: Ieab329873f82890d95136e490086cc2cffff7ba8
2022-09-14 19:45:41 +00:00
Vinit Nayak 7fb4f997c4 Add metrics sources for split invocation
* See design doc in bug description for
usage/details

Bug: 231369744
Change-Id: I0c0ec11e924e387c523b5ac5feb7cabf78eaa748
2022-09-14 11:58:03 -07:00
Becky Qiu 1c8e630381 Merge "[Toast] Switch to use a device config instead of feature flag for appSearch." into tm-qpr-dev 2022-09-14 06:53:49 +00:00
TreeHugger Robot 839297e232 Merge "Add error detection for aborting the recents scrolling during transition to home" into tm-qpr-dev 2022-09-13 19:49:44 +00:00
Becky Qiu cdac570298 [Toast] Switch to use a device config instead of feature flag for appSearch.
Bug: 241001264
Test: local
Change-Id: I47416b07a62379ab5c2c17b3b769c8bc8b2ef106
2022-09-13 12:26:42 -07:00
TreeHugger Robot 3ded296cee Merge "Change wallpaper depth in widget picker" into tm-qpr-dev 2022-09-13 18:46:53 +00:00
TreeHugger Robot 22af7c2e7e Merge "Removing UiThreadHelper and moving code to corresponding classes" into tm-qpr-dev 2022-09-13 17:57:44 +00:00
Alex Chau 3d2c062567 Change wallpaper depth in widget picker
- Also changed widget picker open/close duration, refactored the values into DeviceProfile
- Generalized MultiAdditivePropertyFactory to accept aggregator as parameter

Bug: 240580498
Test: manual
Change-Id: I6886ca514593e404b8d7b0e8ed44f20ec2b77c73
2022-09-13 12:20:56 +08:00
Andy Wickham 369c6e8be7 Reduces vertical padding of predicted apps in All Apps.
Rather than using the full allAppsCellHeight, manually construct
the icon + padding + text and add custom padding (8dp).

Screenshots: https://drive.google.com/drive/folders/1hgEE72PaTj60SxgfPUzQ8hGwnCOWx-Lp?resourcekey=0-TgrHKITyzIXmNAAMYpA_MA&usp=sharing

Fix: 242915342
Test: Manual inspection
Change-Id: Ic566e0f7ea7cf486054bb8fe2429ee5c53e8b174
2022-09-12 18:34:14 -07:00
Becky Qiu a7be354913 Merge "[Toast] Add a debug log config for app search flow." into tm-qpr-dev 2022-09-13 00:33:26 +00:00