Commit Graph

9851 Commits

Author SHA1 Message Date
Chris Li 411c1b4856 Transfer PipContentOverlay when swipe to home with Shell transition
Update launcher to pass the taskId to Shell, so that Shell can reparent
the overlay from the remote transition leash to the Task leash.
Otherwise the overlay will be removed with the transition leash when
transition is finished.

Bug: 222030101
Test: verify with swipe to home with Shell transition
Change-Id: I838c22951fdf79c3213f2c9b1cb73a4a90341597
2022-03-02 22:55:51 +08:00
Winson Chung 42698fcb17 Merge "Revert "Disable flakey fallback recents test"" into tm-dev 2022-03-02 05:36:42 +00:00
Evan Rosky bcc343d944 Merge "Don't use incorrect inputconsumers during recents animation" into tm-dev 2022-03-01 23:49:06 +00:00
TreeHugger Robot b7e181c741 Merge "Combining the Thumbnail bitmap with the background to fix background spilling in the front." into tm-dev 2022-03-01 22:29:09 +00:00
Evan Rosky 9918df01af Don't use incorrect inputconsumers during recents animation
Shell transitions resumes launcher. This was causing logic in
launcher to pick incorrect inputconsumers which resulted in
aborting animation logic.

Bug: 220196913
Test: quickswitch very quickly
Change-Id: I66d894436a6cc6eae57d505db8a7abf6c10ab00f
2022-03-01 11:09:21 -08:00
TreeHugger Robot 33b858d4cc Merge "[ShellTransition]: invoke WMS#setRecentsAppBehindSystemBars to WM" into tm-dev 2022-03-01 08:53:12 +00:00
Winson Chung 384beda472 Revert "Disable flakey fallback recents test"
This reverts commit 4c2e3310e6.

Reason for revert: Lets try reverting this now that ag/17006986 landed

Change-Id: If9311a459ce6250d3f8c8341c1210b8bedd5bbbd
2022-03-01 05:23:05 +00:00
Tracy Zhou 26f5393db3 Improve the staged split animation
- Introduce rounded corners (since we scale x and y differently, we can't use outline since it doesn't support rx and ry. It's achieved by custom drawing).
- Make sure the thumbnail content doesn't shift during the transition (we use custom cropping for TaskThumbnailView, and we have to do it accordingly here)

TODO: update UX of the initial split view (b/219085340)

Fixes: 194414938
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/64953aa7-62ea-427c-8ec0-5f2bd96e4762
Change-Id: Id9a5d2f0f41cb4d619c8b3bd3a83c633e3d1f2de
2022-02-28 21:12:16 -08:00
TreeHugger Robot 094a4bdd48 Merge "Removing some unnecessary layout calls in TaskView" into tm-dev 2022-02-28 22:16:30 +00:00
Hyunyoung Song fbdf40ff4f Merge "Change the all apps atomic transition duration to 150 ms" into tm-dev 2022-02-25 22:59:56 +00:00
Alex Chau 890e4a75c3 Dump DeviceProfile in TouchInteractionService dumpsys
- So DeviceProfile dumpsys will be available in bugreports, useful for debugging
- Only dump DeviceProfile in createdOverviewActivity if it's non-null

Fix: 221395133
Test: adb shell dumpsys activity service com.google.android.apps.nexuslauncher/com.android.quickstep.TouchInteractionService
Change-Id: Iaf7b7abd25771814be6cb918e96e042d1085debb
2022-02-25 12:46:27 +00:00
Winson Chung e479619836 Just return an empty list if the system returns null
Bug: 206648922
Test: Presubmit (unable to reproduce this)
Change-Id: I04a4759a1c237513ab314ece4acd542e1407edb1
2022-02-25 06:41:45 +00:00
TreeHugger Robot 2a431f4a79 Merge "Passing in the launch cookie for widget broadcast trampolines" into tm-dev 2022-02-25 00:21:27 +00:00
Hyunyoung Song d68872426c Change the all apps atomic transition duration to 150 ms
Test: manual

TL;DR;; this value is used for tap on qsb all apps container
atomic transition. 320 is value that used to be used in R
when all apps travel distance used to be entire window height.
In S, we reduced the travel distance to 1/3 of the height.

Change-Id: Ib66f8a4408fd77350c31c5b894d9f8b2c889159f
2022-02-24 20:33:23 +00:00
Sebastian Franco 5a9dce518e Combining the Thumbnail bitmap with the background to fix background spilling in the front.
What's happening is that we first draw a background,
on top of it, we then draw the Task and because we
have a curvature the corners have pixels with transparency,
and those pixels get combined with the background pixels.
Most tasks have a transparent background or background
of the same color as the task so we don't see this
but for example, Telegram has a white background and
you can see this in the corners.

Fixed by creating a bitmap, drawing the background on it
and then drawing the thumbnail on top of it then using
that bitmap to draw it on the canvas.

Test: Put Telegram in recent Task (shouldn't be the first one) and you won't see a white border. Also when a task was in multitask the backgroudn should be draw.
Fix: 146521490
Change-Id: Id02a64ef472eb07900b0c7c5522d931d5b08f94e
2022-02-24 19:11:55 +00:00
Winson Chung 871759483b 1b/ Replace removed shared lib calls with direct calls
Bug: 219861883
Test: Builds
Change-Id: I7831d0de14286c9fa39fed59b168535e0a70d94d
2022-02-24 18:04:02 +00:00
Alex Chau 21c63bc809 Merge "No longer stash taskbar when swiping up all apps" into tm-dev 2022-02-24 11:59:57 +00:00
Mady Mellor 57eab45996 Merge "Add a reason to the broadcast to collapse system dialogs" into tm-dev 2022-02-24 01:30:11 +00:00
TreeHugger Robot dde28b487e Merge "Removing unnecessary AM.getTasks() call on every touch" into tm-dev 2022-02-23 23:38:14 +00:00
Tony Wickham 4fda59a0cc No longer stash taskbar when swiping up all apps
Instead, scale down hotseat behind all apps alongside workspace.

Test: Swipe up to all apps from home; all apps button in an app works as before
Fixes: 221094533
Change-Id: Ia6f1e7bac86849018dc8d0b1d95f0bab963835a8
2022-02-23 22:04:35 +00:00
Sunny Goyal d2ec834fac Removing unnecessary AM.getTasks() call on every touch
Bug: 220906427
Test: Verified on device
Change-Id: I58ed22c4d6069f10198ec30ec02fa8c2f7c55cbe
2022-02-23 13:35:25 -08:00
Sunny Goyal d4c4ad9212 Removing some unnecessary layout calls in TaskView
Bug: 221095750
Test: Presubmit
Change-Id: I277c1350109ce3bd0b29502c588482c737ab1e3d
2022-02-23 13:06:46 -08:00
TreeHugger Robot c089baa668 Merge "Remove Taskbar and Taskbar EDU flags." into tm-dev 2022-02-23 20:10:02 +00:00
Vinit Nayak 58c27cce73 Remove Taskbar and Taskbar EDU flags.
Bug: 219035565
Change-Id: I643b5d006b5759723418901ffeb463fa04a82cbc
(cherry picked from commit ec4adc1d5a)
2022-02-23 18:14:28 +00:00
Alex Chau b8c22e1155 Tune AllApps bottom sheet VisD and motion
- Make AllApps bottom sheet solid and appears from bottom
- Teleport AllApps bottom sheet as user drag to reduce drag range
  - Consider teleport interpolation for state transition sdetection
- Tuned workspace motions for AllApps bottom sheet (no translate, shrink)
- Add portrait vertical translate for tablet portrait including taskbar AllApps
- Updated bottom sheet handle and created common variables for other bottom sheets

Bug: 208599118
Test: manual on tablet AllApps, taskbar Allapps and handheld AllApps
Change-Id: I69dba5f155914cd012cc8ef3be1ef71fb2be5a40
2022-02-23 17:08:06 +00:00
Brian Isganitis a1370bfc5f Put taskbar all apps in separate overlay window and stash taskbar.
All apps should display below system UI components such as the
notification tray and power menu, so an overlay window is more
appropriate. As a result, all apps has a separate window activity
context, but some properties are delegated to the taskbar activity
context. Taskbar should also be stashed while all apps is open.

Change-Id: I593457708779d84a0ab8b949a966d247d0a2e1b7
Test: Manual
Bug: 216843189
Fix: 217383817
(cherry picked from commit 473b980bf9)
2022-02-23 15:06:56 +00:00
TreeHugger Robot 0f3b6511aa Merge "Fix Launcher icons not animated during unfold" into tm-dev 2022-02-23 14:03:39 +00:00
Alex Chau 82166fa6d8 Merge "Disable flakey fallback recents test" into tm-dev 2022-02-23 10:58:26 +00:00
Winson Chung 4c2e3310e6 Disable flakey fallback recents test
- Seems to be an existing failure in the recents animation not
  finishing, should disable to unblock folks

Bug: 218403080
Test: Presubmit
Change-Id: Ia42009666c67c29c1a78a2fe197bdce53dcb2ec8
2022-02-23 06:44:55 +00:00
TreeHugger Robot 49cb99a420 Merge "Fix jump in animation for hotseat while re-arranging icons" into tm-dev 2022-02-23 02:40:11 +00:00
Mady Mellor 411e862175 Add a reason to the broadcast to collapse system dialogs
Test: manual - see other CL in topic
Bug: 218517365
Change-Id: I9aa686bb95f11b4eeab0139833876abaf8b80cad
2022-02-22 14:14:34 -08:00
Nicolo' Mazzucato 5765d42ada Fix jump in animation for hotseat while re-arranging icons
While re-arranging icons the hotseat remains in scale 1.0f, while the workspace reduces it's scale (as defined by SpringLoadedState.java). Previously, the code to aggregate animations was assuming hotseat and workspace always had the same scale.

MultiScaleProperty.get() was being used to set the starting value of the animation. Previously, it was returning the last aggregated value. However, this value was correct only for the workspace, but not for the hotseat. Returning the current view scale makes it always correct.

Bug: 220271046
Test: Dragged icons from hotseat to workspace, and verified animation didn't jump
Change-Id: Ic01776c1d8e3967624626ed7c44d194a06295790
2022-02-22 18:27:26 +01:00
Nicolo' Mazzucato d4a5bb244a Fix Launcher icons not animated during unfold
If icons are re-bound during the animation, they were not moved. I was able to reproduce this case 100% of times by folding, restarting launcher and unfolding. From a perfetto trace it seems that in this case `finishBindingItems` was called after the animation already started, therefore not registering any view.

With this cl, items are animated also after they are rebound.

Bug: 197834977
Test: folded -> restarted launcher -> unfolded -> verified icons are now moving towards the center
Change-Id: I5b001c502860c17d6ea5d54d099f04b2ddf1820a
2022-02-22 13:48:35 +01:00
Jordan Demeulenaere 78ef3a5348 Enable back gesture when a SyUI dialog is showing (2/2)
Test: Manual
Bug: 210270549
Change-Id: I8fbf9a90287cbd8d9ddad354e24bbc4d074bd0ef
2022-02-22 11:09:03 +01:00
Ming-Shin Lu cb60b65bc0 [ShellTransition]: invoke WMS#setRecentsAppBehindSystemBars to WM
With enabling shell-transition, in case of seeing status bar icon
blinking when hammer tapping on the navigation bar to trigger recents
animation quickly as CL[1] mentioned,

As the result, Launcher side still need to callback recents app
behind system bar status to signal WM if launcher should affect
system bar appearance with [1] introduced method
setRecentsAppBehindSystemBars.

Bug: 215504556
Test: manual as below steps
  1) Launching a app
  2) Hammer tapping on the navigation bar
  3) Expect the staus bar icon won't blinking

Change-Id: I4b41e06e559168a61a29fa6ea9f58b834a7f1a1c
2022-02-22 05:54:41 +00:00
Selim Cinek 46c8678447 Passing in the launch cookie for widget broadcast trampolines
The launch cookie can now be transfered via the broadcast

Fixes: 220290671
Test: add Photos widget, return properly to widget
Change-Id: Ibfe9e5232317837f3111459212a4b016b5828ef4
2022-02-21 11:42:09 +00:00
Winson Chung 3516ecc534 Allow split with an existing split task
- Determine the task in the group being clicked in split-select mode
  and launch split using that selected task
- Also make sure we don't handle drag cancel twice when we are animating
  the return of the drag surface

Bug: 219060441
Test: Split from home/overview with fullscreen+fullscreen task, and with
      fullscreen+split task

Change-Id: I48ec0a82812197803ff4b3698830a9cb705719e3
2022-02-18 17:49:59 +00:00
Vinit Nayak afd9bfebe1 Merge changes from topic "presubmit-am-a8c798abe8b24577a107553295b8cd0f" into sc-v2-dev-plus-aosp am: 0dffbfcba6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16828919

Change-Id: I0e30b14ef15fde94a27369f3c76f975c8272736f
2022-02-16 21:43:27 +00:00
Vinit Nayak 0dffbfcba6 Merge changes from topic "presubmit-am-a8c798abe8b24577a107553295b8cd0f" into sc-v2-dev-plus-aosp
* changes:
  [automerge] Add null check for null task in getItemInfo() 2p: 73c6288038
  Add null check for null task in getItemInfo()
2022-02-16 21:23:47 +00:00
Vinit Nayak 95686cd9be Merge "Ensure starting split animation scale is always 1" 2022-02-16 18:49:40 +00:00
TreeHugger Robot 64162f1e05 Merge "Update TAPL object hierarchy in preparation for Taskbar TAPL tests" 2022-02-16 18:20:06 +00:00
Presubmit Automerger Backend 21e44c56bb [automerge] Prevent lingering divider animators in AbsSwipeUpHandler 2p: 7faaffa56a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16693066

Bug: 213403679
Change-Id: I628b14fb01461a103dd0cdd7168835197a28f1c5
Merged-In: I078a7d0f22c2ef2ba847796ec79e740c789ce1ae
2022-02-16 17:13:58 +00:00
Winson Chung 7faaffa56a Prevent lingering divider animators in AbsSwipeUpHandler
- Refactor the util method to create the animator and track the existing
  animation in AbsSwipeUpHandler to be able to cancel it if another call
  to change the visbility comes in.  Note that this doesn't address
  the case where the launch animation overlaps with swipe up (though that
  hopefully shouldn't happen in normal usage)

Bug: 213403679
Test: Tap in the gesture space while split
Change-Id: I078a7d0f22c2ef2ba847796ec79e740c789ce1ae
Merged-In: I078a7d0f22c2ef2ba847796ec79e740c789ce1ae
2022-02-16 17:13:48 +00:00
Tony Huang b39ef58493 Merge "Refactor startIntentAndTaskWithLegacyTransition" 2022-02-16 03:45:02 +00:00
TreeHugger Robot 940e5c7328 Merge "Cover thumbnail view instead of TaskView for split animation" 2022-02-15 23:22:32 +00:00
Evan Rosky 0a2f5b0baa Merge "Switch pip to fixed-rotation in shell transitions" 2022-02-15 22:34:34 +00:00
TreeHugger Robot 451e468678 Merge changes from topic "presubmit-am-cc24ad26c93446a690f8a34ffde58aa3" into sc-v2-dev-plus-aosp am: 3a6a78f7b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16828915

Change-Id: Icfc37fdb5858352e77628959ed7e627712620cdd
2022-02-15 22:32:43 +00:00
Schneider Victor-tulias d6279ae641 Update TAPL object hierarchy in preparation for Taskbar TAPL tests
See design at: go/taskbar-tapl-tests

Test: Ran tests remotely
Bug: 215218813
Change-Id: I1c2ceac8954973ea3ae5b2f797fdfb96ba7a6ec4
2022-02-15 13:33:26 -08:00
Vinit Nayak 12a24dca8d Cover thumbnail view instead of TaskView for split animation
Fixes: 219622592
Test: Slowed down animation and verified same as before
refactor was done.

Change-Id: Iec8dc9ea1d7925575c3a3b84e12653829a00d8dd
2022-02-15 12:41:11 -08:00
Vinit Nayak 181f4b2c40 Ensure starting split animation scale is always 1
Bug: 194414938
Test: After second app selected, first split placeholder
view doesn't jumpcut to arbitrary Y bounds.

Change-Id: Ic8b809f147bf38f78198ef4224d810faf5e3c5ba
2022-02-15 12:01:37 -08:00