Sunny Goyal
4729740170
Merge "Fix some touch issues during gesture nav transition" into sc-dev am: 6348858734 am: 13405411e7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15137733
Change-Id: I7f02d9d35b861955d8bbf4591f62b7060f37ec59
2021-07-02 18:46:56 +00:00
Tracy Zhou
0d31266d00
Merge "Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp" into sc-dev am: fa72529b05 am: 6ffacb09a9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15184810
Change-Id: Ia6be7ba248c4a40a997c44f9eefe0a93f6c65a42
2021-07-02 18:45:38 +00:00
Sunny Goyal
13405411e7
Merge "Fix some touch issues during gesture nav transition" into sc-dev am: 6348858734
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15137733
Change-Id: Ibebb2ef1c6c05b95ef143ce0136ea203cd2a7863
2021-07-02 18:35:53 +00:00
Tracy Zhou
6ffacb09a9
Merge "Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp" into sc-dev am: fa72529b05
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15184810
Change-Id: I94bff6e7bc83f86aab2fc12d3c2649e4b65360e6
2021-07-02 18:35:15 +00:00
Sunny Goyal
6348858734
Merge "Fix some touch issues during gesture nav transition" into sc-dev
2021-07-02 18:33:34 +00:00
Tracy Zhou
fa72529b05
Merge "Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp" into sc-dev
2021-07-02 18:18:23 +00:00
Alex Chau
d942860979
Merge "Add screen record for failing TaplTestsQuickstep" into sc-v2-dev am: 34c449d72e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15179052
Change-Id: Iff6bc95c4a7b761ee5433d3091d1ec22cec1b9f0
2021-07-02 17:32:45 +00:00
Alex Chau
34c449d72e
Merge "Add screen record for failing TaplTestsQuickstep" into sc-v2-dev
2021-07-02 17:20:30 +00:00
Alex Chau
b297c7e615
Add screen record for failing TaplTestsQuickstep
...
- For debugging failures that only happnes on cuttlefish
Bug: 191344757
Test: TaplTestsQuickstep
Change-Id: Iac16e222dc7b60f94e1eb7f305c5ccb909161783
2021-07-02 15:14:05 +01:00
Tracy Zhou
d2039614e0
Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp
...
Fixes: 192458435
Test: N/A
Change-Id: I3f0b828bf9fa9645bbd253612aa073f37b21e4b2
2021-07-01 23:52:34 -07:00
Tracy Zhou
52eb75bfee
Enable live tile in 3 button mode am: 1fe5fda3d8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14254546
Change-Id: If5a526a1e949629ce610ce18a042be9e6eb8b544
2021-07-02 06:51:44 +00:00
Tracy Zhou
740b2381c4
Enable live tile in 3 button mode am: d09ebe660f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15133050
Change-Id: I779ad9e03302864b1a2f59a8da7092917c0f72ad
2021-07-02 05:21:57 +00:00
Tracy Zhou
1fe5fda3d8
Enable live tile in 3 button mode
...
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355
Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.
Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
Merged-In: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
2021-07-02 05:19:32 +00:00
Tracy Zhou
d09ebe660f
Enable live tile in 3 button mode
...
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355
Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.
Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
2021-07-01 18:40:56 -07:00
Alex Chau
43e40493fa
Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev am: 679f8bb9ca am: e526fd6a00
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15175270
Change-Id: I25d921c104e5285fa163124d2b0863cda5a9bc45
2021-07-01 22:49:27 +00:00
Alex Chau
e526fd6a00
Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev am: 679f8bb9ca
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15175270
Change-Id: I4cc43374c577299c7be3d63bb8a7393a90447231
2021-07-01 22:28:30 +00:00
Alex Chau
4eabe23108
Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev am: 679f8bb9ca
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15175270
Change-Id: I409622ab04cc934290013203281329987e0ae5ec
2021-07-01 22:27:33 +00:00
Alex Chau
679f8bb9ca
Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev
2021-07-01 22:12:54 +00:00
Tracy Zhou
ec5c2ea87e
Merge "Do not switch to screenshot and finish recents animation for menu options that already do so" into sc-dev am: e54f789de9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15176734
Change-Id: I6e980151382b7ce10fb4d206d86295a41e938b8f
2021-07-01 19:45:18 +00:00
Tracy Zhou
e54f789de9
Merge "Do not switch to screenshot and finish recents animation for menu options that already do so" into sc-dev
2021-07-01 19:32:39 +00:00
Jonathan Miranda
8e7c617775
Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev am: 3334c32120 am: e6f0509d1d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164770
Change-Id: I9b3d03c8050ac47e0368161dba58110b0e047605
2021-07-01 18:48:39 +00:00
Sunny Goyal
cac11af5a1
Merge "Fixing some dimentions in AllSet activity" into sc-dev am: f3d3dcf4a1 am: 2e5176e51f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160037
Change-Id: Ie2e2042efc2048e9d2d66a5fea40b5470b771359
2021-07-01 18:48:29 +00:00
Jonathan Miranda
e6f0509d1d
Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev am: 3334c32120
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164770
Change-Id: I38ace4adec4591e9259a8859ed547e1b951b922c
2021-07-01 18:36:20 +00:00
Jonathan Miranda
d156f372f5
Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev am: 3334c32120
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164770
Change-Id: I3680615723b0ef5edf175db01fd44ed068f2147f
2021-07-01 18:35:30 +00:00
Jonathan Miranda
3334c32120
Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev
2021-07-01 18:34:47 +00:00
Sunny Goyal
2e5176e51f
Merge "Fixing some dimentions in AllSet activity" into sc-dev am: f3d3dcf4a1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160037
Change-Id: I3e8d01451a9ad4b14128bf90a9d758e922d04f4e
2021-07-01 18:32:02 +00:00
Sunny Goyal
08fa7008b0
Merge "Fixing some dimentions in AllSet activity" into sc-dev am: f3d3dcf4a1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160037
Change-Id: I8f187fe98130bc8c35864a97b21fc31fb1161e30
2021-07-01 18:31:02 +00:00
Sunny Goyal
f3d3dcf4a1
Merge "Fixing some dimentions in AllSet activity" into sc-dev
2021-07-01 18:16:45 +00:00
Tracy Zhou
99adef95b3
Do not switch to screenshot and finish recents animation for menu options that already do so
...
The issue is that in landscape mode we add overview shortcuts (e.g. screenshot) to the task view menu, where we switch to screenshot and finish recents animation before executing the shortcut action. However for shortcut actions like screenshot, we do the same, resulting in two chained "switch to screenshot and finish". This is a temporary fix for S given it's late in the cycle and we don't want to introduce unwanted regressions.
Fixes: 192272546
Test: manual
Change-Id: I7ef596e8bce6c15aa4a27163197beac12359b691
2021-07-01 17:46:44 +00:00
Alex Chau
e0fcee01b3
Restore previous currentPage in applyLoadPlan in case task is re-ordered
...
Fix: 186537288
Test: Repeatededly launch task from home and swipe to home, animation is correct
Test: Quick switch, launch task then swipe up, there is no jump
Change-Id: I9fd7416d9811ce4e54a1c6d20374d89d00417cd5
2021-07-01 18:43:20 +01:00
Tony Wickham
5fac02bc5e
Fix some touch issues during gesture nav transition
...
- Don't recreate the laucher transition controller if we've already ended it, as it could clobber a touch interaction that started in the meantime
- Test: swipe up from an app to overivew, swipe to dismiss it during the transition.
- Previously, we were ending the controller twice (once on touch down as we started proxying, and again in setupLauncherUiAfterSwipeUpToRecentsAnimation()), and the second one could happen after starting the dismiss interaction.
- Don't recreateControllers() if orientation didn't change
- Test: swipe up to go from an app to home, swipe up to all apps during the transition.
- Previously, we were getting the following sequence:
1. Touch down on home to start swiping to all apps - all current controllers get this down event to start determining whether to intercept
2. Before reaching touch slop, we recreateControllers(), so all new controllers won't get the down event and thus won't intercept
- Now, we avoid unnecessarily recreateControllers(), so the original controllers can still intercept.
Test: see above
Fixes: 189700453
Change-Id: I7b5fb3d21ab7a7a7044fcec7f2c1e39afe23c5dd
2021-07-01 07:39:59 -10:00
Winson Chung
927059c8be
Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2 am: 2ae6a3e3c9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033
Change-Id: I717210002017b6ed71bfa49a90171f4e32a7532f
2021-07-01 17:16:24 +00:00
Winson Chung
2ae6a3e3c9
Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033
Change-Id: I4183018dbe6ad644824f842cae259ab0786c9657
2021-07-01 17:15:48 +00:00
Winson Chung
a717b7b45a
Merge "Remove unused logs" into sc-v2-dev am: efa5e9f5ea
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15167125
Change-Id: I12a6c3dd689fdeda918809b6848772b97bd9b376
2021-07-01 17:15:29 +00:00
Winson Chung
277e9c83c7
Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033
Change-Id: I4ed3c6d9009dcff282b08e6597fecd9dcfdecd0e
2021-07-01 17:14:51 +00:00
Winson Chung
eb0a38c5f2
Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev
2021-07-01 17:11:35 +00:00
Winson Chung
8185663b6e
Remove unused logs
...
Bug: 191698994
Test: Just removing logs
Change-Id: Ia6ae528f1444cbdbe3823657492deeb6c4a3d6ce
2021-07-01 04:44:04 +00:00
Tracy Zhou
89f8d0763d
Merge "[Live Tile] App surface is above launcher even after reaching Overview" into sc-v2-dev am: d25ee3294c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15158868
Change-Id: Ic6dfce00e0b80adaa26da23b05363578ada8689a
2021-07-01 01:22:10 +00:00
Tracy Zhou
d25ee3294c
Merge "[Live Tile] App surface is above launcher even after reaching Overview" into sc-v2-dev
2021-07-01 01:11:11 +00:00
Jon Miranda
17cc821c28
Fix bug where app icon is gone for first frame on cold start.
...
We need the icon to be full alpha during the init pass, then when
the actual animation starts, we can swap the icon with the window
(splash screen that draws the icon).
Bug: 192366079
Test: slow down window animations
check no empty frame on cold start app launch
check no empty frame on warm start app launch
Change-Id: I16a1779e5252d8e88bc3c408e1dc40b264fe4cf4
2021-07-01 00:11:41 +00:00
Hongwei Wang
4b38eb6f95
Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev am: 005e269220 am: c3a9f0e75b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15132509
Change-Id: Id3d94c0000cd8738475213b21435dfe306b13feb
2021-06-30 20:52:44 +00:00
Hongwei Wang
52df9c8580
Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev am: 005e269220
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15132509
Change-Id: I0fa466ab04f93a9d6f1f6ab15658a1d10f968fa4
2021-06-30 20:41:42 +00:00
Hongwei Wang
c3a9f0e75b
Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev am: 005e269220
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15132509
Change-Id: Id256786bd820ea5f01174c136fc992fc2cd82999
2021-06-30 20:35:28 +00:00
Hongwei Wang
005e269220
Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev
2021-06-30 20:23:23 +00:00
Sunny Goyal
25f386edc8
Fixing some dimentions in AllSet activity
...
Bug: 192412172
Test: Manual
Change-Id: I599c858fc21d45dd41eaa01ff3d91863d52f6ae8
2021-06-30 12:19:30 -07:00
Winson Chung
a7d7f78c08
Defer cleaning up screenshot until after we actually switch to screenshot
...
- In the case where we get a screenshot on cancel, we should wait to
finish the recents animation until the view gets a chance to update
Bug: 185643608
Test: Swipe up to overview in 2 button, hit home
Change-Id: I2ac3567006f6fa7e6f473499f6862e5e408dfc3d
2021-06-30 12:03:33 -07:00
Yogisha Dixit
8235d49e74
Merge "Log widgets source." into sc-dev am: f9acf1d5d4 am: 669bac8bd6
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879
Change-Id: I5b2fe5baebd5f38e897412523f3920ff22054247
2021-06-30 18:47:29 +00:00
Yogisha Dixit
ba28286260
Merge "Log widgets source." into sc-dev am: f9acf1d5d4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879
Change-Id: I2fa39b66ca31549f7754657b7d3bde6bdf8a5f59
2021-06-30 18:33:44 +00:00
Yogisha Dixit
669bac8bd6
Merge "Log widgets source." into sc-dev am: f9acf1d5d4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879
Change-Id: Ib47b6d3aaacaa30c723dafeeb65492510a150eb2
2021-06-30 18:32:53 +00:00
Yogisha Dixit
f9acf1d5d4
Merge "Log widgets source." into sc-dev
2021-06-30 18:18:12 +00:00