Fixed padding issue (tightness) between Personal/WorkTabs/EduDialog
Aligned Work Toggle button to be the same with the workTabs/eduCard
raised button up 20dp to align with specs
Fixed issue where allApps apps invade the tabs. Fixed RTL issues where it wasn't going RTL.
Fixed RTL issue for the workfab button where there was no margin on the left side of the button
Added DeviceProfile to constructor
Bug: 200810328
Bug: 224731300
Test:
Before: https://screenshot.googleplex.com/6sRgNZQz4wKYn5n
After: https://screenshot.googleplex.com/8hBLyDiMbMH9tn2
After(showingLayoutBounds): https://screenshot.googleplex.com/MuVUXCegukAMzSr
Change-Id: Ibac3f5b8fe7d877c2f54a2c87f4393c1a91dc806
This reverts commit 6729f0b950.
Reason for revert: This change caused b/230648542.
Please see https://b.corp.google.com/issues/230648542#comment5 for the video after reverting this change.
Bug: 206905515
Bug: 230648542
Change-Id: I85f063c56cad137c05b810204244bba7e8f94ee7
- Align overview actions to the top with a defined margin below task thumbnail, except for vertical bar layout
- In modal state, use task view's bottom as pivot, and expand using all the space about pivot
- Simplified overview actions margin calculation and moved some logic to DeviceProfile
Bug: 209981696
Test: manual on various devices
Change-Id: I4c96cb02c6f3d6adf30633ddeb883bc4eec16f36
This will help enable transitions between A-Z apps lists and
search results because both can be seen simultaneously and
manipulated independently.
Some high level items of the refactor:
- SearchRecyclerView is added; logic that populated the main
(personal) tab with search results was simply redirected to
this RV instead.
- BaseAllAppsContainerView added isSearching() method. Returns
false, and ActivityAllAppsContainerView overrides (as search
is handled there).
- Renamed BaseRecyclerView to FastScrollRecyclerView to better
describe what it does. SearchRecyclerView extends this, but
returns false for supportsFastScrolling().
- AlphabeticalAppsList#mAllAppsStore is now optional, so the
Search RV doesn't need to store/listen to apps. Note this
doesn't affect the predicted app row which is still updated
if one of the predicted apps is uninstalled (I tested this).
Future work:
- Determine why dispatchRestoreInstanceState is not called for
BaseAllAppsContainerView. Save is called, e.g. on rotation.
Effect of restore not called: rotating while searching goes
back to A-Z list.
- Keep suggested apps in Header while searching. Currently they
are rendered in the SearchRV above search results, as before.
- Potentially extract Personal/Work tabs to move independently of
header.
- AlphabeticalAppsList is a misleading name because it can also
contains search results. However, things are pretty intertwined
between that and BaseAllAppsAdapter (effectively a circular
dependency), so I figured cleaning all that up was out of the
immediate scope of this refactor, which is mainly meant to
unblock transition work.
Bug: 206905515
Test: Manually checked for regressions, ran tests.
Change-Id: I4d3757c8a8f9b774956ca6be541dd4fcdad1de13
Test: check that the launcher home settings activity transitions use the clear color activity animation with the correct background color
Bug: 229898866
Change-Id: Ic96ceb0fdbd6c4f10b411492dc5be18e979796c8
Bug:228533817
Test: Enable back animation from FlagFlipper (Predicitve Back Animation)
and swipe back on Flag Flipper. Try in both portrait and landscape mode.
Change-Id: I7792dc5079698c1b5a7dd3cd06344ba46c4a2da6
Creating an AlertDialog when the disabled reason of the shortcut is DISABLED_REASON_VERSION_LOWER, which happens when the backed-up shortcut was created from an application that has a version higher than the one installed on the device. The AlertDialog will direct the user to the play store and update the application.
Test: Manual
Fix: 224796975
Change-Id: I0125fada60b48176775de6782ba03ee6790904aa
Revert "[automerge] Making tablet grid scalable and tuning size ..."
Revert submission 17607211-aosp_tablet_tune
Reason for revert: Breaking a test b/228490147
Reverted Changes:
I88e581231:[automerge] Making tablet grid scalable and tuning...
I078d19905:Making tablet grid scalable and tuning size
Original bug: b/227344807
Change-Id: Ie6e55edcf5b82b73ad2c8ed7ffd5f0fa5b53594a
The text "Don't suggest app" is too long when the device language
is GE or JA, or if you make the text bigger in settings.
Before truncating the text completely we are going to try to make
the text smaller until it gets to a predefined value
(button_drop_target_min_text_size).
Test: Change the language to German (Deutch) and install a new app and drag it to the workspace to see the button "App nicht vorschlagen"
Test: Also, a nice way to test is to go to SecondaryDropTarget#setupUi and hardcode the option to always show "Don't suggest app"
Fix: 221480721
Change-Id: I99def4e23cd17109a297aecaa620cef7a0d137e7
Sunny Goyal
Brandon Dayauon
TreeHugger Robot
Bill Yi
Thales Lima
Anushree Ganjam
Alex Chau
Pablo Gamito
Andy Wickham
Zak Cohen
Pat Manning
Shan Huang
Sihua Ma
Luca Zuccarini
Sebastián Franco