Commit Graph

2643 Commits

Author SHA1 Message Date
Tony Wickham 3ff1000632 Merge "Replace OnGlobalLayoutListener with StateListener to update predictions" into ub-launcher3-qt-qpr1-dev
am: fc520edbc6

Change-Id: I8e5b43a582bd243e21f02b5a83b931f4f277eb95
2019-09-13 14:29:31 -07:00
Sunny Goyal 30d998c625 Merge "Adding support for building a "spring like animation" with precomputed values" into ub-launcher3-qt-qpr1-dev
am: 791dd73217

Change-Id: I1ecde4721df9895b0fb215f36a43d8cb85a392ef
2019-09-12 15:05:48 -07:00
Hyunyoung Song 057059665e When DeviceConfig/FeatureFlag value is different than the previous value, refresh icon cache
am: e17a699618

Change-Id: I5c2e54c069fc03172f471f9655cd8b09b5ac6dce
2019-09-12 15:05:19 -07:00
Tony Wickham fc520edbc6 Merge "Replace OnGlobalLayoutListener with StateListener to update predictions" into ub-launcher3-qt-qpr1-dev 2019-09-11 23:42:23 +00:00
Tony Wickham 51f2919815 Replace OnGlobalLayoutListener with StateListener to update predictions
Previously we were using OnGlobalLayoutListener, which is only called
when AllAppsContainerView or a child is re-laid out or visibility
changes to or from GONE. Since we no longer relayout when already
scrolled to the top, we need a better hook to check whether all apps has
changed visibility for the purpose of updating predictions.

Bug: 140823188
Change-Id: I7c4a0d94c529eb86b55729c75843c8b0bd673d8c
2019-09-11 14:41:52 -07:00
Sreyas 78010c1958 Refactoring RecentsView to handle non-TaskViews
Change-Id: I0bc28ef670a1dad9a3912ca5360c9bab18afd4b2
2019-09-11 14:07:26 -07:00
TreeHugger Robot 791dd73217 Merge "Adding support for building a "spring like animation" with precomputed values" into ub-launcher3-qt-qpr1-dev 2019-09-11 20:16:19 +00:00
Hyunyoung Song e17a699618 When DeviceConfig/FeatureFlag value is different than the previous
value, refresh icon cache

Bug: 135638690
Bug: 138964490

Test: manually toggled feature flag UI on/off
$ adb shell device_config put launcher APP_SEARCH_IMPROVEMENTS [true|false]
when launcher is in foreground and also when it is in the background

Afterwards, saw if "bank" would show BofA app or not

Change-Id: I98b62bd07b14a225168217d7eb9bfdfc7f74435d
2019-09-11 10:38:14 -07:00
Sunny Goyal 3600fb7777 Adding support for building a "spring like animation" with precomputed values
Bug: 138396187
Change-Id: Idba323090ecd9aca43c01414a32ab3b2e292e73e
2019-09-09 17:21:53 -07:00
Winson Chung 478414a7c3 Merge changes I4532e429,I532645de into ub-launcher3-qt-future-dev
* changes:
  Defer listening on widget host until after the state transition ends
  Migrate to using DefaultDisplay
2019-09-09 21:39:18 +00:00
Miranda Kephart fad2f3734d Merge "Add distance threshold for assistant gesture fling" into ub-launcher3-qt-qpr1-dev
am: 329cc8c53f

Change-Id: Ib1e4040010cf3919163e24971d2a368664bec1db
2019-09-09 14:22:47 -07:00
Tony Wickham 0d37f05a12 Merge "Properly prevent All Apps relayouts by avoiding scrollToPosition" into ub-launcher3-qt-qpr1-dev
am: d785fc289c

Change-Id: I69738f5d9c1f77195f2f82f963958d3cc741e9af
2019-09-09 14:17:33 -07:00
Vadim Tryshev c698c0cdbb Merge "Adding a test method to get a Launcher object when it becomes non-null" into ub-launcher3-qt-qpr1-dev
am: b34f951e7e

Change-Id: Id63a1df1aef2f35b0f6cdb0f8ab851163c8140c9
2019-09-09 14:17:20 -07:00
Miranda Kephart 329cc8c53f Merge "Add distance threshold for assistant gesture fling" into ub-launcher3-qt-qpr1-dev 2019-09-09 21:02:43 +00:00
Winson Chung ef52876739 Defer listening on widget host until after the state transition ends
Bug: 140246642
Change-Id: I4532e4298f04ff5c6dea04ccda89320995cadb80
2019-09-09 10:24:53 -07:00
Winson Chung 13c1c2cd65 Migrate to using DefaultDisplay
- Remove extra binder calls to get the default display

Bug: 140633033
Change-Id: I532645deac101a6065d90484b87a67b67aa717f5
2019-09-09 10:21:28 -07:00
Jon Miranda a87abbad31 resolve merge conflicts of 1bd96b1e96 to ub-launcher3-qt-future-dev
Test: I solemnly swear I tested this conflict resolution.
Bug: None
Change-Id: Ide6c914d4e69eb4fa70d6634780324cd45a21610
2019-09-06 11:35:34 -07:00
Tony Wickham d785fc289c Merge "Properly prevent All Apps relayouts by avoiding scrollToPosition" into ub-launcher3-qt-qpr1-dev 2019-09-05 21:27:41 +00:00
vadimt cf61e16a2c Adding a test method to get a Launcher object when it becomes non-null
Change-Id: I1c56777c87827b5edf1c7f55ad9639321e598311
2019-09-04 19:02:54 -07:00
TreeHugger Robot 1bd96b1e96 Merge "Update app open/close animations." into ub-launcher3-qt-qpr1-dev 2019-09-04 22:33:33 +00:00
Jon Miranda 9b78e190fa Update app open/close animations.
- For app open, the icon text remains where it is and only the icon moves.
- Similarly for app close, the icon text remains where it is and fades in
  with the rest of the other icons text.

- With this change, the original view is always "VISIBLE"
  (if BubbleTextView/FolderIcon) but we hide certain elements.

Added video to bug.

Bug: 137200188
Bug: 139885365
Change-Id: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
Merged-In: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
2019-09-04 21:45:05 +00:00
Vadim Tryshev 72fddba837 Merge "Enabling debug tracing for all UI tests" into ub-launcher3-qt-qpr1-dev
am: 846656f138

Change-Id: Ie40cc1d55d40ffefe6c1b2d3588b03ff92d2cb38
2019-09-04 12:37:40 -07:00
Vadim Tryshev 846656f138 Merge "Enabling debug tracing for all UI tests" into ub-launcher3-qt-qpr1-dev 2019-09-04 17:52:11 +00:00
vadimt 0ce38af957 Enabling debug tracing for all UI tests
Change-Id: I434ee378baf35de955c8a589b8380e1751e4107a
2019-09-03 17:16:34 -07:00
Tony Wickham bfdeda96e6 Properly prevent All Apps relayouts by avoiding scrollToPosition
Calling scrollToPosition on RecyclerView internally calls
requestLayout() (to cacluate where to scroll and then go there).
Therefore, we should avoid calling that whenever possible, especially
during transitions. In particular, we can optimize scrollToTop() to not
scrollToPosition() if we are already at the top.

This makes some other workarounds unnecessary, namely setting All Apps
to GONE during system gestures.

Test: Open an app, swipe up, ensure AllAppsRecyclerView doesn't get
onLayout().  If we had scrolled to an app first, we get one layout
in prepareRecentsUi(), but not during the transition.

Bug: 140308849
Change-Id: I62ee341bf5893c121cfc013cc6542559f79d2a42
2019-09-03 16:16:54 -07:00
Andy Wickham 90c16ace8a Reduces padding of the Overview shelf in no button mode.
Before: https://screenshot.googleplex.com/iw6baTCfoy2.png
After: https://screenshot.googleplex.com/8CcsQvLhYDo.png
Desired: https://b.corp.google.com/action/issues/139551306/attachments/26925873?download=false

Test: Examined before and after padding and verified 3-button is unaffected.
Fixes: 139551306

Change-Id: Ia416399cf25e7c6c2fb8aa84ad20e7ad74dcd31b
(cherry picked from commit ddc9622e92)
2019-09-03 22:05:20 +00:00
Tony Wickham 4feff8ba95 Don't update all apps content visibility during home animation
am: 7310bb4b5c

Change-Id: I92382497e4444e2ca1d1951c44646bc5047a6f36
2019-08-30 16:22:51 -07:00
Tony Wickham 7310bb4b5c Don't update all apps content visibility during home animation
We already set the all apps content visibility = GONE at the start of
the gesture to prevent relayouts, but when animating home we were
inadvertently changing it to INVISIBLE, causing a relayout and jank.

Bug: 140308849
Change-Id: I285746f8ac8f3f857282e22ebec8eebd0b98647f
2019-08-30 22:10:55 +00:00
Andy Wickham ddc9622e92 Reduces padding of the Overview shelf in no button mode.
Before: https://screenshot.googleplex.com/iw6baTCfoy2.png
After: https://screenshot.googleplex.com/8CcsQvLhYDo.png
Desired: https://b.corp.google.com/action/issues/139551306/attachments/26925873?download=false

Test: Examined before and after padding and verified 3-button is unaffected.
Fixes: 139551306

Change-Id: Ia416399cf25e7c6c2fb8aa84ad20e7ad74dcd31b
2019-08-29 11:11:12 -07:00
Samuel Fufa 19b15701ce Light QSB to Dark QSB transition lags
Test: Manual (slowmo video)
Bug:139893571
Change-Id: I652a1d9daf52b1a30643ba92f8ea06b68cef4cf0
2019-08-27 12:30:44 -07:00
Vinit Nayak b57c577669 Merge "Add unique id to trace logs through recents animations" into ub-launcher3-master 2019-08-26 22:55:01 +00:00
Vinit Nayak 9b26e63f90 Add unique id to trace logs through recents animations
Generate a 3 digit number and append it to
log statements here as well as in platform.

fixes: 134619041
Test: Inspected log output with adb shell dumpsys activity service TouchInteractionService

Change-Id: I52a76dd2950565b246384d7766fdede9e28f5bb9
2019-08-26 15:10:21 -07:00
vadimt 0d6f41bef2 Saving screenshots for failures in NavigationModeSwitchRule
am: f13eaa0242

Change-Id: I9a3b4e93491a02263fd90640b3cc9d55aeb41703
2019-08-23 20:56:08 -07:00
vadimt 7468bbd2d4 Adding debug tracing for All Apps appearing instead of Overview
am: 197ae725a0

Change-Id: Iab3642e2dcb4f766d490a88aa7a481a1117b98a3
2019-08-23 20:01:22 -07:00
Becky Qiu 71959e59d2 Merge "Move swipe actions on container logging to west world." into ub-launcher3-qt-qpr1-dev
am: 6d0d8969f6

Change-Id: I2229ea7c878ac84b00110235df65ced2f9baf171
2019-08-23 20:01:05 -07:00
vadimt f13eaa0242 Saving screenshots for failures in NavigationModeSwitchRule
Change-Id: I732076a5eb14b181f560024e2780e2012a81fd95
2019-08-23 14:18:32 -07:00
vadimt 197ae725a0 Adding debug tracing for All Apps appearing instead of Overview
Bug: 139941530
Change-Id: Ia9827c6edd48c559e9602e1e37de83293517ad5e
2019-08-23 12:11:00 -07:00
Becky Qiu f0a014d7ff Move swipe actions on container logging to west world.
Test: manual
Bug: 137777105

Log result for swiping in and out of -1 screen.
  data {
    elapsed_timestamp_nanos: 597609736235111
    atom {
      launcher_event {
        action: SWIPE_LEFT
        src_state: HOME
        dst_state: HOME
        is_swipe_up_enabled: true
      }
    }
  }

  data {
    elapsed_timestamp_nanos: 597610569783111
    atom {
      launcher_event {
        action: SWIPE_RIGHT
        src_state: HOME
        dst_state: HOME
        is_swipe_up_enabled: true
      }
    }
  }


Change-Id: Ic84d3c32d1c9f780f13ec5cd6320e9f1d610f018
2019-08-22 16:27:49 -07:00
Sunny Goyal 6fe3eec95c Moving various common executors to a single location
Change-Id: I44bca49b8adb6fa22c3b48d10f674e42c28d792c
2019-08-20 14:36:17 -07:00
Tracy Zhou 4fa6f63ffd Make sure that live tile overlay is added only once.
Users report seeing empty launcher. After adding some logging, live tile
overlay can be added twice and removed only once. I added some logic to
make sure that it can only be added once.

Test: manual
Fixes: 135864059
Change-Id: I9d3325c56e76654f1397cc65979b97a6c0a80aee
(cherry picked from commit d3ef57b4dd)
2019-08-20 18:16:28 +00:00
Vadim Tryshev f24ae74cd2 Merge "Extending the list of test owners" into ub-launcher3-qt-qpr1-dev
am: 1cbdcb2961

Change-Id: I5f01dc9b50cc33499bd9cb88913157802656cd52
2019-08-16 10:56:32 -07:00
Vadim Tryshev 1cbdcb2961 Merge "Extending the list of test owners" into ub-launcher3-qt-qpr1-dev 2019-08-16 17:36:54 +00:00
Hyunyoung Song 27df700f05 Merge "Make TogglableFlag backed by DeviceConfig for e2e testing" into ub-launcher3-qt-qpr1-dev
am: 96eba3aea6

Change-Id: I738256f1623119a61197c03008e098b066161542
2019-08-15 16:03:32 -07:00
Hyunyoung Song 96eba3aea6 Merge "Make TogglableFlag backed by DeviceConfig for e2e testing" into ub-launcher3-qt-qpr1-dev 2019-08-15 22:25:33 +00:00
Hyunyoung Song d4204437de Make TogglableFlag backed by DeviceConfig for e2e testing
Bug: 138964490

TL;DR;; need this to be part of QQ1 or QD1 to verify if DeviceConfig
can be supported for launcher toggleableFlags.

Not handled in this CL:
- When flag is locally modified, that will override the flag value
How that scenario is handled should be discussed separately and is not
within scope of this CL.

Change-Id: I2e6694a40bee9202ed0b0d559e3b5607634071bf
2019-08-15 14:02:28 -07:00
vadimt a81be5003c Extending the list of test owners
Otherwise, changes in tests would require my-only approval.

Change-Id: Ia957a28a5a8e55dc2ee4efdf9a46c91511d3e611
2019-08-14 17:18:45 -07:00
TreeHugger Robot 46463f6a19 Merge "Adding support for storing keywords in iconCache" into ub-launcher3-qt-qpr1-dev 2019-08-14 23:08:43 +00:00
Felipe Leme 0940c487b1 Fixed PredictionAppTracker as service might not be available on device.
am: 7ca46ba2ee

Change-Id: Ib7eed879bdb25291cd5faefa5e2176aed0b32095
2019-08-14 15:53:49 -07:00
Sunny Goyal 934ebd087b Adding support for storing keywords in iconCache
Change-Id: I1183e63a6556ebfb3eee5df23d149e09728193a9
Merged-In: I1183e63a6556ebfb3eee5df23d149e09728193a9
(cherry picked from commit e529a86fbd)
2019-08-14 22:12:49 +00:00
Felipe Leme 7ca46ba2ee Fixed PredictionAppTracker as service might not be available on device.
Fixes: 139416391
Bug: 135218095

Test: echo 'in TreeHugger we trust'

Change-Id: Iea89b3d379792327657e01869c9494975e7b0306
(cherry picked from commit 214a45ee02)
2019-08-14 22:02:22 +00:00