Commit Graph

2277 Commits

Author SHA1 Message Date
Charlie Anderson 72c5d8ffde Merge "Use DoubleShadowIconDrawable to draw shadow behind archived cloud icon" into main 2024-08-08 17:38:51 +00:00
Alex Chau 1ceac5ddfe Implement e2e test for desktop windowing
Code changes:
- TaskView, GroupedTaskView and DesktopTaskView now uses different resId, so it can be differentiated by TAPL
- Extracted result handling of icon loading, so we can override in DesktopTaskView
- DesktopTaskView now load icons, so titleDescription can be loaded. When icons are loaded, contentDescription are applied to respective snapshotViews; icon unloading is ignored
- Track launchDesktopFromRecents and composeRecentsLaunchAnimator in TAPL events so we can test if the TaskView launch path is correct

Test changes:
- Added TaplTestsOverviewDesktop that move 2 TestActivities into Desktop, and launch the DesktopTaskView as static and live tile
- TaplTestsOverviewDesktop is limited to Tangor/cf_tablet only, and added LimitDeviceRule to AbstractLauncherUiTest to enable @AllowedDevices and @IgnoreLimit

TAPL changes (2 APIs added/modified):
- Changed TaskView matcher to use id/task_view_* to match all TaskView types
- When Overview is launcehd from Background, mark the currentTask after the launch as liveTile. When an OverviewTask has the same accessibility node as the liveTile, it'll expect different event when launching.
- [API change] BaseOverview.getTestActivityTask can now matches mutiple test activiites, useful for matching GroupedTaskView and DesktopTaskView; Fix a bug that getTestActivityTask wrongly use `getParent()` which is RecentsView to match activityName.
- In OverviewTask.open, we'll expect different events based on TaskView types and whether it's a live tile. Launching DesktopTaskView will in additional verify Desktop header is present on screen.
- [API change] In OverviewTaskMenu, support tapping Desktop menu and verify Desktop header is present on screen.
- Removed unused OverviewTaskMenuItem

Fix: 320313527
Test: TaplTestsOverviewDesktop
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I89261c787364901320f3acb18f01ddad5f62d17c
2024-08-08 10:37:40 +01:00
Charlie Anderson 99147f53e0 Use DoubleShadowIconDrawable to draw shadow behind archived cloud icon
- Refactor Launcher3 ShadowInfo out of DoubleShadowBubbleTextView

Bug: 350758155
Test: locally verified + screenshot test
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: I8e5e5936296fafbfbf3caf80a936ca1038c125e3
2024-08-07 11:56:33 -04:00
Vadim Tryshev 9fc3734030 Clearing package data as recommended by owners of the "pm clear" command
Bug: 353541583
Test: running on abtd
Flag: NONE test change
Change-Id: I227eb145f5c2fa5c07972bae15fb66e69e623dd8
2024-07-31 00:50:00 +00:00
Treehugger Robot 779c79129b Merge "Fix grid migration item copy bug" into main 2024-07-30 20:19:19 +00:00
Brandon Dayauon dfb1722afc Merge "Make a dummy view at the bottom of all apps" into main 2024-07-30 20:15:26 +00:00
fbaron 5ff84328f0 Fix grid migration item copy bug
When migrating from a grid with 2+ copies of the same item to a grid that has less copies of that item, but more than 0, the extra copies don't migrate to the new grid.

Bug: 354946925
Test: ValidGridMigrationUnitTest
Flag: EXEMPT bugfix
Change-Id: I76ad0cb0f5abe9b5bf895c07467fc05986e9fea4
2024-07-30 10:11:58 -07:00
Brandon Dayauon 4a024c0834 Make a dummy view at the bottom of all apps
This is so that user can scroll all the way to bottom of all apps.
- updated tests to account for this new view

bug:340936636
Test manually:
before:https://drive.google.com/file/d/18mKMAedQh2uUOR2G4U_ZORIKP2tkRmEk/view?usp=sharing
after:https://drive.google.com/file/d/1UEl3kBfeInqxsgF2HwCfzOBEcsEqdbJ4/view?usp=sharing
Flag: NONE addingViewToBottomOfAllApps

Change-Id: Ib4b67a66cfc7ec2ba0dbbe211a241f244d204aaf
2024-07-29 14:58:25 -07:00
Brandon Dayauon 0ffb2d5530 Merge "Create floatingMaskViewTest and make FloatingMaskView testable." into main 2024-07-25 05:00:46 +00:00
Brandon Dayauon a616e79764 Create floatingMaskViewTest and make FloatingMaskView testable.
bug: 354209068
Test: presubmit locally
Flag: NONE writing test for floatingmaskview
Change-Id: I90cbed18a908279365af185330fb2dc1e747ebff
2024-07-24 15:32:36 -07:00
Shamali Patwa b4d185e3cc Merge changes from topic "popup-refactor" into main
* changes:
  Delete the unused code from popup provider
  Update references that read popup data provider to use picker provider
  Update references that wrote widget data to popup data provider
  Move widget related listeners to widget picker data provider
  Define widget picker data provider separate from popup provider
  Create a separate class for widget related methods from popup provider
2024-07-24 18:46:35 +00:00
Treehugger Robot e3078707a0 Merge "Move more tests to deviceless" into main 2024-07-23 23:16:08 +00:00
Liam Lee Pong Lam c1d3fa453f Merge "Fixes SettingsChangeLoggerTest failures" into main 2024-07-23 21:35:41 +00:00
Anushree Ganjam 7c32ae9acf Move more tests to deviceless
Bug: 353339741
Test: Manual
Flag: TEST_ONLY
Change-Id: Ib43d5a17feb812b08d9749b1bf6dcacabf205d47
2024-07-23 13:57:28 -07:00
Shamali P 5a1b372536 Update references that read popup data provider to use picker provider
Covers the UI references related to widget picker or its shortcut.

Test: Existing tests
Flag: EXEMPT minor refactoring
Bug: 353347512
Change-Id: Ifed1b7600ca9836df147949f3740ca1e89acd04a
2024-07-23 20:16:50 +00:00
Liam, Lee Pong Lam 80ffa83957 Fixes SettingsChangeLoggerTest failures
To revert the preference change on PreviewItemManagerTest for on-device
test.

Bug: 354157494
Test: Unit tests
Flag: EXEMPT bugfix
Change-Id: I966cbd7bf85b0336e131c6e9e4bb306b3700a928
2024-07-23 19:33:27 +00:00
Charlie Anderson e17788e9b8 Merge "[Test Week] add unit tests for InstallSessionTracker" into main 2024-07-23 18:55:55 +00:00
Charlie Anderson 528c716182 [Test Week] add unit tests for InstallSessionTracker
6 public methods tested, 8 unit tests total
no previous test class

Bug: 353303621
Test: unit tests
Flag: TEST_ONLY
Change-Id: Ie2b5c88566c1a512e534654ccc7db1ec6b277a83
2024-07-23 13:05:28 -04:00
Charlie Anderson 2abb3eb582 Merge "[Test Week] Add unit tests for UserCache" into main 2024-07-23 16:34:39 +00:00
Sebastián Franco 7d97bfbf0a Merge "Add unit test for FolderNameInfosTest" into main 2024-07-22 22:02:22 +00:00
Treehugger Robot 76a048d072 Merge "Test Week - Add test for PageIndicatorDots.java" into main 2024-07-22 18:42:02 +00:00
Treehugger Robot d8d1532825 Merge "Test Week - Add more coverage for Folder.java" into main 2024-07-22 16:22:18 +00:00
Charlie Anderson 5cb2e93e7b [Test Week] Add unit tests for UserCache
6 new methods tested.
added 1 method to help with testing.
no previous test class.

Bug: 353303621
Test: unit test
Flag: TEST_ONLY
Change-Id: I27e607df91bacc1a5dc5adc3b76a2f1758404e6a
2024-07-19 20:02:40 -04:00
fbaron aa1a462d0e Test Week - Add test for PageIndicatorDots.java
* 2  methods covered
* Adding tests for PageIndicatorDots.java

Bug: 353303621
Test: Not Applicable
Flag: TEST_ONLY
Change-Id: Ie30c0fb0e5efb041eb805e474d6d824d61238a3d
2024-07-19 16:59:21 -07:00
Sebastian Franco 85392b745f Add unit test for FolderNameInfosTest
Bug: 353588686
Flag: TEST_ONLY
Test: FolderNameInfosTest
Change-Id: I77b703548be5d45669800946874c5245e96e9b37
2024-07-19 16:57:36 -07:00
fbaron f8962a5406 Test Week - Add more coverage for Folder.java
* Refactored Folder class
* 30  methods covered
* Adding more coverage for Folder.java

Bug: 353303621
Test: Not Applicable
Flag: TEST_ONLY
Change-Id: Ibd7ca8c2121ddc71c33f91262b46e593670eadfe
2024-07-19 14:35:29 -07:00
Sebastián Franco 5217ae7fa3 Merge "Refactoring FolderPagedView to make it more testable" into main 2024-07-19 16:59:35 +00:00
Marcelo Arteiro f38d98d1a6 Align color resources in launcher projects.
This is an effort to align/unify color usage across all launcher projects and the system itself.
This fix recreates all dynamic color attributes present in the OS since many launcher areas cannot access private attributes.
It is recomemnded to use these new local attributes in all launcher areas and avoid creating new color resources when these can be used directly.

Bug: 352690172
Test: Presubmits
Flag: EXEMPT bugfix
Change-Id: Ic36b8bf70ee37f2fdd32e459e66f0e2d001d6ba2
2024-07-19 14:22:21 +00:00
Sebastian Franco cda3427fea Refactoring FolderPagedView to make it more testable
Bug: 353588686
Test: FolderPagedViewTest.kt
Flag: TEST_ONLY
Change-Id: I2a2efd9f9b2a6ac32153f8102613a3af5afc1ecf
2024-07-18 23:33:21 +00:00
Fengjiang Li f28a059e5b Merge "[Test Week] Move SimpleBroadcastReceiver to multivalentTests folder" into main 2024-07-18 21:06:30 +00:00
Fengjiang Li 5c4c3bcbf3 [Test Week] Move SimpleBroadcastReceiver to multivalentTests folder
Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: I82a59b6d090df7a246ba283bbfa286c99417c876
2024-07-18 09:20:49 -07:00
Charlie Anderson 7dc0ce4019 Merge "[Test Week] Add tests for each operation in PackageUpdatedTask" into main 2024-07-17 17:55:45 +00:00
Vadim Tryshev 300ca3422f Merge "Adding screen record for the bug where we can't find a folder after dragging" into main 2024-07-17 17:00:25 +00:00
Fengjiang Li a92b80f357 Merge "[Test Week] Move ViewCacheTest.kt to multivalentTests folder" into main 2024-07-17 16:55:38 +00:00
Charlie Anderson 98c3cafcaf [Test Week] Add tests for each operation in PackageUpdatedTask
Bug:353303621
Test: unit test
Flag: TEST_ONLY

Change-Id: Ic2194fd1506c4ff5a542eac62a492f395d12886e
2024-07-17 11:06:38 -04:00
Treehugger Robot 4997c14218 Merge "Adding screen record for the bug where com.google.android.apps.nexuslauncher:id/popup_container is not present" into main 2024-07-17 14:10:16 +00:00
Vadim Tryshev 1b540e7a99 Adding screen record for the bug where Play Store is not present on the workspace
Bug: 330232490
Test: presubmit
Flag: TEST_ONLY
Change-Id: I147cd0b45298a9b34c3dfb331af80e1253c013c4
2024-07-16 18:45:05 -07:00
Vadim Tryshev 243650e2cb Adding screen record for the bug where we can't find a folder after dragging
Bug: 353600888
Test: presubmit
Flag: TEST_ONLY
Change-Id: Idc26dc294aa05a88ce590f9466e60adf2d2f4898
2024-07-16 17:40:17 -07:00
Jagrut Desai c6c95c8381 Merge "Remove getWorkspaceIconsPositions()" into main 2024-07-16 22:37:29 +00:00
Vadim Tryshev 78e9ef2b12 Merge "Increase clearPackageData timeout" into main 2024-07-16 21:52:28 +00:00
Jagrut Desai 6276f1797b Remove getWorkspaceIconsPositions()
This cl addresses
	- removing of getWorkspaceIconsPositions()
	- addition of getWorkspaceIconPosition()

getWorkspaceIconsPositions() was not reliable as it was getting any icon selector and not actually waiting for the icon of intereset.
now we wait for specific icon of interest and tests are change accordingly.

Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY

Change-Id: Ia65b9d51520763a7fbbb8d5cd3bc129496e443cc
2024-07-16 13:48:27 -07:00
Vadim Tryshev be508f4aa1 Adding screen record for the bug where com.google.android.apps.nexuslauncher:id/popup_container is not present
Bug: 349439239
Test: presubmit
Flag: TEST_ONLY
Change-Id: I177080040244462c8d1ca36ec433d36a7fbd7897
2024-07-16 13:24:33 -07:00
Vadim Tryshev eeeaa6da56 Increase clearPackageData timeout
Apparently, on slow devices the operation may time out.

Bug: 353541583
Test: presubmit
Flag: TEST_ONLY
Change-Id: I6a569810d47452012f597e412311066c33aec7bb
2024-07-16 12:31:52 -07:00
Fengjiang Li 6cd7630504 [Test Week] Move ViewCacheTest.kt to multivalentTests folder
Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: Ie969e9bffecf61bbcfd7b2132ef7a5df1d97cbed
2024-07-16 11:36:31 -07:00
Fengjiang Li 3f5e44e0cc [Test Week] Add ViewOnDrawExecutorTest
Number of new tested methods: 7

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: Ic89984fac515924cf9a16ebc6fc7028325bed386
2024-07-16 11:32:54 -07:00
Fengjiang Li 7c8f90f04a [Test Week] Add ViewCacheTest
Number of new tested methods: 3

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: I235ba375db12b9f3fac6f204018b32e692835eab
2024-07-15 16:51:10 -07:00
Sebastian Franco e84cdcc468 Promote test testAddDeleteShortcutOnHotseat
Flag: TEST_ONLY
Test: testAddDeleteShortcutOnHotseat
Bug: 338869019
Change-Id: Ib3dd4fec0e8e6b4ac9e4233172197b557890ab15
2024-07-11 17:56:44 -07:00
Fengjiang Li dd7471f3bf Merge "[Launcher Jank] Improve SimpleBroadcastReceiver.java" into main 2024-07-11 20:22:22 +00:00
Treehugger Robot 01b577432a Merge "Add screenrecord to testDragIconToPage2" into main 2024-07-11 19:27:59 +00:00
Fengjiang Li b87ad6f945 [Launcher Jank] Improve SimpleBroadcastReceiver.java
Bug: 348649441
Flag: NONE - jank fix
Test: manual - presubmit
Change-Id: I17bd7e4d7f0640522476e94edae691f983835f62
2024-07-11 11:12:29 -07:00