Commit Graph

8418 Commits

Author SHA1 Message Date
TreeHugger Robot 8eed4f30a9 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev am: 69c04c21c5 am: ab6be24eec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19976255

Change-Id: Ie607c03fb5aa6ca01648ebfeeba10cecf2d3bf80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 18:30:23 +00:00
TreeHugger Robot 69c04c21c5 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev 2022-09-19 17:12:40 +00:00
Jeremy Sim 08a9bcac1f Fix issue with Overview thumbnails appearing blank in certain situations
This CL fixes an issue where canceling any Launcher animation by entering Quick Switch would cause Overview to appear with all thumbnail tiles blank.

The issue occurred because we recently added a reset() to Overview that triggered on all state transition animation cancels. This fixed some issues, but introduced this bug.

Fixed by tailoring the reset() to only fire on animation cancels within BaseRecentsView and FallbackRecentsView.

Fixes: 246232494
Fixes: 243471493
Test: Manual
Change-Id: I175a22d52597a63e164a6f3b9353c62b199b0712
2022-09-17 16:01:46 -07:00
Jeremy Sim 85397e333f Merge "Fix two bugs with rotation in split select state" into tm-qpr-dev am: c528e7e818 am: 69a22b907f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19960985

Change-Id: I807a208f233234a6dd35ac6de5546fb0b824ccc5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 22:50:56 +00:00
Jeremy Sim c528e7e818 Merge "Fix two bugs with rotation in split select state" into tm-qpr-dev 2022-09-17 21:45:24 +00:00
Pinyao Ting 777c13eb00 Explicit Nullbility in Launcher (Part 5)
This CL addresses the nullbility in LauncherModel and update tasks.

Bug: 242895652
Test: manual
Change-Id: Ied635c944c3656f0d493b295f772aa0329b354b9
2022-09-16 17:17:16 -07:00
Vinit Nayak d887b56183 Reset TaskView transformations on orientationHandler change
* Transformations in the old orientation handler
(ex. translate X for portrait) aren't reset when
device changes to fake landscape (starts modifying translate Y).
The new translations are picked up correctly, this resets the
old ones.

Test: Bug no longer repros.
Rotated device while scrolling through tasks, no change in
behavior from before.
Can't think of other instances where tasks are in motion
and orientation handler can change.
Fixes: 233316942

Change-Id: Ie07340e69a2c93b71b1dabb8029c96ad05a4d4a1
2022-09-16 16:45:50 -07:00
Jeremy Sim 7917ff31cc Fix two bugs with rotation in split select state
This CL fixes two bugs that were triggered by rotating in split select state:
1) Rotating in split select state will no longer cause a jittery animation to play
2) Initiating split from home, then rotating will no longer create extra split placeholders on screen

The bugs were present because handleSplitSelectionState() animated every state transition into SplitSelect, including SplitSelect > SplitSelect (which happens when rotating). This caused a jittery animation to play, and in certain cases, caused additional copies of FloatingTaskView and SplitInstructionsView to be created.

Fixed by auto-skipping animations for SplitSelect > SplitSelect, and by safely removing views when entering SplitSelect (to prevent duplicates).

Fixes: 242965515
Fixes: 243088958
Test: Verified visually on-device.
Change-Id: Iab813b1fe599bfdc550fe9a1d354b28cedb4b659
2022-09-16 15:28:33 -07:00
Hongwei Wang 2515a14429 Merge "No auto-pip animation if SysUI is not available" into tm-qpr-dev am: 93f650d3e0 am: 334b1e0ee6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19969480

Change-Id: I964f5f6c6984a4d2b5e1fa85fd6c480ea3cf568c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 20:37:07 +00:00
Hongwei Wang 93f650d3e0 Merge "No auto-pip animation if SysUI is not available" into tm-qpr-dev 2022-09-16 19:26:33 +00:00
TreeHugger Robot 5a469bd163 Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev am: af2fe7fd12 am: d7d05d1d7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967481

Change-Id: I3729ee399399d7bbea5e0569f132ce53690b45df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 17:52:21 +00:00
TreeHugger Robot af2fe7fd12 Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev 2022-09-16 16:50:04 +00:00
Alex Chau fa83199e62 Turn off changing depth in wallpaper picker
Fix: 246845529
Bug: 240580498
Test: manual
Change-Id: Ib8fd624c518fb4c26d2598137d056b196a0ddeb7
2022-09-16 16:39:47 +08:00
TreeHugger Robot 1508328e72 Merge "Moving ViewCapture to Quickstep level to use hidden apis." into tm-qpr-dev am: 9fb4802a67 am: 3d021d46d9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19975454

Change-Id: Ifa5a7419ff4a314b3ac1aaa9a90da6eb63d814df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 08:38:55 +00:00
TreeHugger Robot 9fb4802a67 Merge "Moving ViewCapture to Quickstep level to use hidden apis." into tm-qpr-dev 2022-09-16 06:23:07 +00:00
Stefan Andonian 5df305fed6 Moving ViewCapture to Quickstep level to use hidden apis.
Bug: 242867462
Test: Compilation succeeded while using private flags.
Change-Id: I9b15967b594963c5573ea1a0000b60f7c705da95
2022-09-16 03:36:15 +00:00
TreeHugger Robot cee4a9b588 Merge "Revert "Using Transaction directly instead of building surface p..."" into tm-qpr-dev am: 3187928c51 am: c3f2fcea3e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19971330

Change-Id: I0d5f920d02125a61380c32007b01956a0baa9a54
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 01:42:14 +00:00
Schneider Victor-tulias 8e2781fa9a Merge "Remove redundant start recents animation logs" into tm-qpr-dev am: 03732ff0f8 am: cb7e57bd5a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19956393

Change-Id: Ia173460b0a2d2723830895230fffc659a1c83266
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 21:43:10 +00:00
Schneider Victor-tulias 53a54000ec Merge "Reuse log IDs when a GestureState is being reused" into tm-qpr-dev am: ff7e5382b5 am: ab78301082
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944062

Change-Id: I0ae0146e1a117c05ce50b2df73f4072013762298
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 21:43:09 +00:00
Schneider Victor-tulias fe71f79735 Merge "Update ActiveGestureLog to print logs from oldest to newest" into tm-qpr-dev am: 11507173a1 am: 3e6519bab1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944061

Change-Id: I3ddb22630ea12b21ab461835b85cc678acb76319
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 21:43:07 +00:00
Sunny Goyal 9925bbd147 Revert "Using Transaction directly instead of building surface p..."
Revert "Removing unused surface transaction wrappers"

Revert submission 19933596-tcompat

Reason for revert: b/246899728
Reverted Changes:
I31123dff7:Using Transaction directly instead of building sur...
I2e2526d21:Removing unused surface transaction wrappers

Change-Id: I63d1d8bb723b7bd05d345fb21a67f88e5fb36bc1
2022-09-15 14:07:51 -07:00
Schneider Victor-tulias 03732ff0f8 Merge "Remove redundant start recents animation logs" into tm-qpr-dev 2022-09-15 20:23:46 +00:00
Schneider Victor-tulias ff7e5382b5 Merge "Reuse log IDs when a GestureState is being reused" into tm-qpr-dev 2022-09-15 20:23:46 +00:00
Schneider Victor-tulias 11507173a1 Merge "Update ActiveGestureLog to print logs from oldest to newest" into tm-qpr-dev 2022-09-15 20:23:46 +00:00
TreeHugger Robot 97ad678adc Merge "Update secondary task menu check to explicitly check for phone" into tm-qpr-dev am: 7532df84c5 am: 2d061d279f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944101

Change-Id: I2b96bf5e7510a9cc44eca665fc90ce6a8e19073a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 20:20:52 +00:00
Hongwei Wang 7da9a38669 No auto-pip animation if SysUI is not available
The Launcher crash in the bug is a consequence of SysUI being stopped
due to ANR. In this rare case, we should not start the auto-pip
animation to further crash the launcher.

Bug: 245947669
Test: N/A
Change-Id: I2e99a82d4dccf302788fdb0752f70091fe5a18a3
2022-09-15 12:49:29 -07:00
TreeHugger Robot 7532df84c5 Merge "Update secondary task menu check to explicitly check for phone" into tm-qpr-dev 2022-09-15 19:12:38 +00:00
Pat Manning e0a7478fde Refresh taskbar apps show on DeviceProfile change.
Fix: 244269456
Test: manual
Change-Id: Ie95813c77b45b03a824542a25d1349675b1825c0
2022-09-15 14:42:57 +01:00
TreeHugger Robot f6b9723bd6 Merge "Add metrics sources for split invocation" into tm-qpr-dev am: e58e123bd7 am: 1c46220a98
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19820319

Change-Id: I1b7e2debef2cbe78f110403f7ce80e8873b28708
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 10:00:15 +00:00
TreeHugger Robot e58e123bd7 Merge "Add metrics sources for split invocation" into tm-qpr-dev 2022-09-15 09:35:12 +00:00
Zimuzo Ezeozue d6bf600aee Merge "Disable Launcher AIDL_TAG tracing special case" 2022-09-15 07:29:07 +00:00
Tony Huang 8b44e3a53c Merge "Fix split divider flash if swipe again quickly" into tm-qpr-dev am: ade8b9d753 am: 2bf9faa538
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19903469

Change-Id: I636366ff6ac6adc9be0f0ae563aff68f28d0493e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 05:34:49 +00:00
Jeremy Sim 1ccec2e53a Update animations for TM-QPR: Overview > OverviewSplitSelect transition am: 21a5b12b6f am: 7439620808
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19728187

Change-Id: If7323b12cc2653bf914d8345a123e00c1aadee9d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 04:55:16 +00:00
Tony Huang ade8b9d753 Merge "Fix split divider flash if swipe again quickly" into tm-qpr-dev 2022-09-15 04:46:26 +00:00
Schneider Victor-tulias 2c76db1d4d Merge "Add onTaskAppeared error detection." into tm-qpr-dev am: 56c92899f1 am: 86b01d948e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19936975

Change-Id: I87765df4d2eff0506923d3f8922fb5387503b5f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 02:09:21 +00:00
Jeremy Sim 21a5b12b6f Update animations for TM-QPR: Overview > OverviewSplitSelect transition
This change updates the Overview > OverviewSplitSelect animation to the latest spec. This is a re-upload of a previous change, ag/19464657, but no longer will cause the b/241165022 issue.

Includes:
- New timings
- Task thumbnails slide in with an "overshoot" animation
- Icons fade out and fade in appropriately
- SplitInstructionsView has a new compound "unfold" animation

Bug: 236760307
Test: Manual on tablet. Made sure the b/241165022 issue is fixed.
Change-Id: Ia22f6b6d7b9474b782e693fae2320a34a2985b18
2022-09-14 18:06:05 -07:00
Winson Chung d2db9167a8 Merge "Update Launcher for removed shared wrappers" into tm-qpr-dev 2022-09-14 22:03:05 +00:00
Schneider Victor-tulias b7fd614a42 Remove redundant start recents animation logs
Fixes: 227514916
Test: completed several gestures and checked the logs
Change-Id: I75ef19efca92e0bc8e9f38f72c440f0c53857322
2022-09-14 14:30:56 -07:00
Schneider Victor-tulias 75260282e5 Reuse log IDs when a GestureState is being reused
Fixes: 227514916
Test: completed several gestures in rapid succession then checked the logs
Change-Id: Ieecde51fbf0398470f85bf54d71ccd4a765463e8
2022-09-14 21:22:46 +00:00
Sunny Goyal e5f8f0ec23 [conflict] Using Transaction directly instead of building surface params am: fd2c9eb04e am: bb2c85a3eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19933596

Change-Id: Id10383b9dfd5319ba0570a65863fd0cf2156226b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-14 21:11:20 +00:00
Vinit Nayak 7fb4f997c4 Add metrics sources for split invocation
* See design doc in bug description for
usage/details

Bug: 231369744
Change-Id: I0c0ec11e924e387c523b5ac5feb7cabf78eaa748
2022-09-14 11:58:03 -07:00
Schneider Victor-tulias 56c92899f1 Merge "Add onTaskAppeared error detection." into tm-qpr-dev 2022-09-14 17:39:27 +00:00
Winson Chung 3f649ef892 Update Launcher for removed shared wrappers
- Launcher can reference system code directly now

Bug: 219861883
Test: Builds/Presubmit
Change-Id: I3f656b6c7fce93243ccb7591e52441e99137dec6
Merged-In: I3f656b6c7fce93243ccb7591e52441e99137dec6
2022-09-14 17:14:32 +00:00
Winson Chung d51fdaa573 Merge "Update Launcher for removed shared wrappers" 2022-09-14 16:30:42 +00:00
Tony Huang 3fc57cb50a Fix split divider flash if swipe again quickly
This bug caused by divider will be set to show when animation
cancelled, because split screen will show divider itself when
both split visible, this call might be unnecessary. Fix it by
removing these lines.

Add surface valid checking when running divider animation to
avoid crash caused if surface was released during animation.

Fix: 242823773
Bug: 246371786
Test: manual
Test: pass existing tests
Change-Id: I10aaf86e4164327b1c6c2f323c62b246c600228a
2022-09-14 15:37:02 +08:00
Tracy Zhou a0ca1ebd54 Merge "Fix subsequent tabbing in recents from alt tab not working" into tm-qpr-dev am: 39d9eb819c am: de315c24d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19938037

Change-Id: Ib92a6b7b50dd55a3bf71c7c274f4c10607090ac0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 23:49:53 +00:00
TreeHugger Robot fcb43caf6b Merge "Add error detection for aborting the recents scrolling during transition to home" into tm-qpr-dev am: 839297e232 am: d675769721
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19873684

Change-Id: I4e7fba7f2c510893d744317eedad78934e9b7a3c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 23:46:58 +00:00
TreeHugger Robot fb77b34d1d Merge "Change wallpaper depth in widget picker" into tm-qpr-dev am: 3ded296cee am: 9c43626a36
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852193

Change-Id: Ie17c03949c3ac30156129182fec88f19cfb46e1d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 23:38:23 +00:00
Schneider Victor-tulias 350ebd8f5c Update ActiveGestureLog to print logs from oldest to newest
Fixes: 227514916
Test: completed several gestures and checked the logs
Change-Id: I8dca4a75c46f7324684a3ba297d1946105825fa6
2022-09-13 15:33:55 -07:00
Schneider Victor-tulias 56fc942e48 Add onTaskAppeared error detection.
Bug: 246340474
Test: used several gestures normally, and reproduced b/246340474, then checked logs
Change-Id: I8cdcb9c00c5cacc7737e796dbf5adf544c0220a7
2022-09-13 15:31:06 -07:00