Commit Graph

14494 Commits

Author SHA1 Message Date
TreeHugger Robot 3ea398ecb7 Merge "Cleaning Utilities.java" into tm-qpr-dev 2022-11-17 02:39:38 +00:00
TreeHugger Robot ff86dd930d Merge "[QL-v2] Add logging for quick launch." into tm-qpr-dev 2022-11-17 02:01:56 +00:00
Sihua Ma c6bd4ad21f Merge changes If022ec8d,I34341937 into tm-qpr-dev
* changes:
  Move LauncherWidgetHolder to widget package
  Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder
2022-11-17 01:46:55 +00:00
TreeHugger Robot 579ddc7aff Merge "Removing unnecessary event dispatching via touch-controller. Instead using a poll method similar to other touch controllers" into tm-qpr-dev 2022-11-17 01:22:54 +00:00
Sunny Goyal 47d4d81b4f Cleaning Utilities.java
> Removing some unused methods
> Moving some specialized methods to corresponding classes
> Removing GridProvider check as it is released

Bug: 257555083
Test: Presubmit
Change-Id: Ib0f8c673d018071d3f4b7d9247e0a35718ab009c
Merged-In: Ib0f8c673d018071d3f4b7d9247e0a35718ab009c
2022-11-17 01:06:16 +00:00
Sihua Ma 8bbfcb6581 Move LauncherWidgetHolder to widget package
Making LauncherAppWidgetHost package-private as well

Bug: 235358918
Test: N/A
Change-Id: If022ec8d429579a972991872b2dc11db76719341
2022-11-16 14:31:14 -08:00
Sihua Ma aa2b872d1c Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder
Test: N/A
Bug: 235358918
Change-Id: I343419376491203a195154f2766b12e5def38879
2022-11-16 14:30:08 -08:00
Sunny Goyal 6abdd5c735 Removing unnecessary event dispatching via touch-controller.
Instead using a poll method similar to other touch controllers

Bug: 259447608
Test: Verified on device
Change-Id: I5c29c7c1b87acb668ea93e9f44fb685379de54fb
2022-11-16 13:58:05 -08:00
Jon Miranda c3fc8da433 Merge "Check NPE and log error condition for enableTransientTaskbar in test harness." into tm-qpr-dev 2022-11-16 20:43:27 +00:00
Federico Baron 22ea023a32 Merge "Fix spring-loaded folder animation offset bug" into tm-qpr-dev 2022-11-16 20:07:09 +00:00
Alex Chau 0ea0b898a5 Merge "Put IDP.getDeviceProfile logging behind a feature flag" into tm-qpr-dev 2022-11-16 19:10:27 +00:00
Anushree Ganjam 9dd595b972 Merge "Introduce imeHeight in KeyboardStateManager." into tm-qpr-dev 2022-11-16 18:38:39 +00:00
Jon Miranda 182d1e93dd Check NPE and log error condition for enableTransientTaskbar in test harness.
Fixes: 259337908
Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: Ifa929dca18437ae101cf3290feda4209790604d2
2022-11-16 08:04:57 -08:00
Jon Miranda 47bea3eb5b Merge "Move feature flags that have been changed to the top of the list." into tm-qpr-dev 2022-11-16 02:18:50 +00:00
TreeHugger Robot c2f03ae080 Merge "Add ImpressionLogger to StatsLogManager" into tm-qpr-dev 2022-11-15 23:35:21 +00:00
TreeHugger Robot 8a03be1880 Merge "Added Tests for Secondary Display Launcher" into tm-qpr-dev 2022-11-15 22:41:51 +00:00
TreeHugger Robot 87ccecb6fc Merge "Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""" into tm-qpr-dev 2022-11-15 22:31:55 +00:00
Federico Baron c7e76005e0 Fix spring-loaded folder animation offset bug
The folder close animation is offset due incorrect scaling in SpringLoaded mode. We fix the folder offset by scaling offsetX() and offsetY() by the scale of the workspace in spring loaded mode (scaleRelativeToDragLayer), and the offset of the preview icons is fixed by dividing previewItemOffsetX by initialScale rather than initialScale / scaleRelativeToDragLayer

Fix: 255420905
Test: manual
Change-Id: I305c1047c14c4c9f1b4c3bd0143e9bb764c71524
2022-11-15 12:51:57 -08:00
Jon Miranda deaff5fbb4 Move feature flags that have been changed to the top of the list.
Bug: 259270717
Test: change flag, check that its at the top of the sorted list
Change-Id: Ib10882e8de625471ef430a2f3162b85f9c6e1c1d
2022-11-15 20:16:18 +00:00
Sihua Ma 3ccbba3e9f Merge "Making talkback focus on the widget after the resize" into tm-qpr-dev 2022-11-15 18:32:55 +00:00
Sebastián Franco 659197407b Merge "Fix the wiggle reorder aniamtion stopping if dragging" into tm-qpr-dev 2022-11-15 18:28:29 +00:00
Anushree Ganjam 30c1043b1c Merge "Add SearchResultCode to onSearchResult()" into tm-qpr-dev 2022-11-15 18:17:33 +00:00
Sam Dubey 3d24f6735a Merge "Revert "Reorder widgets no longer overlaps when no space is avai..."" into tm-qpr-dev 2022-11-15 14:28:11 +00:00
Sam Dubey 3dad4fec9f Revert "Reorder widgets no longer overlaps when no space is avai..."
Revert "Reorder widgets no longer overlaps when no space is avai..."

Revert submission 20427045-258023561

Reason for revert: Likely causing NPE while running launcher shortcut tests (Part of DM+Platinum monitor rotation. The revert won't be submitted if proven otherwise)

Bug: 259234533
Reverted Changes:
Ie599f7cb7:Reorder widgets no longer overlaps when no space i...
I04b262ecc:Reorder widgets no longer overlaps when no space i...

Change-Id: I4cc552588c8099356bc3f05c4c63d17a524f2a24
2022-11-15 13:24:19 +00:00
Luca Zuccarini 56ccb4eda5 Merge "[Toast] Update A-Z <-> Toast transition for drawable backgrounds." into tm-qpr-dev 2022-11-15 10:54:03 +00:00
TreeHugger Robot e2334d76fe Merge "Reorder widgets no longer overlaps when no space is available" into tm-qpr-dev 2022-11-15 09:53:02 +00:00
Saumya Prakash 7eac37254b Add a flag for the redesigned Gesture Nav Tutorial
We plan to improve the gesture navigation education tutorial as
discussed and shown in go/gesture-nav-education.

Test: N/A
Bug: 241813570
Change-Id: I2ad8d12cf14c1b3f0eec3208ad12a24ac54b9dbc
2022-11-14 22:38:21 +00:00
Alex Chau 2426514bf6 Put IDP.getDeviceProfile logging behind a feature flag
- To avoid memory regression in performance testse

Fix: 257359801
Test: manual
Change-Id: I5ed768d90dba149eeb8f7be7d1d229b0b599a485
2022-11-14 21:19:44 +00:00
Sihua Ma 7a382f139d Making talkback focus on the widget after the resize
Fix: 216386890
Test: Manual
Change-Id: I79b0280c0f24a81be44e1578755ed90cf3343f88
2022-11-14 13:12:44 -08:00
Federico Baron c0dc93d384 Add flag for 'Improve widget picker UX on large display form factor'
here's how we plan on improving widget picker under this flag: https://docs.google.com/presentation/d/1mcdjJWutr-ZGbPOndhe1D8YCdCh6EbO8eNyK3YMMVEY/edit#slide=id.g1571d496dda_0_145
Test: N/A
Bug: 256684299

Change-Id: I365516b43e70a37c7b93e089b6822c58a0f81540
2022-11-11 22:24:18 +00:00
Anushree Ganjam c36593139c Introduce imeHeight in KeyboardStateManager.
Bug: 204781396
Test: Manual
Change-Id: If9dc9427a73ab22d6418edb9c954e79fd0958395
2022-11-11 19:20:16 +00:00
Anushree Ganjam 6024013953 Add SearchResultCode to onSearchResult()
Bug: 204781396
Test: Manual
Change-Id: Ia776be0fdd42e1d5fa405911e28d9b0a12c1fdde
2022-11-11 18:26:58 +00:00
Anushree Ganjam 96c72745ae Add ImpressionLogger to StatsLogManager
go/toast-search-impression-logging

Bug: 204781396
Test: Manual
Change-Id: If00027581000d315590ce2fac46428cbf173da49
2022-11-11 18:23:25 +00:00
Sebastian Franco 592e2691f6 Fix the wiggle reorder aniamtion stopping if dragging
We were using the minimum span to calculate the cell position
of the widget and if you move slightly because the minimum is usually smaller than the current size it would calculate wrong cell positions
that are change more frequently because it's smaller.

Also, I went back and moved
performReorder(... CellLayout.MODE_SHOW_REORDER_HINT) with the
alarm if block as it was before one of my refactors, it still works
if they are separate but is harder to think about the logic if they
are divided so it's better to all be in one block.

Fix: 255421416
Test: manual testing, reordering and making sure the animation is playing well.
Test: atest ReorderWidgets (to make sure the reorder is not broken)
Change-Id: I3eff5bc9f21fda8f2f8908380397d8639ac15ff9
2022-11-10 21:53:33 +00:00
Anushree Ganjam b63cc3f113 Merge "Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags." into tm-qpr-dev 2022-11-10 20:31:01 +00:00
Anushree Ganjam fd7afb707a Merge "Add OnLayoutCompleted() Listener." into tm-qpr-dev 2022-11-10 20:19:42 +00:00
TreeHugger Robot 267d7179cd Merge "Create test for default grid" into tm-qpr-dev 2022-11-10 19:37:11 +00:00
Vinit Nayak 2ca82f38e4 Merge "Improve Split portrait gesture animation" into tm-qpr-dev 2022-11-10 19:19:39 +00:00
Jon Miranda f0349354ec Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""
This reverts commit e7011d2b87.

Reason for revert: attempt to fix test issues

- Instead of using SharedPrefs which can be flaky anyways,
  we pass along a boolean to test transient taskbar when
  we are in the test harness

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I7c15a97363adc377f29853c1fe60b1960c77bfc3
2022-11-10 11:11:14 -08:00
Anushree Ganjam 29eb74f9bd Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags.
Bug: 204781396
Test: Manual
Change-Id: Icd1170d8fc349ca3a50836ef0d1d0c9a0c793002
2022-11-10 17:41:20 +00:00
Anushree Ganjam f213afc0a7 Add OnLayoutCompleted() Listener.
OnLayoutCompleted() Listener for RecyclerView.LayoutManager#onLayoutCompleted(RecyclerView.State) so we can do impression logging when RecyclerView has finished laying out the items.

Bug: 204781396
Test: Manual
Change-Id: I59b81e98415b2b0c6f3b26d2c41d348242342048
2022-11-10 17:38:59 +00:00
Luca Zuccarini 431f05b3a0 [Toast] Update A-Z <-> Toast transition for drawable backgrounds.
This and the other change in the topic are protected by a new feature
flag (included here).

Bug: 229297414
Bug: 248006105
Test: manual (see screenshots and recordings in the second bug)
Change-Id: I3478d7e194ee5d3bc4f8affdadbec969c033d084
2022-11-10 14:43:20 +00:00
Thales Lima b67bfa7512 Create test for default grid
Fixes: 256044695
Test: DeviceDefaultGridTest
Change-Id: Ie0a4de12f777ad3d15020252b2f67b575cc0eca9
2022-11-09 14:00:44 +00:00
Luca Zuccarini 3d69d9bd98 Merge "Fix IME sync flicker with 3-button navigation." into tm-qpr-dev 2022-11-09 10:19:30 +00:00
TreeHugger Robot 8dd01f3ac2 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev 2022-11-09 01:07:11 +00:00
Jon Miranda e7011d2b87 Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."
This reverts commit d5a6b5f688.

Reason for revert: Breaks tests due to "SharedPreferences in credential encrypted storage are not available until after user is unlocked"

Bug: 258256906
Change-Id: I1de69249685f9d2e71183357cf3eda8d443c7d97
2022-11-08 21:56:52 +00:00
Jon Miranda 3153cd9b97 Proposal to move Developer Options to top of Home settings if studio build.
- Increases developer efficiency by avoiding the need to scroll

Bug: 258263867
Test: manual
Change-Id: I6cb46fdd12b51f8c45017f823dd4b2458e21fc72
2022-11-08 20:50:42 +00:00
Vinit Nayak 29e71bdd72 Improve Split portrait gesture animation
* Crop out taskbar from bottom thumbnail for vertical split
* TODO: Need to re-calculate thumbnail sizes if taskbar
 is stashed. There's also a very slight rounding error
 somewhere even in the unstashed case that needs to be
 revisited

Bug: 219411750
Test: Start gesture animation in split in potrait
Change-Id: I35f2415e13af7467e0735ac8865cee0e3e3d27f8
2022-11-08 11:33:08 -08:00
Sebastian Franco 893615f241 Reorder widgets no longer overlaps when no space is available
In the previous refactor I got confused between findNearestVacantArea
and findNearestArea thinking the later did the former. So it ignored the occupied spaces and treat it as a solution.

Changed the names to prevent further confusion.

Fix: 258023561
Test: manual, need to add this case to ReorderWidgets
Change-Id: I04b262ecce168d5c93a9d66ef62d5b0e148e38b6
2022-11-08 19:02:15 +00:00
Luca Zuccarini 81f5cee2cb Fix IME sync flicker with 3-button navigation.
With keyboard sync, the dismissal is handled by the animator. Calling
hideKeyboard() on top of that causes the two signals to conflict with
each other, resulting in the visible flicker and extra delayed hiding
animation.

Fixes: 251185052
Test: manual, see videos in the bug

Change-Id: Ic12ad304ef9e4b6a51279ce18d6c09ba93bd59be
2022-11-08 17:26:46 +00:00