Commit Graph

16600 Commits

Author SHA1 Message Date
Sunny Goyal 3e596d3aa4 Updating the top scrim to also use dynamicaly generated bitmap
Bug: 237818532
Test: Verified on device
Flag: N/A
Change-Id: I22ceb470677ab9df53e40fb78f0292b7fd5e2241
2023-06-01 19:20:04 +00:00
Sunny Goyal 50c9126cc3 Merge "Adding main thread binder tracing in development build." into udc-qpr-dev 2023-06-01 17:27:21 +00:00
Sunny Goyal 3db98b1152 Adding main thread binder tracing in development build.
> Unifying multiple binder tracing implementations
> Removing wallpaper customization check as it has been rolled out
  few years ago, this avoids additional RPC to check for wallpaper
> Removing RaceConditionReproducer as it is not used anywhere and
  is not integrated with this tracing anymore

Bug: 273718665
Test: Presubmit
Flag: N/A
Change-Id: I801af5d039a9d38d5d39e803723ec6da50a9d59f
2023-06-01 09:39:50 -07:00
Alex Chau 3e68f68528 Enable Grid only overview in teamfood
Bug: 270397206
Test: manual
Change-Id: I5f1fed8f04f63cb53af66a94ad415d3d6814245d
2023-06-01 14:29:55 +00:00
Nick Chameyev c1eafd92ab Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-qpr-dev 2023-06-01 12:55:27 +00:00
Sunny Goyal b980b529a4 Merge "Fixing icon cache thrashing due to an unsupported icon" into udc-dev am: 6c8d57d8b5 am: d063440188
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23493432

Change-Id: I040576bf5def42760d5543bf5140144fd77395da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 02:04:16 +00:00
Vadim Tryshev 01a4b4990a Merge "Fixing a flake when workspace loading never finishes." into udc-dev am: 5fe61d4ff7 am: 88ad0211ac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23493702

Change-Id: Ia6a4ac682df6d374029823333faa9746ab75d991
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 02:04:01 +00:00
Sunny Goyal 6c8d57d8b5 Merge "Fixing icon cache thrashing due to an unsupported icon" into udc-dev 2023-06-01 01:31:26 +00:00
Vadim Tryshev 5fe61d4ff7 Merge "Fixing a flake when workspace loading never finishes." into udc-dev 2023-06-01 00:50:25 +00:00
Schneider Victor-tulias 807f6d1828 Merge "Fix flaky null pointer in LauncherWidgetHolder" into udc-dev am: 2b06cbc748 am: d9a7a143f8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23454674

Change-Id: I12c4749ee9b9740796bf4380a728b678757ebdf3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 23:43:51 +00:00
Sunny Goyal 41737b3e8b Fixing icon cache thrashing due to an unsupported icon
Bug: 284032965
Test: Verified by reproducing the use case
Flag: N/A
Change-Id: I835dd545a01eb2fd7990e0fd5ad51bac0e4b1f33
2023-05-31 23:21:13 +00:00
Schneider Victor-tulias 2b06cbc748 Merge "Fix flaky null pointer in LauncherWidgetHolder" into udc-dev 2023-05-31 22:07:57 +00:00
Jagrut Desai 9edf316ca3 Merge "Fixing Toast Hiding behind Taskbar - Part 2" into udc-dev am: e208e02aba am: 3d630fdddb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23455641

Change-Id: I4b47b8d6304830311eef6545ee08bfee51554269
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 21:26:47 +00:00
Jagrut Desai e208e02aba Merge "Fixing Toast Hiding behind Taskbar - Part 2" into udc-dev 2023-05-31 20:45:37 +00:00
vadimt 9c102e5634 Fixing a flake when workspace loading never finishes.
The flake was caused by the fact that addOnDrawListener(), the redraw is not guaranteed. This ultimately results to the workspace loading never finishing.
Forcing the redraw.

Bug: 267200150
Test: atest Launcher3Tests:com.android.launcher3.celllayout.ReorderWidgets#simpleReorder --rerun-until-failure
Flag: N/A
Change-Id: I47683425150a07ab2632e2bebdeca4d304e30d1b
2023-05-31 10:59:25 -07:00
Jagrut Desai 84e959a72a Fixing Toast Hiding behind Taskbar - Part 2
Test: Visual, Manual
Bug: 282964229
Flag: not needed
Change-Id: If2373d8f0bc44a555844c78d20877e9636a7e176
2023-05-31 10:41:16 -07:00
Nick Chameyev 6d756970e7 [Unfold animation] Do not preemptively start the animation if it has run already
Currently if we open an app, unfold the device and then go to home
screen we will start the unfold animation preemptively in Launcher
because Launcher activity will receive updated configuration change
(where isTablet = true) only after going back to home screen, not
when unfolding the device.

This causes a problem because SystemUI won't send the unfold animation
events after going back home as the animation has already run, so we
end up with wrongly started animation in Launcher.

This CL fixes the issues by checking if SystemUI has finished the
animation (or if it is currently running) to avoid preemptive animation
start in this case. This is done by subscribing to the original
unfold transition progress provider which emits progress events
sent through IPC from SystemUI.

Bug: 285150685
Test: open an app on folded screen, unfold, go to home screen =>
  check that icons are not squished
Test: fold/unfold when launcher is open
Change-Id: Ic437ff4d19cbd5764635f3007d99880622150f5b
2023-05-31 17:12:08 +00:00
Kateryna Ivanova 72fbdc7976 Merge "Migrate Interpolators from Launcher3 to the public animation library" into udc-qpr-dev 2023-05-31 15:25:40 +00:00
Thales Lima 2ffa6d99a8 Merge "Implement calculations of Responsive Grid in DeviceProfile" into udc-qpr-dev 2023-05-31 13:21:17 +00:00
Nick Chameyev 28caa7586c Merge "[Unfold animation] Disable preemptive launcher animation" into udc-dev am: 0bb67d4c2c am: ff417fc486
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23476096

Change-Id: I7d26cd3c3972ce690157aec072b3251c2f02bd7e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 11:59:13 +00:00
Nick Chameyev 0bb67d4c2c Merge "[Unfold animation] Disable preemptive launcher animation" into udc-dev 2023-05-31 10:03:03 +00:00
TreeHugger Robot f7d08912fa Merge "Add LAUNCHER_APP_LAUNCH_PENDING_INTENT where an app is launched through pending intent." into udc-dev 2023-05-31 06:13:38 +00:00
TreeHugger Robot 76a7def698 Merge "Possibly fix the widget restoration bug" into udc-dev am: 7dabd57f2d am: 8fbd56b2c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23481736

Change-Id: Iade89cc8961c46bacfd3ceeec189cb5f03df635b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 03:20:09 +00:00
TreeHugger Robot 8fbd56b2c5 Merge "Possibly fix the widget restoration bug" into udc-dev am: 7dabd57f2d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23481736

Change-Id: Ia460fd62985e83f82addc5ddb6ae8f449bbfde9a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 02:16:44 +00:00
TreeHugger Robot 7dabd57f2d Merge "Possibly fix the widget restoration bug" into udc-dev 2023-05-31 01:32:53 +00:00
Anushree Ganjam adcaf22ae6 Merge "Add LAUNCHER_APP_LAUNCH_PENDING_INTENT where an app is launched through pending intent." into udc-d1-dev am: ca7f0e97db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23477755

Change-Id: I5920e153d71ea05ae0a5af3819d0fc16f7e2ed5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 00:05:03 +00:00
Anushree Ganjam cfbbf8510c Add LAUNCHER_APP_LAUNCH_PENDING_INTENT where an app is launched through
pending intent.

Bug: Bug: 282236269
Test: Manual
Flag: NA
Change-Id: I6fb15a77f32ce5914f9632f5fb77f340acd3cfda
Merged-In: I6fb15a77f32ce5914f9632f5fb77f340acd3cfda
2023-05-30 23:47:22 +00:00
Anushree Ganjam ca7f0e97db Merge "Add LAUNCHER_APP_LAUNCH_PENDING_INTENT where an app is launched through pending intent." into udc-d1-dev 2023-05-30 23:46:24 +00:00
Treehugger Robot c109f165d4 Merge "Fix widget picker crash" into udc-dev am: 6c3c6b3ae6 am: fc67846a48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23477033

Change-Id: Ia5220da7103443ee1f44925760fd9d30540f58d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 23:40:03 +00:00
Treehugger Robot 9a55a1a6f2 Merge "Fix invalid outline after widget resizing" into udc-dev am: 3b7f4eb675 am: ee93fa42ac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23470897

Change-Id: I848fedf20f02de2e7cdeb58b5ae9df29040be2d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 23:39:40 +00:00
Treehugger Robot 6c3c6b3ae6 Merge "Fix widget picker crash" into udc-dev 2023-05-30 22:53:34 +00:00
Sihua Ma 48465319f6 Possibly fix the widget restoration bug
The update will always be considered as failed because we always return 0 for all the commits.

Test: N/A
Bug: 234700507
Change-Id: I33ee8af996cef62dbc14349f9a7dd3cb72836ab6
2023-05-30 15:12:00 -07:00
Treehugger Robot 3b7f4eb675 Merge "Fix invalid outline after widget resizing" into udc-dev 2023-05-30 22:06:10 +00:00
Fengjiang Li 4f8fc56598 Merge "Clip folder chidren during folder open/close animation" into udc-dev am: a640098439 am: c4ab06d77d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23355102

Change-Id: I237fe3df960b3a279cfee416380dd7f87c65b636
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 21:47:32 +00:00
Fengjiang Li a640098439 Merge "Clip folder chidren during folder open/close animation" into udc-dev 2023-05-30 20:10:48 +00:00
Sihua Ma 734da5c1eb Fix invalid outline after widget resizing
Fix: 283778989
Test: Manual
Change-Id: I8821658a1db333159684562ba79f30fd92291fad
2023-05-30 13:03:08 -07:00
Anushree Ganjam aa0e91820b Add LAUNCHER_APP_LAUNCH_PENDING_INTENT where an app is launched through
pending intent.

Bug: Bug: 282236269
Test: Manual
Flag: NA
Change-Id: I6fb15a77f32ce5914f9632f5fb77f340acd3cfda
2023-05-30 19:10:16 +00:00
TreeHugger Robot 7ae39b1bee Merge "Add logs to see if launcher model isn't loaded when work profile app is added" into udc-dev am: 78b6e76486 am: dcf359c459
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23455279

Change-Id: I0409212df4be2e1554a6a489c65453d65e9e78c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 19:02:32 +00:00
Stefan Andonian 4439bec7aa Merge "Use LockedUserState in TouchInteractionService." into udc-qpr-dev 2023-05-30 18:55:02 +00:00
fbaron bbab64e00c Fix widget picker crash
It looks like if shouldClearVisibleEntries() evaluates to true and we clear mVisibleEntries, we get an Inconsistency IndexOutOfBounds error, the same as the one reported in the crash.

Bug: 276766307
Test: Verify that with these changes the widgets still update correctly when changing languages
Change-Id: I9f92e61d967aab2c8297cfc2fb4b04193df67650
2023-05-30 18:46:55 +00:00
TreeHugger Robot 78b6e76486 Merge "Add logs to see if launcher model isn't loaded when work profile app is added" into udc-dev 2023-05-30 17:26:53 +00:00
Nick Chameyev 0873afd7fa [Unfold animation] Disable preemptive launcher animation
Disables preemptive unfold animation by default.

Bug: 281821523
Test: unfold on launcher
Change-Id: I767f25cf0414a91c82a33cf86ca16db2e4dcfa22
2023-05-30 18:10:08 +01:00
Thales Lima 7945649c5e Implement calculations of Responsive Grid in DeviceProfile
When a grid has a responsive spec and the feature flag is on, use the new calculations for the sizes in Workspace. This shouldn't affect Scalable grids.

Fix: 277064708
Test: HomeScreenImageTest
Test: DeviceProfileDumpTest
Test: ResponsiveHomeScreenImageTest
Test: DeviceProfileResponsiveDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: Idef3d17fbfa1b2e0c82c12e7784a7584f1ba1b88
2023-05-30 16:14:34 +00:00
Kateryna Ivanova 7120373bbc Migrate Interpolators from Launcher3 to the public animation library
Test: atest
Bug: 271850966
Change-Id: Iba999f2e753764a37d35e508e707df02388432e9
2023-05-30 07:20:38 +00:00
Tracy Zhou 48ac5a0f74 Simplify trackpad multi-finger gesture recognition logic for gesture nav
Now we can use AXIS_GESTURE_SWIPE_FINGER_COUNT per ag/23288416

Test: swipe up to overview / home; workspace scroll 2-finger only / quick switch/ pull down notifications works
Bug: 284463803
Change-Id: Ie1c7d13f4683d3b9c8de6e5ea2821df73b97ca29
2023-05-27 21:16:25 -07:00
Vinit Nayak 2c353f29a2 Add logs to see if launcher model isn't loaded when work profile app is added
* Add helper method to avoid checking sDebugTracing when
logging for tests

Bug: 243688989
Flag: None
Change-Id: Id6cc3b286171eb598e593c5a8aaea6f2466aad60
2023-05-26 15:45:42 -07:00
Schneider Victor-tulias fb2affac5f Fix flaky null pointer in LauncherWidgetHolder
- LauncherWidgetHolder.startListening is called before Launcher.setupView, so it's possible for getWorkspace() to be called as part of the appWidgetRemovedCallback. Reordered these calls to fix this null pointer

Flag: not needed
Fixes: 283850341
Test: Screenshot tests
Change-Id: Ied1f23647721fc4199eab2a5a79def1e306b00f3
2023-05-26 15:09:41 -07:00
Stefan Andonian cf36a3f3a8 Use LockedUserState in TouchInteractionService.
This change was previously attempted, but failed because of a tricky issue where the LockedUserState singleton object was getting permanently set to a mock context in LockedUserStateTest, and then was failing TaplTests because isUserUnlocked was always false.

This fixes that by avoiding using the singleton LockedUserState instance in the unit tests.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly. Post-submit was tested and this CL passed all previously
failing tests: https://android-build.googleplex.com/builds/abtd/run/L12900000960898179

Change-Id: I045c9f2558a6bdacb4bfa029fbf6a07c3c190fe7
2023-05-26 17:06:09 +00:00
Vadim Tryshev ecbad7a0d9 Merge "Adding tracing for workspace loading that never finishes" into udc-dev am: 8cf338148b am: 304ecb6f24
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23414622

Change-Id: I0aedfb1de537ea8bf56ecc69a6920bf649b4b88d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-25 18:41:38 +00:00
Vadim Tryshev 8cf338148b Merge "Adding tracing for workspace loading that never finishes" into udc-dev 2023-05-25 17:17:50 +00:00