Commit Graph

11677 Commits

Author SHA1 Message Date
Jeremy Sim 3d0b47a5ea Merge "Allow user to select second split app from Taskbar" into tm-qpr-dev am: d5525c3bda
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20365694

Change-Id: I8d1e153a3d9f2b04293a41a0e008cc348fe028d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 19:25:02 +00:00
Jeremy Sim d5525c3bda Merge "Allow user to select second split app from Taskbar" into tm-qpr-dev 2022-11-10 18:56:22 +00:00
TreeHugger Robot 10b0703a40 Merge "Add CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS" into tm-qpr-dev am: eaa5703f75
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20339809

Change-Id: Ib8d77e7a1ec40f44b8bccc1dd485c6e10411b616
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 13:08:47 +00:00
TreeHugger Robot eaa5703f75 Merge "Add CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS" into tm-qpr-dev 2022-11-09 12:27:25 +00:00
TreeHugger Robot b5c134d72c Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev am: 8dd01f3ac2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20416308

Change-Id: I1c271f89300a0483af71aac53dafebfe7c45429e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 01:32:38 +00:00
TreeHugger Robot 8dd01f3ac2 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev 2022-11-09 01:07:11 +00:00
TreeHugger Robot 17fdc95996 Merge "Prevent rotating TaskMenuViewWithArrow for large screen" into tm-qpr-dev am: 9297483eef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20250157

Change-Id: I289a222b4724adb5c98dd241122b9ae3d9e64815
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-08 23:43:53 +00:00
TreeHugger Robot 9297483eef Merge "Prevent rotating TaskMenuViewWithArrow for large screen" into tm-qpr-dev 2022-11-08 23:08:28 +00:00
Jeremy Sim 93fc0f3a7c Allow user to select second split app from Taskbar
This patch makes it so that (when we enable Taskbar in Overview) users will be able to select their second app for splitscreen by tapping the Taskbar icon, or the icon in AllApps.

This was done by performing a check to SplitSelectStateController when a taskbar icon is hit. If we are currently in split select mode, Taskbar/AllApps icons will no longer launch their respective fullscreen apps, but instead confirm the split attempt. The confirmed app will either be an already-running instance of the app, or a fresh instance of the app (if none is currently running). The split confirmation function is located in TaskbarUIController, where it is accessible to both LauncherTaskbarUIController (for 1P Launcher) and FallbackTaskbarUIController (for 3P launchers).

Also cleans up ~2 lines of unused code from the old splitscreen instructions toast.

Outstanding issues:
- When selecting a second app from within AllApps, the AllApps shade does not animate away in a satisfying way
- When selecting a second app and launching a fresh instance of that app, the animation appears to come from the wrong location
- Intent + Intent splitting does not currently work
- If the selected app is already running with multiple instances, it picks the oldest instance. Ideally, the newest instance is preferred.

Bug: 251747761
Test: Manual testing with Taskbar in Overview flag enabled
Change-Id: I302dc092740bb880f9134ba8e2e587c4f2c29d01
2022-11-08 14:38:05 -08:00
Jon Miranda e7011d2b87 Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."
This reverts commit d5a6b5f688.

Reason for revert: Breaks tests due to "SharedPreferences in credential encrypted storage are not available until after user is unlocked"

Bug: 258256906
Change-Id: I1de69249685f9d2e71183357cf3eda8d443c7d97
2022-11-08 21:56:52 +00:00
TreeHugger Robot 269c56df92 Merge "Unstash taskbar when transitioning to fallback overview." into tm-qpr-dev am: 98f400397b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20187724

Change-Id: I83f29014f6bd50a3bcb3fc2ebf964163438bbcbb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-08 18:26:53 +00:00
Jon Miranda b71037c58b Merge "Have responsive taskbar UI during swipe up gesture." into tm-qpr-dev am: caa398ed35
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20333665

Change-Id: Id96043e6aa186eb04bc5d171fdb72159ae7e4c42
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-08 18:26:43 +00:00
TreeHugger Robot 98f400397b Merge "Unstash taskbar when transitioning to fallback overview." into tm-qpr-dev 2022-11-08 18:14:55 +00:00
Jon Miranda caa398ed35 Merge "Have responsive taskbar UI during swipe up gesture." into tm-qpr-dev 2022-11-08 17:53:05 +00:00
Jon Miranda 416680d8f0 Merge "Add TaskbarModeSwitchRule to test both transient/persistent taskbar." into tm-qpr-dev am: 881588bfb5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20391679

Change-Id: I46efa448ae986d2fd723e2f98faa09a562cfe98f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-08 16:38:36 +00:00
Jon Miranda 881588bfb5 Merge "Add TaskbarModeSwitchRule to test both transient/persistent taskbar." into tm-qpr-dev 2022-11-08 16:13:07 +00:00
Pat Manning e1100b904d Unstash taskbar when transitioning to fallback overview.
Update LauncherInstrumentation taskbar visibility check to include assertions in fallback launcher using OverviewObject instead of LauncherObject.

Fix: 253042501
Test: manual
Change-Id: I9f2aa228e8aa97ef8ca1a4535b7f8fcded8a4572
2022-11-08 15:07:12 +00:00
Jon Miranda 29f7474056 Have responsive taskbar UI during swipe up gesture.
- Makes taskbar threshold an absolute Y threshold
  instead of a distance threshold.
- Moves handle, taskbar view, and taskbar background
  during the swipe up gesture

Next CL will address transforming the nav handle <-> taskbar
and ensuring that there's a clean handoff

Bug: 246631059
Test: swipe up on taskbar, release. see bounce
      swipe up on taskbar to go home, proper icon alignment
      swipe up on taskbar, pause for overview, see bounce
      -> further movement should not move taskbar
      test launcher3

Change-Id: I141236fd72428cda7edd0ff116de1d478d18c722
2022-11-08 14:50:02 +00:00
Jon Miranda 97198b03f7 Merge "Stash taskbar if user touch down above the gesture height." into tm-qpr-dev am: 92564539d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20391178

Change-Id: I7e55d23264446cdb747682acbf01468a1487535f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-08 01:24:00 +00:00
Jon Miranda 92564539d2 Merge "Stash taskbar if user touch down above the gesture height." into tm-qpr-dev 2022-11-08 01:00:46 +00:00
Jon Miranda d5a6b5f688 Add TaskbarModeSwitchRule to test both transient/persistent taskbar.
- Lays the foundation for transient taskbar tests.
- Does not add flags that would add ACTION_OUTSIDE in tests.
  We can address testing this functionality in a separate CL

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I44acc5e589b959e6d4bc93fdc369e503c54e7d87
2022-11-07 14:18:37 -08:00
Schneider Victor-tulias aa631328c5 Merge "Refactor recents attached to window animation to keep state handling synchronized." into tm-qpr-dev am: cd587212a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20388919

Change-Id: I1a6f8f2191d2b9a01f89279c6a04f101c72a1611
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-07 18:48:15 +00:00
Alex Chau 6d18d1a974 Merge "Change taskbar corner roundness when entering overview" into tm-qpr-dev am: 3cf779270b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20311858

Change-Id: I938abff8fcd1c435724d26d884a3546e87ba08c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-07 18:46:49 +00:00
Jon Miranda b0523697c6 Stash taskbar if user touch down above the gesture height.
Bug: 252905206
Test: open taskbar, tap in gesture area, confirm no stash
      open taskbar, tap on taskbar item, confirm no stash
      open taskbar, tap to the side above gesture area, confirm stash

Change-Id: Ide030840440b5f0541d0ccfb055b8a8a7e851657
2022-11-07 10:37:28 -08:00
Schneider Victor-tulias cd587212a2 Merge "Refactor recents attached to window animation to keep state handling synchronized." into tm-qpr-dev 2022-11-07 18:21:53 +00:00
Alex Chau 3cf779270b Merge "Change taskbar corner roundness when entering overview" into tm-qpr-dev 2022-11-07 18:08:22 +00:00
Nicolo' Mazzucato 2370406efb Add CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS
Bug: 231130484
Bug: 228969045
Test: recorded prefetto trace while going to recents
Change-Id: If33daaa22f904c928f5d4a561a7ac1a03d82b7eb
2022-11-07 16:52:32 +00:00
Alex Chau 68e7fe6b7d Change taskbar corner roundness when entering overview
- Roundness will be 0 in Launcher, and 1 in an app

Bug: 250645563
Test: With and without taskbar in overview, switch between home/overview/app and observe the round corners above taskbar
Test: Ensure corner above taskbar is correct in overview and in app when chat bubble is active
Change-Id: I1f4911626c8e79fce8d81a76a9bd0d0670d111da
2022-11-07 12:58:47 +00:00
Schneider Victor-tulias 5bb69206a3 Refactor recents attached to window animation to keep state handling synchronized.
Bug: 244593270
Bug: 243471493
Test: went from from app, launched overview from app/home, started overview, then swiped to home from app/home
Change-Id: If3ce8d5d145941af3fac936be28c0fc59c18932b
2022-11-04 15:14:54 -07:00
Schneider Victor-tulias 924e673804 Merge "Improve RecentsModel log dump for ease-of-use and readability." into tm-qpr-dev am: 345ef9ffba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20290151

Change-Id: I67b5b9c1f60a4c1b2af44d16b6c20d34b4314fed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 18:26:58 +00:00
Schneider Victor-tulias 345ef9ffba Merge "Improve RecentsModel log dump for ease-of-use and readability." into tm-qpr-dev 2022-11-04 18:17:51 +00:00
Ats Jenk 60e0de347b Merge "Clean up bubbles home gesture flag" into tm-qpr-dev am: 70d8a12c60
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20377785

Change-Id: I7cef413766ad64bddd45b0803ce148799e4d43ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 18:13:35 +00:00
Schneider Victor-tulias 626bb9fded Merge "Update all set page navigations settings button callback" into tm-qpr-dev am: 0994f74f76
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20376505

Change-Id: I7b290597981453166f4cf7d957038876987a4464
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 18:13:00 +00:00
Ats Jenk 70d8a12c60 Merge "Clean up bubbles home gesture flag" into tm-qpr-dev 2022-11-04 17:56:17 +00:00
Schneider Victor-tulias 0994f74f76 Merge "Update all set page navigations settings button callback" into tm-qpr-dev 2022-11-04 17:16:09 +00:00
Sunny Goyal e869850fa6 Merge "Relying on the controller state instead of animator state for icon alignment" into tm-qpr-dev am: eeaba0903a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20291844

Change-Id: I95c2a079a8cc41f1a2592704f5f1ea0ca2baad6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 15:52:49 +00:00
Sunny Goyal eeaba0903a Merge "Relying on the controller state instead of animator state for icon alignment" into tm-qpr-dev 2022-11-04 15:40:17 +00:00
Jon Miranda 264e97feea Merge "Update insets for transient taskbar" into tm-qpr-dev am: 71370c58eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20307069

Change-Id: I46bdfbf96ca0b0be53f04c0c4aef8f07e1a56297
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 15:37:15 +00:00
Jon Miranda 71370c58eb Merge "Update insets for transient taskbar" into tm-qpr-dev 2022-11-04 15:09:12 +00:00
Sunny Goyal d5bb6459f0 Merge "Adding support for multiple overlay callbacks" into tm-qpr-dev am: 8d3241b359
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20362704

Change-Id: I5a6dc4d339b175062a158444a3afbdc645748a4f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 14:37:12 +00:00
Sunny Goyal 8d3241b359 Merge "Adding support for multiple overlay callbacks" into tm-qpr-dev 2022-11-04 14:13:12 +00:00
Ats Jenk 20ed998a51 Clean up bubbles home gesture flag
Flag is enabled by default. Removing as it is no longer used.

Bug: 256873558
Test: mp launcher
Change-Id: I8cdfde754aec7b683ae9e47aa8861ddc41460a59
2022-11-03 20:22:56 -07:00
Sunny Goyal 67a46acab9 Merge "Removing unused SplitScreen bounds notification from systemUI" into tm-qpr-dev am: 17b4e8bbda
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20378525

Change-Id: I85b2ba62be8092f9423781fc63fe217ecd6f7a7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 02:39:49 +00:00
Sunny Goyal 17b4e8bbda Merge "Removing unused SplitScreen bounds notification from systemUI" into tm-qpr-dev 2022-11-04 02:03:46 +00:00
Jon Miranda 7e8195081e Update insets for transient taskbar
Bug: 252905206
Test: manual
Change-Id: I03bd493dbe63274c8e90cb5e415127a1dd93e9b8
2022-11-03 17:16:48 -07:00
TreeHugger Robot 6eb2a7354a Merge "Update active gesture error detection" into tm-qpr-dev am: a30a016191
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20067246

Change-Id: Ic8efaa8da297ed84a7a58eced24b638ad2354b7a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 23:41:54 +00:00
Vinit Nayak 1169fd447d Merge "Switch to screenshot when finishing recents animation for split select" into tm-qpr-dev am: 7fb1336de7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20364924

Change-Id: I48dc3166018934e249eea473aab3b459819cdeb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 23:41:42 +00:00
TreeHugger Robot a30a016191 Merge "Update active gesture error detection" into tm-qpr-dev 2022-11-03 23:29:00 +00:00
Vinit Nayak 7fb1336de7 Merge "Switch to screenshot when finishing recents animation for split select" into tm-qpr-dev 2022-11-03 22:26:36 +00:00
Sunny Goyal 82379187ea Adding support for multiple overlay callbacks
Bug: 193244407
Test: Presubmit
Change-Id: Ic345972056752238e7e46226533fd8f33d664213
2022-11-03 14:37:40 -07:00