Commit Graph

14297 Commits

Author SHA1 Message Date
Sihua Ma 3cedd3920d Merge "Resize preview for correct clipping" into tm-qpr-dev am: 2d675e8ab0 am: eeb46032ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19324973

Change-Id: I0dec5e33e09efca7afe60c7d7183025018712965
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-17 16:37:36 +00:00
Sukesh Ram e02c21259a Merge "Added Tests for Secondary Display Launcher" 2022-08-17 06:46:19 +00:00
Sukesh Ram 73c27a1fa3 Added Tests for Secondary Display Launcher
These UIAutomator tests for secondary display launcher cover app drawer, drag-n-drop functionality, app predictions, pin/unpinning icons, and correct back press behavior.

We are deviating from  go/modify-tapl due to the time constraints of this project as outlined here (https://docs.google.com/document/d/1wLb2h8qCPGur-VsufCH4mLnnuLDLcmMq0FrCo7ichu8/edit#heading=h.brf6af3bno4g).

A preliminary design document has also been created to reference for future TAPL integration (https://docs.google.com/document/d/1H642SSu5DCM_zSXTsvTWumgm3OHIxsKEXvTlTeC4y54/edit?resourcekey=0-M9sTxdyQBi8bUy5cpjmJNA#heading=h.90f2s4sc5ic9).

Before TAPL integration, we need to follow up on test rewrite to eliminate antipatterns in the following bug: b/242776943.

Bug: 241166788
Test: Run Locally, on presubmit, and on a test on a cuttlefish emulator
Change-Id: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
2022-08-16 23:20:27 +00:00
Sihua Ma 2d675e8ab0 Merge "Resize preview for correct clipping" into tm-qpr-dev 2022-08-16 00:15:06 +00:00
Jeremy Sim 6044de1977 Merge "Update animations for TM-QPR: Overview > OverviewSplitSelect transition" into tm-qpr-dev am: cf03d04469 am: 6a6b5e4e9a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19464657

Change-Id: Ifb097d77968dd73d80aa42327e53dcb1fdc1c2c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-15 22:47:36 +00:00
Jeremy Sim cf03d04469 Merge "Update animations for TM-QPR: Overview > OverviewSplitSelect transition" into tm-qpr-dev 2022-08-15 21:19:21 +00:00
Jeremy Sim a50bb39048 Update animations for TM-QPR: Overview > OverviewSplitSelect transition
The animation from Overview to OverviewSplitSelect is now updated to the latest spec. See bug for details.
- New timings
- Task thumbnails slide in with a new spring animation
- Icons fade out and fade in appropriately
- SplitInstructionsView has a new compound "unfold" animation

Bug: 236760307
Test: Manual on tablet and phone. Looks good on both true and fake orientations.
Change-Id: If98d4464aa51c876d79bee9672279992a2cf9026
2022-08-14 10:34:51 -07:00
Sunny Goyal 083c1043db Merge "Optimizing View capture logic" into tm-qpr-dev am: ee3ef1e991 am: 8e48bd4223
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19572602

Change-Id: Id6d1f9e7447771183ad66c275d07a35e06a19803
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-12 18:14:44 +00:00
Sunny Goyal ee3ef1e991 Merge "Optimizing View capture logic" into tm-qpr-dev 2022-08-12 17:27:22 +00:00
Thales Lima 09fc647338 Merge "Tune display options for non-default display sizes" into tm-qpr-dev am: f1b88dcb85 am: da164682c0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19578549

Change-Id: Ib448bfcfe4fb33bf3e576185eea579a309f7aae2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-11 15:30:59 +00:00
Thales Lima f1b88dcb85 Merge "Tune display options for non-default display sizes" into tm-qpr-dev 2022-08-11 14:47:43 +00:00
Pat Manning 2c60b25805 Merge "Add logging to help debug flake when swiping home to overview." 2022-08-11 09:54:17 +00:00
Alex Chau ea521f4857 Merge "Use WindowManagerProxy.getRotation to determine if rotation has changed" into tm-qpr-dev am: 5d9625b865 am: d86d6223b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19582532

Change-Id: I93957f96b19647c873580ae014e275be2060b3f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-11 00:03:29 +00:00
Sunny Goyal a38aa060eb Optimizing View capture logic
Doing view capture in two passes
1) UI thread: creating a flat copy of the full view tree. Since
   view structure can change on the UI thread, this needs to be
   captured synchronously on UI thread.
2) BG thread: We capture the properties of the View on background
   thread using the flat tree created in the previous step. Since
   reading the properties is atomic, there is no synchronization
   issued.

One down side of this approach is that the properties might change
while the background-tep is underway. So all the properties of a
of a node may not represent the frame-state. But for the purpose
of animations, we can just refer a few continous frames.

Bug: 242095405
Test: Verified on device, frame capture reduced by at least 5x
      every time.
Change-Id: I0a61fb24669940b3b3533c0471e42e476709da55
2022-08-10 15:49:36 -07:00
Alex Chau 5d9625b865 Merge "Use WindowManagerProxy.getRotation to determine if rotation has changed" into tm-qpr-dev 2022-08-10 22:32:51 +00:00
Luca Zuccarini a5722fa5f0 Merge "Introduce a new flag to guard keyboard synchronization." into tm-qpr-dev am: 2e126f985e am: 4728814a0f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19117747

Change-Id: Ia57d8df450a9cf6922ca19327ea55bfa6fdc8d63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-10 18:15:54 +00:00
Luca Zuccarini 2e126f985e Merge "Introduce a new flag to guard keyboard synchronization." into tm-qpr-dev 2022-08-10 17:37:05 +00:00
Alex Chau 360ec033ac Use WindowManagerProxy.getRotation to determine if rotation has changed
- Follow-up of http://ag/19559863 as Config diff on windowConfiguration does not work on 3P Launcher, so diff WindowManagerProxy.getRotation instead
- Also centralized Configuration diff logic into StatefulActivity

Bug: 240730723
Test: manual on 90/180 degree rotation in Launcher, RecentsActivity and 3P Launcher
Change-Id: Ib368ed5d749841a6873a03e2644608ff68885922
2022-08-10 18:14:06 +01:00
Pat Manning 1edba8b0a6 Add logging to help debug flake when swiping home to overview.
Bug: 238461210
Test: TaplTestsQuickstep#testSwitchToOverview
Change-Id: I8ee9af4f4a331c43761ba3738e12acb376ababc2
2022-08-10 13:37:02 +00:00
Alex Chau 1edf184cc9 Merge "Detect potential WindowConfiguration change at onApplyWindowInsets" into tm-qpr-dev am: 16b6511e14 am: 76865013bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19559863

Change-Id: Ibe53bcf7d1839224bf2b8e0d8d5bec6a25096b9f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-10 09:48:54 +00:00
Thales Lima 1fb075de3b Tune display options for non-default display sizes
Fix: 241382721
Test: manual
Change-Id: I05379c359dabad6931ee897455aa847a7a9b470c
2022-08-10 10:47:50 +01:00
András Klöczl 50e2e84023 Merge "Fix widget jump bug when moved to invalid place" into tm-qpr-dev am: 00d27d25da am: f2661363ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19559931

Change-Id: I5d42c0dcef16c584f836377f0c0bbe85f50daa91
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-10 09:20:15 +00:00
Alex Chau 16b6511e14 Merge "Detect potential WindowConfiguration change at onApplyWindowInsets" into tm-qpr-dev 2022-08-10 09:14:11 +00:00
András Klöczl 00d27d25da Merge "Fix widget jump bug when moved to invalid place" into tm-qpr-dev 2022-08-10 08:07:30 +00:00
Vinit Nayak 2d6442c5e6 Merge "Show 3 button nav on phone in Taskbar (1/2)" into tm-qpr-dev am: 89be3a4c6d am: 72864a13db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19534821

Change-Id: Ib9ef7e0923dea9e1700208b9dbdd20ee4368b063
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-10 04:19:00 +00:00
Vinit Nayak 89be3a4c6d Merge "Show 3 button nav on phone in Taskbar (1/2)" into tm-qpr-dev 2022-08-10 03:06:53 +00:00
Sihua Ma e04aa207f2 Resize preview for correct clipping
Before, the remote view for the widget in launcher is reused to generate a new preview. However, measuring the view without changing the scale would cause strange clippings. This CL sets the scale of the widget views by manually computing the size ratio.

Change ag/19572297 is necessary before a complete clean-up.

Test: Create a weather widget on first screen -> go to Wallpaper & style -> App grid -> tap on a different grid and verify that the clipping is correct
Fix: 228328759
Change-Id: I8242d3bcfcf30ec924552c1320e22f8a3592f1c1
2022-08-09 23:57:41 +00:00
Vinit Nayak 8a3d05587e Show 3 button nav on phone in Taskbar (1/2)
* TODO: Landscape/seascape support,
        Separate nav spacing out into
        separate class/add tests

Bug: 219035565
Change-Id: I8f5c007f04ea4d6df15962772806356181d764ff
2022-08-09 13:25:50 -07:00
Alex Chau ccc430e2c1 Detect potential WindowConfiguration change at onApplyWindowInsets
- Invoke onConfiguration when receiving inset changes
- In Laucnher/RecentsActivity onConfiguration, additionally detect for windowConfiguration's rotation change; if Configuration stays the same, it'll be ignored.

Bug: 240730723
Test: manual on 90/180 degree rotation in Launcher and RecentsActivity
Change-Id: I7087878af847d62e1c715a4f52a18818d1a6c258
2022-08-09 19:09:42 +01:00
Andras Kloczl eb6a154230 Fix widget jump bug when moved to invalid place
When dropTargetLayout is null we don't need to
animate the widget to the closest location but
move it back to its original position.
Test: manual
Bug: 236135424

Change-Id: I50a793732cd9656605fdc9908f71ff0efa7e69e9
2022-08-09 10:53:33 +02:00
András Klöczl 6410602190 Merge "Fix flaky two panel TAPL tests v2" 2022-08-09 08:40:57 +00:00
Luca Zuccarini 7f2388ce31 Merge "Update keyboard dismissal logic in the AllAppsTransitionController." into tm-qpr-dev am: 96945fcc24 am: 82c2040047
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18868377

Change-Id: Ib32ddc1ea0003ab8c9b26a021db645c61db18450
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-08 15:15:11 +00:00
Luca Zuccarini 96945fcc24 Merge "Update keyboard dismissal logic in the AllAppsTransitionController." into tm-qpr-dev 2022-08-08 14:34:51 +00:00
Thales Lima c0268f4f49 Merge "Calculate hotseat width based on available width" into tm-qpr-dev am: c92b40f10a am: a1afc2313f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19416116

Change-Id: I3d503774a1cd8e797c96334b51f7af25cfcb1a30
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-08 09:40:48 +00:00
Thales Lima c92b40f10a Merge "Calculate hotseat width based on available width" into tm-qpr-dev 2022-08-08 08:57:20 +00:00
Sunny Goyal eede50377e Merge "Dumping view capture directly to file instead of loading it all in memory" into tm-qpr-dev am: 68ef8bf37a am: 38b9216e1b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19536173

Change-Id: Ic4b5658f6b252f891063dfbcd3149a68f9c45b86
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-06 06:02:33 +00:00
Sunny Goyal 68ef8bf37a Merge "Dumping view capture directly to file instead of loading it all in memory" into tm-qpr-dev 2022-08-06 05:14:16 +00:00
Sunny Goyal a30cf8b7e1 Dumping view capture directly to file instead of loading it
all in memory

This avoid OOM when processing large data

Bug: 241600398
Test: Verified on device
Change-Id: I76072d52e47bea3a2f9802ce3b23ddae58fe8d23
2022-08-05 16:30:01 -07:00
Luca Zuccarini 7e02d6845e Introduce a new flag to guard keyboard synchronization.
Bug: 234812580
Test: manual
Change-Id: I1c8714fa68cde06b95f6a7822075188c7dc2f71f
2022-08-05 12:20:14 +00:00
Luca Zuccarini c7114defc7 Update keyboard dismissal logic in the AllAppsTransitionController.
Dismissing the keyboard immediately interferes with the synchronized
keyboard animation. Instead, we wait until the end of the animation and
if it is successful (transition actually happened and wasn't
interrupted) we hide the keyboard. This call does nothing if the
keyboard was already hidden through the synchronized animation, and
hides it otherwise.

Bug: 234812580
Test: manual
Change-Id: Idabbc707dd0244bdf75316777e945624a8e8bdfc
2022-08-05 12:20:08 +00:00
Pat Manning 5b231b11b1 Merge "Remove scaling from spring loaded y translation." into tm-qpr-dev am: 67fe05beaf am: 3c7d220a0b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19528333

Change-Id: I41134322cf3b2d654d8dc8180ad19ff54100c073
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-05 11:24:04 +00:00
Pat Manning 67fe05beaf Merge "Remove scaling from spring loaded y translation." into tm-qpr-dev 2022-08-05 10:34:30 +00:00
Alex Chau 137c0e1e2e Merge "Adjust height of tablet AllApps base on row height" into tm-qpr-dev am: b0f42f03bf am: 16ac12b450
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19416113

Change-Id: I74473373191600555cd9154dc3aa0fc95477ca7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-04 14:40:46 +00:00
Thales Lima 9938c2f791 Calculate hotseat width based on available width
Navigation buttons take space on the hotseat, so hotseat width (qsb width and border space between icons) should be calculated instead of having a coded value.

Bug: 223724516
Bug: 228998463
Test: manual, changing display size
Test: manual, changing hotseatBarEndOffset value
Test: HotseatWidthCalculationTest
Change-Id: Ibd4f5ff2e06afda8e7420fb744db049d2e418e14
2022-08-04 15:21:06 +01:00
Alex Chau b0f42f03bf Merge "Adjust height of tablet AllApps base on row height" into tm-qpr-dev 2022-08-04 13:55:06 +00:00
Pat Manning 9fd69c0d42 Remove scaling from spring loaded y translation.
Fix: 239401465
Test: manual. To follow up with screenshot test: b/241386128
Change-Id: I916fcca22f5c827e1af38a50847585afcefc330d
2022-08-04 14:53:35 +01:00
Alex Chau 206ede9c1f Adjust height of tablet AllApps base on row height
- Also used hotseatQsbHeight for AllApps QSB height as they have to match to transform between each other

Fix: 232907846
Test: manual on different tablets
Test: atest DeviceProfileTest
Change-Id: I001d0e129db2a5de6c8ace4c3302381110da03f1
2022-08-03 15:29:22 +00:00
TreeHugger Robot 98fd9c0da3 Merge "Account for span greater than 1 in getReorderRadius" into tm-qpr-dev am: 89b8f65277 am: eaeceb9b7b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19441591

Change-Id: I379fa83f94a542bc478bb659fd82b38c5eae6fa5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-03 14:49:44 +00:00
Sunny Goyal 4d83501f4a Merge "Removing unused ShadowDrawable" into tm-qpr-dev am: 41321dfe71 am: 7e0795609f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19506676

Change-Id: Ice81f1a10f5dd6be83efaa938c978310990e312b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-03 14:49:32 +00:00
Sunny Goyal f4d0a0ba70 Merge "Create less number of dot-renderers at startup" into tm-qpr-dev am: f28c428050 am: e00fc434f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19498070

Change-Id: If53c5b0c7977b6570c14bf9aac6efe7802728f48
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-03 14:49:21 +00:00