Commit Graph

17097 Commits

Author SHA1 Message Date
Brandon Dayauon 3cdb32cc1f Do a vertical check for two line text, if it clips dont show two line.
Added extra 16dp to the cell height in DeviceProfile as per spec: https://docs.google.com/presentation/d/1dSt-zY_wRrOmd9a9nsQG458CIK0RUqVJsHJxLHP_0Nc/edit#slide=id.g237e909075a_2_6
Updated tests andincluded vertical check to see if two line can be fully rendered without being clipped. Otherwise just show one line.
Since existing cell height is 104dp, we add 16dp to be up to spec (120dp)
- Clean up FeatureFlag ENABLE_TWOLINE_ALLAPPS and now use aconfig flag

bug: 270390937
Test: manually - photos
Regular font: https://screenshot.googleplex.com/ArUcgZgHqR4ZWBQ
Bigger font than regular that makes text to one line because it wouldve truncate: https://screenshot.googleplex.com/6s8EdMAbBLsYhLi
Bigger font than regular with predicted app row (twoline):
https://screenshot.googleplex.com/38TEQei5GvPiCc7
Super big font: https://screenshot.googleplex.com/3JUYYprJRQ32Hsq
big display and regular font: https://screenshot.googleplex.com/55rBKVQ8htSe9Vc
big display and bigger than regular font: https://screenshot.googleplex.com/3atzKzJUbfM7YQW
flag: is off

Change-Id: I6998ea5da35d3e00ac75327d16b5ca676fb11c1a
2023-09-26 02:38:16 +00:00
Federico Baron 0bc00d24ab Merge "Add extraItems to dump log for BgDataModel" into main 2023-09-25 21:35:15 +00:00
Andrew Cole e81a3cef0c Merge "Unfolded Two Pane Widget Picker Prototype" into main 2023-09-25 19:59:30 +00:00
Brandon Dayauon c65b902cc4 Merge "Fix gray work apps when WorkPausedCard shoul've shown" into main 2023-09-25 18:13:12 +00:00
Andrew Cole c19a618706 Unfolded Two Pane Widget Picker Prototype
As described, this is a small prototype to show what the current state of the two pane widget picker would look like in an unfolded foldable.

Bug: 301918659
Test: N/A
Flag: UNFOLDED_WIDGET_PICKER
Change-Id: Ia495de39a470f1dccf70ce53e59c7929525c4a00
2023-09-25 11:00:24 -07:00
Stefan Andonian 84230b2ea0 Merge "Move "Enable Boot Aware Startup data" to behind a FeatureFlag." into main 2023-09-25 17:06:12 +00:00
Thales Lima 2d1d14193b Merge "Fix to prevent unsorted breakpoints returning wrong spec" into main 2023-09-25 16:12:56 +00:00
Treehugger Robot 3cc4f5baaf Merge "Avoid sending an IME close request if the IME is already closed." into main 2023-09-22 22:14:10 +00:00
fbaron 5c835dafa1 Add extraItems to dump log for BgDataModel
The extraItems include suggested hotseat icons, which we want to have in the dump to help us debug future bugs regarding hotseat

Bug: 301369051
Test: n/a
Flag: no flag
Change-Id: I6a0f5e785441915ecfece95dfcba7d60ef5912d2
2023-09-22 10:27:33 -07:00
Brandon Dayauon c8af851e99 Fix gray work apps when WorkPausedCard shoul've shown
The reason is because WorkManager doesn't reset when user searches (which is why the apps gray out when you go to toast, turn off work profile then back gesture to all apps)

Added test for ActivityAllAppsContainerView that test onAppsUpdated() and check for if there are work apps.
From the test environment, onAppsUpdated() needs to be public because the method is outside the package. However, I've wrapped onAppsUpdated package private so I can test it with a boolean parameter.

bug: 298492729
test: video:
before: https://drive.google.com/file/d/1D0VlGeJEI5lGbYgP5Tnu5UO_Dv61X8Dv/view?usp=sharing
after: https://drive.google.com/file/d/1D0qsq7sX_kAp2t92xser7YI4ADBhQfHY/view?usp=sharing
Change-Id: I4eb7cf21e273e29171fcd62a4762e8bb1778e720
2023-09-22 17:18:10 +00:00
Sunny Goyal 9dfbb0aca8 Merge "Fixing pending tasks being queued on bind after the pending executor is already finalized." into main 2023-09-22 16:52:00 +00:00
Brandon Dayauon 8e24505d09 Merge "Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW" into udc-qpr-dev am: 28ae77df37 am: f9a203c586
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24724750

Change-Id: I4e955f635773b5084b315282d373b16cff6988e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 16:22:21 +00:00
Brandon Dayauon 28ae77df37 Merge "Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW" into udc-qpr-dev 2023-09-22 14:36:45 +00:00
Charlie Anderson 605db4b74a Merge "Make sure to set Launcher restore pending as false after setting in RestoreDbTaskTest to not affect state of Launcher in tests. See tearDown method in RestoreDbTaskTest for fix." into main 2023-09-22 14:13:39 +00:00
Jeremy Sim dcb6f5736e Merge "Request split launches using a new enum, snapPosition, rather than a float splitRatio" into main 2023-09-21 23:50:38 +00:00
Sunny Goyal f0925fdf31 Fixing pending tasks being queued on bind after the pending executor is already finalized.
Bug: 291664186
Test: Tentative fix, will know more from dashboard
Flag: N/A
Change-Id: I1f1883fb315f05417839507b95ccc80e0b57b530
2023-09-21 13:50:48 -07:00
Federico Baron fe442a18c2 Merge "Shortcut crash fix" into main 2023-09-21 19:25:40 +00:00
Federico Baron 9bbb0c7522 Merge "Shortcut crash fix" into udc-qpr-dev 2023-09-21 19:25:25 +00:00
Federico Baron 9c4132b31d Merge "Fix indexoutofbounds folder preview" into main 2023-09-21 19:25:04 +00:00
Stefan Andonian dbc8ec530c Move "Enable Boot Aware Startup data" to behind a FeatureFlag.
Previously this was hard-coded to disabled, but that was before
FeatureFlags were made to be boot aware.

Bug: 251502424
Test: Verified that doing this doesn't break my device. Also tested the
Pre-loading feature itself and didn't see any errors in the logs.

Change-Id: I031e1756b985664a2e8d8ad26e16803ead874727
2023-09-21 19:10:22 +00:00
Jeremy Sim da230cf526 Request split launches using a new enum, snapPosition, rather than a float splitRatio
Split ratios are now stored as an int enum rather than float values. Previously, split ratios were stored as floats, which needed to be recalculated frequently and differed depending on device screen size. Now Shell to store and launch split screen setups using an enum rather than floats.

Bug: 274835596
Bug: 182839788
Test: Existing tests still pass
Change-Id: Iebb8d3c7e8f9d597a59b677e48072300ddea458f
2023-09-21 11:34:07 -07:00
Uwais Ashraf d295e3510a Merge "Set taskbar heights to 0 when taskbar is not present." into udc-qpr-dev 2023-09-21 16:39:10 +00:00
Jordan Silva e4d7aaa6fd Fix to prevent unsorted breakpoints returning wrong spec
It orders the breakpoint list to guarantee that the smallest breakpoint is always returned for a given availableWidth or availableHeight.

Fix: 301396419
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: CalculatedWorkspaceSpecTest
Change-Id: Ia545e84150027bd8daa8d0dde58ff6fc579c3b6a
2023-09-21 11:44:56 +01:00
fbaron 7f4bbfa599 Fix indexoutofbounds folder preview
The indexoutofbounds issue came from the fact that folder was being animated open when there are no items in preview. It might be a race condition where we try to open the folder at a time where it's actually being emptied. This check should prevent folders from running animateOpen() if there's <= 1 items, avoiding the outofbounds error

Fix: 298740874
Flag: no flag
Test: no test
Change-Id: I31ed53fbdf22a7f19bc9ec414242312afe7c6cd2
2023-09-20 23:57:00 -07:00
fbaron d87178460c Shortcut crash fix
Title was empty which caused launcher to crash. If title is empty the shortcut is invalid so we want to remove it.

Fix: 300213039
Flag: no flag
Test: no test
Change-Id: Ifa12877b9ac1d8bc266b74a95b6975b7f1bcf31e
2023-09-21 05:53:45 +00:00
fbaron ba0f7a0b17 Shortcut crash fix
Title was empty which caused launcher to crash. If title is empty the shortcut is invalid so we want to remove it.

Fix: 300213039
Flag: no flag
Test: no test
Change-Id: Ifa12877b9ac1d8bc266b74a95b6975b7f1bcf31e
2023-09-20 22:52:46 -07:00
Randy Pfohl bd585e4d42 Merge "Remove logs for bug investigation" into main 2023-09-20 23:14:33 +00:00
Brandon Dayauon 47000ae6e6 Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW
- Create another icon, "all_apps_predicted_row_icon" that will be the mDisplay for the predicted app row
in AllAppsList

Bug:299171695
Test: video
Before: https://drive.google.com/file/d/1HxNW0015nQHCc7eQiySf-gwsHrLs_JjR/view?usp=sharing
after: https://drive.google.com/file/d/1HyEwKI-yumILTCjglKcqovhTlRVjNGxg/view?usp=sharing - making sure that QL is fine and dragging regular Toast results are normal
Flag: N/a
Change-Id: Ie002cacb168396dbea39f79679bd6a04b80e374b
2023-09-20 14:21:10 -07:00
Charlie Anderson 8c1cf2db26 Make sure to set Launcher restore pending as false after setting in RestoreDbTaskTest to not affect state of Launcher in tests.
See tearDown method in RestoreDbTaskTest for fix.

This reverts commit 2d86f3337a.

Reason for revert: fixing the issues for revert b/298077774
Test: running presubmit and affected test suite on CL

Change-Id: I94c643f38259c4e920869c231f706229390c7c2a
2023-09-20 18:43:35 +00:00
Sunny Goyal 48c7efb1f7 Fixing crash in SettingsCache am: f17b59bb19 am: 24d3af52e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24804716

Change-Id: Iada63a729c600a6a498eba15fc011d42537a2ae2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-20 03:25:37 +00:00
Pinyao Ting 9ce1a90b4a Merge "Disables local color extraction for widgets" into udc-qpr-dev am: ef9125e5cb am: 06dd1ab24d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24777924

Change-Id: I971778514082b4712ca5f4169760279121589b7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-19 23:51:56 +00:00
Sunny Goyal f17b59bb19 Fixing crash in SettingsCache
Bug: 301119252
Test: Presubmit
Flag: N/A
Change-Id: I1356e6c6ad693cc53716603a0a2ca5efd6af5ea9
2023-09-19 22:37:51 +00:00
randypfohl dad61a0098 Remove logs for bug investigation
Test: built locally

Bug: 295069071

Change-Id: I88d41acb91ced876ab1f5a301e90ee5745119049
2023-09-19 14:13:58 -07:00
Pat Manning 349f101411 Merge "Migrate ENABLE_CURSOR_HOVER_STATES to aconfig" into main 2023-09-19 16:56:45 +00:00
Jagrut Desai 555d71f70f Merge "Taskbar Pinning Analytics Event" into main 2023-09-18 22:11:08 +00:00
Treehugger Robot 29296b3f8b Merge "Fix color in workspace. Where theme badge is applied when it shouldn't" into main 2023-09-18 20:04:42 +00:00
Jagrut Desai 4439af4191 Taskbar Pinning Analytics Event
Inlcuded Analytics Event
- Taskbar Divider Popup Menu Open/Close
- Taskbar was pinned
- Taskbar was unpinned

Bug: 265436916
Test: Confirm with data scientist that data is being logged.
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I307d000efe9ad8a32cdbe0b8df7248b19eabb08b
2023-09-18 12:36:17 -07:00
Pat Manning 66c1051e7e Merge "Remove taskbar tooltip hover delay." into main 2023-09-18 15:37:34 +00:00
Pinyao Ting 88f4f2bf96 Disables local color extraction for widgets
As discovered during investigation of system health issues, doing local
color extraction in widgets (for the purpose of making their color
matches the background during a drag) took many CPU cycle during layout
pass, which may have contributed to animation janks in various scenario.
This CL removes the feature in favors of better performance.

Bug: 266941872
Test: manually verified theme are still honored in widgets.
Change-Id: I63b13bc005907779af2322cd4bedbe141b0f3e27
2023-09-16 00:13:20 +00:00
Uwais Ashraf f8da98a59b Set taskbar heights to 0 when taskbar is not present.
Fix: 289769344
Test: DeviceProfileDumpTest
Change-Id: I53f8a629c8adc12feb1fdf9f5b40b4a680c97b78
Merged-In: I53f8a629c8adc12feb1fdf9f5b40b4a680c97b78
2023-09-15 19:37:10 +00:00
Liran Binyamin 070be25853 Merge "Adjust the hotseat when the bubble bar becomes visible" into main 2023-09-15 17:48:41 +00:00
Uwais Ashraf 3602d1771f Set taskbar heights to 0 when taskbar is not present.
Bug: 289769344
Fixes: 289769344
Test: DeviceProfileDumpTest
Change-Id: I53f8a629c8adc12feb1fdf9f5b40b4a680c97b78
2023-09-15 15:17:07 +00:00
Pat Manning 2db8ce7e94 Remove taskbar tooltip hover delay.
Fix issue when setting fullscreen drag layer causes hover exit/enter events.

Update ArrowTipView paddings to match spec.

Update ArrowTipView to check on each time it is shown if it should point up or down, not only the first time.

Fix: 295851126
Fix: 295315397
Test: TaskbarHoverToolTipControllerTest
Change-Id: I314c65cb9fce3fb8d6002d8917bd5c97301d9dbc
2023-09-15 12:24:51 +01:00
Brandon Dayauon 08cdbc57c7 Fix color in workspace. Where theme badge is applied when it shouldn't
bug: 300368356
Test: Manual
Flag: n/a
Change-Id: I9f391e4ffde41eedba7130f496f4f5e3f51d58db
2023-09-14 21:28:03 +00:00
Sebastián Franco c468af4139 Merge "Disable FOLDABLE_SINGLE_PAGE" into udc-qpr-dev am: 216a765894 am: 07ce8fa893
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681787

Change-Id: I74496b2ce863dadce1fbe3889de242c133a75121
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 19:02:27 +00:00
Andy Wickham be81b736fa Merge "Don't animate layout changes for WorkModeSwitch." into udc-qpr-dev am: 3140efe569 am: ca71d4b857
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24751396

Change-Id: I58f3850bd6671e5bf54002276bab929ac3499ce4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 18:59:15 +00:00
Sebastián Franco 216a765894 Merge "Disable FOLDABLE_SINGLE_PAGE" into udc-qpr-dev 2023-09-14 17:50:54 +00:00
Jagrut Desai a144105c12 Merge "Fix TaplTestsNexus#testSearchForApp" into main 2023-09-14 16:08:35 +00:00
Brian Isganitis 42d12badd8 Merge "Support tapping outside container from above IME if visible." into main 2023-09-14 15:25:05 +00:00
Alex Chau 0f7c0f4a53 Merge "Revert "Add debug log in InvariantDeviceProfile.minCellSize"" into main 2023-09-14 11:35:41 +00:00