Commit Graph

13651 Commits

Author SHA1 Message Date
Treehugger Robot 3cd737db84 Merge "Add null checks to prevent NPE on ViewModel." into main 2025-02-20 11:03:26 -08:00
Treehugger Robot e8a1719649 Merge "Copy drawable so that mutations don't affect other uses of the drawable" into main 2025-02-20 10:28:17 -08:00
Treehugger Robot 9bacd7ce4a Merge "Send intent boradcast when AllSetActivity ends and reaches launcher" into main 2025-02-20 09:42:57 -08:00
Uwais Ashraf 91370114ea Add null checks to prevent NPE on ViewModel.
ViewModel can be null if onRecycle completes before coroutineJob is cancelled.

Fix: 395751707
Flag: Exempt - test fix
Test: OpenActivityEmbeddingPlaceholderSplitTest in postsubmit
Change-Id: I12e1f6e2e5951ae04264fc8ea9d45b6ac6d43308
2025-02-20 17:03:27 +00:00
Uwais Ashraf 19381579f1 Copy drawable so that mutations don't affect other uses of the drawable
Fix: 397770855
Flag: EXEMPT - test fix
Test: OverviewTaskSelectImageTest
Change-Id: I9e0fa179ab3c7de6edf566f50459c51c6efb4377
2025-02-20 08:28:28 -08:00
Treehugger Robot 6f7d05b2a5 Merge "Prevent high res callback from fetching when not needed." into main 2025-02-20 06:29:13 -08:00
Treehugger Robot c6a24e4178 Merge "Use scale adjusted path to avoid warped rounded corners." into main 2025-02-20 05:29:15 -08:00
Alex Chau 0b584b0c98 Merge "Update Desktop tasks's corner radius to match Shell side" into main 2025-02-20 05:25:17 -08:00
Sergey Pinkevich e97f4932fd Merge "Add logs for DesktopAppLaunchTransition when animation starts/no launch change" into main 2025-02-20 02:20:28 -08:00
Treehugger Robot 233e7e2a6f Merge "[Memory Leak] Attempt to fix leak caused by onEndCallback created for open app animation not running" into main 2025-02-20 00:04:03 -08:00
Treehugger Robot cad0c7f8c6 Merge "Make can create new desks a global state" into main 2025-02-19 18:13:42 -08:00
Fengjiang Li c926dd5be2 [Memory Leak] Attempt to fix leak caused by onEndCallback created for open app animation not running
Fix: 397690719
Flag: NONE - release code
Test: presubmit
Change-Id: Icf36b744f21f50b7182c81437ef29b5886c2d43d
2025-02-19 18:00:41 -08:00
Treehugger Robot 1444e05a5f Merge "Fix performance regressions with handheld apps panel." into main 2025-02-19 17:32:20 -08:00
Eric Lok 8504c427c7 Merge "Mark tasks on launcher as perceptible" into main 2025-02-19 15:55:22 -08:00
Cosmin Băieș 4af51a46f6 Merge "Use FLAG_ALT_FOCUSABLE_IM in taskbar when needed" into main 2025-02-19 15:08:48 -08:00
Treehugger Robot f0dd54fb83 Merge "Exclude dynamic shortcuts from being force themed" into main 2025-02-19 14:46:39 -08:00
Treehugger Robot af35666c20 Merge "[CD Taskbar] Create new taskbars only when we have system decor" into main 2025-02-19 14:39:03 -08:00
minch 92cb978575 Make can create new desks a global state
Bug: 389209338
Test: m
Flag: EXEMPT new APIs update without impl yet.
Change-Id: Id7ebfbc1d03d823932515df42fa51e22f44f8116
2025-02-19 21:24:49 +00:00
Sukesh Ram 1b4d00e250 [CD Taskbar] Create new taskbars only when we have system decor
Only allow for new taskbars  when wm.shouldShowSystemDecors=true.

Bug: 397250946
Change-Id: I29577224e763ca44a2b1878691dce3e3aa1534ff
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays
2025-02-19 11:25:27 -08:00
Sunny Goyal 91547eb4d2 Merge "Simplifying icon normalization for adaptive icons" into main 2025-02-19 10:36:30 -08:00
Sihua Ma 097efdc8ac Exclude dynamic shortcuts from being force themed
Test: Manual
Bug: 397501448
Flag: com.android.launcher3.force_monochrome_app_icons
Change-Id: Iff1010e268c99ce192e1445ec124229c84420b23
2025-02-19 18:16:10 +00:00
Uwais Ashraf acf4dc0a1c Use scale adjusted path to avoid warped rounded corners.
Fix: 355429331
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaskThumbnailViewScreenshotTest
Change-Id: I7f218b53cc2dd644ce61a0d343901a25cc8b0604
2025-02-19 17:29:16 +00:00
Uwais Ashraf 09933afac9 Prevent high res callback from fetching when not needed.
Fix: 395636649
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TasksRepositoryTest
Test: TaskVisualsChangedDelegate
Change-Id: I7e0f47adb07455c1fed4761d67de901b56bdeb52
2025-02-19 17:05:06 +00:00
Lingyu Feng f9ceda3e3b Merge "Remove taskbar when display mirroring starts" into main 2025-02-19 05:31:51 -08:00
Lingyu Feng 0392cb8a7d Remove taskbar when display mirroring starts
Bug: 397095099
Change-Id: I0d21650af45aec084c0b48b50e22e8072d3f9192
Test: adb shell settings put secure mirror_built_in_display 1
Flag: com.android.server.display.feature.flags.enable_display_content_mode_management
2025-02-18 22:37:44 -08:00
Wei Sheng Shih e0221f0c8b Merge "Release predict_back animaton leash in Launcher." into main 2025-02-18 18:24:48 -08:00
Treehugger Robot 3c985a8c65 Merge "Indices correction inside RecentsView" into main 2025-02-18 17:02:45 -08:00
Treehugger Robot f1397811e0 Merge "Do not crash DesktopVisibilityController on unknown displays" into main 2025-02-18 17:02:00 -08:00
Mykola Podolian a593d2a7da Merge changes I6fe1139e,I581dddf2 into main
* changes:
  Handle new bubble notification while drag is in progress.
  Made the bubble bar react to drag events from the Shell.
2025-02-18 14:03:17 -08:00
Ahmed Fakhry 41111bd8f6 Do not crash DesktopVisibilityController on unknown displays
Instead of requiring that a valid display ID is given to
the APIs in `DesktopVisibilityController` and crashing the Launcher,
this CL lets the code handle invalid IDs gracefully, and adds a test
that fails without the fix.

Bug: 392986431
Test: atest NexusLauncherTests:com.android.launcher3.statehandlers.DesktopVisibilityControllerTest
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: Id1bc7876ce654b96191c85089557b9279963acd8
2025-02-18 20:54:19 +00:00
Treehugger Robot bc55a8ee4b Merge "Fix live tile in dismiss and swipe down animation" into main 2025-02-18 11:20:42 -08:00
mpodolian 39c4bf2448 Handle new bubble notification while drag is in progress.
Handle new bubble notification while drag is in progress. Updated logic
to react to new bubble notifications arriving during drag operations
before a drop occurs.

Bug: 388894910
Flag: com.android.wm.shell.enable_create_any_bubble
Test: BubbleBarViewAnimatorTest
Test: Manual. Go to some application and have no bubbles. Start
dragging the taskbar icon over the bubble bar drop zone. Trigger new
bubble with the bubbles test application. Observe drop target is
hidden and new bubble is animated in, followed by flyout. When flyout
disappears, bubble bar remains on the screen. Release icon over the
bubble bar. Observe newly added application bubble is expanded. Repeat
same test, but drag the taskbar icon to the opposite side.
Test: Manual. Go to some application, but have bubbles. Start
dragging the taskbar icon over the bubble bar drop zone. Trigger new
bubble with the bubbles test application. Observe new bubble is added
and the flyout is shown. When flyout disappears, bubble bar remains on
the screen. Release icon over the bubble bar. Observe newly added
application bubble is expanded. Repeat same test, but drag the taskbar
icon to the opposite side.

Change-Id: I6fe1139ef56f4ad40d36a804016d23a9b34abf5f
2025-02-18 10:45:20 -08:00
Saumya Prakash 7286e3b053 Merge "Update Taskbar edu with new font style" into main 2025-02-18 10:40:44 -08:00
minch 754e24c521 Indices correction inside RecentsView
Audit all the functions inside RecentsView with the TaskView index as
a parameter. Make sure the AddDesktopButton is considered while
setting the value of these parameters.

Flag: EXEMPT refactor
Bug: 379942019
Test: m
      alt+tab to the "# more apps" button insde KQS view, the first
      hidden TaskView inside the RecentsView will be focused.
Change-Id: I92cd3e38700e83e72d362dc47d3adae538695b60
2025-02-18 18:11:02 +00:00
Mady Mellor 21fde7581c Merge "Allow bubble bar to show on phones if the flag is enabled" into main 2025-02-18 09:34:44 -08:00
Treehugger Robot a00a837bd8 Merge "Do not translate the AddDesktopButton on dismissing a TaskView" into main 2025-02-18 09:15:44 -08:00
Alex Chau 65c04b0f05 Fix live tile in dismiss and swipe down animation
- Add separate property for grid translation in TaskViewSimulator, so it doesn't get reset when other translations (e.g. dismiss) is applied to live tile
- In createAdjacentPageAnimForTaskLaunch, use onAnimationStart without isReverse parameter, so it's actually called when the PendingAniamtion starts
- Also reset pivot if we have overriden it during createAdjacentPageAnimForTaskLaunch
- Also avoid applying addOverviewToAppAnim on live tile if it's not launching, otherwise recentsViewScale will be applied twice with addOverviewToAppAnim applying wrong value
- Use pivot instead of recentsViewScroll to bring non scroll position live tiel to fullscreen, to avoid a trajectory that will otherwise travel left and then right

Fix: 391146807
Fix: 321013528
Test: launching via swipe down with non-launching live tile
Test: dismissing live tile
Test: launching live tile in non scroll position
Flag: com.android.launcher3.enable_grid_only_overview
Change-Id: I24ee85399b09b25e157a8986103658bb4803a87e
2025-02-18 17:13:21 +00:00
Schneider Victor-Tulias ef06ef3328 Send intent boradcast when AllSetActivity ends and reaches launcher
Flag: EXEMPT supporting new SUW behaviour
Bug: 396378163
Test: registered temporary broadcast receiver and checked logs
Change-Id: Ib39da6bf17efd7e72c8e45bc2528781e1b9aa8d3
2025-02-18 12:08:45 -05:00
Treehugger Robot 329763191a Merge "Reduce ViewPool sizes for Desktop/GroupedTaskView to save RAM." into main 2025-02-18 08:59:42 -08:00
Treehugger Robot 0351edbdcc Merge "Move dismiss utils into new Util class." into main 2025-02-18 08:08:35 -08:00
Alex Chau 9063bd7a46 Update Desktop tasks's corner radius to match Shell side
Fix: 384517710
Test: OverviewDesktopTaskImageTest
Flag: EXEMPT BUG_FIX
Change-Id: I021c3cd4e8c1cc13066def470536535c5dbc791e
2025-02-18 15:19:04 +00:00
Uwais Ashraf 5a148aef44 Reduce ViewPool sizes for Desktop/GroupedTaskView to save RAM.
Bug: 395287683
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - split tasks displaying correctly
Change-Id: Ib4496ee1859cc5245ec4ef76f0723de8fbd55b7c
2025-02-18 07:13:58 -08:00
Pat Manning d093526259 Move dismiss utils into new Util class.
Fix: 396111473
Test: Manual. Does everything build.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I039fc38c133245e52b7ca30ff5231ddba7b77e47
2025-02-18 06:11:41 -08:00
Treehugger Robot bb6c434ca6 Merge "Clean-up unused dependencies from TaskContainer and RecentsDependencies" into main 2025-02-18 05:54:05 -08:00
Sergey Pinkevich 668f630d92 Add logs for DesktopAppLaunchTransition when animation starts/no launch change
Bug: 395495925
Flag: NONE only adding logs, not change of actual code
Test: manually

Change-Id: I02d436b6a7bd2210f7917211648124b11d7bb972
2025-02-18 12:20:14 +00:00
Jordan Silva 73120a210b Clean-up unused dependencies from TaskContainer and RecentsDependencies
Fix: 397222030
Doc: go/launcher-overview-unified-taskviewmodel
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTest
Test: TaskViewModelTest
Test: GetThumbnailPositionUseCaseTest
Test: GetThumbnailUseCaseTest
Change-Id: Idc1793039b4fc57d666dc19c55b984ba617c67bd
2025-02-18 03:39:42 -08:00
Cosmin Băieș 28d8275737 Use FLAG_ALT_FOCUSABLE_IM in taskbar when needed
Previously taskbar would only set/remove the FLAG_NOT_FOCUSABLE, which
also made it IME focusable. This was toggled when a tasbkar folder was
opened/closed, as well as opening the popup by long pressing an app in
the taskbar. Folders do require IME focusability, as the folder name can
be edited. However, the popup does not require IME focusability, and
this lead to the IME suddenly disappearing when the popup is shown.

This fixes the issue by also setting FLAG_ALT_FOCUSABLE_IM as needed,
only when the taskbar is also focusable. This follows the same logic
as in NotificationShadeWindowControllerImpl.

Flag: EXEMPT bugfix
Test: switch to gesture nav, show IME in app, show popup and verify
  IME is still visible
  open folder in either taskbar or launcher and verify IME can be shown
Bug: 361046041
Change-Id: Idb9b4503d5622222e99735f0f6981a17add12360
2025-02-18 12:12:40 +01:00
wilsonshih 3f20308743 Release predict_back animaton leash in Launcher.
Release the animation leash after back_to_home animation done.

Flag: EXEMPT bugfix
Bug: 395035430
Test: Use the back gesture to trigger the back_to_home animation
multiple times and perform multiple random transitions, dumping the
Surface Flinger to check the predict_back leashes not remain in the
offscreen layer.

Change-Id: I7ed9dfd510e38bed28b51762df9976d33c4a5644
2025-02-17 23:19:16 -08:00
mpodolian c7106806f1 Made the bubble bar react to drag events from the Shell.
Added logic to show and hide the bubble bar drop target on Shell
drag-and-drop events.

Test: Manual. Drag a shortcut or an application icon from the taskbar to
the bubble bar drop zone. Observe that if the bubble bar is showing
bubbles, the background stroke color becomes non-transparent; if there
are no bubbles, the drop zone appears. Drag the app icon to the opposite
side and observe that the bubble bar location is animated or the drop
zone appears on the dragged side. Drop the application icon or shortcut
on any side and observe that a new bubble is added and immediately
expanded. Additionally, the bubble bar remains at the drop location.
expanded.
Bug: 388894910
Flag: com.android.wm.shell.enable_create_any_bubble

Change-Id: I581dddf2c76ac982a5c78bc32d94b79bf63fd2b9
2025-02-17 16:50:46 -08:00
David Stevens 1189ee33c6 Mark tasks on launcher as perceptible
Mark all tasks on launcher as perceptible tasks.
Flag enablement is for desktop devices only.

Bug: 370890207
Test: Manual
Flag: com.android.server.am.perceptible_tasks
Change-Id: Ic9022dcb07f2fc2d1bd1277bc1a83233ebc5626e
2025-02-17 01:06:13 +00:00