Commit Graph

2012 Commits

Author SHA1 Message Date
ELIYAZ MOMIN (xWF) 31d6be8891 Revert "Moving TisBinder to its own class"
This reverts commit ce9ad064d6.

Reason for revert: <Potential culprit for  b/395855288  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted>

Change-Id: I12d1eb66ae03e2638a503c103d0b1fa8a863b6b5
2025-02-11 08:18:42 -08:00
Sunny Goyal ce9ad064d6 Moving TisBinder to its own class
> Using callback patter for various change events instead of routing it
  via  TIS

Bug: 386288280
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I95577d6a1c17103cb947ef1200c1c22b68fd1d9c
2025-02-11 00:21:51 -08:00
Cole Faust 04bff7b50c Merge "Replace .toList() with .collect()" into main 2025-02-10 11:59:47 -08:00
Adnan Begovic 2eb151771c launcher3: Gate strict mode enablement behind flag.
Bug: 394651876
Flag: com.android.launcher3.enable_strict_mode
Test: Manual
Change-Id: I973dacbfac1fbcd889c503623df948c8fde379dd
2025-02-05 15:32:40 -08:00
Adnan Begovic 3d29c0a062 launcher3: Amend strict mode policy to account for activity leaks.
detectActivityLeaks() will identify any cases where subclasses
  of Activity are leaking.

Bug: 392635961
Test: EXEMPT debug code
Flag: EXEMPT debug code
Change-Id: I28057738a7bb8951a39152f4a4e6954bd2b97706
2025-02-04 14:08:37 -08:00
Sunny Goyal edc1453cf1 Removing BaseDraggingActivity
> Merging come methods to BaseActivtiy
> Separating wallpaper theme implementation to an independent class

Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I8cdb6d1520beff3f8226b62c5b7eafd48b2c674f
2025-02-03 17:23:10 -08:00
Cole Faust 1b9fd985d4 Replace .toList() with .collect()
.toList() was only introduced to android in api level 34, which is newer than
this module's min_sdk_version. Replace it with .collect().

This was found while updating android lint.

Flag: EXEMPT refactor
Bug: 394096385
Test: Presubmits
Change-Id: Id8d1de1531b67a7daf448e45592b7ef78f685fc2
2025-02-03 14:19:12 -08:00
Sunny Goyal dfbbebc9e3 Revert^2 "Unifying various model update callbacks into one"
72f9943f64

Change-Id: I38901714947a2b7926723ea25df4a2b8216303e4
2025-01-30 13:19:32 -08:00
Pechetty Sravani (xWF) 72f9943f64 Revert "Unifying various model update callbacks into one"
Revert submission 31445615-model-callbacks

Reason for revert: <Droidmonitor crested revert due to b/393222548. Will be verified through ABTD for stanadard investigation.>

Reverted changes: /q/submissionid:31445615-model-callbacks

Change-Id: If6893a125756e5abfbb215af377576429bb1c91b
2025-01-29 22:46:55 -08:00
Sunny Goyal 36c3112abf Unifying various model update callbacks into one
Making the BubbleTextView.applyItem stateless so that it does not depend on the order of events

Bug: 390572144
Flag: EXEMPT refactor
Test: atest LauncherBindableItemsContainerTest
      atest BubbleTextViewTest
Change-Id: Ib9c0ac6c330d6f4e08c3db5772d35787fa056b65
2025-01-28 16:03:01 -08:00
Vinit Nayak 3815a095f1 Remove and cleanup splitContextual flag
Bug: 276361926
Flag: EXEMPT removing flag
Change-Id: I6f567a8aae5b962f36ec2bc96b7fb05906b4ff2f
2025-01-14 10:23:59 -05:00
Sihua Ma 67db76e847 Merge "Change home screen state description to manifest page change" into main 2025-01-06 10:37:20 -08:00
Sunny Goyal 6d6529cff9 Merge "Converting LauncherPrefs to dagger" into main 2025-01-03 14:18:19 -08:00
Sunny Goyal e79d453bc8 Converting LauncherPrefs to dagger
Fixing ENABLE_TWOLINE_ALLAPPS_TOGGLE not properly tied to IDP:
http://recall/-/ep7WJ8pKwCEklUN5J1mAkM

Bug: 361850561
Flag: EXEMPT dagger-migration
Test: atest LauncherPrefsTest FakeLauncherPrefsTest
Change-Id: Iba63d060f4a8c2e31033fca2a4638c559c161338
2025-01-03 13:49:53 -08:00
Sihua Ma 2bad402275 Change home screen state description to manifest page change
Bug: 383247157
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I1c2d3aa90d2b4ee9a1beaa4fbe7db57e79ae49dc
2025-01-03 00:00:48 +00:00
Sunny Goyal 04b50a08f6 Fixing low res folder icon when preview changes
Also removing legacy for drawable sharing between folder-content and folder-icon, since preview now always creates new drawables

Flag: EXEMPT bugfix
Bug: 386842651
Test: atest PreviewItemManagerTest
Change-Id: Ib8e4b4d5be4fb0c9601b9d8e3cef8a29d6c77651
2024-12-30 15:47:17 -08:00
Shamali P 9753481abb Remove disruptive announcement when widget is added
Bug: 383423227
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I59aa0c226f197c3e25c50738230ce8c070f7f483
2024-12-23 07:58:46 -08:00
Holly Jiuyu Sun 3bfeb56eca Merge "[a11y] Do not announce "item added to homescreen" after adding web shortcut." into main 2024-12-20 15:05:35 -08:00
Holly Sun 52b5d3b4f0 [a11y] Do not announce "item added to homescreen" after adding web shortcut.
Bug: 383457529
Test: manual
Flag: EXEMPT talkback bug fix
Change-Id: I3fe331b17e51e208e2b5ce74be88e35c2b802077
2024-12-19 11:22:58 -08:00
Sebastián Franco f07079d0ff Merge "Revert^2 "Making sure that test go to FixedLandscape on landscape"" into main 2024-12-18 14:16:08 -08:00
Sebastián Franco 12c346fbab Revert^2 "Making sure that test go to FixedLandscape on landscape"
This reverts commit d98bb0b979.

Reason for revert: b/383917141

Change-Id: I503fd7136b927064a54e428e422335c06e221e2e
2024-12-17 11:19:29 -08:00
Fengjiang Li b8b16bd288 [-1] Fix flicker of -1 when swipe up to exit -1 isn't fast enough
Fix: 381017761
Flag: NONE - released code
Test: manual - record a video
Change-Id: I5bda4a234cdcc8227d4feb9a92a174d07e46f7a2
2024-12-13 12:11:41 -08:00
Sunny Goyal 0cb0166a2c Fixing nullpointer error in genering error description
Bug: 383492095
Flag: EXEMPT bug fix
Test: Presubmit
Change-Id: I43c71bb62df45d53bd757daa3203f216229946a0
2024-12-11 11:41:39 -08:00
ELIYAZ MOMIN (xWF) d98bb0b979 Revert "Making sure that test go to FixedLandscape on landscape"
This reverts commit 279b77a882.

Reason for revert: <Potential culprit for b/383424365 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.>

Change-Id: I4b1c81a8e458432c880ad68fa5bd0e2062f2680f
2024-12-11 02:38:04 -08:00
Sebastian Franco 279b77a882 Making sure that test go to FixedLandscape on landscape
Fix: 379871292
Test: TaplDragTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I56027c22e4c3b1b0532ba0ac00eb0f4caea24abb
2024-12-10 17:08:54 +00:00
Alex Chau c76d4a8971 Restore fallback Overview state when restarted by theme changes
- Moved RUNTIME_STATE_RECREATE_TO_UPDATE_THEME to StatefulActivity
- Handle uiMode in RecentsActivity
- When RecentsActivity is recreated due to theme changes, restore previous state

Fix: 382072029
Test: Manual: Change light/dark them from QuickSettings while in fallback Overview, Overview stay open
Flag: EXEMPT bugfix
Change-Id: Ia596150afa1436c4a25e94fd2b6930a8ded0b0d4
2024-12-06 17:10:03 +00:00
Alex Chau ba8b4d7851 Merge "Reland "Handle uiMode changes in QuickstepLauncher"" into main 2024-12-04 10:45:02 +00:00
Alex Chau 007abe80e4 Reland "Handle uiMode changes in QuickstepLauncher"
- Added uiMode in handled configChanges for QuickstepLauncher, NexusLauncherActivity
- RecentsActivity will be handled separately in b/382072029
- This avoids Launcher from being recreated when swithching from an app in driving mode (e.g. Maps), which causes massive jank
- Launcher layout is unaffected when driving mode changes, so a recreation is unnecessary
- When Light/dark mode changes, BaseActivity.updateTheme will still causes activity to be recreated. Launcher will mark a boolean in saved staete so next recreate will restore previous state even if state has FLAG_DISABLE_RESTORE (e.g. Overview), similar to the existing check that force restore when UI_MODE changes

Relanded changes: /q/submissionid:27627108-b/339747262

Fix: 339747262
Test: Swtich from driving mode app to another or home in 1p and 3p laucnher
Test: Switch light/dark mode and Launcher is updated correctly and stay in previous state
Flag: EXEMPT bugfix
Change-Id: I5a62b1bcd19eed9d232f30db94aa0e032f4541bd
2024-12-03 18:20:56 +00:00
fbaron d1cd8c2ea6 Add GridDimensionSpecs to fixed landscape and make grid dimension generalized so we can use it to determine row count or col count
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: If1dafedc710ebc483fc7b6b5cd6cae6f70dc3cfc
2024-12-03 02:43:13 +00:00
Sebastian Franco cb8f82a9fd Remove Allow Rotation in foldables
Fix: 380128987
Flag: com.android.launcher3.one_grid_specs
Test: NA
Change-Id: I4bdb495b57fa7d638dde3fe47e853f3505f63628
2024-11-20 15:42:43 -08:00
Juan Sebastian Martinez 4c35e50dd4 Adding MSDL history to Launcher's dump information.
The history displays the latest tokens played. Useful for testing and
debugging.

Test: presubmit
Flag: NONE MSDL playback is flagged case by case.
Bug: 377496684
Change-Id: I163889ade9fe4dee7f02459d2d9d81b94197bea1
2024-11-19 15:44:39 -08:00
Sebastian Franco 52ae78d11b Dissable allow rotation when oneGridSpecs flag is on
Flag: com.android.launcher3.one_grid_specs
Test: IntegrationReorderWidgetsTest
Bug: 378956572
Change-Id: I41e591b6d8fa1f93e2034a784516d5a38e83cbd9
2024-11-14 21:53:38 +00:00
Ana Salazar Maldonado bdbad823ce Add contrast pill to workspace apps
When the flag is enabled, allow the BubbleTextView to draw a background
pill behind the app title. Also change the color of the text to properly
ensure contrast.  The contrast pill is only enabled for workpace apps,
so attempt draw the pill only for DoubleShadowBubbleTextView elements.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: Idce27bd8dfca4b525c762fcd0873562f31b45b8f
2024-11-12 13:36:13 -08:00
Sebastian Franco b1c47097d8 Move fixed landscape in RotationHelper from a request to a variable
Bug: 364711735
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I38ed82b2906308754d5157f6319e5d19fcfbc385
2024-11-08 12:09:08 -08:00
Sebastian Franco 9e4c99befd Adding Launcher Mode settings to Launcher settings
Bug: 364711735
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: Iab688ebdb8449f9258b61f59a0afe97875f82a81
2024-11-07 21:17:10 -08:00
Shamali P ea078cb647 Add a resource override for providing default widgets filter.
The implementation in this CL is no-op i.e. all widgets will be shown

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Verified with other child cls
Change-Id: I0a6f8973dc8ec58fd87d29b3f291b5e290ea988d
2024-11-04 22:17:23 +00:00
Treehugger Robot f6c4a7acb1 Merge "[PostBoot] Fix bug where post boot shader has a flicker" into main 2024-10-26 07:17:58 +00:00
Fengjiang Li dd7d854c3a [PostBoot] Fix bug where post boot shader has a flicker
Pass correct default value -1 when getting RUNTIME_STATE_PENDING_REQUEST_CODE when it is not set.

This will avoid accidentally starting ProxyActivityStarter from Launcher#onCreate(), which will cause a flicker for post boot animation

Fix: 375308654
Flag: NONE - xml flag not supported
Test: manual
Change-Id: Ic3888508657b5b7aab37f6022768d53007bf9c00
2024-10-25 03:59:47 +00:00
Schneider Victor-Tulias 8463dc47eb Generalize ActivityTracker to support RecentsWindowManager
Continued quick switch couldn't work using existing infrastructure until RecentsWindowManager could be properly tracked by ActivityTracker. Refactored ActivityTracker into ContextTracker to support this.

Also refactored ActivityInitListener into ContextInitListener to fit the updated pattern.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 366023051
Test: RecentsWindowSwipeHandlerTestCase; Attempted continued quick switch from home and launched app
Change-Id: Ic38ebf3611ef22fbfd1ddeb79d72d8a3621940a0
2024-10-22 15:29:59 -04:00
Brandon Dayauon 093cf62e69 Merge "Force config update when twoline is toggled." into main 2024-10-12 05:33:47 +00:00
Brandon Dayauon 05105162d7 Force config update when twoline is toggled.
Based on the bug, it seems that onHandleConfigChange was not called via the perfetto trace. Here is the call order:
1) Loader Task is created
2) Loader task runs
3) Preinflation happens from setApps() in bindAllApplications() via ModelCallbacks.kt
4) When show long app names toggle happens: it eventually triggers an onHandleConfigurationChanged() which is traceable in perfetto.
5) After configChange, preinflation happens again.

In step 4) there is an early return that happens and makes it so it doesn't call the reinflation of views that happens in the mModel.rebindCallbacks().
When the force configUpdate happens upon toggle, reset the variable after it is done.

bug: 370121944
Test: presubmit/manually/perfetto in bug
Flag: NONE trying to fix edge case
Change-Id: Id0ba591bfe583b300cc241fcfc37db6dd5a85363
2024-10-11 15:43:02 -07:00
Shamali P dfcec9c71c Fix issue that widget drag and drop failed when are off
Remove extra screen & go to normal state only if widget
addition was complete. If a config activity was started, then
don't change to remove screen yet or go to normal state. Else,
QuickStepLauncher clears the existing activity open requests when
going to normal state. When animations are off, this led to config activity to never launch and hence, such widgets not being added.

Bug: 369422714
Test: Manual
Flag: EXEMPT BUGFIX
Change-Id: I4e7e29fd998a0cc5ca18a7a48b91a5b788a60a52
2024-10-09 20:28:39 +00:00
Sunny Goyal 621918feda Changing min-sdk version of Launcher to 31
Bug: 368071216
Flag: EXEMPT refactor -> dead code removal
Test: Presubmit
Change-Id: I1f0113c56de56f12f3a174eb31c3f8e8a09407e6
2024-09-20 06:00:10 +00:00
Mykola Podolian bff3b73c8f Merge "Hide hotseat when bubble bar is expanded." into main 2024-09-17 17:38:33 +00:00
Liran Binyamin 69f4974e24 Hide hotseat when bubble bar is expanded.
Added logic to stash the hotseat when on launcher home screen.

Bug: 280494203
Test: Manual:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/fjfjUw296LRXUm9uYqXU4K
all tests in com.android.launcher3.taskbar
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I67b298831eaed9c549a2fae7dc5a0d9fae51f7c4
2024-09-16 15:50:28 -07:00
Sunny Goyal 4f9ba255a4 Cleaning up some enabled features
Bug: 270394468
Bug: 270393900
Bug: 270390907
Bug: 270390930
Bug: 270390937
Bug: 270391693
Bug: 270391638
Bug: 270395177
Bug: 270395269
Flag: EXEMPT legacy flags cleanup
        ENABLE_SHOW_KEYBOARD_OPTION_IN_ALL_APPS
        ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
        ENABLE_DEVICE_SEARCH
        ENABLE_HIDE_HEADER
        ENABLE_TWOLINE_ALLAPPS
        IME_STICKY_SNACKBAR_EDU
        FOLDER_NAME_MAJORITY_RANKING
        SCROLL_TOP_TO_RESET
        ENABLE_SEARCH_UNINSTALLED_APPS
        ENABLE_HOME_TRANSITION_LISTENER

Test: Presubmit
Change-Id: Ia392c10fc65616405cc4d4a2b8ed566e3bb7d386
2024-09-13 14:24:27 -07:00
Fengjiang Li 97db09dbd8 Merge "[-1] Show toast when user trys to swipe to -1 on extreme battery saver mode" into main 2024-09-10 16:41:21 +00:00
Fengjiang Li a7e357e339 [-1] Show toast when user trys to swipe to -1 on extreme battery saver mode
Fix: 355485335
Flag: com.android.launcher3.use_activity_overlay
Test: manual - record a video
Change-Id: I79a3ece2fb2c0d1eddac0e4f91274ffe222e317f
2024-09-09 19:06:17 -07:00
Sunny Goyal f158286c34 Adding more properties in LaunchCookie, instead of just itemId
This allows better matching of items who do not have a fixed id

Bug: 364363493
Flag: EXEMPT bug fix
Test: Manual- Verified app launch and back animation
Change-Id: I4f9deba89399b89974686b64226b99f91a3d46be
2024-09-09 12:11:36 -07:00
Mark Fasheh 4baa30d151 Update launcher cold startup trace
Bug: 341061764
Flag: EXEMPT bugfix
Test: Boot phone, take trace
Change-Id: I29b5be5525206ac83bc36596395a1f71b43715c6
2024-08-29 00:03:00 +00:00