We use to create a "TaskbarUiThread" for each new taskbar context but forget to destroy the thread.
We fix it by creating a static thread named as "TASKBAR_UI_THREAD"
Fix: TBD
Flag: com.android.launcher3.enable_taskbar_ui_thread
Test: manual
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:66e79baa21573579802ceb7e283c5bb5954a4365)
Merged-In: Idd54c76c39b32a2765c64da1e519c9faa79dac75
Change-Id: Idd54c76c39b32a2765c64da1e519c9faa79dac75
The problem: Currently, when users increases font size to fullest and also display size to fullest, taskbar icons goes beyond screen. The isssue is event worst when there is bubble bar present in the Taskbar. This is currently a problem with 3 button nav button.
The Solution: The solution is in two parts.
Part 1: figure out amount of icons we need to remove from hotseat for the taskbar icons to not got beyond screen and not collide with nav buttons or bubble bar.
Part 2: Once we figure out how many icon we need to not show in takbar which are present in the hotseat, we need to modify the takbar icon alignment controlled to modify alpha animation and eventually the visibility of those taksbar views. We also need to modify taskbar icon layout logic so that we don't take space for invisible taksbar icons and we layout next visible icon on the place of invisible icons.
Test: Manual, Presubmit
Bug: 412835965
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:8def3264e3f4fa3a2354dfa693751ea3d5f33f36)
Merged-In: I8dea948df09c0a86871a9ac649f312ecf281545a
Change-Id: I8dea948df09c0a86871a9ac649f312ecf281545a
Update TaskbarView logic to remove all apps divider when it's not
expected to show (if the taskbar is showing desktop tasks), instead of
just assuming it was never added. This handles an edge case where
`shouldShowDesktopTasks()` may return false initially for taskbar on
home screen, until home screen visibility as seen by taskbar controllers
is updated when transitioning out of desktop mode.
Bug: 416402113
Test: On desktop first device, disable
enable_desktop_taskbar_on_freeform_displays, go to desktop mode,
then minimize/close all desktop windows. On home screen, verify
taskbar is shown, and contains only pinned apps - no divider is
shown between all apps and pinned apps.
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:f10c3e9afe8aa866fe21c797a5aade262bd4fcdc)
Merged-In: I7bb419d87420575cebe0c332111797678b07d654
Change-Id: I7bb419d87420575cebe0c332111797678b07d654
Partially reverts ag/33592869
- It seems that it was meant for close animation, however this value
is mainly used for open animation.
Bug: 424740625
Test: See demo
Flag: EXEMPT BUGFIX
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ee94bdd219120e430e1a262729d9409615ef4130)
Merged-In: I574fc18919d58bc0be3529350ac29bcf8f42f9e4
Change-Id: I574fc18919d58bc0be3529350ac29bcf8f42f9e4
Clear mFloatingRotationButton from NavbarButtonsViewController#onDestroy()
Fix: 424253928
Test: manual - rotate screen in comet and verfiy no leaks
Flag: NONE - released code
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b693a10d6493556ef30d7011eee6804bd7890f89)
Merged-In: I43ef6bcf67e44e76eb17d80e0d996d2066f154e0
Change-Id: I43ef6bcf67e44e76eb17d80e0d996d2066f154e0
LauncherRestoreEventLoggerImpl should be available to NexusLauncher as
well. It was a mistake it was exposed only to Quickstep version.
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: Id36deef2790373651684acb8f03f91ca9e0e662c
This change adjusts the placement for the back button in setup wizard of
16dp. This aligns with the UX design.
Fixes: 418936840
Test: Launch setup wizard and quickly verify a gap between the back
button and the SUW buttons.
Flag: EXEMPT bugfix
Change-Id: Ie7680a5a97e78430b8f7a7fecc8e1c1ee045aa8a
This change removes the talkback announcement for the background app LauncherState, which defaulted to "Recent apps".
Flag: EXEMPT bug fix
Fixes: 418854152
Test: attempted home/overview/quick switch gestures from home and app
Change-Id: I1f390902dfddd2e8576743dbbddce65121690f14
Bug: 404753077
Flag: com.android.window.flags.enable_taskbar_overflow
Test: Verify that taskbar overflow bubble view only shows tasks not
visible in taskbar.
Change-Id: Ie04f79c91b524bbc592309ef62723d428e78f304
This CL prevents taskbar from forcefully moving the existing fullscreen
task to desktop on desktop-first display.
On desktop-first displays, we want to keep the current windowing mode
when its taskbar app icon is clicked.
Flag: com.android.window.flags.enable_desktop_first_fullscreen_refocus_bugfix
Bug: 420499923
Test: TaskbarRecentAppsControllerTest
Change-Id: I5e5c950d2e7bd25762eaddad94c57a4bf29ee800
When we tap on recents, setActivityStarted set to true where
setBaseSurface is called with launcher surface. When app is opened
setActivityStarted is false and setBaseSurface is set to null.
In subsequent calls, between where call to setBaseSurface with launcher
is skipped. This causes due to race condition between
removeOnDrawListener which is "asynchronously" posted from
onLauncherDraw and addOnDrawListener. This makes addOnDrawListener not
to get properly added.
Hence mBaseSurface remains null and we do not get chance to set the blur
to launcher layer to 0 and then reparent/relayer blur behind live tile.
Hence blur is still over launcher layer which makes live tile blur.
Added boolean that makes async removeOnDrawListener in onLauncherDraw
cancellable.
Fix: 387428198
Test: Rapidly tap on recents button
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I5ed2ec198563d9edb181a723c9db47ecfe500c5d
Fixes few instances where taskbar icon layout was calculated incorrectly
for desktop-fist taskbar, assuming that taskbar gets scaled from
transient taskbar sizes to pinned taskbar (which is not the case).
Adds logic to determine whether taskbar supports transition to transient
taskbar to TaskbarFeatureEvaluator, and uses that values in place of
directly checking whether three button nav is enabled.
Bug: 413494672
Flag: com.android.window.flags.enable_desktop_taskbar_on_freeform_displays
Test: Manual - observe the taskbar layout on a desktop device.
Change-Id: Ie0d44ee5be90024ba405f652bbfd888ed22c393b
This is needed as there is no guarantee content mode will be enabled everytime sys decor flag is enabled.
Bug: 422070126
Test: NA
Flag: EXEMPT bug fix
Change-Id: I6bb85e320448448bc7ce1756250a81747f0cbb42
Also add check to SpringSet end listener to ensure it only fires once.
Fix: 420232180
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I87e023c7bf019a22b5d5b91b2ee30547250c9cd1
TaskbarLauncherStateController needs to be aware of both Launcher's and recent window's statemanagers to update the taskbar state properly. Adding recents window state checks
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/post submit
Change-Id: I8b812bec3826f90d63dd710be5093deca726b11d
Pun Butrach
Fengjiang Li
Jagrut Desai
Toni Barzic
Shamali Patwa
Treehugger Robot
Saumya Prakash
Federico Baron
Brandon Dayauon
Anushree Ganjam
Schneider Victor-Tulias
Toshiki Kikuchi
Jon Miranda
Vinay Joglekar
Ebru Kurnaz
Pat Manning
Mykola Podolian