Commit Graph

3328 Commits

Author SHA1 Message Date
Cyrus Boadway 1a9c977b2e Merge "Use icon splash screen when starting activity from widget interaction" into sc-dev am: 9dd0351ed1 am: e92f4af554
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15062776

Change-Id: I8b1eba0032a2427387e6a3fac89ec150e2e9cb35
2021-06-22 18:38:36 +00:00
Sunny Goyal aae557cf07 Merge "Fixing TaskView.launchTask.onEndCallback is not called" into sc-dev am: eb3367796a am: 2537d7e0e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032513

Change-Id: I7a1291b4b7ad951d6d37a2214a4252e90bd5dc42
2021-06-22 18:38:32 +00:00
Cyrus Boadway 9dd0351ed1 Merge "Use icon splash screen when starting activity from widget interaction" into sc-dev 2021-06-22 18:13:52 +00:00
Sunny Goyal eb3367796a Merge "Fixing TaskView.launchTask.onEndCallback is not called" into sc-dev 2021-06-22 18:08:25 +00:00
Tracy Zhou 1aab577cd1 Merge "Null check on target set before rendering task open animation" into sc-dev am: 578b45f919 am: d107554f08
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14698046

Change-Id: I9b6ba01820192ea6e0e12aca87c06b0036b25d58
2021-06-22 17:59:25 +00:00
Tracy Zhou 578b45f919 Merge "Null check on target set before rendering task open animation" into sc-dev 2021-06-22 17:21:32 +00:00
Zak Cohen a6dd5b49d7 Merge "Fade overview action buttons faster in overview -> home" into sc-dev am: 049c2f578b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15054721

Change-Id: I680d45f36df17c08936a29b502c8e09765df3f72
2021-06-22 17:03:20 +00:00
Matt Casey f37285049a Merge "Send a zero for assist invocation on animation end" into sc-dev am: 3a65795298
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15065435

Change-Id: Ib5837248faef0c9ee2160b34dbd1e3adb40b0699
2021-06-22 17:02:36 +00:00
Zak Cohen 049c2f578b Merge "Fade overview action buttons faster in overview -> home" into sc-dev 2021-06-22 16:53:52 +00:00
Matt Casey 3a65795298 Merge "Send a zero for assist invocation on animation end" into sc-dev 2021-06-22 16:46:41 +00:00
Matt Casey eeac1aba30 Send a zero for assist invocation on animation end
When a corner gesture doesn't complete, we animate the progress from its
current value back to 0. When it hits 0, sysui will perform some cleanup
e.g. removing the window. However, it's possible the animator won't
return exactly 0 and will complete, so we should send an explicit 0
whenever the animator completes.

Bug: 187768368
Test: We don't have a repro for the bug, but expect this should be more
      robust. Tested to validate it didn't regress.
Change-Id: Id65f94534363c326fc2c8d0a9114a3c036aa55e4
2021-06-22 10:46:10 -04:00
Cyrus Boadway f158ec33d8 Use icon splash screen when starting activity from widget interaction
Set the flag to use the icon splash screen rather than the empty splash
screen when starting an activity from a widget interaction.

Bug: 191738655
Test: manual
Change-Id: Iff771a43648bbf6dfb88e2a6749c4526fd17da07
2021-06-22 10:14:06 +00:00
Tracy Zhou 8af0dd3e0c Null check on target set before rendering task open animation
Fixes: 190854921
Test: N/A
Change-Id: Iae7ef7cf3f4d2309223bfabe6d40f24b7e34439c
2021-06-21 21:33:28 -07:00
Lucas Dupin f87cd286d5 Merge "Apply depth even when surface is null" into sc-dev am: 818ed4b794
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15055654

Change-Id: I8ecba7fb05ad49dfadba39d849167b0b696304f3
2021-06-22 01:26:46 +00:00
Lucas Dupin 818ed4b794 Merge "Apply depth even when surface is null" into sc-dev 2021-06-22 01:10:23 +00:00
Lucas Dupin a6c38be150 Apply depth even when surface is null
We need to update mDepth even when the surface is null, otherwise
events will be ignored and mDepth will have the wrong value when
waking up from screen-off.

Test: pull up app drawer, screen off, unlock
Test: go to overview, screen off, unlock
Test: launch app, observe blurs and zoom
Fixes: 191153501
Change-Id: I33f5d84a50e24f05a09769b1f7f3c27969f847cd
2021-06-21 16:27:11 -07:00
Sunny Goyal 696c612964 Fixing TaskView.launchTask.onEndCallback is not called
Sometimes onAnimaitonCancelled can be called without onCreate. Calling
onEnd in this case so that the sate is cleared

Removing additional subclassing for the runner

Bug: 190856140
Test: Manual
Change-Id: If105cb343cab446a4eac90a45184ce50c6e4c485
2021-06-21 16:06:40 -07:00
Sunny Goyal 871d435be2 Merge "Finish wrapped launcher animations if impl is gone" into sc-dev 2021-06-21 23:03:27 +00:00
Sunny Goyal a29220f6b6 Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev am: b3eafe97bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032078

Change-Id: I0361531f4ff2695d97b5e48c5abc0c40fe505112
2021-06-21 22:42:06 +00:00
Tony Wickham 16119f5004 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev am: 82fc5c83a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15052402

Change-Id: Ia8a964effbc89754cd7f29986404d6ba1474a668
2021-06-21 22:41:32 +00:00
Sunny Goyal b3eafe97bb Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev 2021-06-21 22:32:23 +00:00
zakcohen 061548668d Fade overview action buttons faster in overview -> home
Spec says transition should take ~80ms, default for this transition is
~300ms, so clamp to a quarter of the range.

Bug: 191699762
Test: Local
Change-Id: I5ef6701eee0d25d5d9987e05cb53aee3e5e8e143
2021-06-21 15:18:16 -07:00
Tony Wickham 82fc5c83a5 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev 2021-06-21 22:15:48 +00:00
Evan Rosky 08c3480b84 Finish wrapped launcher animations if impl is gone
If the runner impl is gone (since it is a weakreference), we
still need to complete the animation contract by calling the
finish callback, so do that.

Bug: 183993924
Test: atest ActivityMetricsLoggerTests
Change-Id: Idce1859f0417cb74bbb9884e0d06750539e4545e
(cherry picked from commit 8a672e15cc)
2021-06-21 20:51:12 +00:00
Sunny Goyal de644313b0 Fixing animation end not-called when cancelling state the animation recursively
Bug: 190856140
Test: Manual
Change-Id: I5d6a00c1d1c0e95e615b7f2115e3e4ebb56b987f
2021-06-21 13:47:49 -07:00
Tony Wickham 9c10d08e1e Ensure mConsumer isn't set to null in reset().
mResetGestureInputConsumer is not initialized until onUserUnlocked(), meaning it might still be null in reset(). Use NO_OP input consumer in that case.

Test: none
Bug: 191669813
Change-Id: Ib9edde50fba0b6164390ec2b5c877d3db74ddfeb
2021-06-21 13:24:01 -07:00
Tony Wickham 0ac023196d Merge "Initial commit of taskbar stashing" into sc-v2-dev 2021-06-21 15:56:12 +00:00
Jonathan Miranda 94df55bada Merge "Fix bug where workspace alpha does not get set to 1 when animation gets cancelled." into sc-dev am: f9df8f3682
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023032

Change-Id: I9ab72caa407fd3e6a2e6130bcf9e924ba2c7726c
2021-06-20 22:59:04 +00:00
Vinit Nayak b974a86c8f Add IDs to buttons in 3 button nav for Taskbar
Bug: 191449914
Test: testSwitchToOverview passes
See bug for more details

Change-Id: I108bbe7607181680bca7cb5fad5e7289191edde6
2021-06-18 18:20:44 -07:00
Tony Wickham 3fd22847ac Initial commit of taskbar stashing
- Added StashedHandleViewController to provide properties such as ViewOutlineProvider to animate the handle that's shown in place of taskbar while it's stashed
- Added TaskbarStashController to coordinate the stashed state, including orchestrating the animation across taskbar controllers
- Added TaskbarStashInput consumer to detect long press in the nav region when taskbar is stashed

Behavior:
- Long pressing taskbar background animates to the stashed state by morphing the TaskbarView into the stashed handle view and offsetting the background offscreen
- We persist the stashed state across app launches and reboot; to unstash, long press the stashed handle
- We also visually unstash when going back home

Test: long press tasbkar background when in an app to stash it, long press the resulting stashed handle to unstash; while stashed, swipe up to home to also unstash until launching another app
Bug: 189503603
Change-Id: I698eff785388dff1ef717c76879719d6af236c2d
2021-06-18 17:51:39 -07:00
Sunny Goyal d7e17a860f Merge "Fixing out of order taskbar callbacks" into sc-v2-dev 2021-06-19 00:40:46 +00:00
Vinit Nayak 70565c5e7d Merge "Default to requesting command type TOGGLE for OverviewCommandHelper" into sc-v2-dev 2021-06-18 22:56:24 +00:00
Jon Miranda 651abb9924 Fix bug where workspace alpha does not get set to 1 when animation gets cancelled.
- Can also remove QSB from app launch animator, since its in the hotseat now.

Bug: 189458349
Test: manual
Change-Id: Ib41376e3f8c58166c6ee6fbfed38bdd443663df4
2021-06-18 15:39:36 -07:00
Sunny Goyal 6e1ce8ccb8 Fixing out of order taskbar callbacks
OnCreate can come before onDestroy for a previous activity which can
cause the callbacks for taskbar to get cleared

Bug: 190170303
Test: Presubmit
Change-Id: I48334605384d4604043a50ffc3d137f84575148a
2021-06-18 12:44:38 -07:00
Vinit Nayak ae7c8cacd5 Merge "Enable 3 button nav for taskbar" into sc-v2-dev 2021-06-18 05:43:41 +00:00
Sunny Goyal deec62378c Fixing Taskbar not initialized properly on recreate
Bug: 187353581
Test: Manual
Change-Id: I6e675937a033a4edcb4fa4e8151c210e14e8f896
2021-06-17 15:19:12 -07:00
Vinit Nayak e91e4f0328 Default to requesting command type TOGGLE for OverviewCommandHelper
Parity with how sysui switches between apps for double
tapping recents button.

Fixes: 190660016
Test: Double tap to switch works, tapping fast also works
Change-Id: If6dda377d8accf564f3385e78c6721c677310361
2021-06-17 12:37:02 -07:00
Alex Chau f77d45cce8 Merge "Send TaskBar touch events to tests" into sc-v2-dev 2021-06-17 17:52:44 +00:00
Winson Chung 3df79133f2 Merge "Do some additional cleanup when switching handlers" into sc-dev am: caabfa1519
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985080

Change-Id: I59c266315e6c5fe8989dcff36fe395457792c189
2021-06-17 17:01:52 +00:00
Winson Chung caabfa1519 Merge "Do some additional cleanup when switching handlers" into sc-dev 2021-06-17 16:48:42 +00:00
Alex Chau 5ca9df757a Apply dismissScale on TaskView instead of TaskThumbnailView
- As icon is hidden while TaskView become focused, there is no need to apply the scaling on TaskThumbnailView only. Apply scaling on TaskView to simplify

Bug: 14622874
Test: manual
Change-Id: Idb5fc8540649d57a071a42d36388dedcdcf893eb
2021-06-17 13:37:10 +01:00
Alex Chau ecc32bd227 Send TaskBar touch events to tests
Bug: 191344757
Test: TaplTestsQuickstep.testOverview
Change-Id: I9e1a4c6d4616e5791762a6340944212e4631862e
2021-06-17 12:56:03 +01:00
Sunny Goyal e900ec68d0 Merge "Updating taskbar icon alignment state" into sc-v2-dev 2021-06-16 22:08:07 +00:00
Jonathan Miranda c01e87daf0 Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev am: 28e39335bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14987185

Change-Id: Iecfbdc781852e24aafb92744f9a3de4ff5cbbd00
2021-06-16 20:39:08 +00:00
Jonathan Miranda 28e39335bc Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev 2021-06-16 20:34:48 +00:00
Sunny Goyal 5cf86b263e Updating taskbar icon alignment state
Icon alignment is only tied to Launcher paused/resumed state
Creating two separate states for this:
  1) Launcher paused/resumed
  2) Active gesture interaction (live-titles can affect paused state)

Removing state handler dependency on taskbar visibility

Bug: 190170303
Bug: 187353581
Bug: 187919439

Test: Manual
Change-Id: Ia97cdf43cec1d9213f5dc2af8d66258b34c57514
2021-06-16 13:30:36 -07:00
Vinit Nayak 58ffbef8f0 Enable 3 button nav for taskbar
Bug: 180046394
Test: Switched between gesture and button nav on
phone and tablet.

Change-Id: Iac2357a3256f8b6b36ca49d3680594a91e824a5f
2021-06-16 13:26:21 -07:00
Jonathan Miranda 47f8a1c3ef Merge "App Shortcut menu bug fixes and polish." into sc-dev am: c846245f1b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985072

Change-Id: Icba377c0032eee2dacec8a3c4364fa5b958880b7
2021-06-16 18:19:16 +00:00
Jon Miranda b73e591712 Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag.
Bug: 191088291
Test: manual
Change-Id: Ia144c72e0fe1292ed856a37ee714a1cda50083d5
2021-06-16 18:13:23 +00:00
Jonathan Miranda c846245f1b Merge "App Shortcut menu bug fixes and polish." into sc-dev 2021-06-16 18:06:13 +00:00