Commit Graph

15457 Commits

Author SHA1 Message Date
Tony Wickham 3979706e06 Merge "Add debug logs for why taskbar might not be destroyed" into tm-qpr-dev am: c8d8c58f5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22391708

Change-Id: I1bea5537e4bfbe6bac55010f58979c2f9fcf6fe4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-04 16:07:16 +00:00
Tony Wickham c8d8c58f5b Merge "Add debug logs for why taskbar might not be destroyed" into tm-qpr-dev 2023-04-04 15:40:28 +00:00
Tony Wickham df59884370 Add debug logs for why taskbar might not be destroyed
Test: Manually read log output
Flag: None
Bug: 254119092
Change-Id: Ibaa7ffdc91030c5c999ddc5f2807a55763854331
2023-04-03 23:20:57 +00:00
TreeHugger Robot 01ebdf81a7 Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev am: b32fd3a556
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22163528

Change-Id: Ib755f18a8f763120fdaa0fd5d39e9491f05f5705
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-03 21:00:44 +00:00
TreeHugger Robot b32fd3a556 Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev 2023-04-03 20:54:16 +00:00
Vinit Nayak 3e5b212204 Merge "Default to using SplitSelectSource drawable if TaskView icon drawable is null" into tm-qpr-dev am: 8e307ba50a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22347415

Change-Id: I9fe261fdaa96ab8d5a0792a3d69cb201beebdb9a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-03 15:22:57 +00:00
Vinit Nayak 8e307ba50a Merge "Default to using SplitSelectSource drawable if TaskView icon drawable is null" into tm-qpr-dev 2023-04-03 14:58:29 +00:00
Andy Wickham c5f8dff8e2 Merge "Don't move down all apps container when touching near scroll bar." into tm-qpr-dev am: 30c2bdda52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22342811

Change-Id: If0e164e719229827e57d2edb34582ab8fd7bc88f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-31 23:25:05 +00:00
Andy Wickham 30c2bdda52 Merge "Don't move down all apps container when touching near scroll bar." into tm-qpr-dev 2023-03-31 23:01:25 +00:00
Brian Isganitis 7d8b81df09 Merge "Clean up device profile change listeners for AllApps." into tm-qpr-dev am: 4500171c6b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22338655

Change-Id: I54c6fb31077ed06f6e0122dca3e47e3a7e6f8f34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-31 17:33:17 +00:00
Brian Isganitis 4500171c6b Merge "Clean up device profile change listeners for AllApps." into tm-qpr-dev 2023-03-31 16:42:07 +00:00
Vinit Nayak ecca8eacbc Default to using SplitSelectSource drawable if TaskView icon drawable is null
* Alternative solution could be to set
onTaskViewVisibilityChanged(true) for the taskView that is about
to be dismissed so it loads it's taskIcon/thumbnail back from the cache
* However, that does still leave us open to race conditions (even though
we can be reasonably confident the icon is probably in the cache)
* Also made other changes to allow already public fields on some classes
to be mockable for unit testing

Fixes: 275267738
Test: Tested with fullscreen task at end of overview,
GroupedTaskView at end of overview,
Initiating split from home,
Initiating split from overview actions,
Initiating split from overview app icon

Change-Id: Ic9059c93c07b90f61c9f418d5d36d6ba201ff96a
2023-03-30 15:26:57 -07:00
Andrew Cole 67f446827b Merge "Fixing an issue with the drop target font becoming very small for removing and uninstalling. I also verified that this doesnt break a fix presented in b/264732627" into tm-qpr-dev am: 6cb7469564
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22338450

Change-Id: I415ab087552478fe95d4055735300be1c77b01bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 16:47:29 +00:00
Schneider Victor-tulias d8e5795131 Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev am: 90259a6db4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22185922

Change-Id: I916c0e191cb2e335b9e393ea76c34cff39778481
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 16:47:04 +00:00
Andy Wickham 23f7d82831 Don't move down all apps container when touching near scroll bar.
Previously we were using any touch outside of the panel to move
the container, but we want to check this last, after checking if
the touch is near the scrollbar (in which case it should intercept
instead).

Test: Manual
Flag: N/A
Fix: 236661990
Change-Id: I518c546356d1f6c6cedf4b31fa621295dd090175
2023-03-29 22:04:11 +00:00
Brian Isganitis d43d7c3702 Clean up device profile change listeners for AllApps.
Test: https://b.corp.google.com/issues/260177372#comment1
Bug: 260177372
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d17261029af89ef03b860686d1d3c6651e7c8e13)
Merged-In: Ic7417980e8280bf2fcb110e5de74ea2ae59d9b74
Change-Id: Ic7417980e8280bf2fcb110e5de74ea2ae59d9b74
2023-03-29 18:46:47 +00:00
Andrew Cole 3ae7be6293 Fixing an issue with the drop target font becoming very small for removing and uninstalling. I also verified that this doesnt break a fix presented in b/264732627
Fix: 274402490
Test: Manual
Change-Id: Id61cf7e33f83e0cb25c82b5e7b167b04657fd612
2023-03-29 17:21:34 +00:00
Schneider Victor-tulias 90259a6db4 Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev 2023-03-29 17:03:59 +00:00
Sunny Goyal 6589b4020b Merge "Updating PinShortcutRequestActivityInfo to provide pinRequest lazily" into tm-qpr-dev am: e1471d3acd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22318893

Change-Id: I38621d4470db873fd0b3b1b1b38047018cbcdec2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-29 06:04:26 +00:00
Sunny Goyal 13a6b228a5 Updating PinShortcutRequestActivityInfo to provide pinRequest lazily
Bug: 275407282
Test: Verified on device
Change-Id: I81867ada454219b44663b58b942329422fb81196
2023-03-28 13:28:34 -07:00
Jon Miranda 705d193aa4 Merge "Fix transient taskbar icon size in two panel portrait DeviceProfile" into tm-qpr-dev am: e7ab5849d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22302207

Change-Id: I43bdf6b1a4391c3e0a7313ae014c86cce253d3cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28 16:23:04 +00:00
Jon Miranda e7ab5849d7 Merge "Fix transient taskbar icon size in two panel portrait DeviceProfile" into tm-qpr-dev 2023-03-28 15:56:49 +00:00
Jon Miranda 4d74ad3c31 Fix transient taskbar icon size in two panel portrait DeviceProfile
Fixes: 275269031
Test: use two panel device
      verify taskbar icon size in portrait
      verify taskbar icon size in landscape
      rotate between the two orientation
Change-Id: I21ae4aee90c3aa54615d8d0881acb40d8b4f351f
2023-03-28 15:55:36 +00:00
Hyunyoung Song a9934f00d3 Merge "Fix lint error in errorprone target (only in tm-qpr-dev)" into tm-qpr-dev am: ec6c2591c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22293181

Change-Id: I57167b224875742ac7f31069e18ebb02460b54b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 23:12:58 +00:00
Hyunyoung Song ec6c2591c5 Merge "Fix lint error in errorprone target (only in tm-qpr-dev)" into tm-qpr-dev 2023-03-27 23:02:38 +00:00
Sebastián Franco 35252fd9f2 Merge "Changing global variable for local variable to prevent memory leaks" into tm-qpr-dev am: 9c83077712
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22293180

Change-Id: Ibba08154760e08134e3d649ad39ef016f1206abb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 22:58:09 +00:00
Sebastián Franco 9c83077712 Merge "Changing global variable for local variable to prevent memory leaks" into tm-qpr-dev 2023-03-27 22:23:26 +00:00
Schneider Victor-tulias 34eb098745 Add debug logs to debug flaky workspace binding
Flag: not needed
Bug: 270216650
Test: ReorderWidgets
Change-Id: Ia5caeb6b0e5ed1b0b406fab9c18e2e6799a4f68a
2023-03-27 14:40:36 -07:00
Schneider Victor-tulias 7cd0ae3f73 Fix TwoPanelWorkspaceTests
- Marking the hotseat long press edu as seen on setup to allow the popup menu to be shown immediately in tests
- Recording onWorkspaceItemLongClick on prediction item long click

Flag: not needed
Fixes: 273239675
Test: TwoPanelWorkspaceTest
Change-Id: I76354fd2e3adde11b2a428374fa9c8855ce2ece9
2023-03-27 14:24:35 -07:00
Hyunyoung Song fa9dbe3291 Fix lint error in errorprone target (only in tm-qpr-dev)
Bug: 275111546
Test: m out/soong/.intermediates/packages/apps/Launcher3/Launcher3/android_common/lint/lint-baseline.xml
Before: https://paste.googleplex.com/6542806926491648
After: https://paste.googleplex.com/5015617085112320

Change-Id: If486407303b81a38b4a35979e442299f33fa49b2
2023-03-27 18:38:35 +00:00
Sebastian Franco 7cdc616a01 Changing global variable for local variable to prevent memory leaks
The array mTmpObjArray is not properly clean but ther is no need
for the array to be global since every time is used is provided
so a use of a local variable will make sure is never leaked.

Fix: 269163620
Test: the flake related to memory leak on testWorkspace should dissapear
Change-Id: I29fb3dd6419f621f2ccce9db2fc5ed86358f7516
2023-03-27 11:18:14 -07:00
Hyunyoung Song 739dcca38a Merge "Icon should not disappear on drag and drop" into tm-qpr-dev am: 7eae6a4ce1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22255567

Change-Id: Ied5d3740325666cc74f407fd0c9d8821bfa8be8e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-26 07:57:20 +00:00
Hyunyoung Song 7eae6a4ce1 Merge "Icon should not disappear on drag and drop" into tm-qpr-dev 2023-03-26 07:22:55 +00:00
hyunyoungs 825480fbcc Icon should not disappear on drag and drop
Bug: 275009677
Test: BubbleTextViewTest

Change-Id: Iddff7a0130c9a0ddb76223064338459dbe9b52e8
2023-03-24 15:16:20 -07:00
Jon Miranda 3cd39729dc Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev am: 085c53869f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22228076

Change-Id: I687ea2a249e73036f8d4c4d187d999fd224b9f02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 22:02:13 +00:00
Hyunyoung Song bb1237eb76 Merge "Revert "Revert "Hide the splash icon when launching with no view..."" into tm-qpr-dev am: e8abfee5e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22067827

Change-Id: I1d5e7b401cfb874a0f801cfc0b5b76b53a608c64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 22:00:27 +00:00
Jon Miranda 085c53869f Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev 2023-03-24 21:51:42 +00:00
Hyunyoung Song e8abfee5e9 Merge "Revert "Revert "Hide the splash icon when launching with no view..."" into tm-qpr-dev 2023-03-24 21:41:04 +00:00
Jon Miranda 9c478b6c29 Add taskbarIconSize to GridOption/DisplayOptions
- Renamed variables to make it more clear what they represent
- DeviceProfile will be source of truth for taskbar
  sizes

Bug: 265144213
Test: phone, multi-display, tablet
Change-Id: Id9c19d15a65894fd7645e0f876a4b6527b713c34
Flag: ENABLE_TRANSIENT_TASKBAR=true
2023-03-24 12:29:11 -07:00
Vinit Nayak cbc884e191 Merge "Log receiving broadcast for managed user unlocked" into tm-qpr-dev am: 4ed9562b37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22238827

Change-Id: I9517d17659a5e650d91037f9f687b81ca5f193d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 18:55:40 +00:00
Vinit Nayak 4ed9562b37 Merge "Log receiving broadcast for managed user unlocked" into tm-qpr-dev 2023-03-24 18:25:51 +00:00
George Lin 67f8285b34 Merge "[Launcher] Hide preview bottom components when overlay tabs are shown" into tm-qpr-dev am: 80233ed0c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22210243

Change-Id: I5a731d86b624bd0f9da1e5911879d26737cbf400
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 01:25:20 +00:00
George Lin 80233ed0c7 Merge "[Launcher] Hide preview bottom components when overlay tabs are shown" into tm-qpr-dev 2023-03-24 01:01:50 +00:00
Vinit Nayak d3925b662d Log receiving broadcast for managed user unlocked
Bug: 243688989
Change-Id: I6f1b575a90e51ad1674154f60199ffef5004a224
2023-03-23 15:38:19 -07:00
Charlie Anderson a106266c06 Merge "reorder System shortcuts for taskbar and secondary display" into tm-qpr-dev am: bc65c3d442
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22225432

Change-Id: Ic742a73372f90ac630af30af51d5313ede0283f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 21:17:39 +00:00
Charlie Anderson bc65c3d442 Merge "reorder System shortcuts for taskbar and secondary display" into tm-qpr-dev 2023-03-23 20:39:06 +00:00
Tony Wickham 0324f024b0 Merge "Handle swipe down on taskbar to stash" into tm-qpr-dev am: 2b8b47952f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22147222

Change-Id: I6d774a769e11294efd0b0bd39429807528176b18
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 19:47:22 +00:00
Tony Wickham 2b8b47952f Merge "Handle swipe down on taskbar to stash" into tm-qpr-dev 2023-03-23 18:54:09 +00:00
George Lin f469c4c006 [Launcher] Hide preview bottom components when overlay tabs are shown
For deciding show/hide of the bottom components, we need to take care of 2 cases
1. When on color update, we need to set the QSB flag and re-render the
   surface
2. When show/hide the wallpaper control, we specifically send a message
   to show/hide the workspace bottom components

Test: https://drive.google.com/file/d/1z1EG6KsLKFxAlS8GBLV16GoGvwI72IHc/view?usp=sharing&resourcekey=0-OGzB0RmiK5qvV2rwMYvUHQ
Test: https://drive.google.com/file/d/1gK54Y5MuHTt2tAuFDxY7z8RIL22J5c9f/view?usp=sharing&resourcekey=0-jPPC1pl1VkCS_tib2-pVxA
Test: https://drive.google.com/file/d/1ntUSgD7KbHPDGNpomQ5zE0D2fsYVeuNA/view?usp=sharing&resourcekey=0-TCuuvL4p022ATzKYuF-Q1A
Test: https://drive.google.com/file/d/1yA1K52N-orajamnrxWD17Qg7bCclmq53/view?usp=sharing&resourcekey=0-6LHnZGM5JpFQISNJ6X7jEg
Bug: 266618769
Change-Id: I428e6f50dc71369aa8fcdee31629023709e6503f
2023-03-23 18:36:18 +00:00
Jon Miranda 0f43611645 Merge "Fix spring not springing when unstashing." into tm-qpr-dev am: cbe578b269
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22202345

Change-Id: I25e8204b0e93dd986a88329d53fef8e0507b7832
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 18:18:42 +00:00