Commit Graph

12973 Commits

Author SHA1 Message Date
Liran Binyamin 3931b671b4 Reset the bubble bar scale when the animation is interrupted
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 381283214
Test: atest BubbleBarViewAnimatorTest
Test: manual
       - have a bubble in the bubble bar
       - launch an app
       - set animator scale to 5x to slow down animation
       - send a bubble
       - when the bubble bar animates interrupt the animation by
         touching the bubble bar
       - observe the bubble bar scale is reset correctly
Change-Id: I1abd81e3df987ba749a13eb1b7506d5c1d8fdddd
2024-12-02 11:23:35 -05:00
Liran Binyamin 495fe1d255 Merge "Animate the bubble bar on dismiss" into main 2024-12-02 14:28:30 +00:00
Andy Wickham 3be4c7d458 Merge "Cleanup the null checks added in ag/30408877" into main 2024-12-01 06:00:19 +00:00
Treehugger Robot 16740cd22a Merge "Make TaskView not clickable when in select mode for switch access and touchscreen usage." into main 2024-11-29 21:13:31 +00:00
Uwais Ashraf a8f01bac1d Make TaskView not clickable when in select mode for switch access and touchscreen usage.
Fix: 320228423
Flag: EXEMPT BUG_FIX
Test: Manual - steps from bug
Change-Id: Ib831ab52ce3cc3a19e73f6b255cab519074c24b6
2024-11-29 16:38:14 +00:00
Johannes Gallmann cc6e7f09c9 Merge "Fix ConcurrentModificationException in TouchInteractionService" into main 2024-11-29 13:13:39 +00:00
Johannes Gallmann 108dc037a0 Fix ConcurrentModificationException in TouchInteractionService
Bug: 381018493
Test: Manual, i.e. verified that unregistering listener during set iteration works
Flag: EXEMPT bugfix
Change-Id: Ia4600797ce579b80621b32977fcd9712d4fc26bb
2024-11-29 11:15:40 +00:00
Treehugger Robot b1629b250d Merge "Add missing overview state event to tests" into main 2024-11-28 22:38:13 +00:00
Treehugger Robot 9ba4899872 Merge "Wait until AllSetActivity.onResume to start the background animation" into main 2024-11-28 16:42:01 +00:00
Gustav Sennton 68648283a8 Use bugfix flags for desktop mode transitions (exit, applaunch, alttab)
The transitions changes are bug fixes / polish, so use bugfix flags
for these changes.
An existing non-bugfix flag cannot be changed into a bugfix flag, so
instead we create new flags with the bugfix type.

Bug: 380224768
Bug: 380225486
Bug: 380224832
Test: manual - disable main flags, use bugfix flags
Flag: com.android.window.flags.enable_desktop_windowing_enter_transition_bugfix
Change-Id: I1c9ea635a362db741f4a632e6360aee87c12750e
2024-11-28 12:32:34 +00:00
Mykola Podolian 6baca730ff Merge "Only adjust the hotseat if bubble bar is visible." into main 2024-11-28 04:09:00 +00:00
mpodolian 24521dd6f8 Only adjust the hotseat if bubble bar is visible.
The change avoids setting up the hotseat if there is no bubble bar.

Fixes: 379809704
Test: EXEMPT bugfix
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I26820e3a13a4eaceb0897e44852c0d70aa71918b
2024-11-27 17:12:25 -08:00
Andy Wickham cdcfaa80b2 Cleanup the null checks added in ag/30408877
These checks should be safe, but could be hiding other issues.
They were originally added as a workaround for presubmit failures
only on mokey_go32 (32 bit Android Go).

Bug: NA
Flag: EXEMPT cleanup
Test: Manual and existing presubmit tests
Change-Id: Ifcd136f61c885dba316e492a2408b67b42dcffcf
2024-11-27 15:36:37 -08:00
Andy Wickham 28d920ef05 Merge changes from topic "rm-lph-flag" into main
* changes:
  Make ContextualSearchInvoker not a ResourceBasedOverride.
  End live tile when invoking Circle to Search over Overview.
2024-11-27 23:32:29 +00:00
Liran Binyamin 7e387fa505 Animate the bubble bar on dismiss
When the last remaining bubble is dismissed by drag or from the menu
we now fade out the bubble bar.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 347062801
Test: manual
       - create a single bubble in the bar
       - expand
       - dismiss by drag or from menu
       - observe animation
Change-Id: I86fcaf04c6f5949126744b81e0042b0e58318a13
2024-11-27 16:23:26 -05:00
Andy Wickham 2ae01adf71 Make ContextualSearchInvoker not a ResourceBasedOverride.
This was previously only used to honor the INVOKE_OMNI_LPH flag
which has been enabled for a long time. So this is part of that
cleanup.

Bug: 297561673
Test: Manual
Flag: EXEMPT deleting legacy flag
Change-Id: Ife9f14faa2099f579f631da2aadaa6a56cbba51d
2024-11-27 13:03:18 -08:00
Andy Wickham 03a96eb8f7 End live tile when invoking Circle to Search over Overview.
This fixes many animation/state issues related to switching tasks
from the live tile to AGA.

Demo before: https://drive.google.com/file/d/1aBsn_-4tRHRsfGSqsx44_1B7dgdPOq_v/view?usp=drive_link&resourcekey=0-EHyEiKRVEC2ooUo-0rcjHg
Demo after: https://drive.google.com/file/d/1Sf5cUh8hC-slUZc_efOChzxxw710pG65/view?usp=drive_link&resourcekey=0-Wr33tL3ytedMibcVNd6auw

Bug: 372592549
Bug: 297831970
Test: Manual, updated ContextualSearchInvokerTest.
Flag: EXEMPT bugfix
Change-Id: I538cb1de61e48de4cf7c6fca8710a655933d07a3
2024-11-27 13:03:08 -08:00
Mykola Podolian 400fc4ad98 Merge changes I239f9357,I57a32ac5 into main
* changes:
  Update setting taskbar window height
  Set bubble bar aligned to QSB
2024-11-27 20:44:53 +00:00
Uwais Ashraf bfede7eb48 Merge "Exclude cleanup methods from CUJ for entering split select." into main 2024-11-27 20:28:40 +00:00
Treehugger Robot d7b3369036 Merge "Ignore events that occur between app icons on the taskbar" into main 2024-11-27 20:22:17 +00:00
Liran Binyamin ed249f0451 Merge "Show the bubble bar edu view" into main 2024-11-27 20:09:07 +00:00
mpodolian 3111daf2f1 Update setting taskbar window height
Updated the logic to set the taskbar window height to accommodate the
bubble bar with its maximum flyout height before the bubble bar
animation begins. The height is reverted to the default value once the
animation is completed.

Fixes: 378400160
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Set 3-button navigation mode and have the QSB placed
above the hotseat. Send a notification that will display a bubble, and
observe the bubble bar animation and final placement aligned with the
QSB.
Next, set gesture navigation mode and repeat the flow above. Observe
that the bubble bar is aligned with the hotseat icons.
Felix video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/gYMVt0sH4si0KOpaBxIPem
Tangor video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/fz95MbjcjW3awStnuOl8BJ

Change-Id: I239f935743c3936fed44822c3c62652073ffefe2
2024-11-27 10:19:24 -08:00
mpodolian 28907bcbd6 Set bubble bar aligned to QSB
Change logic to updated bubble bar alignment with the QSB vertical
center for 3 buttons navigation mode.

Fixes: 378400160
Flag: com.android.wm.shell.enable_bubble_bar
Test: PersistentBubbleStashControllerTest
Test: TransientBubbleStashControllerTest
Test: Manual. Set the buttons navigation mode and observe that the
bubble bar is centered with the QSB when the QSB is not aligned with the
hotseat. Then, switch to gestures navigation mode and observe that the
bubble bar is centered with the hotseat when the QSB is not aligned with
the hotseat.

Change-Id: I57a32ac5bde7a7055b54a89727429424e5c0ca4f
2024-11-27 10:15:08 -08:00
Artsiom Mitrokhin 75974d8361 Merge "Prevent spawning multiple pinning popups on right click" into main 2024-11-27 15:49:19 +00:00
Schneider Victor-Tulias c062d5aa43 Add missing overview state event to tests
This missing event was causing FallbackRecentsTest to fail when using the recents window

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 380440464
Test: FallbackRecentsTest
Change-Id: I13a69e58811a14ffa88187acd42a1a12016d081d
2024-11-27 15:28:39 +00:00
Schneider Victor-Tulias 0a1dbd4dc7 Wait until AllSetActivity.onResume to start the background animation
The background animation was originally getting started through AllsetActivity.onCreate, which is a lot of work to put on the main thread during the launch animation. The animation will now instead start onResume through AllSetActivity.maybeResumeOrPauseBackgroundAnimation

Flag: EXEMPT bug fix
Fixes: 380392303
Test: started AllSetActivity locally and checked that the animation still starts
Change-Id: I201428dd9e7b754e9ab3199432d0754f2529e6c9
2024-11-27 15:28:24 +00:00
Marcelo Arteiro 8b63ee3420 Merge "Migrate materialColor* attributes into colors" into main 2024-11-27 14:55:47 +00:00
Vinay Joglekar 0bb2421c94 Merge "Fix animation while hiding Desktop tasks during split" into main 2024-11-27 13:33:59 +00:00
Treehugger Robot 02038f4deb Merge "Log various TaskView properties in TaksContainer.itemInfo" into main 2024-11-27 12:59:31 +00:00
vinayjoglekar f567e7e2fa Fix animation while hiding Desktop tasks during split
1. Scale down desktop tasks
2. Change translation start when all desktop tasks need to hidden

Fix: 378447894
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: Manual: Add desktop window and split focussed task, desktop task(s)(also in RTL)
Change-Id: I25c11d654539efc6529a2e995d8d00cbf73c870d
2024-11-27 11:34:22 +00:00
Alex Chau 09f2433253 Log various TaskView properties in TaksContainer.itemInfo
- Extracted itemInfo creation in to TaskViewItemInfo and added a test
- Created a standalone atom for TaskView, logging data we want (please refer to the bug)
- Convert TaskView atom to StatsLog data in StatsLogCompatManager
- Simplified DesktopSystemShortcutTest and ExternalDisplaySystemShortcutTest to avoid extra testing on DesktopModeStatus

Fix: 341320349
Test: TaskViewItemInfoTest, DesktopSystemShortcutTest, ExternalDisplaySystemShortcutTest
Flag: EXEMPT logging
Change-Id: Icf04ff2b1670c3f3d5f6a66f99c0d28314efaf21
2024-11-27 10:41:43 +00:00
Uwais Ashraf 02f7a1a96d Exclude cleanup methods from CUJ for entering split select.
Fix: 378007383
Flag: EXEMPT BUG_FIX
Test: ABTD run - https://android-build.corp.google.com/builds/abtd/run/L73400030008027437
Change-Id: Ied6897a8a84b4411517ac4fd9904e00eeb86d3ad
2024-11-27 10:05:48 +00:00
Treehugger Robot a8f25d26ad Merge "[Launcher Memory Leak] Avoid leaking Folder/FolderIcon when removing FolderIcon from TaskbarView" into main 2024-11-26 20:37:21 +00:00
Uwais Ashraf 322b831d1d Merge "Make RV focusable when empty to read out content desc for TalkBack." into main 2024-11-26 15:25:25 +00:00
Liran Binyamin 16a604fe0c Show the bubble bar edu view
We now show the bubble bar edu view after a request from shell
to show it was received, and as soon as the user performs a touch
gesture on the bubble bar or flyout that causes the bar to be
expanded.

The click listener on the bubble bar is removed with this change
because the input consumer already handles taps. Removing the
listener avoids processing the tap twice which causes the edu view
to not be displayed. Removing the click listener solves the issue
but ideally we should move the edu view to launcher since that
would allow us to manage its state easily.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 374842575
Test: atest PersistentBubbleStashControllerTest
Test: atest BubbleBarSwipeControllerTest
Test: atest TransientBubbleStashControllerTest
Test: manual
       - force show the bar edu view
       - send a bubble
       - tap the bubble bar to expand
       - observe bubble bar edu is visible
       - repeat with swiping on the bar and tapping the flyout
       - launch an app
       - swipe up to show the taskbar
       - observe edu view not visible
       - send a bubble with auto expand
       - observe bubble bar expanded and edu view not visible
Change-Id: I98ec44e6edf6c69d6d47b5709140796c2ecab23e
2024-11-26 10:23:45 -05:00
Uwais Ashraf 6c85912736 Make RV focusable when empty to read out content desc for TalkBack.
Fix: 379638096
Flag: EXEMPT BUG_FIX
Test: Manual - go to overview with and without tasks. Check TalkBack.
Change-Id: I1f3faace530ed3c9b0384b94dbc163f5b8c15dda
2024-11-26 11:42:42 +00:00
Chaitanya Cheemala (xWF) 1743fd9e77 Merge "Revert "Use the Coreographer's frame time for a more reliable ti..."" into main 2024-11-26 11:37:15 +00:00
Chaitanya Cheemala (xWF) 9155cf9066 Revert "Use the Coreographer's frame time for a more reliable ti..."
Revert submission 30509816-raf-timing

Reason for revert: Likely culprit for b/381006945  - verified through ABTD before revert submission as part of standard investigation process.

Reverted changes: /q/submissionid:30509816-raf-timing

Change-Id: Iaed968120be662df8d915bac61e7cfa5b936f35c
2024-11-26 11:35:00 +00:00
Alex Chau 1d720793fa Merge "Add TaskOverlay children for accessibility" into main 2024-11-26 10:49:34 +00:00
Treehugger Robot cff3ade324 Merge "Remove padding from All Apps and Divider views for transient taskbar." into main 2024-11-26 04:02:56 +00:00
Treehugger Robot f612dc1a5b Merge "Fix taskbar visibility when default-to-desktop" into main 2024-11-25 23:18:43 +00:00
Fengjiang Li 3daaad8498 [Launcher Memory Leak] Avoid leaking Folder/FolderIcon when removing FolderIcon from TaskbarView
Fix: 380868830
Flag: NONE - released code
Test: Presubmit
Change-Id: I57c179384df06015a7e95a173c399cfcda236e46
2024-11-25 11:30:53 -08:00
Alex Chau 0aee46e098 Add TaskOverlay children for accessibility
- ag/28947579 add a speicifc order for children of TaskView to be added for accessibility. All TaskView children will need to added through TaskContainer.addChildForAccessibility

Fix: 379802031
Fix: 380016834
Fix: 204280593
Test: Go to Select mode, ensures Talkback can cycle through text selection boxes
Flag: EXEMPT BUG_FIX
Change-Id: Id7991a8b3e76fe47f562e338e9967c8e85fa4908
2024-11-25 19:04:46 +00:00
Saumya Prakash 43ecc1d0a1 Merge "Fix Taskbar not auto stashing from multi instance menu" into main 2024-11-25 18:34:35 +00:00
Jon Miranda f86e0e4b88 Remove padding from All Apps and Divider views for transient taskbar.
(Initial CL removed padding always) I0f9cce376d47918e69a65ed288f10143930ee3be

Bug: 375661139
Test: confirmed with design team
Flag: EXEMPT bugfix
Change-Id: I467d0a5ae3ab48ebebc5a05f7a0902ddd01f8084
2024-11-25 18:16:26 +00:00
Schneider Victor-tulias 54e50f43a6 Merge "Start the home intent when swiping from home to home" into main 2024-11-25 17:53:27 +00:00
Luca Zuccarini fb2525a850 Merge "Use the Coreographer's frame time for a more reliable timestamp." into main 2024-11-25 16:19:35 +00:00
Schneider Victor-Tulias ccd08f4667 Start the home intent when swiping from home to home
This allows us to clean up the home screen properly (close all apps and floating views)

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 380049465
Fixes: 380049942
Test: TAPL tests
Test: swipe home from home all apps, with and without an open popup menu, with and without a 3P launcher
Change-Id: I3c3c8e832329afc3ffaa1de7cf646be79d84e9a3
2024-11-25 10:56:54 -05:00
Artsiom Mitrokhin 86bf6ae902 Prevent spawning multiple pinning popups on right click
The dismiss logic only checks for `ACTION_DOWN` events, but when the
user frequently right-clicks OR right-press-move-release, we get
multiple `ACTION_MOVE` events instead, which are ignored by the dismiss
logic of the previous popup instance.

Attached screen recordings to the bug.

Bug: 362475367
Flag: EXEMPT bugfix
Test: manual
Change-Id: I665c3127e4b449a8f4c71e443cc6ae07c1bf2794
2024-11-25 10:52:36 -05:00
Johannes Gallmann 0b0452eda9 Merge "Cancel predictive back when sliding off back button" into main 2024-11-25 08:17:56 +00:00