Commit Graph

1827 Commits

Author SHA1 Message Date
Andy Wickham 373de559c2 Update Launcher3 TAPL "find app icon" logic to allow whitespace.
Previously this used the content description which was generally the
same as the displayed text with whitespace adjustments + additional
text (e.g. "Play Store has 7 notifications").

That worked fine, but I thought it would be a bit more robust to work
with the text directly. Specifically, we consider it a match if all
of the non-whitespace characters are there, along with optional added
whitespace between characters. See TaplUtilityTests for examples.

More importantly for the other change in this topic, this Pattern is
also used for search result icons, to allow those tests to pass with
multiline labels enabled.

Bug: 315053839
Flag: LEGACY ENABLE_TWOLINE_DEVICESEARCH ENABLED
Test: Manual and TaplTestsTaskbarSearch + other unit tests

Change-Id: I4ad52840d743f06576d415f4e5ea6d8870e5dd2c
2023-12-20 19:57:11 -06:00
Jagrut Desai d89b61a487 Merge "Adding Support for Tapl Workspace Tests into PlatformScenario" into main 2023-12-20 19:11:36 +00:00
Federico Baron 1abb9a47b4 Merge "Align QSB with hotseat and workspace icons" into main 2023-12-20 17:36:12 +00:00
Priyanka Advani 1a0c6844eb Merge "Revert "Re-promoting some tests to postsubmit"" into main 2023-12-20 01:32:13 +00:00
Priyanka Advani 4c222bfb3c Revert "Re-promoting some tests to postsubmit"
This reverts commit 82a67a1a2d.

Reason for revert:b/317133692

Change-Id: Ibd66d2a113611380876c274d1c6203a7ab777a53
2023-12-20 00:33:25 +00:00
Jagrut Desai 295027d0d1 Adding Support for Tapl Workspace Tests into PlatformScenario
Test: Presubmit, manual
Bug: 303258153
Flag: NONE
Change-Id: Ic7d2cd3dc24bbe4b252ef490c1e6d3cf0e3e217a
2023-12-19 15:37:07 -08:00
Vadim Tryshev 57b240ca02 Merge "Re-promoting some tests to postsubmit" into main 2023-12-19 22:20:50 +00:00
Uwais Ashraf dbf585db73 Merge "Rename Tapl tests that do not match *Test.(kt|java) for easier groups" into main 2023-12-19 22:14:25 +00:00
fbaron e69b6f49f7 Align QSB with hotseat and workspace icons
The QSB was a bit wider becuase icons visible size is a bit smaller than their actual size due to b/235886078 so we add a workaround to adjust QSB size based on the visible icon size

Bug: 281587788
Test: atest HomeScreenImageTest
Flag: NONE
Change-Id: I593ca2d588f08b830be0b2ac389c747b6f558b91
2023-12-19 13:52:45 -08:00
Vadim Tryshev 82a67a1a2d Re-promoting some tests to postsubmit
Will watch their stability; may further promote to presubmit

Bug: 187761685
Test: presubmit, abtd
Flag: N/A
Change-Id: Idf3949b1f04b0ff761ef1216fa41e9e8d11e8cdd
2023-12-19 12:51:14 -08:00
Uwais Ashraf e0a4feb664 Rename Tapl tests that do not match *Test.(kt|java) for easier groups
Test: presubmits passing
Bug: 316551909
Flag: NA
Change-Id: Ib2070d7610927777376acf0ddefcbc90e582e6f6
2023-12-19 11:54:10 +00:00
Jagrut Desai 10473c5950 Merge "Refactoring testDragIcon() test" into main 2023-12-18 22:01:22 +00:00
Vadim Tryshev 4f6602839e Adding a rule so that @Stability annotation works presubmit
Bug: 316588649
Test: presubmit
Flag: N/A
Change-Id: Ic82db1c30c97f2653f8c30fc322a248b2b409695
2023-12-18 10:17:14 -08:00
Vadim Tryshev e281a5fb7e Merge "Disabling a failing test from presubmit" into main 2023-12-18 03:02:43 +00:00
Federico Baron ff2eec89ea Merge "Stop interrupt to see if it fixes failing tests" into main 2023-12-15 21:26:54 +00:00
fbaron e392955e37 Stop interrupt to see if it fixes failing tests
Bug: 316394228
Test: atest WidgetsListContentEntryTest
Flag: NONE
Change-Id: Iaabbcb0c00040f78ad4d6355fef9bc91f4b66ed7
2023-12-15 11:30:58 -08:00
Winson Chung de778ab5b8 Merge "Workaround for handling single device specific state in dump tests" into main 2023-12-15 19:22:00 +00:00
Vadim Tryshev 971358567d Disabling a failing test from presubmit
Bug: 316588649
Test: presubmit
Flag: N/A
Change-Id: I98487a4786fdab7f0ee5b10d59fc8df0e621b4f0
2023-12-15 10:33:09 -08:00
Vadim Tryshev ae625f3d6a Merge "Converting more pressBack calls to calls that wait for animation" into main 2023-12-15 18:07:20 +00:00
Winson Chung 734c6f3974 Workaround for handling single device specific state in dump tests
- There's a DeviceProfile state that is dynamic on a specific device
  class (based on a fw resource), this causes problems with the dump
  tests which compare the device profile against static prior dumps.
  For now, we can just update the expected dump based on the state
  of the resource to ensure that the current device profile state on
  this device matches.  To do this, we also need to consolidate the
  various duplicate methods to assert the current and golden dumps
  match to have a common place to adjust the expected dump.

Bug: 315230497
Test: atest DeviceProfileDumpTest
Test: atest DeviceProfileAlternativeDisplaysDumpTest
Change-Id: I5130d330878757702af07e166a669cc76452b271
2023-12-15 05:10:04 +00:00
Jagrut Desai 9e9799b28c Refactoring testDragIcon() test
- refactoring getWidget method to add support for different app packages.
 - removing platinum test annotation since adding test on platform scenario test.

Test: Presubmit, Local
Bug: 303258153
Flag: NONE
Change-Id: Ifd5e50cfe8019984ba25312f52266e8b1774318e
2023-12-14 15:41:55 -08:00
Fengjiang Li e228112c33 Merge "Cancel all apps icons preinflation when device profile has changed" into main 2023-12-14 18:16:30 +00:00
Fengjiang Li 939ca48bae Cancel all apps icons preinflation when device profile has changed
Bug: 312816372
Test: perinflate large number of App Icons then rotate screen. Verified 1) preinflation runnable is cancelled and 2) no ViewHolder created from this cancelled runnable is added to RecyclerViewPool
Flag: LEGACY ENABLE_ALL_APPS_RV_PREINFLATION ENABLED
Change-Id: I1a6110278e1af2b32387ab27273106d30513886f
2023-12-13 15:31:30 -08:00
Vadim Tryshev fb3ae6a6c4 Converting more pressBack calls to calls that wait for animation
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ib4e08b4778a24ac617ea1e0101147612b0f53967
2023-12-13 13:07:46 -08:00
Vadim Tryshev 8fa129e9a8 Merge "Disabling the failing piece of a test in presubmit" into main 2023-12-13 19:53:10 +00:00
Vadim Tryshev 122e5b9389 Disabling the failing piece of a test in presubmit
Bug: 315847371
Test: presubmit
Flag: N/A
Change-Id: I9cf9818946de8b53edc8c44cbd9e673f3bea832f
2023-12-13 10:33:20 -08:00
Vadim Tryshev fd309ca3d0 Merge "Inserting waiting for settling in the Workspace state after "back" from All Apps" into main 2023-12-13 00:27:08 +00:00
Vadim Tryshev d48279bf1d Merge "Disabling ViewCaptureRule" into main 2023-12-12 23:10:57 +00:00
Vadim Tryshev 9c1df6db6b Inserting waiting for settling in the Workspace state after "back" from All Apps
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Idd6e3383be21c2040797148817b96105a6f94fe3
2023-12-12 14:03:45 -08:00
Sebastián Franco c715781453 Merge "Removing debbug comments" into main 2023-12-11 20:37:38 +00:00
Vadim Tryshev 5e9e07e0dc Merge "Enabling wallpaper animation wait in presubmit widget tests" into main 2023-12-11 20:10:51 +00:00
Vadim Tryshev 5915443a33 Merge "Disabling leak checks in presubmits" into main 2023-12-11 19:50:20 +00:00
Vadim Tryshev 8c3dbdf22a Enabling wallpaper animation wait in presubmit widget tests
This check is stable now

Bug: 313926097
Flag: N/A
Test: presubmit, postsubmit runs
Change-Id: Id6bbe5f8ca3aaae3ef025732b4d429d109b567ce
2023-12-11 10:31:20 -08:00
Vadim Tryshev 79e12b893d Disabling leak checks in presubmits
They block 36% of presubmit runs

Bug: 313501215
Test: presubmit
Flag: N/A
Change-Id: Id91e5a467dfe2485614a4ac99861670a1afaa533
2023-12-11 10:16:13 -08:00
Vadim Tryshev 04e044565d Merge "Disable alpha jump detector" into main 2023-12-11 18:07:03 +00:00
Sebastian Franco 9658523297 Removing debbug comments
Bug: 303263644
Flag: NA
Test: TaplWidgetPickerTest
Change-Id: I6ad428100b2455110315755cea4b75f46b7217c0
2023-12-11 10:01:16 -06:00
Thales Lima df643c4540 Merge changes from topic "numFolderRows" into main
* changes:
  Update dump tests
  Make numFolderRows/Columns accept more values
2023-12-11 10:54:04 +00:00
Thales Lima 1faa4edc42 Make numFolderRows/Columns accept more values
InvariantDeviceProfile hold values that are not related to current DP in use. Now other classes get the value correctly from DeviceProfile, and each posture can hold different values, making it akin to iconSize.

Fix: 309800141
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I32295738585de67205dcd6c8942d08a3d07d169a
2023-12-08 22:00:48 +00:00
Vadim Tryshev 5eac9a5d81 Waiting for wallpaper animation in widget tests only for Nexus Launcher and in postsubmit
This code flakes in postsubmit and presubmit, but the failure is
not reproducible in local and abtd runs. Landing the change to make postsubmit
flake; then I'll use tricks like tracing to debug the cause.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I77c324d43a2400fe1015f5cd0a4729e34552687c
2023-12-08 12:06:45 -08:00
Vadim Tryshev 229a181771 Disabling ViewCaptureRule
Looks like vire capture needs some time to stabilize; for now,
 it sometimes generates empty view capture data.

Bug: 315482167
Flag: N/A
Test: presubmit
Change-Id: I864ffacf4a3a28cfc01b300ac1df71890f93c5e1
2023-12-08 10:44:48 -08:00
Sebastián Franco 4d548b5992 Merge "Make all tapl test start with Tapl" into main 2023-12-08 15:43:47 +00:00
Thales Lima 65cc1ff5a4 Merge "Adding test for folder preview loading" into main 2023-12-08 10:15:51 +00:00
Sebastian Franco 957e4e513e Make all tapl test start with Tapl
Flag: NA
Bug: 298234173
Test: only test name change
Change-Id: Ib2e67a569599568cf1e681a7f1ac44924da83b84
2023-12-07 22:27:53 +00:00
Sunny Goyal 522dfa139a Adding test for folder preview loading
Bug: 315352494
Test: atest FolderIconLoadTest
Flag: N/A
Change-Id: Idcef30427b8ea637eb98b1a7a0d2eda09abd0837
2023-12-07 12:11:38 -08:00
William Leshner 5836cec7ec Merge "Show Launcher's widget picker in an activity." into main 2023-12-07 19:23:58 +00:00
Vadim Tryshev d987586323 Disable alpha jump detector
The detector flakes, and I have no bandwidth now to take care of it.

Bug: 309014345
Test: presubmit
Flag: N/A
Change-Id: I97b02736354274a97ed0eb4eb71773a5c858cae4
2023-12-06 18:57:33 -08:00
Vadim Tryshev 286581ebf2 Partially reverting waiting for animation when setting widget result
It flakes, i.e. sometimes the animation is not detected.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I829e4124879c3a3abe78762a8d04fcd0494f5b1a
2023-12-06 18:15:52 -08:00
Vadim Tryshev c0fc0d2b0b Waiting for wallpaper animation in widget tests only for Nexus Launcher
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I6235b2ffc66db9f32ce998523cad74bb239588d0
2023-12-06 10:21:50 -08:00
Vadim Tryshev 42476cc355 Merge "Waiting for wallpaper animation completion when configuring new widget" into main 2023-12-06 01:43:07 +00:00
Vadim Tryshev 61434924f0 Waiting for wallpaper animation completion when configuring new widget
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ice7ae8a2517d68c53d135a34cc33e11f3203f788
2023-12-05 13:32:41 -08:00