Commit Graph

8368 Commits

Author SHA1 Message Date
TreeHugger Robot 367f8f2e2d Merge "Fixing wrong index passed when highlighting a preference during scroll" into ub-launcher3-master 2018-10-13 02:13:43 +00:00
Sunny Goyal 570dac8123 Fixing wrong index passed when highlighting a preference during scroll
Bug: 117656931
Change-Id: I518ac7a309774cb91b64433ccece2b9f272639db
2018-10-12 15:43:12 -07:00
Ryan Lothian f2e8ddaf79 Remove unused NO_ALL_APPS_ICON flag
Change-Id: I2286121d8e396acc4afe76c77ef99abd6154a866
2018-10-12 14:45:35 -04:00
Vadim Tryshev 14c6c8cee4 Improving tests to fix testBindNormalWidget_withoutConfig, and beyond
1. Make waitXXX methods fail if the condition diesn’t turn true.
2. Waiting for loading to complete in tearDown instead of reloading the
 model
3. Avoiding waiting for load-complete where loading didn’t start
4. Disabling last test in AddConfigWidgetTest
5. Waiting for loading to complete inside setupAndVerifyContents(), not
 outside
6. Unifying how we wait for loader to complete
7. Adding more logging

Bug: 117332845
Test: running all Nexus tests
Change-Id: I3070e1ac2b9161179cc3e0800b0cd8162807389a
2018-10-09 18:47:42 -07:00
Sunny Goyal efb7e84242 Converting long item IDs to int
> Items ids were already being typecasted to int when being bound on the UI
> Using a consistent type allow better use of platform data-structures
> Adding IntArray and IntSet as a replacement for various Collection classes

Change-Id: Id3c650ed2420c2bfca3bd7671d2b705b56112371
2018-10-08 14:52:39 -07:00
TreeHugger Robot f307b6032e Merge "Groundwork for runtime-toggleable feature flags" into ub-launcher3-master 2018-10-08 17:26:57 +00:00
Ryan Lothian 688e9896fa Groundwork for runtime-toggleable feature flags
This is the first step in adding a flag toggler UI to launcher.
The change migrates a single flag (QSB_ON_FIRST_SCREEN) from a
boolean constant to a boolean method. In future, that will allow
us to return different values at runtime.

Bug: 117223984
Change-Id: I1e62c91dd941b8145166021bc0aa157733e62ea0
2018-10-08 13:17:30 -04:00
Vadim Tryshev a7da86e14a More temporary logging to diagnose testPendingWidget_autoRestored
And waiting to loader to finish to improve determinism.

Bug: 117332845
Test: running Launcher
Change-Id: Icdfce969b61f8ceb952a2715037783458da4d4c4
2018-10-05 20:05:34 -07:00
Vadim Tryshev c052e4e68a Adding temporary logging to diagnose testPendingWidget_autoRestored
This test fails

Bug: 117332845
Test: running Launcher
Change-Id: I300c856992b3d1f559c4c31525a45e2c4a960f11
2018-10-05 17:37:01 -07:00
TreeHugger Robot 88c289eae3 Merge "Enabling "in test harness" flag with a direct call" into ub-launcher3-master 2018-10-04 23:45:18 +00:00
Vadim Tryshev c295098e18 Enabling "in test harness" flag with a direct call
This allows running in-proc tests without enabling test harness on
Android and restarting Launcher.

Bug: 110103162
Test: TaplTests
Change-Id: Ife44eff4760eb1349a10847efe2c1f27643bf146
2018-10-04 16:33:45 -07:00
TreeHugger Robot bd5a2dbb4f Merge "Fix issue where pointer id was being used to set as action index" into ub-launcher3-master 2018-10-04 20:20:40 +00:00
Hyunyoung Song 6b82a0843e Fix issue where pointer id was being used to set as action index
Bug: 117157432
Bug: 116744159

Context: In vary rare case, Pointer id can be higher than
MotionEvent.getPointerCount. When I was fabricating ACTION_POINTER_DOWN
event, I was using pointer id instead of index to create MotionEvent.
This resulted in stack trace as seen in the bug.

Change-Id: I802c2a45a274f0dda5984f1d266334fc8b6b0bea
2018-10-04 12:41:00 -07:00
TreeHugger Robot 18cc858445 Merge "Fix clipping issue on adaptive icons" into ub-launcher3-master 2018-10-04 17:47:52 +00:00
Hyunyoung Song 44bd6fd020 Fix clipping issue on adaptive icons
Bug: 116527322

More context: unlike previous issue that resulted in clipping on adaptive
icon due to launcher drawing issue (drawing outside the bounds, etc).
This issue is happening on b4 because when canvas is scaled after
the circle mask is digitized, there is a optical illusion that one line
of pixel seems missing. The issue is non observed if scaling is done
before setting the view bounds.

Change-Id: I7099075c88e77776c9cc4f23d79152293489cca2
2018-10-03 16:33:40 -07:00
Sunny Goyal 6c3f44b663 Cancelling previous touch interaction when a new touch starts
Bug: 79220524
Change-Id: I7157dcdc7af92e1e5689da56c87961a82a0e6a05
2018-10-02 11:29:49 -07:00
Sunny Goyal 15dba75e55 Merge "Caching widget labels in icon cache to avoid lookup at startup" into ub-launcher3-master 2018-10-01 18:53:42 +00:00
Hyunyoung Song be2307bbea Reduce falsing on swipe down for notification shade.
b/116879058

Change-Id: If3dde635cdff09faf27dbab2cd022b9d246c7c2b
2018-10-01 11:41:37 -07:00
Sunny Goyal ac8154a23d Caching widget labels in icon cache to avoid lookup at startup
Change-Id: Ie026ee47905454bd70e774d422cd7fe142aec7e2
2018-09-28 16:36:33 -07:00
Sunny Goyal 9f2e997b30 Fixing packageInfo map not getting initialized properly
Change-Id: I395a2a3175675815d6d12a04898132094d3a889c
2018-09-26 15:30:48 -07:00
Jon Miranda b0edaeb268 Align rounded corner of fastscroller popup with the top of the thumb.
Bug: 63852509
Change-Id: I90b6d3e87206a53cfb4c8025a8e5f9597cf73898
2018-09-26 13:19:25 -07:00
Hyunyoung Song 3d6fa5205b Merge "Move IconNormalizer/ShadowGenerator/LauncherIcons to icons package" into ub-launcher3-master 2018-09-26 19:12:42 +00:00
Hyunyoung Song 48cb7bc7a4 Move IconNormalizer/ShadowGenerator/LauncherIcons to icons package
Bug: 115891474

Sending out the package name changing CL first before I make
LauncherIconsHandler and tests around it.

Change-Id: Ic10479a06333e1435b392a7072cd08782e710cbd
2018-09-26 11:57:37 -07:00
Tony Wickham c6dc0c24ec Merge "Change long press timeout to use a factor of ViewConfiguration.getLongPressTimeout()" into ub-launcher3-master 2018-09-26 00:01:12 +00:00
TreeHugger Robot 8968604045 Merge "Extracting icon caching logic into a base class." into ub-launcher3-master 2018-09-25 23:44:12 +00:00
Sunny Goyal 0b3053c9fc Extracting icon caching logic into a base class.
This will allow using the cache cache for other type of objects,
like shortcuts and widgets.

Change-Id: I38616d031cb051f93e724d9cc0e8fe9a822b9e3a
2018-09-25 16:36:06 -07:00
Sunny Goyal 8c79668069 Merge "Using velocity tracker for computing the velocity of motion events" into ub-launcher3-master 2018-09-25 21:15:26 +00:00
Jon Miranda 1786df36c2 Fix bug where folder items get clipped.
We need to account for both sides in the folder margin calculation.
eg. in MW mode with display set to Largest, the folder can reach both edges

Bug: 115955939
Change-Id: I145c8c1c2a75891eb3386284f06fc98800fe5ce9
2018-09-25 13:05:23 -07:00
Tony 2ca999cf1b Change long press timeout to use a factor of ViewConfiguration.getLongPressTimeout()
This way, if the default ViewConfiguration timeout changes, we will adjust accordingly.

Bug: 113639506
Change-Id: Ic3b93311c8e8d8196db2850fa641ffc675a16fb2
2018-09-24 17:24:51 -04:00
Sunny Goyal 73a3d79d24 Cancelling long press on workspace if touch point moves a lot
Bug: 113695336
Change-Id: I9a2e5972b6718b31cffd88be218fe5744c702827
2018-09-24 11:31:22 -07:00
Sunny Goyal f7ed9c0f2c Merge "Removing additional rpc due to icon cache update" into ub-launcher3-master 2018-09-24 16:43:18 +00:00
Sunny Goyal f840f10d50 Removing additional rpc due to icon cache update
When launcher loads, it fetches the list of apps twice, once for
loading all-apps and again for updating icons. Instead reusing
the previously fetched apps list.
Also moving the icon loading in a separate package for further
generalization

Change-Id: Ibd2dae56e6027a31b633da030bc6b43a90b27e1b
2018-09-21 15:27:03 -07:00
TreeHugger Robot 19e0e8ab1f Merge "Add support for testing in portrait mode" into ub-launcher3-master 2018-09-21 22:03:07 +00:00
Vadim Tryshev 802a28946c Add support for testing in portrait mode
Bug: 110103162
Test: TaplTests
Change-Id: I7f633405c04984ea8f04acdc6dd4ad21019d3409
2018-09-21 14:53:11 -07:00
TreeHugger Robot 1473b8e102 Merge "Removing ViewScrim and cutom drawing code" into ub-launcher3-master 2018-09-21 20:28:03 +00:00
TreeHugger Robot 3a030ef994 Merge "Removing various reflection based animations, to allow for better proguarding" into ub-launcher3-master 2018-09-21 18:34:01 +00:00
Sunny Goyal 55bdeed7bb Removing various reflection based animations, to allow for better proguarding
Change-Id: If9df24ea4170e8a3d336057d1c3dc800934fc1ac
2018-09-21 18:21:04 +00:00
Sunny Goyal 6687ba0cc9 Merge "Skip starting new fragment, if the manager is in paused state" into ub-launcher3-master 2018-09-21 17:18:39 +00:00
Hyunyoung Song f58cf5e337 Disable scrolling noti shade on abstract floating view with swipe down
interactions already doing something else.

Bug: 116143342

Change-Id: If3716de0eb1f7b508c3b74dbe2593ba62fffcf74
2018-09-19 17:05:09 -07:00
Sunny Goyal 5077aefc30 Skip starting new fragment, if the manager is in paused state
Bug: 111684268
Change-Id: Ice529356733d98181371e37beed7a34922313cc4
2018-09-19 22:19:08 +00:00
Sunny Goyal 1642f7173f Removing ViewScrim and cutom drawing code
Bug: 109828640
Change-Id: I2cab0215a32c2ca6bc331d48083fcc00ada05c3b
2018-09-18 11:41:02 -07:00
Hyunyoung Song 24b209c65a Swipe down on status bar
Bug: 111839343

Change-Id: I5332dc098af980b4d4ef45b095586d68975ad98c
2018-09-18 11:11:04 -07:00
Sunny Goyal 194f58525a Adding a provider class for various popup actions
so that it can be customized easily.

Change-Id: I633846631ac3d4c70ebb3ea35a3edc2feee8339e
2018-09-17 17:05:32 -07:00
Sunny Goyal 4d8ec15fb5 Using velocity tracker for computing the velocity of motion events
Change-Id: I14f2f970825a2936f4bb285834405d67daf8667c
2018-09-13 09:50:47 -07:00
Tony Wickham 05b351dd42 Merge "Update undo snackbar visuals" into ub-launcher3-master 2018-09-12 00:28:06 +00:00
TreeHugger Robot 297ee90d60 Merge "Ignore any error when killing our process" into ub-launcher3-master 2018-09-11 22:47:06 +00:00
Tony Wickham 08c7cd5625 Update undo snackbar visuals
- Use accent color for action
- Update font-family to use TextTitle style
- Reduce elevation to 3dp
- Inset snackbar left/right margins more, unless we need to increase the
  width to fit the text
- For largest display/font size, fallback to 2 lines and smaller font if
  necessary to not cut off the label
- Remove top/bottom padding on action (b/114084048)
- Allow up to 20 char for the action (b/114317987)

Change-Id: I833c102aaac3ba3db2283997c142926c3830336d
2018-09-11 15:35:47 -07:00
Tobias Dubois a4c1002bac Fix auto install add of installed activity
Reset the restore status for auto install icons where the activity is
installed and enabled so the item is not stuck in the auto install
state.

Bug: 112664405
Test: manual - See issue
Change-Id: I37116b6e6ecbe4215d96627f9b1ea6909d12a6c0
2018-09-07 13:59:04 -07:00
Sunny Goyal e3fec0f177 Ignore any error when killing our process
Bug: 113929153
Change-Id: Ie9a8b59fda1f813748404ed529269cccb1e28c61
2018-09-06 16:26:52 -07:00
Tony Wickham 77a1efed36 Merge "Gracefully fallback to new ComponentName if one is renamed/removed" into ub-launcher3-master 2018-09-06 19:21:35 +00:00