Commit Graph

1910 Commits

Author SHA1 Message Date
Thales Lima 9938c2f791 Calculate hotseat width based on available width
Navigation buttons take space on the hotseat, so hotseat width (qsb width and border space between icons) should be calculated instead of having a coded value.

Bug: 223724516
Bug: 228998463
Test: manual, changing display size
Test: manual, changing hotseatBarEndOffset value
Test: HotseatWidthCalculationTest
Change-Id: Ibd4f5ff2e06afda8e7420fb744db049d2e418e14
2022-08-04 15:21:06 +01:00
Sunny Goyal f28c428050 Merge "Create less number of dot-renderers at startup" into tm-qpr-dev 2022-08-03 14:08:07 +00:00
Sunny Goyal 65190aef37 Create less number of dot-renderers at startup
Bug: 235568943
Test: Launcher starts and shows dots normally
Change-Id: I6958b9b98efb43aa280e6ce31af9c0c936610dea
2022-08-02 14:43:31 -07:00
Schneider Victor-tulias 4eec22f818 Merge "Add logging to help debug additional app infos being updated by CacheDataUpdatedTask" into tm-qpr-dev 2022-08-01 21:50:09 +00:00
Pat Manning 5f74bfd76d Refactor DeviceProfile tests based on dump() and use real device dimensions for tests.
- Added roundPxValueFromFloat when converting dp/sp to px to deterministically round up values around .5

Fix: 240133465
Bug: 237542518
Test: DeviceProfileTest.kt
Change-Id: If4239f714487fe5bf2ef44274e2ce415bd75c86d
2022-08-01 17:54:43 +00:00
TreeHugger Robot 0438ea2293 Merge "Revert "Add testSplitFromOverview test (for phones)"" into tm-qpr-dev 2022-07-29 07:05:34 +00:00
Winson Chung 24df4bffd8 Revert "Add testSplitFromOverview test (for phones)"
This reverts commit 1780cee0fe.

Reason for revert: b/240517487

Change-Id: Id0b690ebba880dd9c978ed42c0f965beb2678b8c
2022-07-29 00:01:17 +00:00
Schneider Victor-tulias 62511de74e Add logging to help debug additional app infos being updated by CacheDataUpdatedTask
Bug: 239465630
Test: ran test locally.
Change-Id: I1b31cfaeb697f87acd99d787284f55d7e6b75b54
2022-07-28 23:09:39 +00:00
Tracy Zhou f1a523a790 Merge "Add testSplitFromOverview test (for phones)" into tm-qpr-dev 2022-07-28 05:06:40 +00:00
vadimt f6ef879cf4 Moving all sources that are shared between Launcher and TAPL in one directory
This will help SysUI test team (who uses TAPL) to set up Gradle build for their tests.

Bug: 202567877, 234414088
Test: presubmit
Change-Id: I3d923ea4b54d1a4c3d2b345be09692727d30433e
2022-07-27 20:18:46 +00:00
Tracy Zhou 1780cee0fe Add testSplitFromOverview test (for phones)
Design doc: go/split_tapl

Bug: 238553914
Fixes: 239082974
Test: run this test
Change-Id: I6b67ede6d62a9fb48222aa4d15fe29ccd1d0fa06
2022-07-27 04:18:50 +00:00
TreeHugger Robot 5e6fe32818 Merge "Space out 3 button nav on taskbar" into tm-qpr-dev 2022-07-26 16:32:06 +00:00
Alex Chau 66bac181ac Merge "Revert "Move BaseActivityInterface task size methods to DevicePr..."" into tm-qpr-dev 2022-07-26 09:36:18 +00:00
Vinit Nayak c7293179d0 Space out 3 button nav on taskbar
* Add additional margin on nav buttons if
there's overlap w/ contextual button
* End spacing is dependent on grid layout

Bug: 223724516
Test: Tested on unfolded with different
grid sizes.

Change-Id: Ie814f35cd1f35629744050ee3f7242c5a8599883
2022-07-25 13:15:11 -07:00
Alex Chau 62572c04e2 Revert "Move BaseActivityInterface task size methods to DevicePr..."
Revert "Move BaseActivityInterface task size methods to DevicePr..."

Revert submission 19279487-baseactivityinterface

Reason for revert: As per discussion in ag/19341332, make sure DeviceProfile can properly react to inset changes before moving task size calculations there
Reverted Changes:
I30324d34c:Move BaseActivityInterface task size methods to De...
Ia9c1d0387:Move BaseActivityInterface task size methods to De...

Bug: 238593212
Change-Id: I0d40fdd4a5d4468494e30cef32a284479ddd2feb
2022-07-25 18:38:03 +00:00
Tracy Zhou 3e64f94387 Merge "Add splitFromOverviewForTablet test" into tm-qpr-dev 2022-07-19 19:06:47 +00:00
Sebastián Franco df1c1c84b5 Merge "Adding test for the Widgets reordering." into tm-qpr-dev 2022-07-19 16:36:31 +00:00
Pat Manning 01a7bcc665 Merge "Move BaseActivityInterface task size methods to DeviceProfile." into tm-qpr-dev 2022-07-19 10:31:51 +00:00
Tracy Zhou 86a844c976 Add splitFromOverviewForTablet test
Design doc: go/split_tapl

Bug: 238553914
Test: run this test

Change-Id: Ibb385d852f73dee10470d14c4962cf482740105d
2022-07-19 01:57:35 +00:00
Sebastian Franco 5cba476362 Adding test for the Widgets reordering.
TAPL design chagnes at https://docs.google.com/document/d/1PdJZZIn-85-UMRFGZuqj-tJgruIWcg31lZnrb34iBTY/edit?resourcekey=0-uAZuiLCDFV9YhOtLB7wQHQ

The tests consist of a board representing the widgets on
the CellLayout a position to move the main widget (m) to
and the resulting board.

iiiii    iiiii
-----    --x--
-xxx- -> -xmx-
--m--    -----
-----    -----

Move m to 2,2.

Then whe make sure the device corresponds with the resulting
board.

I had to add the event TestLogging.recordEvent(TestProtocol.SEQUENCE_MAIN, "Widgets.onLongClick");
on ItemLongClickListener because the tests where not expecting
a long press on a widget after is being place on the
workspace.

Also, I needed to add the option to drag a widget
to a specific point instead of the previous option
of only dragging to the workspace.

Fix: 231449779
Test: Run the test and make sure they pass.
Change-Id: I58183b7ce2ca64c999e21073cce5e0ba6e6f3a9e
2022-07-18 11:52:12 -07:00
Pat Manning 4e73e5e352 Move BaseActivityInterface task size methods to DeviceProfile.
Fix: 238593212
Test: DeviceProfilePhoneTest.kt
Test: DeviceProfileVerticalBarTest.kt
Test: DeviceProfilePhone3ButtonTest.kt
Test: DeviceProfileVerticalBar3ButtonTest.kt
Test: DeviceProfileTabletLandscapeTest.kt
Test: DeviceProfileTabletPortraitTest.kt
Test: DeviceProfileTabletLandscape3ButtonTest.kt
Test: DeviceProfileTabletPortrait3ButtonTest.kt
Test: DeviceProfileTwoPanelLandscapeTest.kt
Test: DeviceProfileTwoPanelPortraitTest.kt
Test: DeviceProfileTwoPanelLandscape3ButtonTest.kt
Test: DeviceProfileTwoPanelPortrait3ButtonTest.kt
Change-Id: I30324d34ca119a467f530b590949743c2ba7b91a
2022-07-18 16:35:02 +01:00
Sunny Goyal cba5f9a64e Removing unnecessary work adapter wrapper
Simplifying view type constants to make it easier to add new view types

Bug: 234008165
Test: Verified on device
Change-Id: I96589ceba362ea7e75afdfc3fe8da3be214aa682
2022-07-15 16:24:31 -07:00
Pat Manning e700efde22 Merge "Add DeviceProfile tests on all attributes across different configurations." into tm-qpr-dev 2022-07-13 10:45:50 +00:00
Winson Chung 8bd458b518 Extend accessibility timeout indefinitely before overview screenshot
Test: atest TaplTestsQuickstep#testOverviewActions
Bug: 236730000
Change-Id: I4db9fc01aaa048cead47e14c34df609bb43f3906
2022-07-12 16:31:57 +00:00
Pat Manning 26f70f777e Add DeviceProfile tests on all attributes across different configurations.
Fix: 237542518
Test: DeviceProfilePhoneTest.kt
Test: DeviceProfileVerticalBarTest.kt
Test: DeviceProfilePhone3ButtonTest.kt
Test: DeviceProfileVerticalBar3ButtonTest.kt
Test: DeviceProfileTabletLandscapeTest.kt
Test: DeviceProfileTabletPortraitTest.kt
Test: DeviceProfileTabletLandscape3ButtonTest.kt
Test: DeviceProfileTabletPortrait3ButtonTest.kt
Test: DeviceProfileTwoPanelLandscapeTest.kt
Test: DeviceProfileTwoPanelPortraitTest.kt
Test: DeviceProfileTwoPanelLandscape3ButtonTest.kt
Test: DeviceProfileTwoPanelPortrait3ButtonTest.kt
Change-Id: I1596dcd1fb8c9b353cdfcab224d7670d88bed716
2022-07-12 14:17:18 +01:00
Tony Wickham 0c8ceda6e7 Merge "Move TEST_HARNESS_TRIGGER_TIMEOUT to MotionPauseDetector directly" into tm-qpr-dev 2022-07-06 16:25:03 +00:00
Thales Lima b8c0595d42 Add new hotseat bottom margin options
This changes how the hotseat height is calculated and by consequence how spaces are distributed in the workspace as well. This is the first of a series of changes that will improve and streamline workspace calculations.

Bug: 228998463
Fix: 234023782
Fix: 230191631
Fix: 232914299
Fix: 236238226
Test: manual, HSV and comparing to mocks
Change-Id: If021e8ba2c7c24c0bf9f27a1aa7aa946792ed04f
2022-07-05 15:33:47 +01:00
Pat Manning 0f8bbef729 Merge "Simplify vertical bar hotseat bottom calculation for spring loaded state." into tm-qpr-dev 2022-07-05 10:28:10 +00:00
Pat Manning a7335bccdc Simplify vertical bar hotseat bottom calculation for spring loaded state.
Fix: 236941743
Test: manual.
Change-Id: I7f110fea48eb88e7f941a64c17a65feec14531f3
2022-07-04 12:45:40 +01:00
Tony Wickham 539c2703ea Move TEST_HARNESS_TRIGGER_TIMEOUT to MotionPauseDetector directly
- Removed TestProtocol.sForcePauseTimeout and
  TestProtocol.REQUEST_SET_FORCE_PAUSE_TIMEOUT
- Instead, add MotionPauseDetector.TEST_HARNESS_TRIGGER_TIMEOUT, which
  is used when Utilities.IS_RUNNING_IN_TEST_HARNESS.

Test: unbundled/launcher/launcher3_test_platform
Fixes: 232548865
Change-Id: I224e99042b41375cab6bffd555434217518958c5
2022-06-30 12:16:08 -07:00
TreeHugger Robot 72c5f330bf Merge "Add TAPL API for adding app icon to hotseat" into tm-qpr-dev 2022-06-30 05:28:14 +00:00
Alex Chau f52a13e424 Merge "Add test to dismiss AllApps bottom sheet" into tm-qpr-dev 2022-06-27 09:56:58 +00:00
Chilun Huang 7662dae663 Add TAPL API for adding app icon to hotseat
Please refer to go/tapl-add-icon-to-hotseat for more details.

Bug: 231400119
Test: atest NexusLauncherTests:TaplTestsQuickstep#testAddDeleteShortcutOnHotseat
Change-Id: I8cadecbe742413e3ce35ff269c0f78057331532c
Merged-In: I8cadecbe742413e3ce35ff269c0f78057331532c
2022-06-27 11:10:21 +08:00
Vadim Tryshev 542d3cf4f2 Ignoring failing test
Bug: 233075289
Change-Id: I4f270127b72255037dd5aaccdc375dfebb6b1dc4
Test: presubmit
2022-06-24 20:50:42 +00:00
Alex Chau d936273b1f Add test to dismiss AllApps bottom sheet
- http://docs/document/d/1ITZDMchoMndfa0nMuOTXbhKhK2aMDz0AT9dgusgxEro

Bug: 236360930
Test: TaplTestsLauncher3.testAllAppsDeadzoneForTablet
Test: TaplTestsNexus.testSearchDeadzoneForTablet
Change-Id: I62adb1d6ef237f9bca3812b8cdce9e5a8383158f
2022-06-24 18:29:43 +01:00
Vadim Tryshev 0bc6491ee7 Merge "Remove unused tracing; it confuses investigators" into tm-qpr-dev 2022-06-24 02:05:16 +00:00
Sebastián Franco 9ffbbf8f2c Merge "Cherrypick needed for merge conflict with ag/18875278" into tm-qpr-dev 2022-06-23 21:54:13 +00:00
vadimt 020c9e4b22 Remove unused tracing; it confuses investigators
Bug: 196820244
Test: presubmit
Change-Id: If403f475f393fc95e5efd098ae63c8e8bb199ddc
2022-06-22 17:10:08 +00:00
vadimt a18e9f2637 Reducing max timeout in TAPL
Lab presubmits now have a limit 60 sec per test, so failing to find an expected view will result in a cryptic "Test did not run due to instrumentation issue. Run level error reported reason: 'Instrumentation did not output anything for the configured timeout. ddmlib reported error: Failed to receive adb shell test output within 600000 ms. Test may have timed out, or adb connection to device became unresponsive.'"

Reducing the timeout to get better messages.

Bug: 236308045
Test: presubmit
Change-Id: I09e7fa02a12f4e2d0900d29b0029686337a381b0
2022-06-21 20:14:08 +00:00
Ling WO 9a8964b122 Cherrypick needed for merge conflict with ag/18875278
Support move to a specific location on workspace for all workspaceDragSource, so other workspaceDragSource such as HomeAppIconMenuItem can be moved to a fixed location during testing to avoid ui-diff flakiess

Design doc:
https://docs.google.com/document/d/1tZWbfsv86O6UAKtHJrDBGecu-x3ac51qmWvARDg057M

Test: atest
Bug: 216189838

Change-Id: Ia6ef7338beb257d0313be17a53a9fc59ae39fdb6
(cherry picked from commit fe8fb4d137)
2022-06-15 22:38:04 +00:00
Alex Chau 661f02de18 Use normalized CachedDisplayInfo as key
- For system Launcher, migrate to use getPossibleMaximumWindowMetrics instead of getDisplays
- Removed usage of displayId
- In estimateInternalDisplayBounds, use CachedDisplayInfo directly as a key
- When cache retunrs null for the current display (e.g. the 3P launcher case), invalidate the cache and estimate again, and only add to supportedBounds if current display is not found in the new cache

Bug: 227459045
Bug: 198965093
Test: manual
Change-Id: Ibcc05ba483ed31a40d16e3cf49c3f3d43af68cf6
2022-06-09 11:36:47 +01:00
Andy Wickham a1ec03bdfe [conflict] Merge "Moves Search results into a separate RV (take 2)." into tm-dev am: 4ca247a6bb am: 15dc59f8b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18420827

Change-Id: Ic7e380e21342011afcbd1ada0eb453dc83eff4be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 23:31:31 +00:00
Andy Wickham 4ca247a6bb Merge "Moves Search results into a separate RV (take 2)." into tm-dev 2022-05-26 21:41:55 +00:00
Tracy Zhou 674ac75930 Add ScreenRecord tag to understand in proc test failure
Bug: 233075289
Test: N/A
Change-Id: I22333f20f68692a352312bad034ce54def9c29ef
2022-05-26 18:16:57 +00:00
Schneider Victor-tulias 8c8b35c368 Merge "Add screen recording to drag to splitscreen taskbar tests to help with debugging." into tm-dev am: 467f30dbb7 am: b210664095
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18529596

Change-Id: If00b8b6ff429556e7860089b855bac390983c37d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 21:59:30 +00:00
Schneider Victor-tulias 467f30dbb7 Merge "Add screen recording to drag to splitscreen taskbar tests to help with debugging." into tm-dev 2022-05-25 21:03:04 +00:00
Andy Wickham 2ba7797edb Moves Search results into a separate RV (take 2).
Bug: 206905515
Test: Manually verified b/230648542 did not resurface. Tested
on phone and tablet with and without work profile.

Change-Id: If724f635286b9dff2c64255f9ece3568a5cb4ea9
2022-05-24 17:10:24 -07:00
Schneider Victor-tulias aa5ae621c5 Add screen recording to drag to splitscreen taskbar tests to help with debugging.
Test: presubmit and local
Bug: 231615831
Change-Id: I87ea5eb30eaf9ec1f4f96572c78bc9daf976a589
2022-05-24 11:46:31 -07:00
Nicolo' Mazzucato 25b36f7716 Fix flakiness in getIconPosition test
After uninstalling the app, it was disappearing after some time. For this reason, tryGetWorkspaceAppIcon was still returning it after the uninstall.

Fixes: 232009313
Test: atest TaplTestsLauncher3
Change-Id: I62e3a8f9a481e9786a136b6c00051c1025ab5b32
2022-05-24 09:42:24 +00:00
Tracy Zhou 3438c92334 Add drag icon to folder use case back
Test: presubmit
Fixes: 232417717
Change-Id: Idca54eb8b1fec10e8c9d7e5cb338e179b733850b
2022-05-17 02:41:30 +00:00