Commit Graph

65 Commits

Author SHA1 Message Date
Treehugger Robot 8114a7ffb5 Merge "Reland slow gesture callback handling" into 24D1-dev 2024-04-23 17:47:37 +00:00
Schneider Victor-tulias c30642b97f Reland slow gesture callback handling
Now that b/329324086 has been fixed, we can be more certain that launcher always gets a signal to clean up from WM.

- Relanding original fix for b/285636175 with some additional error checking
- We will now check whether the recents animation start is pending on ACTION_UP
- We will now block entire swipes to prevent sending additional inputs an input consumer while the recents animation start is pending
- We will now only stop blocking inputs on ACTION_DOWN

Flag: LEGACY ENABLE_HANDLE_DELAYED_GESTURE_CALLBACKS TEAMFOOD
Bug: 329324927
Fixes: 285636175
Test: added a delay in RecentsAnimationCallbacks.onAnimationStart and attempted several rapid gestures
Change-Id: I9805114da34bf44e6b28c2a8a665e4cca88904c2
(cherry picked from commit f3f0e28762)
Merged-In: I9805114da34bf44e6b28c2a8a665e4cca88904c2
2024-04-23 15:36:01 +00:00
Sebastian Franco 8c3d830b39 Making 2 flags read only since they are used on backup and restore
The flags are narrow_grid_restore and grid_migration_fix.

Flag: ACONFIG enable_grid_migration_fix enabled
Flag: ACONFIG enable_narrow_grid_restore enabled
Bug: 325286145
Bug: 325285743
Test: BackupAndRestoreDBSelectionTest.kt
Test: GridMigrationTest.kt
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5ea61960ab4b0da02aeb5dd36968c2ef923709aa)
Merged-In: Ia6a439553c3c5098115144eae532342ce73be4f2
Change-Id: Ia6a439553c3c5098115144eae532342ce73be4f2
2024-04-22 16:15:30 +00:00
Fengjiang Li ea67949eb0 Fix a bug where PURPOSE_BUGFIX was added to wrong flag
ag/26027892 added `PURPOSE_BUGFIX` to `enable_tablet_two_pane_picker_v2`, instead it should be added to `enable_add_app_widget_via_config_activity_v2`

Flag: aconfig enable_add_app_widget_via_config_activity_v2 DISABLED
Test: NONE
Bug: 284236964
Change-Id: I55ac6ae0f3af7ab1ed239ac11a04dd59eaf95c4a
2024-02-29 11:42:29 -08:00
Sebastián Franco 8833826b00 Merge "Adding grid_migration_fix and narrow_grid_restore flag" into main 2024-02-28 17:20:31 +00:00
LaMont Jones 74f7786401 Fix container for aconfig flags.
This app is in system_ext, not system.

Bug: b/325307746
Test: manual
Flag: NA
Change-Id: Ibb1c7a4b338b6bf900a626e7ec66a28e0f90169d
2024-02-26 14:54:31 -08:00
Sebastian Franco e28239053d Adding grid_migration_fix and narrow_grid_restore flag
Flag: ACONFIG grid_migration_fix disabled
Flag: ACONFIG narrow_grid_restore disabled
Test: NA
Bug: 325286145
Bug: 325285743
Change-Id: Ibac4f8f7df7b020582bfa6cbc5756fcb743a3d09
2024-02-23 17:55:10 +00:00
Brandon Dayauon 0fa9113028 Merge "Add home settings toggle featureflag for enablingTwoLineText" into main 2024-02-21 18:14:21 +00:00
Fengjiang Li 73ece207a2 Merge "Avoid flicker to drop a widget that needs a config activity." into main 2024-02-17 03:16:40 +00:00
Fengjiang Li 8bd66ee82d Avoid flicker to drop a widget that needs a config activity.
When dropping a widget that requires an config activity, drop a
PendingAppWidgetHostView to workspace

Adb command to try the feature:

adb shell device_config put launcher com.android.launcher3.enable_add_app_widget_via_config_activity_v2 true

Fix: 284236964
Test: manual
Flag: aconfig launcher.enable_add_app_widget_via_config_activity_v2 DISABLED
Change-Id: Ifd0be5c607a388cf8a8f6d77b46c03112e3e599f
2024-02-16 17:05:40 -08:00
Willie Koomson fda1b4b0d0 Merge "Use generated RemoteViews preview for widget picker if available" into main 2024-02-13 21:18:45 +00:00
Willie Koomson fedc18e9a8 Use generated RemoteViews preview for widget picker if available
WidgetCell will use the generated RemoteViews preview to display
previews in the widget picker. It will fallback to current preview
methods if not available.

Introduces WidgetManagerHelper.loadGeneratedPreviews as a utility
function. WidgetManagerHelper is passed into the constructor of
WidgetItem to avoid calling
context.getSystemService(AppWidgetManager.class) for each widget.

Bug: 308041327
Test: atest Launcher3Tests:GeneratedPreviewTest
Flag: ACONFIG com.android.launcher3.enable_generated_previews DEVELOPMENT
Change-Id: I37429057cda83a5321884ace2537038e050b9a58
2024-02-13 18:49:44 +00:00
Brandon Dayauon 5787a2710c Add home settings toggle featureflag for enablingTwoLineText
- Have shouldUseTwoLine() be decided with the home settings toggle value

bug:316027081
spec: https://www.figma.com/file/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?type=design&node-id=405-384593&mode=design&t=UBkdeuNlAdRh2FGU-0
Test:
Video: https://drive.google.com/file/d/15VUhNVro2fiwv3SzMda1StiPb3PV1eMT/view?usp=sharing
before searchPreferenceScreen: https://screenshot.googleplex.com/3uqdMsZoGSBYb6c
after searchPreferenceScreen: https://drive.google.com/file/d/15dswiHRTnafyhgQA_tL2tRc7vHFWdHbZ/view?usp=sharing
before homeSettingsPage: https://screenshot.googleplex.com/7wsNevxGun2KCCB
after homeSettingsPage: https://drive.google.com/file/d/15m5bjEyewlNHI_h26aygHa7zrgZ5qDF6/view?usp=sharing
AppListSettingsPage: https://drive.google.com/file/d/15hl4ScHBOLgKv3M38HtatMxQw85pgl7t/view?usp=sharing
Flag: enableTwolineToggle DEVELOPMENT

Change-Id: I3ad133dd51dcb97e14ccded730e7737c5049261a
2024-02-12 09:24:48 -08:00
Oriol Prieto Gascó 0f1c6dedf5 Merge "Set the container field of aconfig flags" into main 2024-02-12 16:41:08 +00:00
Oriol Prieto Gasco 59234c574e Set the container field of aconfig flags
Please see go/aconfig-flag-containers for more context

Test: m
Bug: 312769710
Change-Id: I95efda5d266ad45202501d82d256d9e9f8e7826a
2024-02-07 20:00:34 +00:00
Fengjiang Li cd60d191a8 [Predictive Back] Replace legacy flag with aconfig flag in launcher
Fix: 323971106
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Test: manual
Change-Id: Ie8051af2540699a7d75f1ed05132584d0b40d17d
2024-02-05 16:41:29 -08:00
Himanshu Gupta 69f37fd722 Merge "Preventing DragAndDrop for PS apps." into main 2024-02-01 09:14:43 +00:00
Himanshu Gupta 3ec66fb333 Preventing DragAndDrop for PS apps.
This Cl restricts item dragging for PS apps from
all launcher surfaces such as AllApps, AppPredictionRow, etc.

Video: https://photos.app.goo.gl/PKGw8n23hJVJMyUk7

Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_item_drag DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I2c5dbaa325095ec63aedf39b6b2c269f745d58ca
2024-02-01 06:46:25 +00:00
Sunny Goyal fffb4feb4e Adding a flag to support activity overlay on home screen
Bug: 273828110
Flag: aconfig use_activity_overlay disabled
Test: N/A
Change-Id: Ic29c2c21da22554213a1792a38caf6907438c86d
2024-01-31 11:34:00 -08:00
Shamali P c48c660bb5 Add a feature flag for displaying categorized widget recommendations.
Bug: 318410881
Test: NONE
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_suggestions DEVELOPMENT
Change-Id: I6f8a0cc8f74823f1a29cef1b5f8ac0a3e9411609
2024-01-29 18:40:22 +00:00
Himanshu Gupta f591ce5f17 Restricting Accessibility flows for Private Profile.
Adding PS apps to the home screen is restricted.
This CL prevents the same from accessibility drags.

Bug: 289223923
Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_accessibility_drag DEVELOPEMENT
Test: Ran Launcher3 Tests.
Change-Id: I3e2b7b196b96a4d2ba34d8ece5fd6e0463f17253
2024-01-25 04:19:20 +00:00
Sunny Goyal 7ec2e11b0c Merge "Implementing an unfold animation using CannedAnimationController" into main 2024-01-22 19:06:41 +00:00
Sebastián Franco 82d88d3fdc Merge "Updating launcher settings so that they become split-screen" into main 2024-01-22 04:58:09 +00:00
Sunny Goyal 2faf66e5d3 Merge "Revert "Set aconfig container to "system""" into main 2024-01-19 23:31:17 +00:00
Sebastian Franco 9ae403298d Updating launcher settings so that they become split-screen
Following this guide:
https://developer.android.com/guide/topics/large-screens/activity-embedding#extract_an_activity_from_a_split_to_full_window

Bug: 204463748
Test: Open the settings app and open multiple settings, for now
only the options inside of the launcher3 package work
Flag: ACONFIG com.android.launcher3.Flags.enableTwoPaneLauncherSettings DEVELOPMENT

Change-Id: Ie6a9eb3760171da92d94cf06376127b02afff8df
2024-01-19 22:33:20 +00:00
Sunny Goyal d609f6ea39 Revert "Set aconfig container to "system""
This reverts commit 2916945dbf.

Reason for revert: breaks android-studio development flow

Change-Id: I219eb87c170b2b0dd1bb98894afa680bffb360b5
2024-01-19 21:35:29 +00:00
Sunny Goyal 2c206400a2 Implementing an unfold animation using CannedAnimationController
Bug: 297057373
Flag: aconfig enable_unfold_state_animation DISABLED
Test: Manual
Change-Id: Iaa352133ebf06ab74b9ba4b8c4d3523f27666089
2024-01-18 11:49:37 -08:00
Oriol Prieto Gascó 8cba27bc8a Merge "Set aconfig container to "system"" into main 2024-01-18 14:29:17 +00:00
Sunny Goyal d3ee2c3427 Merge "Adding feature flags for Launcher reboot and load improvements" into main 2024-01-18 00:07:54 +00:00
Anushree Ganjam cbfa8043c8 Merge "Add "Don't suggest app" shortcut to suggested apps." into main 2024-01-17 22:25:17 +00:00
Sunny Goyal 24d68d852b Adding feature flags for Launcher reboot and load improvements
Bug: 318539160
Bug: 298231234
Test: N/A
Flag: ACONFIG com.android.launcher3.enable_reboot_unlock_animation DEVELOPMENT
Flag: ACONFIG com.android.launcher3.enable_workspace_inflation DEVELOPMENT
Change-Id: Ica99710a4168eae556ea656f65a444628f9fd8e9
2024-01-17 14:14:23 -08:00
Charlie Anderson da3138cd91 Replace ENABLE_LAUNCHER_BR_METRICS flags with fixed aconfig flag.
This is necessary because the value of the read-write flag will not be updated in time for backup/restore.

Bug: 307527314
Test: compiles
Flag: ACONFIG ENABLE_LAUNCHER_BR_METRICS_FIXED TEAMFOOD
Change-Id: I67a1a820734d8881b3ed5be4a1f2f1556e6e4704
2024-01-12 14:33:29 -05:00
Anushree Ganjam 5e9b71e055 Add "Don't suggest app" shortcut to suggested apps.
This works for suggested apps in both Home and AA+. When enable_shortcut_dont_suggest_app is true, the secondary drop target "Don't Suggest app" is removed instead "Don't suggest app" is added to shortcuts.

Video: https://b.corp.google.com/issues/319250810#comment5

Home: https://screenshot.googleplex.com/d7Wts48X6EmFAYg.png
Private space app suggested: https://screenshot.googleplex.com/BukzCRTvkzbpwQ3.png

AA+: https://screenshot.googleplex.com/ADMCHnQ378jvJEE.png
Private space app suggested : https://screenshot.googleplex.com/AYga8Km3646AqMt.png

Bug: 319250810
Flag: aconfig com.android.launcher.enable_shortcut_dont_suggest_app DEVELOPMENT
Test: Manual.

Change-Id: Ia7df749a1c7d806bd9d74124be138384c3050119
2024-01-12 10:33:24 -08:00
Anna Zhuravleva eb1966c278 Merge "Add shortcut to install an app to Private space" into main 2024-01-12 15:51:05 +00:00
Anna Zhuravleva 29a3139815 Add shortcut to install an app to Private space
Introduce long-press shortcut to install a copy
of the main user app to private space.

Test: manual, installed apps in different stores
and tried shortcut
https://screenshot.googleplex.com/6oAVamTytiYmvPC.png
Bug: 316118005
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space_install_shortcut DEVELOPMENT

Change-Id: I702cd2a27388e3cc6e9e126308d5479836ba6655
2024-01-11 12:40:28 +00:00
Oriol Prieto Gasco 2916945dbf Set aconfig container to "system"
Bug: 312769710
Flag: NA
Test: TH
Change-Id: I7fbb8e31629b7aa90fbdf2b029932c111cce8d42
2024-01-10 19:52:57 +00:00
Tracy Zhou 899c28193c Merge "Delete enable_split_from_fullscreen_with_keyboard_shortcuts from aconfig" into main 2024-01-05 21:20:33 +00:00
Tracy Zhou ef8e4e2e77 Delete enable_split_from_fullscreen_with_keyboard_shortcuts from aconfig
It's merged with split_contextual in ag/25511408

Bug: 270394122
Test: N/A
Change-Id: Idabddee7c566ec426be744261ff50d7b360e2afa
2024-01-05 10:45:22 -08:00
Rohit Goyal 2e6010c421 Add support for progress bar during unarchival of app.
* With this change, progress bar should appear whenever app update for archived app reaches non-zero progress.
* Once the update is cancelled, the progress bar should also disappear.

Test: PromiseIconUiTest and manually tested the progress bar using Play Store
Bug: 302115555
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Iacf7a0fd865dba34915fa09f59c63a1da6e47315
2024-01-03 23:44:52 +05:30
Jagrut Desai 2107717252 Merge "Change Tracking Bug for Taskbar pinning feature flag" into main 2024-01-02 20:52:50 +00:00
Jagrut Desai 5bcad413ec Change Tracking Bug for Taskbar pinning feature flag
Test: Presubmit
Bug: 296231746
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I4be1d2a247f0aa6b39854a667b576a523a8a776a
2023-12-20 11:09:50 -08:00
Himanshu Gupta ce2b013d31 Merge "Adding methods to access LauncherApps APIs." into main 2023-12-19 11:27:09 +00:00
Himanshu Gupta 6c25654e84 Adding methods to access LauncherApps APIs.
These methods are added to ApiWrapper class
so that Launcher can acess these APIs.

Bug: 308054233
Test: Presubmit
Flag: ACONFIG com.android.launcher3.Flags.private_space_sys_apps_separation DEVELOPMENT
Change-Id: Ic2e64b38cc8b0d262d3f6e9614e2b3fceb9d82a0
2023-12-18 19:47:13 +00:00
helencheuk b4626f4698 Add focus outline to launcher
Fix: 310953377
Test: TBC
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: Ie395ec74c8a4a13a68539ca7ec6496481d96b860
2023-12-15 16:56:31 +00:00
fbaron 5176d7b074 Add ACONFIG flag enable_tablet_two_pane_picker_v2
Bug: 315055849
Test: NONE
Flag: ACONFIG com.android.launcher3.enable_tablet_widget_picker_v2 DEVELOPMENT
Change-Id: I7c7e49dc6fe2de3c4f3f28a9b8f67035c67831e6
2023-12-05 17:44:15 -08:00
fbaron 9efed13652 Add ACONFIG flag enable_unfolded_two_pane_picker
Bug: 301918659
Test: NONE
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT
Change-Id: I16e4cafb676564faa9da2d7402357cb815fd178e
2023-11-29 20:56:09 +00:00
Charlie Anderson c23a440f8d Add aconfig flag enable_launcher_br_metrics
Flag: ACONFIG  com.android.launcher3.enable_launcher_br_metrics DEVELOPMENT
Bug: 307527314
Bug: 305984208
Test: locally verify
Change-Id: I28488de7133d898e6ef990183f0af5f34732cced
2023-11-17 17:38:33 +00:00
Tracy Zhou 859edd00e9 Migrate ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS to aconfig
Bug: 270394122
Test: N/A
Change-Id: I9bacd906099518b4a4c43a9f80ab0c753beac89a
2023-11-13 13:12:09 -08:00
Jagrut Desai bd997801e9 Merge "Migrate ENABLE_TASKBAR_PINNING to aconfig flag" into main 2023-11-13 20:13:15 +00:00
Jagrut Desai 90dd098c85 Migrate ENABLE_TASKBAR_PINNING to aconfig flag
Test: Manual, Presubmit
Bug: 265437087
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I4800230c04feceefa2398e189c493c8c4a7b2fe5
2023-11-09 23:20:03 +00:00