Commit Graph

9129 Commits

Author SHA1 Message Date
Jagrut Desai 6acf350107 Merge "Fix Taskbar Education Tooltip Bottom Margin" into udc-dev 2023-05-22 17:04:25 +00:00
Jon Miranda 9e0eee3729 Merge "Fix SUW unstash animation." into udc-dev 2023-05-20 20:16:17 +00:00
Jon Miranda 0aef6981ac Fix SUW unstash animation.
- Defer any UI updates to taskbar after the SUW unstash animation is created.
- Predicted app icons take longer to load, so it's possible that they are
  added after the animation is created.
- This avoids the case where icons are seemingly in the taskbar but
  do not get animated like the rest of the icons.

- We also need to call onAnimationStart for the reveal animation immediately,
  otherwise the clipToOutline params never get set.

Bug: 277712185
Test: flash device, very quickly go through SUW
Change-Id: I4c3089da0d20bf91672e2305655c4c37b1f367aa
2023-05-19 17:24:50 -07:00
Jagrut Desai 709242e89e Fix Taskbar Education Tooltip Bottom Margin
Test: Manual
Bug: 282990924
Flag: Not needed
Change-Id: I977e7fc84382b1c43612516c8d6f27610ad25a3f
2023-05-19 15:45:41 -07:00
Vinit Nayak 258019fe8e Merge "Separate code paths to launch split from existing pair vs new pair" into udc-dev 2023-05-19 17:51:23 +00:00
Hongwei Wang 0c66b151e3 Merge "Notify WMShell on aborting auto-enter-pip" into udc-dev 2023-05-18 23:00:03 +00:00
Saumya Prakash 66e7ec721b Merge changes If2c82082,I03532b80 into udc-dev
* changes:
  Update Lottie animations for gesture navigation tutorial to enable custom colors
  Update gesture tutorial colors
2023-05-18 22:01:49 +00:00
Hongwei Wang 45b8d39ab8 Notify WMShell on aborting auto-enter-pip
Note that this change does not fix the bug listed here. This is to
callback WMShell when the transition is aborted and WMShell can choose
how to handle this.

Bug: 283177443
Test: adb shell dumpsys activity service SystemUIService WMShell
Test: go/winscope and check the SF/WM dump
Change-Id: I8abfc2db47d1f0bfc3d400066936bed354743420
2023-05-18 13:15:57 -07:00
Treehugger Robot 80e9a3b64e Merge "Fix widget clipping in widget back animation" into udc-dev 2023-05-18 19:59:21 +00:00
Saumya Prakash 0a6fb2c9e1 Update Lottie animations for gesture navigation tutorial to enable custom colors
This change introduces tokens for all the lottie animations in the
gesture navigation tutorial so that the colors can be changed to match
with the current design spec at http://shortn/_aig7n8W7rF

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 279823249
Bug: 281764891
Test: Tried changing colors and verified that lottie animations changed
appropriately.

Change-Id: If2c820826603fb1cf424f5f0c97d83b195d26606
2023-05-18 10:47:44 -07:00
Schneider Victor-tulias 474f3c4e90 Update gesture tutorial colors
- Updated all redesigned gesture nav menu and tutorial colors to dynamic color spec

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 281764891
Bug: 279823249
Test: launched tutorial menu and tutorial steps
Change-Id: I03532b80c6e14867c1374bbdf9f984c1cece9809
2023-05-18 10:47:33 -07:00
Vinit Nayak 6ab2786d16 Separate code paths to launch split from existing pair vs new pair
* Launching existing pair doesn't rely on any existing
data/state in SplitSelectStateController or SplitSelectDataHolder
* Consolidate launchTask*() methods in GroupedTaskView

Test: TaskThumbnailViews measured correctly, animation
correct on small+large screen, initiating split
still working
Fixes: 274540670
Flag: none needed

Change-Id: Id359f53ac5f2bba19948d4ae3231092fb90cc7c5
2023-05-18 10:43:17 -07:00
Jagrut Desai b9a88db27c Merge "Fixing spacing between folder icon and folder itself" into udc-dev 2023-05-18 17:21:33 +00:00
Sihua Ma f8acb23e1f Fix widget clipping in widget back animation
Test: Manual
Fix: 280261814
Change-Id: I4db24ca624d50b1d860df428fdab9d591f35ac5e
2023-05-17 13:32:20 -07:00
Saumya Prakash e212779ffd Merge "Display app icons in quick switch task view when there are no updates." into udc-dev 2023-05-17 17:11:49 +00:00
Winson Chung 2e1ce4c72f Merge "Only set drag shadow params if they are valid" into udc-dev 2023-05-17 03:44:42 +00:00
Saumya Prakash 033412a892 Display app icons in quick switch task view when there are no updates.
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fix: 275629107
Test: Launched keyboard quick switch view and changed focus back and forth

Change-Id: I6ce39e7842bb04c80d49d871002ef957708a8e59
2023-05-16 23:00:46 +00:00
Jagrut Desai 172266fb4e Fixing spacing between folder icon and folder itself
Test: Manual
Bug: 282990506
Flag: not needed
Change-Id: I4a873495ffdf6210b496a4d7d18546dc7483e66e
2023-05-16 14:04:14 -07:00
Charlie Anderson afb447ee0d Merge "Adding a new Edit Mode LauncherState" into udc-dev 2023-05-16 18:42:34 +00:00
TreeHugger Robot b9f04842b5 Merge "Add a no recent tasks message to the keyboard quick switch view" into udc-dev 2023-05-16 06:49:52 +00:00
Schneider Victor-tulias 4ee471fecf Merge "Update keyboard quick switch view ordering and add icons" into udc-dev 2023-05-16 05:12:47 +00:00
Treehugger Robot 56f539538f Merge "Don't treat Recents as transient for all apps from overview." into udc-dev 2023-05-16 01:28:49 +00:00
Schneider Victor-tulias b29355c192 Add a no recent tasks message to the keyboard quick switch view
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 280652620
Test: launched the keyboard quick switch with 0, <=6 and >6 tasks launched
Change-Id: I560707645b83b79ba2203460e62e4c540f5da421
2023-05-15 16:49:45 -07:00
Schneider Victor-tulias f0233c53d3 Merge "Code cleanup: recycle typed arrays when they are no longer needed" into udc-dev 2023-05-15 23:48:11 +00:00
TreeHugger Robot f0c96721ba Merge "Add handling for toggling keyboard stashing from the keyboard" into udc-dev 2023-05-15 22:57:14 +00:00
TreeHugger Robot 15bc0d388a Merge "Adding support for listening to end callbacks when launching an intent from Launcher" into udc-dev 2023-05-15 22:20:32 +00:00
Winson Chung 583de1621d Only set drag shadow params if they are valid
- Invalid params trigger an exception to be thrown when starting a
  system drag

Bug: 269016702
Test: Presubmit
Change-Id: I4b1953afd72ab1c6d41f3b5b536f9578ef40d792
2023-05-15 22:10:16 +00:00
Tony Wickham 4f69ca52ef Merge "Remove unused/obsolete feature flags" into udc-dev 2023-05-15 21:46:15 +00:00
Tracy Zhou 3711aa64ac Merge "[Reland] Fix touch focus not updated correctly after launching overview with live tile." into udc-dev 2023-05-15 19:45:46 +00:00
Schneider Victor-tulias b6407699ae Update keyboard quick switch view ordering and add icons
- Updated the keyboard quick switch view ordering to left-to-right (vice versa in RTL)
- Added app icons to keyboard quick switch taskviews

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 275629107
Test: launched keyboard quick switch view and changed focus back and forth
Change-Id: Ie2f0a1c08c7065c53075f6fa015000a2d6184491
2023-05-15 12:06:19 -07:00
Schneider Victor-tulias eb8dce01ce Add handling for toggling keyboard stashing from the keyboard
Flag: ENABLE_KEYBOARD_TASKBAR_TOGGLE
Bug: 281726846
Fixes: 246660615
Test: toggled the transient taskbar with the meta+t input
Change-Id: I315f83850b11d24d8b55061d7111300effb43936
2023-05-15 18:41:25 +00:00
Schneider Victor-tulias 581fd3eede Code cleanup: recycle typed arrays when they are no longer needed
The border animator does not need the typed array anymore after initialization. recycling the object.

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 282202504
Test: changed focus in quick switch view and overview
Change-Id: Iea9077e49e754894008899dfc9b90e3876b53051
2023-05-15 11:38:17 -07:00
Treehugger Robot 11939898f3 Merge "Update app ring color and alpha" into udc-dev 2023-05-15 17:33:23 +00:00
Sunny Goyal 4fdc9181dd Adding support for listening to end callbacks when launching an intent from Launcher
Also moving various state handling to these end callbacks enstead of relying on resume

Bug: 265134143
Test: Verified that the end callback is received
Change-Id: I326a99c80154d244c0e49f678717c476602b6240
2023-05-15 10:31:06 -07:00
Treehugger Robot ba4fcb0171 Merge "Fix bug where unstash animation plays twice." into udc-dev 2023-05-13 01:47:20 +00:00
Jeremy Sim ab9e66c260 Merge "Allows splitscreen with work & personal version of the same app" into udc-dev 2023-05-13 00:23:23 +00:00
Jon Miranda e30a551f93 Fix bug where unstash animation plays twice.
Fixes: 282056846
Change-Id: I372444684fafd246369f6bc1e77c5e6fbb651c6f
Flag: ENABLE_TRANSIENT_TASKBAR
Test: open app, then very quickly swipe to unstash taskbar
2023-05-12 16:27:57 -07:00
Schneider Victor-tulias 8f23be7b6f Merge "Fix the overview tutorial step success animation" into udc-dev 2023-05-12 22:40:14 +00:00
Jeremy Sim d27b06f500 Merge "Force Taskbar to remain stashed when in 3p launcher or recents" into udc-dev 2023-05-12 22:08:51 +00:00
Saumya Prakash 24aec5e6b0 Merge "Fix UI issues of fake task view in gesture nav tutorial." into udc-dev 2023-05-12 21:41:38 +00:00
Tony Wickham 53c811fd7d Remove unused/obsolete feature flags
Flag: N/A
Test: N/A
Fixes: 270391641
Fixes: 270395077
Change-Id: I91834b43bf043a26c2fe8e5f7b2e720592830918
2023-05-12 21:09:30 +00:00
Charlie Anderson 438d405aab Adding a new Edit Mode LauncherState
- Edit Mode doesn't close after dragging / dropping an app
	- Edit Mode can be entered through options popup menu, Spring Loaded still entered by dragging items
	- Adds new onLeavingState call to launcher states to cleanup changes

Bug: 279590398
Flag: MULTI_SELECT_EDIT_MODE
Test: manually tested the new state with flag on/off

Change-Id: If4550037f9659dcb8cd8b1943388d1ec5d55fa29
2023-05-12 14:54:45 -04:00
Treehugger Robot 87abc0644b Merge "Cleanup SettingsChangeLogger onClose()" into udc-dev 2023-05-12 17:39:19 +00:00
Schneider Victor-tulias a8ccd542bc Fix the overview tutorial step success animation
- Tapping the screen after a successful overview gesture, but before the delayed success feedbck created a janky experience
- Immediately setting the gesture as successful

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281742006
Test: tapped the screen quickly after successfully completing the overview gesture
Change-Id: I166060191753d6b95bc223e2be08df2bb4b4ecfd
2023-05-12 10:24:39 -07:00
Brandon Dayauon 125e121834 Merge "Separate animations and add dragOffSet points in dragOptions" into udc-dev 2023-05-12 15:22:48 +00:00
Jeremy Sim f4835a8884 Force Taskbar to remain stashed when in 3p launcher or recents
This patch makes it so that the transient Taskbar cannot unstash when in 3P launcher.

Previously, the user was able to unstash Taskbar when in 3P launcher, causing a janky-looking UI (3P launchers may implement their own version of Taskbar on the home screen. This also caused problems with certain Taskbar commands like split screen, which provide an entry portal to Pixel-specific implementations.

Fixed by forcing the Taskbar to stay stashed when a 3P Launcher is displayed. The Taskbar is still usable inside of other non-launcher apps. This was done by using TopTaskTracker to check for ACTIVITY_TYPE_HOME or ACTIVITY_TYPE_RECENTS, and disabling Taskbar when these activities are running.

Fixes: 277963491
Test: Manual
Change-Id: Ifc0f3c07e3b76eb610f93205978fbc596bab6253
2023-05-12 00:32:24 -07:00
Jeremy Sim 92e1eeb5f0 Allows splitscreen with work & personal version of the same app
This patch makes changes in various splitscreen controllers to pass userId to the new shell API, to allow same-app splitting with different users.

Fixes: 274973415
Test: Manual
Change-Id: I810b5353aad738c7c275856586b9c521f1554022
2023-05-11 22:10:51 -07:00
Jerry Chang 303d6101fb Merge "Fix not tracking splitting tasks correctly" into udc-dev 2023-05-12 00:49:21 +00:00
Vinit Nayak f68f1fa3cc Cleanup SettingsChangeLogger onClose()
* Correct name for San*d*box

Bug: 280463854
Flag: none
Test: v2/gnl-eng/unbundled/launcher/nexus_unit_test_multi_device_platform
Change-Id: I2446871c8ea0b146ccfa2ea7caa1727aec42dd42
2023-05-11 16:32:27 -07:00
Winson Chung e04071e19c Merge "Only refresh the launcher resume state when the task launch fails" into udc-dev 2023-05-11 23:31:21 +00:00