Commit Graph

19072 Commits

Author SHA1 Message Date
Treehugger Robot 27c2f4ddc1 Merge "Decouple Backup / Restore Error Codes" into main 2024-12-02 18:57:17 +00:00
Treehugger Robot b5bf7820e6 Merge "Adding MSDL haptics for dragging app icons in Workspace and Hotseat." into main 2024-11-29 08:14:34 +00:00
Stefan Andonian 6df13d3b8e Decouple Backup / Restore Error Codes
Bug: 381315244
Test: Simply looked at emitted error codes and changed names if they were used in multiple locations.
Flag: EXEMPT bug fix
Change-Id: Iab4a8d6ff410682f448b2ac32e44b766d79a7616
2024-11-27 16:48:28 -08:00
Treehugger Robot c4a90de0e9 Merge "Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints" into main 2024-11-27 21:17:43 +00:00
Ana Salazar Maldonado ffef53ecb6 Merge "Fix condition for showing contraste tile" into main 2024-11-27 21:16:38 +00:00
Mykola Podolian 400fc4ad98 Merge changes I239f9357,I57a32ac5 into main
* changes:
  Update setting taskbar window height
  Set bubble bar aligned to QSB
2024-11-27 20:44:53 +00:00
mpodolian 28907bcbd6 Set bubble bar aligned to QSB
Change logic to updated bubble bar alignment with the QSB vertical
center for 3 buttons navigation mode.

Fixes: 378400160
Flag: com.android.wm.shell.enable_bubble_bar
Test: PersistentBubbleStashControllerTest
Test: TransientBubbleStashControllerTest
Test: Manual. Set the buttons navigation mode and observe that the
bubble bar is centered with the QSB when the QSB is not aligned with the
hotseat. Then, switch to gestures navigation mode and observe that the
bubble bar is centered with the hotseat when the QSB is not aligned with
the hotseat.

Change-Id: I57a32ac5bde7a7055b54a89727429424e5c0ca4f
2024-11-27 10:15:08 -08:00
Ana Salazar Maldonado 1e392d6679 Fix condition for showing contraste tile
Merge error caused the condition to only draw contrast tiles for empty
labels.

Bug: 381062398
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: Id2d55d3bc16e76613faca07b0fd28ef01921f016
2024-11-27 10:00:58 -08:00
Marcelo Arteiro 8b63ee3420 Merge "Migrate materialColor* attributes into colors" into main 2024-11-27 14:55:47 +00:00
Ana Salazar Maldonado 9531c19ba3 Merge "Avoid drawing the contrast tile on empty text" into main 2024-11-27 02:57:30 +00:00
Anushree Ganjam 4c390b98f2 Merge "Create ApplicationInfoWrapper with ItemInfo.getTargetPackage() to support DeepShortcuts" into main 2024-11-26 23:08:59 +00:00
Ana Salazar Maldonado 2161355885 Avoid drawing the contrast tile on empty text
Bug: 381062398
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: Ic3199d6263ac3adfd7c270de14439b0095afed1c
2024-11-26 14:52:26 -08:00
Sebastián Franco ded458db94 Merge "Add Event log for FIXED_LANDSCAPE_TOGGLE" into main 2024-11-26 19:44:45 +00:00
Anushree Ganjam 61d0c95f76 Create ApplicationInfoWrapper with ItemInfo.getTargetPackage() to support DeepShortcuts
Follow up fix for
https://googleplex-android-review.git.corp.google.com/c/platform/packages/apps/Launcher3/+/29586180/9/src/com/android/launcher3/popup/PopupPopulator.java#119
and crash since componentName can be null for Deep shortcuts.

Bug: 375567866
Test: Presubmit
Flag: EXEMPT Bugfix
Change-Id: I5b20248a3cc87cf044aac9848aed4cbeb6d5b092
2024-11-25 20:14:41 -08:00
fbaron 493583435b Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: I391e001ddee454baccbc0a8f1e002cc815722239
2024-11-26 00:38:19 +00:00
Sebastian Franco 8fc5f39007 Add Event log for FIXED_LANDSCAPE_TOGGLE
Bug: 364711735
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I154839e78a197444ccbcbd86bba101865c6a964b
2024-11-22 15:35:35 -08:00
Ana Salazar Maldonado f18e02fa7b Merge "Avoid drawing the launcher pill outside the view bounds" into main 2024-11-22 22:13:38 +00:00
Ana Salazar Maldonado f9884f20f3 Avoid drawing the launcher pill outside the view bounds
When drawing the launcher pill, the round rect corners may extend a little
beyond the view bounds.  Add a small padding for the round rect corners around
the text view to avoid drawing out of bounds for the view.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I41cd2ad9909081cb66751d7f03e52f03f8ae928b
2024-11-22 11:06:14 -08:00
Juan Sebastian Martinez a91fbb2efd Adding MSDL haptics for dragging app icons in Workspace and Hotseat.
The feedback occurs when an icon hovers over an empty available space in
Workspace and Hotseat, as well as over other icons to create folders.
This is now compliant with the Multi-sensory Design Language spec.

Test: manual. Verified haptics while dragging icons over Workspace and
  Hotseat.
Test: manual. Verified haptics with adb shell dumpsys of Launcher and
  checking the MSDL token history.
Flag: com.android.launcher3.msdl_feedback
Bug: 371314631

Change-Id: I7d039ddf9d05faa39a6e6e3f9a84217d8916adc0
2024-11-22 10:31:18 -08:00
Juan Sebastian Martinez 12c5b06add Merge "Adding a mock for MSDLPlayerWrapper to DeleteDropTargetTest." into main 2024-11-22 18:21:05 +00:00
Treehugger Robot 05e02fae43 Merge "Add logs for grid migration" into main 2024-11-22 15:52:00 +00:00
Treehugger Robot f2f8cd7536 Merge "Remove redundant a11y announcement upon removal of workspace item." into main 2024-11-22 15:49:35 +00:00
Pinyao Ting 604ae3283c Remove redundant a11y announcement upon removal of workspace item.
When a workspace item is removed, launcher currently shows a Snackbar which contains a message saying "item removed". This renders the a11y announcement in DeleteDropTarget#onAccessibilityDrop redundant since it's saying exactly the same string.


Bug: 378032433
Change-Id: Iaf3b42404ecd382b1ee15f670cc4ebe0124218d2
Test: manual
Flag: EXEMPT bugfix
2024-11-22 00:34:03 +00:00
Brandon Dayauon 90ff53775a Merge "Fix keyboard staying up in AOSP launcher." into main 2024-11-21 22:06:11 +00:00
fbaron 4f1e64c8e6 Add logs for grid migration
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: n/a it's just logs
Change-Id: Icce21f507e07adfd954fd88634bdd7f0becf4a4c
2024-11-21 13:59:39 -08:00
Juan Sebastian Martinez 86f3d35839 Adding a mock for MSDLPlayerWrapper to DeleteDropTargetTest.
The mock makes sure we don't rely on a device hardware for tests.

Test: DeleteDropTargetTest
Flag: com.android.launcher3.msdl_feedback
Bug: 379958544
Change-Id: I202b81f3dd16af1c0985980d0b962be0000bf31f
2024-11-21 13:32:43 -08:00
Marcelo Arteiro bc02103a6a Migrate materialColor* attributes into colors
TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this  developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.

Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2
2024-11-21 13:08:11 +00:00
Sebastian Franco cb8f82a9fd Remove Allow Rotation in foldables
Fix: 380128987
Flag: com.android.launcher3.one_grid_specs
Test: NA
Change-Id: I4bdb495b57fa7d638dde3fe47e853f3505f63628
2024-11-20 15:42:43 -08:00
Brandon Dayauon c2f4537495 Fix keyboard staying up in AOSP launcher.
The keyboard doesn't close when swiping down from A-Z list. So in Launcher when going to any state from A-Z getAPpsView().reset() gets called which eventually
calls resetSearch() where we can hideKeyboard.

bug: 379052503
Test: before in bug
after: https://drive.google.com/file/d/11oVTvkBtj9rECEtz4IVH1tURaJz6pFTO/view?usp=sharing
Flag: NONE bug fix
Change-Id: I707bf5dc2f81d5e83e869e34de674ef7fc065486
2024-11-20 14:30:41 -08:00
Schneider Victor-tulias 602dc74c5b Merge "Fix broken first gestures when using recents window" into main 2024-11-20 21:13:34 +00:00
Schneider Victor-Tulias c14e143338 Fix broken first gestures when using recents window
The first gestures fail to finish the recents animation controller when using the recents window tracker. This change fixes several test failures and makes gesture nav more stable on launcher restart.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 377679001
Test: TAPL tests
Change-Id: I617a27238a834dc734c9ae036045f159b06fd004
2024-11-20 11:44:19 -05:00
Juan Sebastian Martinez 9241d291aa Merge "Adding MSDL history to Launcher's dump information." into main 2024-11-20 16:11:03 +00:00
Treehugger Robot 5b1796daeb Merge "Fix inaccurate ItemInfo.id from DatabaseHelper with AtomicInteger" into main 2024-11-20 07:05:50 +00:00
Fengjiang Li be930c838f Fix inaccurate ItemInfo.id from DatabaseHelper with AtomicInteger
We can have both bg and UI threads accessing DatabaseHelper to read/write mMaxItemId, thus we should use AtomicInteger to avoid producing duplicated id, which will fail ModelWrite#checkItemInfoLocked

Fix: 379490918
Test: presubmit
Flag: NONE - crash fix
Change-Id: I6cebbb7e854a9eb48ff59b61f5ebba42ea449ec7
2024-11-19 21:18:26 -08:00
Juan Sebastian Martinez 4c35e50dd4 Adding MSDL history to Launcher's dump information.
The history displays the latest tokens played. Useful for testing and
debugging.

Test: presubmit
Flag: NONE MSDL playback is flagged case by case.
Bug: 377496684
Change-Id: I163889ade9fe4dee7f02459d2d9d81b94197bea1
2024-11-19 15:44:39 -08:00
Juan Sebastian Martinez 3f0d356619 Merge "Adding MSDL feedback to dragging apps and widgest over drop targets." into main 2024-11-19 15:58:35 +00:00
Sebastián Franco 3448777679 Merge "Changing name of RowCount to GridDimension to be more general" into main 2024-11-19 05:36:43 +00:00
Shamali Patwa d2cc1f0577 Update the enforce_system_radius_for_app_widgets flag's type
Renamed to use_system_radius_for_app_widgets since metadata cannot be updated after submitting definition.

Bug: 373351337
Test: N/A flag metadata update
Change-Id: I25283b05341517f5984b0f2fc0d27efe8027a3de
Flag: com.android.launcher3.use_system_radius_for_app_widgets
2024-11-18 21:58:48 +00:00
Jeremy Sim ec788cb24d Merge "Migrate away from listening for main/side specific stage types" into main 2024-11-18 18:41:38 +00:00
Sebastián Franco fefe9bbd12 Merge "Making the QSB align in Fixed Landscape" into main 2024-11-18 18:34:00 +00:00
Ana Salazar Maldonado 933baa72cf Merge "Draw contrast tile around the text" into main 2024-11-18 18:20:56 +00:00
Liana Kazanova (xWF) bd5afcfdda Merge "Revert "Remove redundant a11y announcement upon removal of workspace item."" into main 2024-11-18 17:24:25 +00:00
Charlie Anderson 6edad19ce2 Merge "Clean up usage of FileLog, and some logging related to B&R" into main 2024-11-18 14:23:09 +00:00
Johannes Gallmann cd46d978bd Merge "Never scale navbar scrim in all apps and widget picker" into main 2024-11-18 08:20:46 +00:00
Brandon Dayauon 519be86c57 Merge "Add perfetto traces to privateProfile CUJs" into main 2024-11-18 06:41:43 +00:00
ESWAR MAGATAPALLI (xWF) 9707b2cd0d Revert "Remove redundant a11y announcement upon removal of workspace item."
This reverts commit 556db6df04.

Reason for revert: Droidmonitor created revert due to b/379322118. Will be verifying through ABTD before submission.

Change-Id: Iece717248c63b3b8dabcdf1c413309d24f51c37f
2024-11-18 02:40:15 +00:00
Himanshu Gupta dad333da84 Merge "Handle Quiet Mode for Work Profile gracefully when Pixel Launcher is not default." into main 2024-11-17 16:57:15 +00:00
Treehugger Robot ebe64c7cc2 Merge "Add new heuristic for deciding whether we should add extra rows on grid migration to the bottom or top of the grid" into main 2024-11-16 00:55:02 +00:00
Sebastian Franco 5353cd8626 Making the QSB align in Fixed Landscape
Fix: 378959186
Fix: 378959255
Bug: 364711735
Test: HomeScreenImageTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I36612949006f12929cdc5b21f27f20ebc9751201
2024-11-16 00:39:44 +00:00
Fengjiang Li f6f4c18ff9 Merge "Revert "Revert AllAppsRecyclerViewPoolTest.kt"" into main 2024-11-16 00:09:23 +00:00