Commit Graph

16119 Commits

Author SHA1 Message Date
Sebastián Franco 2a40823a78 Merge "Fixing test that fail when FOLDABLE_SINGLE_PAGE is set to true" into udc-dev 2023-03-21 22:32:42 +00:00
Federico Baron 28a8d5a14c Merge changes I8ccf962f,I383c7540 into udc-dev
* changes:
  Turn on the flag for large screen widget picker
  Add test for widget picker on landscape mode for tablets
2023-03-21 22:28:18 +00:00
Pinyao Ting bb90cfb25a Merge "Retains cached widget in launcher process" into tm-qpr-dev am: a35d04afef am: bb38c78fa5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146535

Change-Id: I825f19436115fbfa3279ba2182305cd9825b27dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-21 21:25:06 +00:00
Pinyao Ting bb38c78fa5 Merge "Retains cached widget in launcher process" into tm-qpr-dev am: a35d04afef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146535

Change-Id: Ib434ecc52eb81643a6513071cd66e189f427de4e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-21 20:29:50 +00:00
Pinyao Ting a35d04afef Merge "Retains cached widget in launcher process" into tm-qpr-dev 2023-03-21 20:15:41 +00:00
Tony Wickham 5513239387 Merge "Update folder leave-behind color for taskbar" into tm-qpr-dev am: 0165aa82c6 am: f497c59b5e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21968430

Change-Id: Ie80383899e7881512b4434f72a43df7328f36113
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-21 18:43:20 +00:00
Pinyao Ting bd638e7b41 Retains cached widget in launcher process
Currently cached widget are retained in LauncherWidgetHolder which is
released when Launcher activity is recreated. This CL moves the cached
widget into LauncherAppState to keep the cache alive.

Bug: 268189435
Test: steps below
1. Add multiple widgets (Calendar / Weather ... e.t.c) to Home Screen
2. Open Google Map, start navigation to any place
3. Google Map enters navigation mode and changes resolution
4. Swipe up to exit Google Map and go to Home Screen
5. Verify you don't see deferred widget host view.

Change-Id: I8b56167313780cd1be2a5da88517114acc6d44af
2023-03-21 11:04:31 -07:00
Tony Wickham f497c59b5e Merge "Update folder leave-behind color for taskbar" into tm-qpr-dev am: 0165aa82c6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21968430

Change-Id: Ifd652848a3006de0c975410623ed3f59c8f17023
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-21 18:04:28 +00:00
Saumya Prakash d3eadb74d3 Merge "Enable the redesigned gesture navigation tutorial" into udc-dev 2023-03-21 17:39:00 +00:00
Federico Baron ac978187a7 Turn on the flag for large screen widget picker
Bug: 256684299
Test: N/A
Change-Id: I8ccf962faab42c3ea012ddcf4650ded01cfaf7f2
2023-03-21 16:48:12 +00:00
Federico Baron c3ab820144 Add test for widget picker on landscape mode for tablets
When we added widget picker two pane layout, it broke some tests with the flag on. Here we fix those tests.
Bug: 256684299
Test: AddWidgetsTest and TaplTestsLauncher3#testWidget

Change-Id: I383c754016d82fba51fa0b7b0459cd7e83b274d8
2023-03-21 16:48:12 +00:00
Tony Wickham 0165aa82c6 Merge "Update folder leave-behind color for taskbar" into tm-qpr-dev 2023-03-21 16:38:46 +00:00
Jon Miranda 6e816aaf37 Merge "Add a way to fade out taskbar view when closing an app in the taskbar." into tm-qpr-dev am: 149246f077 am: ce06cf89b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22141153

Change-Id: I919b45021c1fbc2a5d5c30c2d5eca71a672cd5be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-21 14:14:43 +00:00
Jon Miranda ce06cf89b0 Merge "Add a way to fade out taskbar view when closing an app in the taskbar." into tm-qpr-dev am: 149246f077
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22141153

Change-Id: Ia0212c2829b01c5b0faf120d6303b7cf6d147ad6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-21 13:33:32 +00:00
Jon Miranda 149246f077 Merge "Add a way to fade out taskbar view when closing an app in the taskbar." into tm-qpr-dev 2023-03-21 13:01:30 +00:00
Saumya Prakash 5a7a23bd3c Enable the redesigned gesture navigation tutorial
Bug: 270396257
Bug: 241813570
Test: N/A
Change-Id: I49a548b69da37aecf422c08b932592befc1a2cf8
2023-03-20 23:30:35 +00:00
Jon Miranda 4202d43e48 Merge "Tune springs when app animates home into the hotseat on devices with a taskbar." into tm-qpr-dev am: fad8c1c449 am: 03bb5fe49c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146526

Change-Id: I0adde19b10d0bf6c25c5025453fd361a0804cf62
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 22:12:54 +00:00
Jon Miranda 03bb5fe49c Merge "Tune springs when app animates home into the hotseat on devices with a taskbar." into tm-qpr-dev am: fad8c1c449
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146526

Change-Id: Iaa1d5cf3e030398c97841fe604ad923cce4e25e7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 21:34:11 +00:00
Sunny Goyal 717072d1d5 Merge "Scale folder if it doesn't fit the screen" into tm-qpr-dev am: d2a34a2d54 am: 92e392d55b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22139063

Change-Id: I5df3d13170ae2125f9113f0c3cd41d9c47b093a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 21:13:42 +00:00
Jon Miranda fad8c1c449 Merge "Tune springs when app animates home into the hotseat on devices with a taskbar." into tm-qpr-dev 2023-03-20 20:54:27 +00:00
Sunny Goyal 92e392d55b Merge "Scale folder if it doesn't fit the screen" into tm-qpr-dev am: d2a34a2d54
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22139063

Change-Id: I9e77f805e0b3e198ef44a075f6176b9fcc8f6cd9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 20:27:54 +00:00
Sunny Goyal d2a34a2d54 Merge "Scale folder if it doesn't fit the screen" into tm-qpr-dev 2023-03-20 20:01:52 +00:00
Stefan Andonian 6da4ac41cc Merge "Revert "Revert "Enable CONTINUOUS_VIEW_TREE_CAPTURE FeatureFlag.""" into udc-dev 2023-03-20 19:02:12 +00:00
Jon Miranda c0c1c55c5d Add a way to fade out taskbar view when closing an app in the taskbar.
Prior to this change, if taskbar is showing and we are cloing an app
that is visible in the taskbar, the taskbar view would immediately
disappear.

Now we will fade out the view until the animation is 33% complete,
at which point the 'space' will be clear for the FloatingIconView
to settle at its final location.

Bug: 273961611
Test: open app in hotseat
      note that the taskbar view is gone immediately
      have taskbar visible, close app that is shown in taskbar
      note that the taskbar view fades out

Change-Id: I5589e2ce3033cfa19669d1bfaf568aef2a96015e
2023-03-20 18:21:42 +00:00
Jon Miranda 18c53ac26b Tune springs when app animates home into the hotseat on devices
with a taskbar.

Thought about using the Builder pattern here but the CL becomes
much larger due to SwipePipToHomeAnimator having its own
Builder.

Bug: 268026344
Test: swipe up to close app thats in hotseat
      swipe back to close app thats in hotseat

Change-Id: Idd0729224374579753fc91c7820f3b04a7d3e1a4
2023-03-20 10:56:43 -07:00
Jon Miranda a479a6e3fd Merge "Keep foreground drawable centered during app open/close animation." into tm-qpr-dev am: ad94440c5f am: d0c8aa31bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22140592

Change-Id: Iee4811dc9cef70e390514106cbc32ea618d1b759
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 17:23:17 +00:00
Sebastian Franco 25423867af Fixing test that fail when FOLDABLE_SINGLE_PAGE is set to true
We need to change the result of REQUEST_IS_TWO_PANELS when the
flag is on because now we don't have two panels only 1.

Another of the issues is a rounding error when calling
getUnusedHorizontalSpace().

And lastly updating workspaceToBoards so that it maps the coordinate
of workspace items to their right position.

Bug: 270395274
Test: atest ReorderWidgets
Change-Id: I2620e5bf1ba132f984e00d2a6c21081953d259fd
2023-03-20 17:06:20 +00:00
Stefan Andonian 053a7e3743 Revert "Revert "Enable CONTINUOUS_VIEW_TREE_CAPTURE FeatureFlag.""
This reverts commit 17f7406a5e.

Reason for revert: To be submitted after the fix for b/273614966 is downstream merged into udc-dev (ag/22102493).

Change-Id: I3038b46776815069898829e46321885278b1caff
2023-03-20 16:59:29 +00:00
Jon Miranda d0c8aa31bd Merge "Keep foreground drawable centered during app open/close animation." into tm-qpr-dev am: ad94440c5f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22140592

Change-Id: I7c5c1c5f39906eb5e4f5caff4ec4a8c828e5300c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 16:45:42 +00:00
Sunny Goyal 19691f60f1 Merge "Fixing overscroll getting lost due to float point comparision" into udc-dev 2023-03-20 16:16:18 +00:00
Jon Miranda ad94440c5f Merge "Keep foreground drawable centered during app open/close animation." into tm-qpr-dev 2023-03-20 16:14:43 +00:00
Jon Miranda f23e2d1e16 Keep foreground drawable centered during app open/close animation.
For apps that use AdaptiveIcon, we used to animate the foreground
drawable independently from the background. This is sometimes
perceived as jank so we remove the animation since it is very subtle
in the best case scenario.

Bug: 268026344
Test: open/close apps/folders that use AdaptiveIcons
Change-Id: I500bf56e04823757d511d909a93d3b30703249a1
2023-03-20 16:13:02 +00:00
Sunny Goyal b7c0f3c386 Fixing overscroll getting lost due to float point comparision
When swipping back from overscroll, deltaX becomes close-to-0
causing the equality check (deltaX != 0) to fail. This
causes the overscroll to jump.
Platform views like HorizontalScrollView use int instead of
float to avoid this.

Bug: 273828110
Test: Verified on device that the overscroll finishes smoothly
Flag: N/A
Change-Id: I140750a2bdc39cebcbeb8ea83bb38efb0449dd5a
2023-03-17 13:30:59 -07:00
Sunny Goyal feca2d8700 Merge "Simplifying some page indicator dots attributes so that it can be easily modularized" into udc-dev 2023-03-17 19:02:01 +00:00
Thales Lima 7eee74b3f8 Scale folder if it doesn't fit the screen
Scale folder attrs if a full folder doesn't fit the screen width. This will make icons and text smaller than the workspace.

As a follow-up, another bug will be created to only scale full folders instead of all folders.

Bug: 271554689
Test: manually create a full folder, change the display size to large+
Change-Id: I47dc4bd4fe0c9eae989095fc1d179b81d350ef77
2023-03-17 14:13:04 -03:00
Charlie Anderson e1f1fd0924 Merge "Revert "Revert "flip app shortcut popup design on for U""" into udc-dev 2023-03-17 16:33:47 +00:00
Mike Schneider 06abb655f1 Merge "Add optional debug logging to on flag changes" into tm-qpr-dev am: 8daf6d804e am: ea674e208c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21868395

Change-Id: I3e7c7a84bcaaf37bb55225ea714c46fea999a067
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-17 09:04:47 +00:00
Mike Schneider ea674e208c Merge "Add optional debug logging to on flag changes" into tm-qpr-dev am: 8daf6d804e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21868395

Change-Id: I8a871b40687dffb7feb45fb7da9b27727e36ba97
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-17 08:28:05 +00:00
Mike Schneider 8daf6d804e Merge "Add optional debug logging to on flag changes" into tm-qpr-dev 2023-03-17 07:54:33 +00:00
Charlie Anderson 7c7ccbb2ad Merge "Fixes tests and issues when toggling new app shortcut popup flag." into tm-qpr-dev am: d4eed6ec90 am: cd6fd73639
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21992972

Change-Id: Id79a204f2f489e35829f2336743d1a06cd0d9908
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-17 01:21:16 +00:00
Charlie Anderson cd6fd73639 Merge "Fixes tests and issues when toggling new app shortcut popup flag." into tm-qpr-dev am: d4eed6ec90
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21992972

Change-Id: Ic4c29770d9b485252bc8e12e7666f8ab0598cdec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-17 00:45:25 +00:00
Charlie Anderson d4eed6ec90 Merge "Fixes tests and issues when toggling new app shortcut popup flag." into tm-qpr-dev 2023-03-17 00:15:54 +00:00
Brandon Dayauon 678da0e9c4 Merge "Set textSize and compound drawable padding for mDisplay == DISPLAY_SEARCH_RESULT" into tm-qpr-dev am: 26958a0961 am: d8ae733516
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22079203

Change-Id: I8cbeee78df7e0b6474cf277689af3b65f5773808
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-16 23:29:34 +00:00
Brandon Dayauon d8ae733516 Merge "Set textSize and compound drawable padding for mDisplay == DISPLAY_SEARCH_RESULT" into tm-qpr-dev am: 26958a0961
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22079203

Change-Id: Ic18cf7d1cd4e0605202461dc0c1cb1f39cb3f25e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-16 23:11:49 +00:00
Sunny Goyal a5ead45967 Simplifying some page indicator dots attributes so that it can
be easily modularized

> Moving the color configuration to xml
> Moving auto-hide logic to a subclass as it doesn't
  need to be in the main library

Bug: 274011949
Test: Verified on device
Change-Id: Icf7bd5d1cbde3daa9441f2af51f98a931bcd6ee2
2023-03-16 15:57:06 -07:00
Brandon Dayauon 26958a0961 Merge "Set textSize and compound drawable padding for mDisplay == DISPLAY_SEARCH_RESULT" into tm-qpr-dev 2023-03-16 22:52:47 +00:00
Fengjiang Li d44129149c Merge "[Predictive Back] Remove OnBackPressedHandler" into udc-dev 2023-03-16 21:18:11 +00:00
Tony Wickham ec6fd6ffb5 Update folder leave-behind color for taskbar
Test: open folder in light theme and dark theme
Fixes: 265828742
Change-Id: Ib544ab85dad16c203917ae02f924650e8a5bbc6f
2023-03-16 18:13:20 +00:00
Fengjiang Li b7860bd85e [Predictive Back] Remove OnBackPressedHandler
OnBackPressedHandler was mimicking android.window.OnBackAnimationCallback because later one was hidden API to T.

Now that we have moved to U, we can remove the former handler.

Test: manual
Bug: 272797556
Change-Id: Ic5302cfa0a6fb15c4a64bdf5dc331834b1f06f38
2023-03-16 09:39:31 -07:00
Charlie Anderson 3a2a69ab3d Fixes tests and issues when toggling new app shortcut popup flag.
Bug: 247880037
Test: manually tested app popup. Also ran Launcher tests locally with U flag on/off.
Change-Id: I93c04f9715d583376c36d823c23353619afd26b6
2023-03-16 12:37:14 -04:00