This CL makes it so that app pair creation includes updating some flags on the newly created WorkspaceItemInfos -- specifically the FLAG_NON_RESIZEABLE flag. Previously, flag updating only happened upon launcher restart or package change, which meant that newly created app pairs were missing some flags.
This caused App+Camera pairs to not have the FLAG_NON_RESIZEABLE flag immediately on app pair creation, which affected the disabled state.
Fixes: 323088270
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I96c6ec3723bec2ddaa0af625890b983faf2fe2c7
This CL fixes 2 issues with app pairs:
- When an app pair is incompatible with the screen size due to a non-resizeable app (e.g. Camera), the app pair will now be properly disabled and display an error message. If the user is on a foldable, it will prompt the user to unfold their phone.
- The app pair icon will now properly redraw with lower opacity when it is disabled.
Fixes: 323088270
Test: Manually paused and unpaused apps, created Camera app pairs and tested with foldable
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I66514c96bc19f480c9788661e4dffaa5b1cdc2ca
I’ve never seen a useful failure from these checks, and now I’m seeing a false positive error. That error is fixable by reworking the code, but I think the value of these checks is not worth the effort.
Bug: 322823209
Test: presubmit
Flag: N/A
Change-Id: If675dad254fb82a2a842ef3f9054936f38de1cff
When saving app pairs, we should grab attributes[0] and attributes[1] instead of attributes[0] and attributes[0].
Fixes: 326854996
Test: App pairs saves the correct two apps
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I8d2fc4597cf1f1bd36bc0b910cc022c79a48f067
Flag: N/A
Fixes: 324228222
Test: forcicly set SystemUiProxy.mRecentTasks to null. multiple startRecentsActivity call attempts were made rather than just one
Change-Id: I2e5f8cc0cf47a143dcd7985b31292bb4d8cbbcad
The predictive back infra checks the opt-in status when a callback is registered, and drops the registration if the Application / Activity is not opted-in
Fix: 326627953
Test: manual
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Change-Id: I8f2e2378d0bf966b3784cf08c12045509b6d5682
This change addresses a recent regression that caused quick switch to not scale up to full screen during the launch animation.
Fix: 326625526
Test: Launch quick switch from home and ensure it is a smooth transition
Flag: N/A
Change-Id: Id94d5d3eae0625225f880897e1e5f3cf9e4fea6c
For devices with a camera cutout, we only need the increased inset to
accomodate a camera cutout on the sides/orientations where the cutout
interrupts the taskbar. This change ensures that the insets are only
added when necessary.
Fix: 325508089
Test: Open an app and ensure the insets remain unchanged for 0 and 90
degree rotations. Ensure the insets for 180 and 270 degrees are still
covering the camera cutout.
Flag: N/A
Change-Id: I3ee14ffc84d72512acdb750d0f614acacefc7639
This reverts commit 21ab3b979b.
Reason for revert: Culprit for b/326611479. Will be verifying through ABTD for confirmation and before submitting the revert.
Change-Id: Ib71791d159b3ac65ca332f58500341a1a0fe36e1
- Currently when runningTaskId is -1, it can skips setting contentAlpha for all TaskViews if they haven't been loaded, this cause RecentsView to become empty in the bug
- Can be reproduced with excludeFromRecents=true apps
Bug: 324495241
Test: swipe up from an app that has excludeFromRecents=true, e.g.
Volume Dialog, Home quick settings tile, and Routines widget; ensure RecentsView is visible after gesture settles
Flag: None
Change-Id: I9f1b4ffed6d09805c83c6e2241903c73d4ead9ad
Other parts of the animation rely on currentRectF to remain stable, therefore we shouldn't modify the RectF object in place.
Bug: 323628523
Flag: NONE
Test: Manual, i.e. verifying that widget close (and app close) animation animates correctly regardless of device orientation
Change-Id: I48e9ed047b956db654192eef39e5d94fbac53553
Bug: 321923510
Bug: 321968468
Flag: ACONFIG com.android.systemui.predictive_back_system_animations TEAMFOOD
Test: Manual, i.e. verifying that recents transition is not invokable during the predictive back to home animations and instead the flickerless overview transition is is invoked (same as for regular back-to-home)
Change-Id: I90029de8d0c98853d38ed8984cbe7cda3b566b5a
This CL changes the way app pairs are saved. Previously, we saved the app pair using WorkspaceItemInfos directly from Recents, which caused certain apps to fail on launch because they weren't being launched with the correct Intent.
Now, we look up a proper launchable WorkspaceItemInfo from the AllAppsStore and save that to the app pair, which should fix the launch issues.
Bug: 323112914
Bug: 323110399
Test: Can launch Slides, Play Store, and Calendar when part of an app pair.
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I475afa1a237c50ffb0ffaf85af43912a803b8011
Better conform to documentation about how to use widget sizes when
filtering for sizes in WidgetPickerActivity.
Bug: 322191186
Test: atest Launcher3Tests
Flag: NA
Change-Id: I4239e64dd620e00a3c55046bfb66fe3099336aac
Make the DesktopVisibilityController not change the taskbar visibility
when there are no freeform tasks visible.
Test: Go from freeform to fullscreen, observe taskbar doesn't pop up
Bug: 323129412
Flag: ACONFIG com.android.wm.shell.enable_desktop_windowing DEVELOPMENT
Change-Id: I67f246cfc2ddc198326c093fd0af83886de8b0a9
This "migration" feature was planned as an effort to reduce latency upon
startup. That being said, now that there is a loading screen being added
to pixel startup time, it doesn't make sense to perform a risky data
migration just to save a 100ms or so of startup time. Therefore, I am
removing this code as a clean up effort to make LauncherPrefs simpler.
Also, there was a cyclical dependency introduced in b/324670265 that
makes this cleanup effort especially worthwhile, as it resolves a bug
for other developers.
Bug: 324670265
Test: Installed this on a device and tested that nothing was broken.
Flag: NA
Change-Id: I81df710057d80fbd071bc26a53cb191d453e7dee
Issue : Currently opposite jank is being reported taskbar expand and taskbar collapse
Test: Checked the trace
Fixes: b/326333977
Flag: None
Change-Id: Ib5adeb33506717ee28d669c5d46557087ebf7e60
Jeremy Sim
Schneider Victor-tulias
Sam Cackett
Treehugger Robot
Uwais Ashraf
Luca Zuccarini
Helen Cheuk
Vadim Tryshev
Orhan Uysal
Fengjiang Li
Saumya Prakash
William Leshner
Johannes Gallmann
Priyanka Advani
Pat Manning
Alex Chau
bvineeth
Bill Yi
Sunny Goyal
Anushree Ganjam
Sebastián Franco
Jagrut Desai
Stefan Andonian