Commit Graph

2699 Commits

Author SHA1 Message Date
Vinit Nayak 2fea4c6f1b Merge "Refactor SplitSelectStateController to add testing" into tm-qpr-dev am: c9120521ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21487925

Change-Id: Id91fe8d96fbcc1cdad9ef59610c934e59c441410
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 22:30:50 +00:00
Vinit Nayak 4e3636e8d0 Refactor SplitSelectStateController to add testing
Bug: 266482558
Change-Id: I2d62a3a310043710d66a26bc533df2309084b81e
2023-02-22 10:51:49 -08:00
Tony Wickham c8207a7e23 Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev am: 3d1bb16493
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21533764

Change-Id: I04cbb24dc071677a8e6f5c4fa8981efc5bec6d34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 16:59:30 +00:00
Tony Wickham 3d1bb16493 Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev 2023-02-22 16:24:48 +00:00
Pat Manning 3eadaa7d77 Merge "Animate grid tasks to modal state." into tm-qpr-dev am: 1b27affb03
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21060663

Change-Id: I3fc5d3fde2fadf3e95383c3827be7901b3712ef5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 13:00:42 +00:00
Pat Manning 1b27affb03 Merge "Animate grid tasks to modal state." into tm-qpr-dev 2023-02-22 11:18:47 +00:00
Tony Wickham b506ae73b0 Merge "Fix a couple of drag and drop issues from transient taskbar" into tm-qpr-dev am: 2a567ec85a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21527497

Change-Id: Ica30f4d7a313b5966b8ca72654f4002e581faf31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 05:23:21 +00:00
Tony Wickham 00f89fbbf6 Fix taskbar drag view scale when returning to original icon
- Use getSourceVisualDragBounds() if the target view is BubbleTextView;
  this accounts for padding as well as extra ring inset for
  PredictedAppIcon
- Also ensure we always use the final drag view scale when switching to
  the system drag and drop, instead of using the current scale which
  might be in the process of animating

Test: drag regular and predicted icons in taskbar, but drop it in a
region that doesn't accept it (e.g. the taskbar itself), check that the
return animation scales and offsets more correctly than before
Bug: 269814838

Change-Id: Ie8398b2617340e1d2568773563aa0263a3366940
2023-02-22 03:41:03 +00:00
Tony Wickham 2a567ec85a Merge "Fix a couple of drag and drop issues from transient taskbar" into tm-qpr-dev 2023-02-22 03:38:38 +00:00
Vinit Nayak 06ed4db282 Merge "Move split functions from RecentsView to SplitSelectStateController" into tm-qpr-dev am: 54c262cd67
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21468212

Change-Id: Id6f868aa87f0ba53673764f412d12ed936f78aea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 02:50:49 +00:00
Vinit Nayak 54c262cd67 Merge "Move split functions from RecentsView to SplitSelectStateController" into tm-qpr-dev 2023-02-22 02:15:46 +00:00
Tony Wickham 16cfed3d1f Fix a couple of drag and drop issues from transient taskbar
- Don't stash until drag ends, but immediately stash at that point
  (regardless of success or failure, though failure will animate to the
  original icon before stashing)
- Send transient taskbar's bounds to WM Shell via intent extra such that
  they ignore drag events in that region

Test: manual in persistent and transient taskbar
Bug: 269814838
Fixes: 268526633
Fixes: 259645384
Change-Id: I5ded3998046f259ed6e79cb4ed765ad7b0c72e45
2023-02-22 00:46:51 +00:00
Winson Chung 0e9de04dfb Merge "Fix issue with global drag from taskbar being disabled" into tm-qpr-dev am: d30ef72606
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21491928

Change-Id: I0e22beac88c2dd89078767d1846fb3470a8b26d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 00:17:27 +00:00
Winson Chung d30ef72606 Merge "Fix issue with global drag from taskbar being disabled" into tm-qpr-dev 2023-02-21 22:50:31 +00:00
TreeHugger Robot f94e71eca0 Merge "Remove setImeIsVisible/setTouchesEnabled as its already handled by insets." into tm-qpr-dev am: 73a2334f7f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20590940

Change-Id: Ie07cb2abf9cadb3812014585691e58cf63c5baf6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 21:45:28 +00:00
Schneider Victor-tulias 42f0aaac4b Merge "Keyboard quick switch polish" into tm-qpr-dev am: 8129ebfd04
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21466357

Change-Id: I55765649648db123f919699ffd6f42c787bf9ddc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 21:44:54 +00:00
Jon Miranda 2bd32abb3f Merge "Seamless handoff between stashed handle and taskbar." into tm-qpr-dev am: 6bb01ee8ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21486650

Change-Id: I3b2f7b368eb7007886e415391585e3725d9dcd82
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 21:44:41 +00:00
TreeHugger Robot 73a2334f7f Merge "Remove setImeIsVisible/setTouchesEnabled as its already handled by insets." into tm-qpr-dev 2023-02-21 21:15:22 +00:00
Schneider Victor-tulias 8129ebfd04 Merge "Keyboard quick switch polish" into tm-qpr-dev 2023-02-21 21:03:30 +00:00
Jon Miranda 6bb01ee8ca Merge "Seamless handoff between stashed handle and taskbar." into tm-qpr-dev 2023-02-21 20:09:41 +00:00
TreeHugger Robot 90cf9e6855 Merge "Translate the taskbar icons to match nav handle shape." into tm-qpr-dev am: 9769b2844c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21452616

Change-Id: Icfa1d57cb210098675ef70313c675f62c29b5e61
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 04:34:48 +00:00
TreeHugger Robot 9769b2844c Merge "Translate the taskbar icons to match nav handle shape." into tm-qpr-dev 2023-02-21 03:24:41 +00:00
Jon Miranda 7a73f3ee82 Seamless handoff between stashed handle and taskbar.
Bug: 267806083
Bug: 246634367
Test: manual
Change-Id: I0c3d7a19aaa36a323c6fb3349852727f56842bb2
2023-02-21 01:42:30 +00:00
Pat Manning 550181e69e Animate grid tasks to modal state.
Bug: 265641913
Test: OverviewActionsControllerTest.java
Change-Id: I5cfa5bc3a9e0fdc024d0d709bfb2b5eccd6ea5a2
2023-02-20 17:10:01 +00:00
Winson Chung 3bce15d2a2 Fix issue with global drag from taskbar being disabled
- BackgroundAppState extends OverviewState, so in some cases we will
  transition to background app, which inadvertently triggers global
  drag and drop from being enabled

Bug: 269819279
Test: Enter split, cycle the screen and try to drag an app from the
      transient bar
Change-Id: I0e8c5e8bbaa0220fc870d2db866152864253010f
2023-02-18 06:34:08 +00:00
Vinit Nayak c97bb4600f Move split functions from RecentsView to SplitSelectStateController
* Moving things out of RecentsView to avoid
dependency on a non-testable class
* Also helping prevent bloating RecentsView.java

Bug: 266482558
Test: Single Chrome instance in recents. Initiate split
with Chrome from workspace, tap on Chrome again in Taskbar,
ensure no crash.

Change-Id: I99ec704479ffaa860f4d80c2cb9f54182f31f41a
2023-02-17 17:28:08 -08:00
Jon Miranda ddb909603a Remove setImeIsVisible/setTouchesEnabled as its already handled by insets.
Bug: 260101467
Test: manual
Change-Id: Iba22a6db61abd4be0b2a15b2e4099d9bc03ddbc9
2023-02-18 00:27:03 +00:00
Schneider Victor-tulias 0bba3d6184 Keyboard quick switch polish
- Added support for escape(backtick on some keyboards) keyboard keys
- Added support for d-pad left and right keyboard keys
- Fixed janky behaviour when quick switching too quickly.
- Removed unused code

Bug: 269618928
Test: Tried quick switch very quickly, tried escape, d-pad left and right keys in RTL and LTR modes
Change-Id: Ie03207cb349891e9c2de18502f3f65b7c8f9c018
2023-02-17 15:44:04 -08:00
Winson Chung 785f15d965 Merge "Only call per-user calls for gesture settings observer" into tm-qpr-dev am: 192e7afc3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21459072

Change-Id: Ia6ba4cf78923ee0d2b7cba88be4482c09e05b524
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-17 21:22:56 +00:00
Winson Chung 192e7afc3c Merge "Only call per-user calls for gesture settings observer" into tm-qpr-dev 2023-02-17 19:44:52 +00:00
Winson Chung 0371d0f699 Only call per-user calls for gesture settings observer
Bug: 231648761
Fixes: 269392826
Test: Unable to reproduce 269392826, but verified this doesn't
      break existing paths to adjust the insets
Change-Id: I8aa82f3fb77e627ac02352ef31b788b81c2ca901
2023-02-17 19:44:29 +00:00
Jon Miranda 13e9b9f889 Translate the taskbar icons to match nav handle shape.
- We need to reset icon alignment whenever icon layout bound
  changes. This fixes the issue where we build an icon
  alignment animator before any of the views are laid out.
- Separated animation logic between.
  createTransientAnimToIsStashed and createAnimToIsStashed
* The values still require a bit more tuning but this gets us
  a lot closer to spec for many of the motion polish.

Bug: 267806083
Bug: 246634367
Bug: 246635237
Test: manual
Change-Id: Id122134b22ef4e418ce632e4a8137239dc8bb313
2023-02-17 10:56:59 -08:00
Alex Chau e892b3e4c5 Merge "Log stackstrace if updateIconAlphaForHome is called after Taskbar is destroyed" into tm-qpr-dev am: ac4c866538
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21467064

Change-Id: Ic7965790ddf7f1e7930428df77b1ac7e7e550f09
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-17 18:51:11 +00:00
Alex Chau ac4c866538 Merge "Log stackstrace if updateIconAlphaForHome is called after Taskbar is destroyed" into tm-qpr-dev 2023-02-17 17:49:18 +00:00
TreeHugger Robot 9eeb09c948 Merge "Suppress transient Taskbar features EDU in overview." into tm-qpr-dev am: 4c6f172a62
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21451980

Change-Id: Id081e2eba6f776b573cecda740184f7f4bbfb5e2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-17 00:02:28 +00:00
TreeHugger Robot 4c6f172a62 Merge "Suppress transient Taskbar features EDU in overview." into tm-qpr-dev 2023-02-16 23:18:48 +00:00
Alex Chau 9a647d53cb Log stackstrace if updateIconAlphaForHome is called after Taskbar is destroyed
Bug: 269409332
Test: manual
Change-Id: I0ff4be33b1e621b0e1a837f8211eb70c27368be1
2023-02-16 18:56:13 +00:00
Jagrut Desai 594f47ebef Merge "Removing ENABLE_ALL_APPS_IN_TASKBAR and FLAG_STASHED_IN_APP_EMPTY Test: Visual(pics in buganizer) Bug: 265462138 Bug: 267382941" into tm-qpr-dev am: 202c68c8a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21255946

Change-Id: I9e93c745ae24ac50afe6cb354efec18393601582
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-16 18:27:25 +00:00
Jagrut Desai 202c68c8a2 Merge "Removing ENABLE_ALL_APPS_IN_TASKBAR and FLAG_STASHED_IN_APP_EMPTY Test: Visual(pics in buganizer) Bug: 265462138 Bug: 267382941" into tm-qpr-dev 2023-02-16 17:39:35 +00:00
Vinit Nayak 5c64c1dcb7 Merge "Add overview taskbar split support for 3P launcher" into tm-qpr-dev am: 0a9056502b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21311163

Change-Id: I83f88af4546c81b8fc5a8f231ff2883f91d5e0b6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-16 01:26:25 +00:00
Vinit Nayak 0a9056502b Merge "Add overview taskbar split support for 3P launcher" into tm-qpr-dev 2023-02-16 00:33:46 +00:00
Jagrut Desai f13a3413a8 Merge "Making taskbar to stay stashed if user launches app for split screen view from all apps view" into tm-qpr-dev am: 4ffc71262d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20840305

Change-Id: Ia860db35051a564b00c6f1af54227fbda88ecad6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 23:53:38 +00:00
Jagrut Desai 4ffc71262d Merge "Making taskbar to stay stashed if user launches app for split screen view from all apps view" into tm-qpr-dev 2023-02-15 23:03:19 +00:00
Stefan Andonian 8775725e06 Merge "Refactor Workspace Loading / Processing code." into tm-qpr-dev am: 3a14f1331d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20544534

Change-Id: I9185bbd2b89d0f40ce85ae4e4b2843643d9ecce8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 22:54:49 +00:00
Brian Isganitis dbe968335d Suppress transient Taskbar features EDU in overview.
The EDU explains how to drag to splitscreen applications, but this operation is unavailable in overview. Therefore, let's only attempt to show the EDU when we are in an application.

Test: Manual
Fix: 269363653
Change-Id: I97aa5c76b44562189862432fb3856bf5634c6e4b
2023-02-15 22:31:55 +00:00
Stefan Andonian 3a14f1331d Merge "Refactor Workspace Loading / Processing code." into tm-qpr-dev 2023-02-15 22:16:29 +00:00
TreeHugger Robot 8df8b19411 Merge "Deferred widget update" into tm-qpr-dev am: 3f07d154fb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21405131

Change-Id: I20005f8053c4b8935b040febc0dc4efff074ac98
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 20:25:31 +00:00
TreeHugger Robot 3f07d154fb Merge "Deferred widget update" into tm-qpr-dev 2023-02-15 20:01:07 +00:00
Vinit Nayak f4e7e5aaf4 Add overview taskbar split support for 3P launcher
* Created b/268120202 to track other states of split
selection that are unhandled on 3P launchers

Test: Able to initiate split in overview with 3P launcher
Fixes: 264576761
Change-Id: I0311fe83380bf914fa79956b2565b61cc5eab916
2023-02-15 11:26:06 -08:00
Ats Jenk c6d31fa3d8 Merge "Disable quickswitch for desktop windowing" into tm-qpr-dev am: 5e74542570
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21423028

Change-Id: I631637c50dec098e9da6d51c3577b3eab0198915
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 18:46:16 +00:00