Commit Graph
28 Commits
Author SHA1 Message Date
Liran Binyamin f53c72b4ed Deflake BubbleBarViewScreenshotTest
Suppress animation to avoid flakes

Fix: 416207075
Flag: EXEMPT test only
Test: atest BubbleBarViewScreenshotTest
Change-Id: I6e3c6105cef4a5d74567de91de75e8bec7609b3c
2025-05-28 13:16:50 -07:00
Sebastián Franco 50c607d4d4 Merge "launcher: Get rid of redundant folders like testing when we have the test folder" into main 2025-05-15 08:29:45 -07:00
Sebastian Franco cc2d14be93 launcher: Get rid of redundant folders like testing when we have the test folder
Bug: 324261526
Test: BubbleBarViewAnimatorTest
Test: BubbleBarViewScreenshotTest
Test: BubbleViewScreenshotTest
Test: DepthControllerTest
Test: DesktopVisibilityControllerTest
Test: ExcludeFromRecentsTestActivity
Test: FakeBubbleViewFactory
Test: WidgetsPredicationUpdateTaskTest
Flag: EXEMPT test only
Change-Id: I2fb9dfebade1925cc5b5875487f97003d97c49de
2025-05-13 22:05:14 +00:00
Liran Binyamin a0dcefc714 Mark a BubbleBarViewScreenshotTest test flaky
Bug: 416207075
Flag: EXEMPT test only
Test: treehugger
Change-Id: Ib3c5878e554be19aa0580450f46c63365c622771
2025-05-09 14:02:06 -07:00
Liran Binyamin 00dc879e2c Merge "Send bubble bar distance to shell" into main 2025-05-02 14:35:40 -07:00
Liran Binyamin 34024fe26a Send bubble bar distance to shell
We previously sent the top coordinate of the bubble bar to shell.
However when the screen height changes, launcher takes a bit longer
to update than shell. So instead of calculating the top coordinate
on the launcher side, we now send the amount of space between the
bubble bar and the bottom of the screen to shell, where we can offset
that as needed.

Bug: 392893178
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual
       - send some bubbles
       - launch app
       - expand
       - swipe to home
       - fold and unfold
Change-Id: I57b96db49dab1e2304fde8dc55a99eaaf85e40f8
2025-05-02 10:54:39 -04:00
Ats Jenk 6c7cb1a5f0 Do not animate bubbles from initial update [4/N]
Bubbles that are restored with initial update should not be animated in.
If we restore the bubble bar after rotation, we need to show it
immediately. Attempting to animate the bubbles from initial update
causes the UI to flicker.

Bug: 357115534
Test: on home screen, have bubble bar expanded, rotate device, check
  bubble bar bubbles do not flicker after rotation
Test: have no bubbles in bubble bar, trigger a bubble, check it is
  animated
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I3da2bc22588c0f5d2dd9c7a3adfcd2c19c339809
2025-04-28 18:44:26 -07:00
Ats Jenk 416f80dc82 Rename method to set bubble bar expanded state [1/N]
Rename methods in BubbleBarViewController and BubbleBarView that set the
expanded state.
These will update the state using an animation.
Update the name to highlight this.
Enables us to create methods to set the state without animation.

Bug: 357115534
Test: refactor, presubmit
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I9d2c46ab1640ab0b19f54103ab8cdb37a5d19dbb
2025-04-25 10:20:41 -07:00
mpodolian 04bd5b49ea Stash the taskbar on every bubble bar expansion
Added logic to enable BubbleBarView to  notify BubbleBarViewController
of expanded state change. Also updated all the test that uses
BubbleBarView to pass empty Controller.

Fixes: 411304392
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Go to any app. Swipe up to show the taskbar. Trigger any
bubble. Observe taskbar is stashed on bubble bar expanded.

Change-Id: I88ad167eb0ed444629716df3672bbb06ca8adcc4
2025-04-18 11:16:40 -07:00
Liran Binyamin 75675e123d Rename bubble bar flyout fields
Long term we'd like to use bubbles for any app, so this change
uses more general names instead of the chat-specific naming

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: built and tested on a device
Change-Id: Idec2aa7d9a8df5df0df49231e8871298084f8aa1
2024-10-07 10:37:55 -04:00
Liran Binyamin 8bd8feb72d Bubble bar flyout polish
Animate the elevation of the flyout along with the expansion animation.
Also start revealing the triangle as soon as we're past the bubble bar.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: Ie7e27240ae3ab86f8e7c3f39aa1c80885cfdc98e
2024-10-01 12:06:36 -04:00
Treehugger Robot 2b1b7d2bb9 Merge "Increase frame limit for bubble bar screen test" into main 2024-09-30 16:56:12 +00:00
Liran Binyamin 74299edbc6 Merge "Update flyout content during animation" into main 2024-09-30 16:54:15 +00:00
Liran Binyamin 5c34cf2741 Update flyout content during animation
This change translates the content of the flyout according
to the progress of the animation. Adding an outline provider
allows clipping the content to the bounds of the animating
background.

Also animate the color of the background.

Demo:
on left - http://recall/-/bJtug1HhvXkkeA4MQvIaiP/cH2EK0FiD92dykhLkLeyh1
on right - http://recall/-/bJtug1HhvXkkeA4MQvIaiP/btpcter79rAlcavd4xxHu7

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest

Change-Id: Id142af2041410c0570759a360146d5e084411cc1
2024-09-27 17:27:20 -04:00
Liran Binyamin b140ccec49 Increase frame limit for bubble bar screen test
This test is flaky because the animation sometimes doesn't
finish before the screenshot is taken. Increasing the frame
limit should help to ensure that the animation has time to
finish.

ABTD 100x runs (passed): https://android-build.corp.google.com/abtd/run/L84400030006722716

Change-Id: I410fb74a947d805551ce1b2303f0dc4c8d616de9
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 366544536
Test: ABTD above
2024-09-27 15:19:15 +00:00
Liran Binyamin 272eea45e6 Merge "Implement bubble bar flyout background animation" into main 2024-09-27 12:45:41 +00:00
Liran Binyamin f7fc19bec1 Implement bubble bar flyout background animation
Update the bubble bar flyout drawing behavior to allow to animate
from a collapsed position into an expanded position.

This change only handles the rounded rect and the triangle. The
text is still left unchanged.

When wired up this looks like this:
left: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/gIsckRmFKj8CceafiJnPTa
right: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/dpn51yXFCCkT6ViUegf351

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: I85ae3bf908c04e5473655c9e536495f56d80f466
2024-09-26 14:38:41 -04:00
Liran Binyamin bb87ec09de Add OWNERS file for multivalentScreenshotTests/src/com/android/launcher3/taskbar/bubbles
Flag: EXEMPT only changing OWNERS
Test: EXEMPT only changing OWNERS

Change-Id: If35010b4bfc166bd8e3734a8fa5be58f6c238f0c
2024-09-26 00:15:42 +00:00
Liran Binyamin 87a4cee6d7 Increase frame limit in bubble bar screen test
50x run ABTD (passed): https://android-build.corp.google.com/abtd/run/L87100030006646570

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 366544536
Test: atest BubbleBarViewScreenshotTest and ABTD above

Change-Id: If6683001bf3e87a60500b99d022d956f76dd9da4
2024-09-23 20:44:29 +00:00
Liran Binyamin 19a43fb7cf Update bubble bar flyout according to spec
Also add a triangle

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: I1a16ba6c9e1a2ca4efe01524ba3ef1d049f81d68
2024-09-19 14:02:43 -04:00
Liran Binyamin 36b5ef2271 Create BubbleBarFlyoutView
Initial version of the flyout view for displaying bubble bar
notification.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: I5d0643fe5d2691ad2349b45eaaad6cd2660d9df0
2024-09-17 11:14:54 -04:00
Liran Binyamin 3a2a7685b0 Initial screenshot tests for bubble bar view
Flag: com.android.wm.shell.enable_bubble_bar
Bug: 355454021
Test: atest BubbleBarViewScreenshotTests
Change-Id: Id74c78d99a8b4528bb473c5a751edb19bda34007
2024-09-10 13:59:01 -04:00
Luca Zuccarini d75eacf30d 3/3 Move some Shell utils to the Shared package.
Bug: 322791067
Flag: EXEMPT move only
Test: NA
Change-Id: Iabc42e4c1d9c13667e9d91be5789cf295f3332e1
2024-09-02 09:23:34 +00:00
Mady Mellor 3808adc58c Don't show the app badge on app bubbles
Flag: com.android.wm.shell.enable_bubble_anything
Test: manual - add an app bubble to bubble bar, observe it's not
               badged (with sysui CL)
Bug: 342245211
Change-Id: I768fa9bb478eeaba587b90d478f32f8c2ee88be1
2024-08-30 09:52:45 -07:00
Liran Binyamin 63ef8cf1e7 Deflake BubbleViewScreenshotTest
Hiding the dot runs an animation which is flaky.
Instead the bubble is created with the suppress notification flag.

Flake: https://android-build.corp.google.com/abtd/run/L87700030005824088

ABTD 50x: https://android-build.corp.google.com/abtd/run/L03700030005851578

Flag: EXEMPT test only
Bug: 355454021
Test: atest BubbleViewScreenshotTest
Change-Id: I635eafb44a3e0ffb9b38fd83c8cc7b36822cce75
2024-08-18 08:39:30 -04:00
Liran Binyamin ccb57d8330 Revert^2 "Initial view screenshot tests for BubbleView"
3795d3782b

Flag: Exempt test only
Bug: 355454021
Test: atest NexusLauncherViewScreenshotTest

Change-Id: Ib51491dd2a6910df8953ad972c1a04fd5d79be9f
2024-07-31 16:31:49 -04:00
Liran Binyamin 3795d3782b Revert "Initial view screenshot tests for BubbleView"
Revert submission 28447963-launcher-view-screenshot-tests

Reason for revert: breaks the build -- conflicts with another cl

Reverted changes: /q/submissionid:28447963-launcher-view-screenshot-tests

Change-Id: If40903403d72e8b1bf776feccaa34dbc3e3e8ae2
2024-07-30 15:04:21 +00:00
Liran Binyamin 4b4122d02e Initial view screenshot tests for BubbleView
Flag: EXEMPT test only
Bug: 355454021
Test: atest NexusLauncherViewScreenshotTests

Change-Id: I32c2a190333143c1ec2fe977efef43b4c04fd469
2024-07-29 04:39:28 -04:00