Commit Graph

17993 Commits

Author SHA1 Message Date
Winson Chung b5c4820a5b Merge "Change existing callers to use no matching id constant" into main 2024-03-13 19:11:20 +00:00
Winson Chung 30a9a212cd Change existing callers to use no matching id constant
- Otherwise it can unintentionally match a predicted icon

Fixes: 329353320
Test: None
Change-Id: I9e46126d5fe45a50d4a36140f7ce0317cd2b1b23
2024-03-13 19:11:03 +00:00
Shamali Patwa 1a72429687 Merge changes from topic "preview-sizes" into main
* changes:
  Limit the recommendations space in two pane picker
  Update the widget previews to use the container sizes
  Avoid cropping image previews.
  Add preview container size helper to display previews in picker.
2024-03-13 13:32:05 +00:00
Holly Jiuyu Sun 5beb2498ac Merge "[PS] Do not use AppInfo and use PrivateSpaceInstallAppButtonInfo instead." into main 2024-03-13 03:48:37 +00:00
Shamali P 1076f176c2 Limit the recommendations space in two pane picker
- This makes the suggestion section non-overwhelming
- Currently it shows too many suggestions for user to find any value
- Limiting the height also allows pagination to feel smooth when showing
in categories

Bug: 318410881
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Test: Manual
Change-Id: Iab1f9a15bdd46ee1560734e30551bfb7c8a74a82
2024-03-12 23:47:07 +00:00
Shamali P 927dd27ece Update the widget previews to use the container sizes
Additionally, adjusts the margins on sides, to make space for displaying
multiple previews side by side.

As a result of this change, previews aren't cropped anymore (indirectly
also fixing b/317366201).

There is one more follow up pending - to limit the height of
recommendations in two pane sheet to only visible area to keep the
suggestions quick to look and concise. It will also help with better
scroll experience when size is same across pages.

* http://screencast/cast/NTQ0Njc4ODgyNjc5MTkzNnxjYzZiYTU2Ny02Yw
* http://screencast/cast/NTk4ODMyMDkxOTE1ODc4NHw3NzdlNTgxZS1kMw
* http://screencast/cast/NTYxOTc5NjIxNjM4MTQ0MHxiMjQ2Njc3OC0zOQ
* http://screencast/cast/NDk4MjIxNjI0MDEzNjE5MnxjY2IwYmIxNi00Mw

Bug: 319152349
Flag: N/A
Test: Image test and table utils test
Change-Id: I07465bd4d84597b560a2b998ff1ccbf9867c0192
2024-03-12 23:47:07 +00:00
Shamali P c93f687f12 Avoid cropping image previews.
In most cases, cropping image-based previews to just fit width leads to
degraded UX. Instead we try to fit them to the widget size if possible.

* Before: See attached bug for examples of cropped previews.
* After: http://screen/Bg7Eoydr4qBQdVZ

Additionally center align previews vertically for non-categorized
suggestions too.

Bug: 319152349, 317366201
Flag: N/A
Test: Includes a unit test & manual with the child cls
Change-Id: I4447f99028129d5d5379ead9ca404f7a011d1551
2024-03-12 23:47:07 +00:00
Shamali P a1dbbeab7e Add preview container size helper to display previews in picker.
While we want previews to be displayed at true size, today, there is
less consistency among different widgets. This change is a first step
towards consistent sizes. In this change, we provide helper classes
that provide the size of the container in terms of grid spans.

Note: This does not change the size for rendering widget previews; but,
we take that original rendered preview and scale it maintaining the
aspect ratio to display it in one of closest container sizes.

Bug: 319152349
Flag: N/A
Test: Includes a unit test & manual with the child cls
Change-Id: I335373aa1be9a41fe039c98cded0113a007ad8c4
2024-03-12 23:47:07 +00:00
Sebastián Franco e9ebd2d70a Merge "Revert^4 "Removing all restored backups except one so we don't have old backups"" into main 2024-03-12 22:00:36 +00:00
Himanshu Gupta 201626b553 Merge "Using LauncherApps API for PS Settings and Setup Flow." into main 2024-03-12 21:17:22 +00:00
Willie Koomson be65a75e82 Merge "Check for null preview in WidgetItem.hasGeneratedPreview" into main 2024-03-12 19:15:59 +00:00
Sebastián Franco ad46eb75f4 Revert^4 "Removing all restored backups except one so we don't have old backups"
To prevent the error I introduce the method restorePreviousState().

This reverts commit 1234090589.

Reason for revert: Fixing presubmit breaks

Bug: 325285743
Flag:  ACONFIG narrow_grid_restore disabled
Test: BackupAndRestoreDBSelectionTest
Change-Id: I63666c29eb91dada4243af019ab0538c40bc0f78
2024-03-12 11:01:26 -07:00
Shamali Patwa 7574bed02e Merge "Update labels for the categories to match the UX writer provided strings" into main 2024-03-12 11:37:25 +00:00
Himanshu Gupta 616a1b828d Using LauncherApps API for PS Settings and Setup Flow.
Bug: 310027945
Test: Launcher3 tests
Flag: ACONFIG com.android.launcher3.enable_private_space TRUNKFOOD
Change-Id: I6e04a4b0c33d4526d83b51e512e1e4372ce1cca4
2024-03-11 16:13:08 -07:00
Sebastián Franco 8a5dd1b3cf Merge "Revert^3 "Removing all restored backups except one so we don't have old backups"" into main 2024-03-11 20:17:43 +00:00
Sebastián Franco 1234090589 Revert^3 "Removing all restored backups except one so we don't have old backups"
This reverts commit 4b960d1f11.

Reason for revert: Breaking presubmit, no bug number yet 

Change-Id: I0bafad8bf63fae1d9408b65c6c18c79ab5d40d05
2024-03-11 20:15:24 +00:00
Sebastián Franco 37e9aa2504 Merge "Revert^2 "Removing all restored backups except one so we don't have old backups"" into main 2024-03-11 17:09:21 +00:00
Jakob Schneider 57edffece5 Merge "Improve "isActiveArchive" check by moving it a bit earlier into the method." into main 2024-03-11 16:43:50 +00:00
Catherine Liang 975a0695fb Merge "Remove createWindowContext in Launcher preview renderer" into main 2024-03-11 14:13:01 +00:00
Sebastián Franco bbdcade30d Merge "Add testing for GridMigration." into main 2024-03-09 13:41:00 +00:00
Anushree Ganjam 4a214f5750 Merge "Enable Omnient master flags in client code." into main 2024-03-08 22:46:17 +00:00
Willie Koomson 52f2e98647 Check for null preview in WidgetItem.hasGeneratedPreview
AppWidgetManager.getWidgetPreview has been updated to return null
if the provider does not exist or the caller does not have permission to
access its previews. This change updates WidgetItem to check for that.

Bug: 308041327
Test: GeneratedPreviewTest#widgetItem_hasGeneratedPreview_nullPreview
Flag: ACONFIG com.android.launcher3.enable_generated_previews TRUNKFOOD
Change-Id: Ic2489c8698a81ba1bac005b2eb77348bcbfab999
2024-03-08 22:22:53 +00:00
Fengjiang Li 951f74bb60 Merge "[Predictive Back] Don't hide/reveal scroll bar in predictive back swipe in 2 pane widget picker" into main 2024-03-08 22:04:06 +00:00
Anushree Ganjam 25fc87b340 Merge "Remove expecting DOWN events in TAPL tests." into main 2024-03-08 21:43:04 +00:00
Sebastian Franco 851b1f3b1c Add testing for GridMigration.
Bug: 325286145
Flag: ACONFIG grid_migration_fix disabled
Test: GridMigrationTest
Change-Id: I49fd32be895f3a05204775373b9eec62d9026f3b
2024-03-08 14:46:41 -06:00
Shamali P 20a5f4e8d1 Update labels for the categories to match the UX writer provided strings
Also fix issue that user was not passed when getting application info.
(error noticed by Zak)
http://screen/8fiiTSHvo2SfYdE

Bug: 318410881
Flag: N/A
Test: Unit test
Change-Id: Id85feec0d95d3d4d183a673f7eed40906b0043e2
2024-03-08 19:58:23 +00:00
Sebastián Franco 4b960d1f11 Revert^2 "Removing all restored backups except one so we don't have old backups"
This reverts commit 3306fa5325.

Reason for revert: Fixing issue that caused b/328782012

Change-Id: Ib6a1bbfeedf608f5f77ac6be500271e811320f32
2024-03-08 18:53:57 +00:00
Sebastián Franco 0f0c1dd30b Merge "Revert "Removing all restored backups except one so we don't have old backups"" into main 2024-03-08 18:45:17 +00:00
Sebastián Franco 3306fa5325 Revert "Removing all restored backups except one so we don't have old backups"
This reverts commit bd43b9344f.

Reason for revert: b/328782012

Change-Id: I1666fbd63d82da06ed8c3d9ce58b5ed6b298618b
2024-03-08 18:42:30 +00:00
Federico Baron e81e048183 Merge "Fix folder name touch target size" into main 2024-03-08 17:30:21 +00:00
Federico Baron f9aa2a4a47 Merge "Remove logspam for resolved bug" into main 2024-03-08 16:29:17 +00:00
Sebastián Franco acdcaa21a0 Merge "Removing all restored backups except one so we don't have old backups" into main 2024-03-08 14:16:14 +00:00
Fengjiang Li 7c6f770a41 [Predictive Back] Don't hide/reveal scroll bar in predictive back swipe in 2 pane widget picker
Fix: 328639347
Test: Manual - took a video
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I909cca47477d75c2dd9b861e3c7812b9540e6fa1
2024-03-07 16:29:14 -08:00
Himanshu Gupta 68c145a14b Merge "Clearing All Apps Search For ALL_APPS Intent" into main 2024-03-07 22:29:31 +00:00
Anushree Ganjam 3b220c62ce Enable Omnient master flags in client code.
Bug: 327638681
Test: Manual
Flag: legacy ENABLE_LONG_PRESS_NAV_HANDLE ENABLED
Change-Id: Id8990ed145b4f035e5cd14e901676ebbd03733dd
2024-03-07 12:39:18 -08:00
Anushree Ganjam 461038d5d5 Remove expecting DOWN events in TAPL tests.
ACTION_UP is always preceded by ACTION_DOWN which means when launcher
receives an UP events, down event is obviously sent.

In b/325377690 , we started seeing only in P9 devices the DOWN events didn't reach TAPL. I added InputDispatcher logs which shows both DOWN and UP events are sent by system_server to NexusLauncher.
However TAPL doesn't receive it. After spending lot of time debugging this, I think we are safe to remove DOWN event expectation in TAPL.

Bug: 325377690
Test: Manual, TAPL presubmits
Flag: NA
Change-Id: I6d3587c488d45e3dc53d2c1c4f3b6b49285eae94
2024-03-07 12:31:38 -08:00
fbaron 7e5d855886 Remove logspam for resolved bug
b/318394698 was fixed so we can now remove these logs.

Fix: 321837497
Test: N/A
Flag: NONE
Change-Id: Ifc8b18238778f6aa2c0ad1be5df627c07cbaf1d8
2024-03-07 11:11:36 -08:00
fbaron 0b2253b532 Fix folder name touch target size
With this update, the touch target height for the folder name is now to match the footer height

Flag: NONE
Test: Verified on device with talkback turned on
Fix: 318463992
Change-Id: I77f07280eb54b442efadf7e7373952ea160fc5d2
2024-03-07 09:39:51 -08:00
Fengjiang Li e24af582c6 Merge "Use Matrix.setRectToRect() replace RectUtils.letterBox()" into main 2024-03-07 17:28:11 +00:00
Sebastian Franco bd43b9344f Removing all restored backups except one so we don't have old backups
Adding test to make sure this is the case.

Bug: 325285743
Flag:  ACONFIG narrow_grid_restore disabled
Test: BackupAndRestoreDBSelectionTest
Change-Id: I84c3a92f40598137d5c5c52d34af7583b384122c
2024-03-07 11:23:55 -06:00
Himanshu Gupta e2ae040e35 Merge "Revert Accidental tweak of work profile behaviour" into main 2024-03-07 13:54:11 +00:00
Fengjiang Li c6ae88f904 Use Matrix.setRectToRect() replace RectUtils.letterBox()
Bug: 284236964
Flag: aconfig launcher.enable_add_app_widget_via_config_activity_v2 DISABLED
Test: manual
Change-Id: Ia83f3415442c2359bffb1efcfd1ee96bf17ab9ff
2024-03-06 17:04:02 -08:00
Jeremy Sim 46aa4a58f8 Merge "Fix bug with app pairs appearing in wrong orientation in pinned Taskbar" into main 2024-03-06 21:56:34 +00:00
Vinit Nayak d1fb97ae64 Merge "On disabled app pairs, set color tint instead of changing alpha" into main 2024-03-06 18:39:19 +00:00
Jakob Schneider 343d99781f Improve "isActiveArchive" check by moving it a bit earlier into the
method.

Apply progress level doesn't need to be called unless the app is
actively being unarchived.

Previously this was fixed by adding a check directly in
"setIsDisabled()" which is not quite the right place (we can exit
earlier).

Bug: 326218355
Test: manual
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving TRUNKFOOD
Change-Id: Ia12013dbcec2d40413a6cf819f8d1787b815adc1
2024-03-06 18:12:53 +00:00
Catherine Liang d56332892d Merge "Fix Launcher preview crash" into main 2024-03-06 16:57:16 +00:00
Jeremy Sim 999ab5215a Fix bug with app pairs appearing in wrong orientation in pinned Taskbar
This CL makes it so that app pairs do an orientation check in dispatchDraw() instead of only on init().

Previously we only checked orientation on AppPairIcon.inflateIcon(), and the issue was that orientation was not re-checked when pinned Taskbar was rotated to different sides of the screen. Added a DeviceProfileListener to update orientation when DP changes.

Fixes: 323288812
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, app pair icon always has correct otientation on pinned taskbar
Change-Id: If2de1a4c7334fef1ba4c2edcca09bef9338bc73f
2024-03-05 22:32:36 -08:00
Jeremy Sim 09fe96b95a On disabled app pairs, set color tint instead of changing alpha
This CL changes the way disabled app pair icons are drawn: instead of setting alpha, it sets a color filter to indicate disabled status. This brings it in line with other apps icons and V's design specs.

Fixes: 326665140
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: Ifc8ac694f321a6b28996ba9a42860dfc419d5901
2024-03-05 21:45:00 -08:00
Fengjiang Li 7dea7f0b42 Merge "[2/n] Avoid flicker to drop a widget that needs a config activity" into main 2024-03-06 02:03:48 +00:00
Fengjiang Li f114ec5b26 Merge changes Iab1de455,I0c6585e6,I125670d1 into main
* changes:
  [Predictive Back] Recover taskbar all apps scale to 1f with animation if user swipe back within search [3/n]
  [Predictive Back] Dismiss taskbar all apps's scroll bar during swipe gesture [2/n]
  [Predictive Back] Fix predictive back swipe on task bar all apps [1/n]
2024-03-06 01:32:17 +00:00