Commit Graph

14385 Commits

Author SHA1 Message Date
Alex Chau 2e7ef70770 Use AplicationContext for getWindowCornerRadius on DEFAULT_DISPLAY
- ag/32861507 changed getWindowCornerRadius to use DisplayContext, which does not get updated on configuartion changes, this caused potentially regression of having wrong corner radius after configuration changes
- ag/32896744  attempted to fix this with window context, get is rolled back due to perfroamcne regression
- This CL is a temp fix to make DEFAULT_DISPLAY continue usign AplicationContext for getWindowCornerRadius, if the AplicationContext is associated to a display, and otherwise fallback to displayContext

Bug: 408988616
Test: manual
Flag: EXEMPT bug fix
Change-Id: I72dbcfb7cd6cdc6783e96768b4f4b51b76d9a245
2025-04-10 16:10:12 +01:00
Alex Chau 5e619cd675 Merge "Provides displayContext instead of windowContext for RotationTouchHelper" into main 2025-04-10 07:39:15 -07:00
Alex Chau e246b3273b Provides displayContext instead of windowContext for RotationTouchHelper
- Also limit usage of displayContext on getWindowCornerRadius only, any other usage causes perf regression
- Note that displayContext does not respond to configuration changes, there might be existing functionality bug already that resources are stale after configuration changes, keeping b/408988616 open to handle it in the future

Bug: 408988616
Fix: 409222870
Fix: 409252967
Test: presubmit and ABTD
Flag: EXEMPT refactor
Change-Id: I024c76326a2deb1ecc035de8319976e31887486b
2025-04-10 07:38:55 -07:00
Treehugger Robot c20a68eb4b Merge "Remove EnableHoverOfChildElementsInTaskview flag" into main 2025-04-10 06:30:38 -07:00
samcackett 68a21ed111 Remove EnableHoverOfChildElementsInTaskview flag
Fix: 409610713
Flag: EXEMPT. Flag removal
Test: N/A
Change-Id: Ifa924cb2011bb6e633ee5b79c17601be82b4a779
2025-04-10 10:59:54 +01:00
Sam Cackett bf69d6e6a5 Merge "Add TaskContentView wrapper to TaskThumbnailView" into main 2025-04-09 23:54:40 -07:00
Brian Isganitis 8c6dd04740 Merge "Expose desktop experience CD Taskbar flag to SecondaryDisplayLauncher." into main 2025-04-09 13:33:40 -07:00
Treehugger Robot 3726f6fe06 Merge "Reload visible task data when transitioning to Overview" into main 2025-04-09 12:05:35 -07:00
Alex Chau abd2716fea Reload visible task data when transitioning to Overview
- When onPrepareGestureEndAnimation is called, we already know the end target is Overview, loading thumbnail at this point ensure thumbanil is loaded throughout the transition

Fix: 407525135
Flag: com.android.launcher3.enable_grid_only_overview
Test: Home/app to Overview with gesture/3button
Change-Id: Ie91d3989654ff17df94704275523ca097f786293
2025-04-09 17:39:07 +01:00
samcackett 2244b633cc Add TaskContentView wrapper to TaskThumbnailView
- Keep TaskThumbnailViewDeprecated as-is
- Due to flag guarding and xml changes, added bottomright_snapshot id
- Remove redundant FrameLayout from task_header_view.xml and refactor
the view to handle alignment correctly
- Move feature flag logic to the state mapper
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
 similarly

This reverts commit df6dc455a7.
This reverts commit 714370a9bfb2e53738b0cd9958acd6540d8d649c.

Reason for revert: Reland previously reverted CL's with fixes

Fix: 408971730
Fix: 397889146
Fix: 401469907
Fix: 402277471
Fix: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest & TaskThumbnailViewScreenshotTest & TaskHeaderViewScreenshotTest & SwitchBetweenSplitPairsGesturalNavPortrait
Change-Id: I01758447ad1194ebbeab748113621b42f3384db8
2025-04-09 16:36:51 +01:00
Perry Wu c5d8fbcb82 Merge "Add null check for checking intent component" into main 2025-04-09 08:29:25 -07:00
Vinay Joglekar 96590ffeb0 Merge "Fix unnecessary creation of surface transactions during setBaseSurface." into main 2025-04-09 02:50:18 -07:00
Graciela Putri 3d08afcbb9 Merge "Add displayId to back event" into main 2025-04-09 00:50:47 -07:00
vinayjoglekar 425b11fd9e Fix unnecessary creation of surface transactions during setBaseSurface.
Also swap surface only when required.

Fix: 404647629
Fix: 408937692
Test: Manual. Enter/Exit overview from home/app
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I1562ed11a14021565ec9b9560b7f0d7d2b1468c6
2025-04-09 08:24:35 +01:00
Treehugger Robot d9560b8f92 Merge "[Action Corner] Implement new LauncherProxy method in Launcher" into main 2025-04-08 23:23:05 -07:00
Treehugger Robot 1af8b49518 Merge "Use expressive dismiss when splitting tasks." into main 2025-04-08 16:27:15 -07:00
Treehugger Robot f17d86902a Merge "Fix TaskbarSnapshot leak and ANR." into main 2025-04-08 15:44:43 -07:00
Brian Isganitis b7a5dc0017 Expose desktop experience CD Taskbar flag to SecondaryDisplayLauncher.
Flag: EXEMPT refactor
Fix: 407924023
Test: go/testedequals
Change-Id: I06344f023eb1fab697f25276bc82e1be0209e4a8
2025-04-08 17:17:15 -04:00
Pat Manning f9865debb7 Use expressive dismiss when splitting tasks.
Snap last grid task to hide clear all during scrolls as well.

Fix: 389081467
Test: TaplTestsSplitscreen
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I153b3dcacdf634358416f0793804c1c4c099a993
2025-04-08 22:07:36 +01:00
Jagrut Desai a89c52a0d1 Merge "Fix Taskbar Recents Item after unlock" into main 2025-04-08 13:29:00 -07:00
Treehugger Robot 049a8f608d Merge "Let TaskView.bind take GroupTask instead of Task" into main 2025-04-08 12:54:16 -07:00
Jon Miranda 9bc1b6687d Fix TaskbarSnapshot leak and ANR.
- Makes sure view is removed and set to null
- Makes sure draglayer is visible before trying
  to copy it to the snapshot. I wasn't able to repo
  the ANR, so will need to keep an eye on it once we
  re-enable the flag.

Test: open/close shade multiple times
      trigger launcher recreate by toggling dark theme
      no leak detected in AS
Fixes: 404331867
Bug: 408450275
Flag: com.android.launcher3.enable_taskbar_behind_shade
Change-Id: Ide375943214548b938953230e2140d4df23317df
2025-04-08 11:03:35 -07:00
Treehugger Robot faded705d0 Merge "Use DesktopModeFlags for Alt+Tab CD flags" into main 2025-04-08 10:57:16 -07:00
minch 42efd0c6cc Let TaskView.bind take GroupTask instead of Task
1. Introduce a `groupTask` property to `TaskView` and let all the
   `bind` functions take a type of `GroupTask` as the parameter
   instead of a `Task`.
2. Then let `RecentsView.removeGroupTaskInternal` take the
   `GroupTask` as the parameter instead of a `TaskView`.
3. Caches the `groupTask` before `removeGroupTaskInternal` then
   we can avoid the corresponding `deskId` being set to invalid
   on `removeViewInLayout` in the main thread, which might happen
   before `removeGroupTaskInternal`.

Bug: 408032417
Test: m
Flag: EXEMPT refactor
Change-Id: I51c5b810eb63bc1267b90b915f90164f7ca3cba5
2025-04-08 17:16:08 +00:00
Treehugger Robot 1f4ee92d18 Merge "Fix grammar issue with all set page subtitle" into main 2025-04-08 09:57:13 -07:00
Treehugger Robot b1e5175b76 Merge "Fix blur flash while moving from live tiles to static." into main 2025-04-08 09:50:06 -07:00
Sunny Goyal afd7e35e0d Merge "Moving IconProvider extensions to a separate subclass instead of routing via APIWrapper" into main 2025-04-08 09:46:28 -07:00
Treehugger Robot 5197cda3af Merge "Fix App Chip Menu position in RTL" into main 2025-04-08 09:42:53 -07:00
Jagrut Desai 065a5321a8 Fix Taskbar Recents Item after unlock
we simply fetch the icons at the same time we restore the previously show items.

Test: Manual
Bug: 407932962
Flag: EXEMPT bugfix
Change-Id: I83131ef034fe94583beee32aeeb3e908f07cfc6f
2025-04-08 09:01:59 -07:00
Ajinkya Chalke c86d27deec Use DesktopModeFlags for Alt+Tab CD flags
- Updated flags for both Alt+Tab on CD and KQS flatenning features.

Bug: 407954660
Test: m
Flag: EXEMPT only updated flag usage
Change-Id: If099138c65ae582837293c0929185f61e6f5f350
2025-04-08 15:14:42 +00:00
Schneider Victor-Tulias 02d9e5043a Fix grammar issue with all set page subtitle
Flag: EXEMPT bug fix
Fixes: 392616062
Test: launched all set page with empty and test devices names
Change-Id: I885603f64478642c825e15563f5526399114f0f2
2025-04-08 10:31:19 -04:00
Jordan Silva 1f9073a942 Fix App Chip Menu position in RTL
- Updated IconAppChipView and TaskMenuView to use `Gravity.START` when the layout is natural to launcher (i.e., not fake landscape).
- TaskMenuView updated to use Gravity.START when the layout is natural to launcher as well.
- Updated the RTL translationX for the TaskMenuView.
- Removed the reveal animation when expanding the chip. No longer necessary due to the marquee and horizontal fading.
- Fixed the reveal animation when collapsing the chip in RTL.

Fix: 409035162
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual. Using RTL, expand the app chip menu.
Change-Id: I9e7639a62a08133b3fd4a31a932ba65d03c65d53
2025-04-08 07:21:32 -07:00
vinayjoglekar d905645f1e Fix blur flash while moving from live tiles to static.
Fix : 406231674
Test: Manual. Dismiss live tile from Overview. Long press on live tile to invoke AiAi.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Ibc4c472f9c26862a4dcf0993ab487a8e52062bcf
2025-04-08 14:42:56 +01:00
Graciela Wissen Putri b6488e052c Add displayId to back event
This will allow core to determine which display the back event was
started from.

Flag: com.android.window.flags.enable_independent_back_in_projected
Bug: 401530192
Test: atest TaskbarNavButtonControllerTest
Change-Id: I181aae3e9f5009f99e6ce21092dd45caeeae20cc
2025-04-08 13:28:02 +00:00
Treehugger Robot 75970d1567 Merge "Consider liveTileRemoteTargetHandles when deciding blur layer when launching tasks" into main 2025-04-08 05:00:55 -07:00
Alex Chau 70e22f42c3 Merge "Make HintState transparent when blur is enabled" into main 2025-04-08 02:50:48 -07:00
Alex Chau f995461c1b Consider liveTileRemoteTargetHandles when deciding blur layer when launching tasks
- Simplified setDrawBelowRecents API to setDrawAboveRecents, this clarifies only live tile can be below recents
- Added getDrawAboveRecents to TaskViewSimulator to simplify finding surfaces below recents
- Simplifed updateBlurLayer method that filters below recents live tile surfaces to find the lowest surface

Fix: 406238103
Test: Home to Overview.
Test: App to Overview, launch live tile
Test: App to Overview, launch another task
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I9b6e1cf7b8f1c364a5390c20e0e2b70d72ed18a8
2025-04-08 10:49:42 +01:00
Sunny Goyal a5ddcf78ba Moving IconProvider extensions to a separate subclass instead of routing via APIWrapper
Also adding plugin support for IconProvider

Bug: 366237794
Flag: EXEMPT refactor and extra code behind plugin
Test: Manual
Change-Id: Id286f88b2683e0fabc48c57b7920024f06dd7539
2025-04-07 22:39:58 -07:00
Treehugger Robot 8a7b7a955e Merge "Revert "Revert^2 "Check if all apps are translucent when finishing recents animation.""" into main 2025-04-07 21:57:26 -07:00
Treehugger Robot 49bbc6b324 Merge "Revert "Also cancel TaskView collection Jobs when Overview is not on screen."" into main 2025-04-07 18:37:21 -07:00
Jon Miranda a898bfaee4 Revert "Revert^2 "Check if all apps are translucent when finishing recents animation.""
This reverts commit 73797f8188.
Also reverts commit I82717747408f5776a50aa239c384f87927b54832

Fixes: 406244612
Fixes: 406238331
Bug: 354627538 (reopening)
Test: opening App Info from Overview mutiple times
      opening App, enter Overview, open Split App Pair
Flag: EXEMPT bugfix
Change-Id: Ief81f826cf17ae9ef369eb97d353ebadda8077e3
2025-04-07 16:56:08 -07:00
Treehugger Robot 6b8aba0abb Merge "[CD Taskbar] Fix - Unlock/Lock Removes Recents button + icons" into main 2025-04-07 15:33:50 -07:00
Schneider Victor-tulias 8ae40731ff Merge "Fix Initialization exception when creating RecentsDisplayModel" into main 2025-04-07 15:21:59 -07:00
Treehugger Robot bbd09df63a Merge "Inject and use WindowContext in RotationTouchHelper" into main 2025-04-07 14:45:32 -07:00
Daniel Andersson aba807d57f Merge "desktop-exploded-view: Basic support for minimized tasks" into main 2025-04-07 13:23:45 -07:00
Sukesh Ram cd50c6fd9f [CD Taskbar] Fix - Unlock/Lock Removes Recents button + icons
The SYSUI_STATE_OVERVIEW_DISABLED is being incorrectly set for non-primary displays. Override this behavior on taskbar level for non-primary displays & track the sysUI side fix via b/409075366.

Bug: 408478776
Flag: com.android.window.flags.enable_taskbar_connected_displays
Test: m
Change-Id: Ie93d576dc525e80a8bc1e59dbcefa02b2e50591d
2025-04-07 13:02:57 -07:00
Alex Chau b9c5fa3f12 Make HintState transparent when blur is enabled
- Moved HintState to quickstep to have access to BlurUtils
- Added a dummy HintState outside quickstep

Fix: 406308427
Test: manual
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I8aa2407d87b429584168ebb0601cfffcccad0cfa
2025-04-07 20:17:31 +01:00
Saumya Prakash 830ceb6565 Merge "Don't translate the back button if home button is showing for lockscreen" into main 2025-04-07 11:59:39 -07:00
Daniel Andersson 641ffe50d8 desktop-exploded-view: Basic support for minimized tasks
This makes minimized tasks visible in overview. These tasks are
immediately placed in the exploded position and then fade in during
the course of EXPLODE_PROGRESS.

This CL also moves isLiveTile from TaskTileUiState to TaskData.Data
since it's no longer a TaskView wide state.

Note: this CL only makes the minimized tasks visible in overview. It
does not yet un-minimize tasks on click.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
BUG=370495260

Change-Id: I5e441e81ae542902be9cd33d49bcb76d06bb1190
2025-04-07 10:31:47 -07:00
Schneider Victor-Tulias 6e79190f45 Fix Initialization exception when creating RecentsDisplayModel
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit tests
Change-Id: I5599b02dd34f92ca8645412b61b3c86b4cd91032
2025-04-07 13:20:16 -04:00