Commit Graph

18474 Commits

Author SHA1 Message Date
Liran Binyamin 9b3d882c34 Merge "Fix hotseat icon translation issue" into main 2024-06-22 01:35:49 +00:00
Tracy Zhou 170092ef5d Merge "Enable taskbar on phones when the flag is turned on" into main 2024-06-21 22:47:13 +00:00
Tony Wickham 74fc385999 Merge "Load and draw Recent/Running tasks that aren't in Hotseat" into main 2024-06-21 21:01:41 +00:00
Tony Wickham 59e8952fc9 Merge "Handle running task launch properly in desktop mode" into main 2024-06-21 20:57:38 +00:00
Liran Binyamin 891e9e3c4b Fix hotseat icon translation issue
The current behavior that adjusts hotseat icons to make room for the
bubble bar uses the index of the hotseat icon to calculate translation x.

The problem is that if icons are reordered, the index of the icon may be
different than the actual cell number it belongs to.

This change updates the logic to use the cell rather than the index.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345686425
Test: manual - on tablet in portrait
       - show bubble bar
       - observe hotseat icons adjust
       - drag an icon from the home screen into hotseat
       - observe icons are shown correctly
       - rotate the device to landscape and back to portrait
Change-Id: I8628892234d1b31205b93ba3089c6dbf2820ea04
2024-06-21 16:33:45 -04:00
Tracy Zhou 1983e4fb13 Enable taskbar on phones when the flag is turned on
Bug: 348017501
Test: N/A
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: I8f283609b24c49e4ecd37142b0d94e449d1dc118
2024-06-19 18:45:22 +00:00
Fengjiang Li 622a7e37c5 Merge "[Launcher Jank] Avoid LauncherWidgetHolder and QuickstepWidgetHolder calling IAppWidgetService$Stub$Proxy.setAppWidgetHidden from main thread" into main 2024-06-19 15:19:22 +00:00
Ivan Tkachenko f58d227f61 Fix back gesture navigation in Launcher with DW
The windows back functionality with the
`enable_desktop_windowing_wallpaper_activity` flag enabled works as
expected and doesn't require changes in `#updateDisallowBack`.

- Added the `enable_desktop_windowing_wallpaper_activity` flag check in
  `Launcher#updateDisallowBack`
- The early return statement will get removed after flag is fully rolled
  out (b/333533253)

Bug: 330183377
Test: manual
Flag: com.android.window.flags.enable_desktop_windowing_wallpaper_activity
Change-Id: I2eaaa44da82da6cbdfe534793830d0f44c4668ba
2024-06-19 11:57:06 +00:00
Tony Wickham c5995c8f6d Load and draw Recent/Running tasks that aren't in Hotseat
- Re-support GroupTask as a tag on TaskbarView BubbleTextViews
- Can tap to launch (startActivityFromRecents) or drag and drop
- Move divider when enable_recents_in_taskbar is true

Behavior:
- While in Desktop mode, all open tasks show up in TaskbarView,
  either in the Hotseat section or the Running apps section
  past the divider. Each one also has a running line indicator.
- While in Fullscreen mode, up to 2 Recent apps that are not
  part of Hotseat will be added to the right of the divider.

Flag: com.android.launcher3.enable_recents_in_taskbar
Test: TaskbarRecentAppsControllerTest
Bug: 315354060
Change-Id: I2e2870cca434b51f276a701860edb32069109159
2024-06-19 00:27:30 +00:00
Tony Wickham 4e1befb394 Handle running task launch properly in desktop mode
- Move logic from KeyboardQuickSwitchViewController to handle
  bringing desktop tasks to front, and still support recent
  tasks for non-desktop mode.

Flag: com.android.launcher3.enable_recents_in_taskbar
Test: manually launch tasks from the Recents section in both
Desktop mode and full screen mode (running vs recent)
Bug: 315354060

Change-Id: I0520351b4d0095a3538c6165acd82a7b4c45a5e2
2024-06-19 00:25:45 +00:00
Fengjiang Li 880de362f1 [Launcher Jank] Avoid LauncherWidgetHolder and QuickstepWidgetHolder calling IAppWidgetService$Stub$Proxy.setAppWidgetHidden from main thread
Fix: 347991067
Test: manual - jank fix
Flag: NONE - jank fix
Change-Id: I881e5961ee4422d89e761c95ee8371902ded7ae6
2024-06-18 15:47:31 -07:00
Charlie Anderson 30a3acc779 Only send new first screen broadcast on first load after restore
Flag: EXEMPT launcher_broadcast_installed_apps
Bug: 322314760
Test: manually tested

Change-Id: I28a3ee1fb2c5c382ea8789b6e966c80db1abf0e0
2024-06-18 18:19:46 -04:00
Fengjiang Li 76b1669a48 Merge "[Launcher Jank] Avoid making binder call IContentService$Stub$Proxy.registerContentObserver from SettingsCache" into main 2024-06-18 03:17:52 +00:00
Fengjiang Li 56bf7ad33b [Launcher Jank] Avoid making binder call IContentService$Stub$Proxy.registerContentObserver from SettingsCache
Fix: 347789110
Test: manual
Flag: NONE - jank fix
Change-Id: Ib1409d6c856439455aa08eeb0cfbc8075a222d45
2024-06-17 16:50:49 -07:00
Treehugger Robot 97e7166bc8 Merge "Fix icon flash on app launch" into main 2024-06-17 18:34:33 +00:00
Schneider Victor-tulias 9fb1f80435 Fix icon flash on app launch
Flag: com.android.launcher3.enable_additional_home_animations
Fixes: 343051344
Test: temp logs, launched apps from home, quickly swiped home while quick switching
Change-Id: I91071d53f753eb7bc99305c46241de203bcfdc98
2024-06-14 15:27:36 -04:00
Ats Jenk e095945bf1 Merge "Check the feature flag before showing bubbles shortcut widget" into main 2024-06-14 18:14:31 +00:00
Sebastián Franco aaee1ef060 Merge "If the app is archived, do not remove in case of playstore install error" into main 2024-06-14 00:50:39 +00:00
Randy Pfohl 69092b41f6 Merge changes from topic "windowPrototype" into main
* changes:
  Fixing tests related to abstraction
  Abstracting StatefulActivity from StateManager
2024-06-13 22:11:49 +00:00
Andrew Cole f77600260c Merge "Send additional Extras in first screen broadcasts, to help with app archiving." into main 2024-06-13 21:30:26 +00:00
Charlie Anderson 7cc4302f10 Send additional Extras in first screen broadcasts, to help with app archiving.
- refactor FirstScreenBroadcast.java into FirstScreenBroadcastHelper.kt
	- send Extras to include installed/archived items on first screen
	- send Extras to include installed/archived widgets on all screens.
	- truncate items to limit Broadcast size

Bug: 322314760
Test: unit testing and E2E test of B&R
Flag: launcher_broadcast_installed_apps

Change-Id: I214149ac0c63f177d3d1ca0b6d0cb11be37f4ae0
2024-06-13 21:29:50 +00:00
randypfohl 176ce85d27 Abstracting StatefulActivity from StateManager
Flag: NONE - abstraction with no logic changes.

Test: Built and ran locally, for launcher3 and third party launchers

Bug: 224595066

Change-Id: I9da15bdd649d3a20e98c6552bb9e9abaec72f97f
2024-06-13 10:26:12 -07:00
Sebastian Franco 6d200f63ac If the app is archived, do not remove in case of playstore install error
Fix: 339852615
Test: Manual
Flag: com.android.launcher3.enable_support_for_archiving
Change-Id: I675586d20d09f9e025dfe6a74cf7b79ddcb40cc2
2024-06-12 19:47:17 -06:00
Brian Isganitis e54c1462a3 Test TaskbarAllAppsController non-search behavior.
Flag: TEST_ONLY
Bug: 230027385, 346394798
Test: TaskbarAllAppsControllerTest
Change-Id: Id97e1b82cb8fba48687b5e23222e3bba6695ac4c
2024-06-12 23:59:51 +00:00
Treehugger Robot 8a281ff7a6 Merge "Convert ENABLE_FLOATING_SEARCH_BAR to aconfig." into main 2024-06-12 23:50:20 +00:00
Himanshu Gupta cf3a0ef2f0 Merge "Prompting the user to set Pixel/Quickstep as default Home app." into main 2024-06-12 21:13:19 +00:00
Mykola Podolian 590e662d70 Merge "Add outline to the bubble bar background view." into main 2024-06-12 16:46:55 +00:00
Andy Wickham cfafb55331 Convert ENABLE_FLOATING_SEARCH_BAR to aconfig.
Flag: com.android.launcher3.floating_search_bar
Test: Build (existing code unchanged)
Bug: 346408388
Fix: 346406981
Change-Id: Ia8d15ceb1b2b4754657844d602cb95b9555a4ece
2024-06-12 01:24:36 +00:00
Himanshu Gupta 261a62219b Prompting the user to set Pixel/Quickstep as default Home app.
requestQuietMode API throws SecurityException in case its called
from a non-default Launcher app.
To mitigate this, we catch the exception and prompt the user
to set their default launcher to the current app.

Video(Pixel): https://photos.app.goo.gl/ni5X1c6vBbYW2JMJ9
Video(Pixel-aosp): https://photos.app.goo.gl/cYLJpTYW76Jnbonc9

Bug: 320446272
Test: Manual
Flag: NONE Bug fix tweak.
Change-Id: I6afb2ae85cabc038e1503e9c34eebd974c4f7a50
2024-06-11 19:11:21 +01:00
mpodolian 84f9cfabb9 Add outline to the bubble bar background view.
Added outline to the bubble bar background. Updated pointer
appearing/disappearing animation - now pointer moves into the bubble
bar background.
Demo: http://recall/-/gx8ASgewUeUS3QYohfrd1J/e1wZMrFZTILq73ik8wwrwx

Fixes: 345489039
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: Manual. Expand and collapse bubble bar with the light and the
dark theme.

Change-Id: I095fdc12337955aa21ee0eb622a924ad424ef186
2024-06-11 19:03:24 +01:00
Pragya Bajoria d8522b7828 Update the flag check for back gesture to include tablet filtering to reduce the scope of desktop windowing logic.
Change-Id: I15edeceebfdc14569c1b98caf62c741b40049200
Bug: 346249587
Flag: EXEMPT (windowing is currently only limited to Tablet)
2024-06-10 19:29:30 +00:00
Liam Lee Pong Lam df709d9aef Merge "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard shown" into main 2024-06-10 17:40:24 +00:00
Federico Baron 4ebc6777cb Merge "Fix folder animation clipping and RTL issue" into main 2024-06-08 00:22:45 +00:00
Shamali Patwa 7902265f77 Merge "Fix the flaky screenshot test" into main 2024-06-07 23:14:15 +00:00
Brandon Dayauon 14fb9f27f4 Merge "Make private profile header scrollable" into main 2024-06-07 22:16:42 +00:00
fbaron 31d5b01ecf Fix folder animation clipping and RTL issue
Fix: 341433475
Test: NONE
Flag: EXEMPT bugfix
Change-Id: I05c1ca65efea2fdcebb6ff9435fda1f4bbafb9f1
2024-06-07 15:09:30 -07:00
Ats Jenk cdc0e2c9c9 Check the feature flag before showing bubbles shortcut widget
Flag: com.android.wm.shell.enable_retrievable_bubbles
Bug: 340337839
Test: manual

Change-Id: I39424de3c448a1991a62dd198c195db5418788ba
2024-06-07 11:05:10 -07:00
Mykola Podolian d00bc8a0e7 Merge "Remove scrim view alpha when bubble manage menu is shown." into main 2024-06-07 17:30:57 +00:00
Alex Chau 7656f3c604 Merge "Reserve space for system bars in both orientations in fake orientation" into main 2024-06-07 17:03:03 +00:00
Alex Chau f7c9466c8f Reserve space for system bars in both orientations in fake orientation
- In BaseContainerInterface.calculateTaskSize, combine both portrait and landscape/seascape insets to leave space for status bar/nav bar in either orientations.
- Rotate the paddings to portrait before applying
- Don't use getOverviewActionsClaimedSpace() in fake landscape/seascape

Bug: 344727200
Test: We can't currnetly autotest fake orientaiton
Test: With gesture/3-button, rotate Overview to portriat/landscape/seascape/fake-landscape/fake-seascape, launch task and enter overview
Flag: EXEMPT bugfix
Change-Id: Icda0f483781921cae78f1ea3ef003562b60ad75a
2024-06-07 16:28:19 +01:00
Shamali P 277a4f9d78 Use just the preview for drag and drop in the standalone activity
Bug: N/A
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I62c42b649e720826979123ae2ff6c5e238fe59dc
2024-06-07 00:00:31 +00:00
Shamali P d69e21f8fe Ensure widgets from WidgetSections.xml are included in suggestions
Additionally, let only prediction system provide suggestions, since the
UI surface has been there for a while, adding locally filtered widgets
from app package isn't required.

Bug: 345520128
Test: Unit tests
Flag: EXEMPT bugfix
Change-Id: Ia97f0743fefeae750e07a694bb19d24a5cc11ffe
2024-06-06 22:23:35 +00:00
Shamali Patwa 50fa2e404f Fix the flaky screenshot test
The flake happened to be due to rebinding triggered on attachToWindow that reset the icon cache with placeholder icon

Based on what I see, instead of calling refresh and bind, just triggerring onWidgetsBound should be okay - assuming it was trying to bind view for case when theme or display size was changed while picker was open.

Bug: 337916664
Change-Id: Ic6f3ff9188e4c5eda141a948ffa0c2c7c685162e
Test: Screenshot test
Flag: EXEMPT bugfix for test
2024-06-06 14:07:03 +00:00
mpodolian 4d8ad445c0 Remove scrim view alpha when bubble manage menu is shown.
Updated logic for taskbar scrim view alpha calculation, setting it to 0
when bubble manage menu is shown.

Fixes: 337169457
Flag: NONE
Test: Visual.
For gesture navigation:
1) On foldable phone while device is being folded expand any
bubble, click mange button, then unfold. Observe no scrim view is
visible.
2) Enable persistent taskbar, pull down the notification shade then
swipe it back up while bubbles are open.
3) Enable persistent taskbar, pull down the notification shade then
swipe it back up while bubbles and mange menu is open.
4) Enable persistent taskbar. Fold device. Open bubble and click manage
button. Unfold device. Observe no scrim view is visible.

For 3 button navigation
1) Unfold the device, press the home key, pull down the notification
shade then swipe it back up while bubbles are open.
2) Unfold the device, press the home key, pull down the notification
shade then swipe it back up while bubbles and mange menu is open.
3) Fold device, open bubble and click manage button. Unfold device.
Observe no scrim view is visible.

Change-Id: Ic011ae9bd11801a479062cc51c60377823a926fb
2024-06-06 00:32:08 +01:00
Xiaowen Lei 5eae66429e Merge "Don't add padding for Smartspace (actual and preview)." into main 2024-06-05 22:56:07 +00:00
Treehugger Robot 4dc0025ebe Merge "Push a potential fix for hotseat aggregation" into main 2024-06-05 20:39:11 +00:00
Sihua Ma a44f4ac861 Push a potential fix for hotseat aggregation
This could be caused by landscape layout not receiving inset changes

Adding logs for hotseat layout info as well

Bug: 335141365
Flag: EXEMPT bugfix
Test: N/A
Change-Id: I987f8622907a10fac5375ddddac3db2c5eba41c1
2024-06-05 18:58:23 +00:00
Brandon Dayauon 901edc82e6 Merge "Consolidate the header views updating into a single method" into main 2024-06-05 16:25:38 +00:00
Treehugger Robot 6a69160999 Merge "Add debug logs to TopTaskTracker" into main 2024-06-05 16:17:19 +00:00
Schneider Victor-tulias 86b9ad4ff7 Add debug logs to TopTaskTracker
Flag: NONE debug logs
Bug: 342247547
Test: checked TIS logs
Change-Id: I6c8440af122a0376ffd77df6c8c9b9aeb742d447
2024-06-05 10:34:15 -04:00