Commit Graph

14449 Commits

Author SHA1 Message Date
Vinit Nayak 2ca82f38e4 Merge "Improve Split portrait gesture animation" into tm-qpr-dev 2022-11-10 19:19:39 +00:00
Luca Zuccarini 3d69d9bd98 Merge "Fix IME sync flicker with 3-button navigation." into tm-qpr-dev 2022-11-09 10:19:30 +00:00
TreeHugger Robot 8dd01f3ac2 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev 2022-11-09 01:07:11 +00:00
Jon Miranda e7011d2b87 Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."
This reverts commit d5a6b5f688.

Reason for revert: Breaks tests due to "SharedPreferences in credential encrypted storage are not available until after user is unlocked"

Bug: 258256906
Change-Id: I1de69249685f9d2e71183357cf3eda8d443c7d97
2022-11-08 21:56:52 +00:00
Jon Miranda 3153cd9b97 Proposal to move Developer Options to top of Home settings if studio build.
- Increases developer efficiency by avoiding the need to scroll

Bug: 258263867
Test: manual
Change-Id: I6cb46fdd12b51f8c45017f823dd4b2458e21fc72
2022-11-08 20:50:42 +00:00
Vinit Nayak 29e71bdd72 Improve Split portrait gesture animation
* Crop out taskbar from bottom thumbnail for vertical split
* TODO: Need to re-calculate thumbnail sizes if taskbar
 is stashed. There's also a very slight rounding error
 somewhere even in the unstashed case that needs to be
 revisited

Bug: 219411750
Test: Start gesture animation in split in potrait
Change-Id: I35f2415e13af7467e0735ac8865cee0e3e3d27f8
2022-11-08 11:33:08 -08:00
Luca Zuccarini 81f5cee2cb Fix IME sync flicker with 3-button navigation.
With keyboard sync, the dismissal is handled by the animator. Calling
hideKeyboard() on top of that causes the two signals to conflict with
each other, resulting in the visible flicker and extra delayed hiding
animation.

Fixes: 251185052
Test: manual, see videos in the bug

Change-Id: Ic12ad304ef9e4b6a51279ce18d6c09ba93bd59be
2022-11-08 17:26:46 +00:00
Alex Chau 1feadf7d81 Merge "Improve spaces for folders" into tm-qpr-dev 2022-11-08 16:51:50 +00:00
Jon Miranda d5a6b5f688 Add TaskbarModeSwitchRule to test both transient/persistent taskbar.
- Lays the foundation for transient taskbar tests.
- Does not add flags that would add ACTION_OUTSIDE in tests.
  We can address testing this functionality in a separate CL

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I44acc5e589b959e6d4bc93fdc369e503c54e7d87
2022-11-07 14:18:37 -08:00
Thales Lima b35faed6e7 Improve spaces for folders
Bug: 214582832
Test: DeviceProfileTest
Change-Id: I7c5cae0792d51baf111d0aec46be302ac6ca9994
2022-11-07 18:23:48 +00:00
Sebastián Franco fda1f3c379 Merge "Making code more readable by removing global variable used for optimizations" into tm-qpr-dev 2022-11-04 17:46:22 +00:00
Sebastián Franco c3cefebab4 Merge "Ensure that the reorder preview and what gets submited uses the same solution." into tm-qpr-dev 2022-11-04 17:45:28 +00:00
Jon Miranda 71370c58eb Merge "Update insets for transient taskbar" into tm-qpr-dev 2022-11-04 15:09:12 +00:00
Sunny Goyal 8d3241b359 Merge "Adding support for multiple overlay callbacks" into tm-qpr-dev 2022-11-04 14:13:12 +00:00
Holly Jiuyu Sun 341cd8589c Merge "Update gBoard icon to Go/Search depending on suggestions." into tm-qpr-dev 2022-11-04 03:58:18 +00:00
TreeHugger Robot 12aec8aa29 Merge "Waiting for app install to finish before procedding with the test" into tm-qpr-dev 2022-11-04 02:04:10 +00:00
Jon Miranda 7e8195081e Update insets for transient taskbar
Bug: 252905206
Test: manual
Change-Id: I03bd493dbe63274c8e90cb5e415127a1dd93e9b8
2022-11-03 17:16:48 -07:00
Holly Jiuyu Sun 15bdce40b0 Merge "Bring up IME and focus on input when scroll to top." into tm-qpr-dev 2022-11-03 23:54:31 +00:00
Holly Sun b0fb5096ba Update gBoard icon to Go/Search depending on suggestions.
If there is a highlight item, show Go (->) icon. Otherwise, show Search (magnifying glass) icon.

Implement maybeUpdateEnterKeyIcon() in NexusLauncher because it's gBoard specific.

Test: manual. Verify icon changes according to states.
Bug: 183467628
Bug: 210661150
Change-Id: I5dbcb54a37f9d37ae31bf3eaef241ea8a3ede510
2022-11-03 15:59:02 -07:00
Sunny Goyal 82379187ea Adding support for multiple overlay callbacks
Bug: 193244407
Test: Presubmit
Change-Id: Ic345972056752238e7e46226533fd8f33d664213
2022-11-03 14:37:40 -07:00
Sebastian Franco 5d990eedfd Ensure that the reorder preview and what gets submited uses the same solution.
Design doc: https://docs.google.com/document/d/1RsId9OFGgkcImkkmDwWZBBvITWnGlxKVqniE3cimkqY/edit#heading=h.xzptrog8pyxf

As can be seen in the diagram in b/256770363 on every reorder the
first call in the process is MODE_SHOW_REORDER_HINT so if we make
sure that only then a solution is calculated and we reuse that
solution in the rest of the calls in the same reorder then we would
have more consistency and the animation will always be the same and
the logic state.

Fix: 256770363
Bug: 188081026
Test: atest ReorderWidgets
Change-Id: I93a1d09f5b8cbfbc461043ee3fc41b1cab294fed
2022-11-03 14:11:01 -07:00
Sunny Goyal 50097ef272 Waiting for app install to finish before procedding with the test
Bug: 256659409
Test: Presubmit
Change-Id: Ia0f4cdd072c4c439d09070b0395fcfd6909c2a8f
2022-11-03 13:33:41 -07:00
TreeHugger Robot bcc14682e0 Merge "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile"" into tm-qpr-dev 2022-11-03 11:27:12 +00:00
Holly Sun a793fc6e2c Bring up IME and focus on input when scroll to top.
Do this behind a feature flag AND only when "Always show keyboard" is selected or in prefix state.

Bug: 218846025
Test: keyboard shown when swiping up for QSB and AA+ (both main and work). Keyboard not shown when either the feature flag or Always show keyboard is disabled.
Change-Id: I3df2e0e44a8313eaf749cd6b91b7f9d0b9b80ec3
2022-11-02 15:19:23 -07:00
Sebastian Franco 4a92267d1d Making code more readable by removing global variable used for optimizations
Using the stack was more efficient because it prevented the creation
of new rectangles but it makes the code harder to read and prone to
bugs if the global state of the stack of rectangles gets corrupted
in any way.

When this optimization was written in 2008 it was necessary but now I
don't think it would have a big impact. The stack size is on average
of 30 and the rectangles are only created when doing the reorder which
runs about once per second if the user moves the finger too quickly.

Bug: 188081026
Test: atest ReorderWidgets
Change-Id: I35d8ee8d92f01035e72fe5763a7de47f4b6a73de
2022-11-02 22:10:14 +00:00
Sebastián Franco ef24d5954c Merge "Return the right radius to start reorder when dragging a Widget" into tm-qpr-dev 2022-11-02 21:19:44 +00:00
Alex Chau 5dfd939d41 Reland "Add logs for InvariantDeviceProfile.getDeviceProfile"
This reverts commit b065b4b05a.

Bug: 253338238
Change-Id: Idea32130c8ec535f848ded5cff0269d97ea064e2
Test: manual
2022-11-02 17:40:05 +00:00
Tony Wickham 6b32ce07b1 Merge "Decrease TAPL All Apps scrolling flakiness" into tm-qpr-dev 2022-11-02 15:39:45 +00:00
Sunny Goyal 3c7054f0d2 Updating widget prediction handling:
When handling widget prediction, first match the full provider names
Only if no widgets are found, match any widget in the package

Bug: 256202399
Test: atest WidgetsPredicationUpdateTaskTest
Change-Id: I5337618d935f8b926803aeefede46059545de72d
2022-11-02 02:24:21 +00:00
Sebastián Franco 1b14a73223 Merge "No code changes, this cl only reorganizes the functions" into tm-qpr-dev 2022-11-01 23:43:30 +00:00
Sebastian Franco 9cab1c3ece No code changes, this cl only reorganizes the functions
This is done such that future cls are easier to visualize.

Bug: 188081026
Test: atest ReorderWidgets
Change-Id: I749d21b517dada97887d5b5e7cb5e2ac644d0030
2022-11-01 18:24:43 +00:00
Federico Baron 120c99f440 Merge "Tapping on a "folder" on the Homescreen right after returning home results in it starting to open, then canceling." into tm-qpr-dev 2022-11-01 17:56:50 +00:00
Tracy Zhou 0c853991fd Merge "Support split from fullscreen with shortcuts" into tm-qpr-dev 2022-11-01 17:17:33 +00:00
Luca Zuccarini 938dde8111 Merge "Make sure that PropertySetter applies the final state." into tm-qpr-dev 2022-11-01 12:28:54 +00:00
TreeHugger Robot 86dc1edbf8 Merge "Move DropTargetBar to bottom" into tm-qpr-dev 2022-11-01 07:21:31 +00:00
TreeHugger Robot d20e6676b1 Merge "Add dot pagination in workspace" into tm-qpr-dev 2022-11-01 04:33:29 +00:00
Tracy Zhou ba0b5952c8 Support split from fullscreen with shortcuts
Recording: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/978a3a55-2982-4026-9726-2a73cb694258

TODO: improve transition animation

Bug: 246661484
Test: manual
Change-Id: Id0d1aec0685bc18f4b273f8e466996efc1d9a3d8
Merged-In: Id0d1aec0685bc18f4b273f8e466996efc1d9a3d8
2022-11-01 04:30:39 +00:00
Sebastián Franco 0c3f990b34 Merge "Decoupling finding the solution and animation of a reorder in CellLayout" into tm-qpr-dev 2022-10-31 23:02:44 +00:00
Federico Baron 8bf1bca59a Tapping on a "folder" on the Homescreen right after returning home results in it starting to open, then canceling.
Fix: 243531200, 253264925
Test: manual
Change-Id: I180300e8333536346ad07ce7bc9956d3b84d82e6
2022-10-31 15:12:17 -07:00
Holly Jiuyu Sun c5f43eb9f7 Merge "Log sub event type to latency logger." into tm-qpr-dev 2022-10-31 19:28:27 +00:00
Sebastian Franco c8392ea881 Return the right radius to start reorder when dragging a Widget
Currently the radius is only one cell but in the case of a widget
we want the radius of the whole widget.

Fix: 255421400
Test: this case only happens when dagging comming from outside of the cell layuot in the corners dragging a widget
Change-Id: I3fe294d18283dbecb27df1a2d4748dd44db9b956
2022-10-31 10:20:53 -07:00
Sunny Goyal 276e72c249 Merge "Fixing flakyness in widget tests" into tm-qpr-dev 2022-10-31 16:23:08 +00:00
Holly Jiuyu Sun 35b0378d45 Merge "[QL-v2] Use subtitle as hint if title doesn't apply." into tm-qpr-dev 2022-10-28 19:35:33 +00:00
Sunny Goyal 1d76159de4 Fixing flakyness in widget tests
For some predicted app widgets, the layout happens before the recyclerView
can layout completely (because of preview layout invalidation), causing the
scroll cache to get in a wrong state.
Checking for scroll cache validity everytime instead of only during
data changes

Bug: 255797215
Test: Verified by hardcoing the chrome widget as predicted widget
Change-Id: Id2c68560baa45de89e08c53bdb9ee6820eab68c4
2022-10-28 12:25:04 -07:00
Sebastian Franco 53a15a4b1f Decoupling finding the solution and animation of a reorder in CellLayout
Adding new functions to CellLayout, two of them return a solution
(calculateReorder, getSimpleReorder) and the other one takes a
solution and animates that solution (void performReorder) and it can
either submit the solution or just show it for a preview.

Right now this two things are done under the same function:
int[] performReorder. The need to separate this two functions is
because to add this functionality b/188081026 which needs to find
soluion without animation and animation solutions that can be
calculated in another place.

Bug: 188081026
Test: atest ReorderWidgets
Change-Id: Ib519d4346f58f9b55aff5008cd3ccbcfe8443d2d
2022-10-28 11:55:50 -07:00
Holly Sun 4d6fa05c83 Log sub event type to latency logger.
Bug: 255355348
Test: build
Change-Id: Idac85b5e31e2abdd98f6fd1bed4ec687d8bb5cd5
2022-10-27 16:37:18 -07:00
Federico Baron 626d51c68c Move DropTargetBar to bottom
The DropTargetBar has "Remove" and "Uninstall" buttons for workspace edit mode. We are moving them to the bottom for workspace home gardening

Bug: 251259222
Test: Turn on flag HOME_GARDENING_WORKSPACE_BUTTONS and enter spring loaded mode (edit workspace), notice the buttons are now at the bottom
Change-Id: I739162bdd5764dd8367a63a67fae0fe5c7329b0a
2022-10-27 14:18:00 -07:00
Sihua Ma 17137e8bce Merge "Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost" into tm-qpr-dev 2022-10-27 17:53:28 +00:00
Alex Chau b3ab6f5014 Merge "Update pullback animation to use reset FloatProperty for non-active state" into tm-qpr-dev 2022-10-27 12:38:15 +00:00
Luca Zuccarini 05d19dc261 Make sure that PropertySetter applies the final state.
In some tests with animations disabled, NO_ANIM_PROPERTY_SETTER wasn't
applying the correct final value. See ag/20139786 for more context.

Bug: 251769927
Test: see other CL in topic, plus manual
Change-Id: I296de1a0d64768c43608839745cc7e955ecd2076
2022-10-27 09:31:57 +00:00