In some cases the controller can be null if the view is no longer
connected to the window.
Also, this issue seems to only happen in cuttlefish instances so there
might be a weird behaviour going on there but in any case is good to check
for nulls.
Test: No testing require is only null checkin, just making sure it compiles.
Bug: 302869930
Change-Id: I88d6091b57293e9493385185bfeb3e470c9bad84
Missing a flag check that is necessary in LoaderTask.java to prevent the code from running when the flag is off.
Bug: 300140279
Flag: SMARTSPACE_AS_A_WIDGET
Test: no test
Change-Id: Iaa89e8542475eb01f679f70734a61c13a3cde89f
[App Pairs 4/?]
This patch includes:
- Ability to save and launch app pairs with custom 0.3, 0.7, or 0.5 split ratios
- App pairs now save with default name "App1 | App2"
- Grid migration, prediction, and other misc. flows should now work with app pairs
Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274189428
Test: AppPairsControllerTest.java
Change-Id: I46dd3e30f8de03dd3e6d086c8ff9fc52e7e7fd2b
We used to estiamte more all apps icons to pre-inflate than needed. This would reduce the post boot memory useage.
Test: Grab heap dump after device boot to verify number of BubbleTextView is reduced
Bug: 297352492
Change-Id: Ice3950b781fe7b5d7df2c0c5c7b7a316b5851bc7
Here's a sample log run through of AllAppsStore and PackageUpdatedTask
logs: http://gpaste/5250747917664256
Bug: b/290090023
Flag: None. Adding logging.
Test: None. Adding logging.
Change-Id: Ia1d620a50267d6a65fe719936d7e87e6dad13afa
After reporting startup logs, we should tear down logger to prevent sending invalid logs
Bug: 302560751
Test: Verify rotating screen doesn't send startup logs to server
Change-Id: I8cf0a1a34aa9fffb67ddf83efe27908a28538551
Flag: SMARTSPACE_AS_A_WIDGET
Test: verify that the smartspace gets replaced with a smartspace widget
Bug: 300140279
Change-Id: I42c170de5e2a9fd3d24d99bb8b09cf412c55e3a5
Triggering all apps pre-infation at AllAppsStore#setApps is too late for taskbar, because it is in same frame when user opens all apps from taskbar. We should find an earlier entry point to pre-inflate all apps for taskbar.
Test: Verify taskbar is rendered correctly. Also verify we no longer pre-inflate all apps for taskbar in perfetto trace
Change-Id: If1f8c616b6be7f64ea16807f4b7a8b75da55d038
- Breakout CL part 5
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist of adding isTransientTaskbar as DeviceProfile Builder Poropety
- This cl alos consist a shared pref listener for taskbar pinning to update device profile.
Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I2ade751ffc8c59bd4b862b56c8ca7eb2aa05b7f2
Adding a flag so we can turn off this behavior if it break a drag functionallity
Fix: 299748096
Test: most of dragging test will test this
Change-Id: I4f45faea4f19bd99a946a28372546e18ca5f6a2f
During sys health review it was called out that we could lower the thread priority to pre-inflate BubbleTextView so that ui thread and loader task thread has better chance to run on big core.
Bug: 297352492
Test: Grabbed perfetto trace and observed preinflation is run on "preinflate-allapps-icons" thread
Change-Id: I9330d4fbe5a98cdb793e8bfa970dfd84ae1f6c39
- Keeping FeatureFlags.ENABLE_RESPONSIVE_WORKSPACE for local testing until aconfig is available in FlagFlipper
- Still reference ENABLE_RESPONSIVE_WORKSPACE in tests as aconfig still can't be mocked
Bug: 299935275
Test: manual
Change-Id: I092df894a3624dca6b9d381d56ada71d807547b5
Alex Chau
Brandon Dayauon
Sebastián Franco
Federico Baron
Jeremy Sim
Brian Isganitis
Fengjiang Li
Kevin Lim
Pat Manning
Jagrut Desai
Stefan Andonian
Schneider Victor-tulias
Thales Lima
Andrew Cole