Commit Graph

10745 Commits

Author SHA1 Message Date
Tracy Zhou 37baad8163 Merge "Patch npe in TaskbarAllAppsController" into tm-qpr-dev am: c3ba24f06e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18791875

Change-Id: Id153e998e52d99f07536e374335cf70f5109af70
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 22:28:13 +00:00
Tracy Zhou c3ba24f06e Merge "Patch npe in TaskbarAllAppsController" into tm-qpr-dev 2022-06-09 22:12:08 +00:00
Hongwei Wang d1e80e3c89 Merge "Do not attempt auto-enter-pip if there is no valid leash" into tm-qpr-dev am: 40f049bcb4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18818897

Change-Id: Idf38229913c1e3aefd966d1924044df7a85c8ab7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 20:10:01 +00:00
Hongwei Wang 40f049bcb4 Merge "Do not attempt auto-enter-pip if there is no valid leash" into tm-qpr-dev 2022-06-09 19:55:45 +00:00
Tracy Zhou 2583fb48b8 Patch npe in TaskbarAllAppsController
b/234617317#comment3

Bug: 234617317
Test: manual
Change-Id: I7cff0df86db4fdf58b33240594784598950f1a88
2022-06-09 19:22:31 +00:00
Hongwei Wang 1cd4162b82 Do not attempt auto-enter-pip if there is no valid leash
No reproduce path for the bug being reported, this fix is to ensure we
do not start the auto-enter-pip animation with invalid leash at the
first place.

Bug: 234796719
Test: N/A for the bug, verify the normal auto-enter-pip still works
Change-Id: I6f2164a322877f1b0213a1ee09eb476090300c7f
2022-06-09 10:27:18 -07:00
TreeHugger Robot 5f6281f3ed Merge "Hide taskbar while VoiceInteractionWindow is visible" into tm-qpr-dev am: e9f606f995
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18798079

Change-Id: I79f5f1fba2a4033769de2acdf1e74d1a1348e0f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 17:22:40 +00:00
TreeHugger Robot e9f606f995 Merge "Hide taskbar while VoiceInteractionWindow is visible" into tm-qpr-dev 2022-06-09 16:55:38 +00:00
Alex Chau f290797184 Merge "Use normalized CachedDisplayInfo as key" into tm-qpr-dev am: cbde3a3a8d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18754331

Change-Id: I4a84ca5e6752c936538288fae986da2edad4711f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 15:26:22 +00:00
Alex Chau cbde3a3a8d Merge "Use normalized CachedDisplayInfo as key" into tm-qpr-dev 2022-06-09 15:10:27 +00:00
Alex Chau 661f02de18 Use normalized CachedDisplayInfo as key
- For system Launcher, migrate to use getPossibleMaximumWindowMetrics instead of getDisplays
- Removed usage of displayId
- In estimateInternalDisplayBounds, use CachedDisplayInfo directly as a key
- When cache retunrs null for the current display (e.g. the 3P launcher case), invalidate the cache and estimate again, and only add to supportedBounds if current display is not found in the new cache

Bug: 227459045
Bug: 198965093
Test: manual
Change-Id: Ibcc05ba483ed31a40d16e3cf49c3f3d43af68cf6
2022-06-09 11:36:47 +01:00
Tony Wickham 9a54d2aa43 Hide taskbar while VoiceInteractionWindow is visible
- Fade out icons (or stashed handle if stashed)
- Move background to APPLICATION_OVERLAY layer (behind VIW)
  - Only for gesture nav
- On home screen in 3 button mode, translate buttons down when assistant
  is invoked

Test: Invoke assistant, ensure it draws above taskbar background and
taskbar stops drawing icons or stashed handle
Bug: 225200928

Change-Id: I7807d30df8f358295b8231d89217c7413f32c6f9
Merged-In: I7807d30df8f358295b8231d89217c7413f32c6f9
2022-06-09 05:21:42 +00:00
Jerry Chang 74c70f1f89 Merge "Prevent wallpaper flicker while entering split screen from overview" into tm-dev am: 0b944f6a4d am: 585411a3fa am: 291115ce7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18797269

Change-Id: Ie7c71ca5ccd2aa2bd8c98b042a1f1c3560468099
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 02:41:07 +00:00
Jerry Chang 291115ce7e Merge "Prevent wallpaper flicker while entering split screen from overview" into tm-dev am: 0b944f6a4d am: 585411a3fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18797269

Change-Id: I7cf326d0a00c4b1dccbd3472b1adc5ec8aa9b418
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 02:07:24 +00:00
Jerry Chang 585411a3fa Merge "Prevent wallpaper flicker while entering split screen from overview" into tm-dev am: 0b944f6a4d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18797269

Change-Id: Ia67807cf497fed81837707dcc401aeaa7d6f4a72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 00:54:35 +00:00
Jerry Chang 0b944f6a4d Merge "Prevent wallpaper flicker while entering split screen from overview" into tm-dev 2022-06-09 00:32:49 +00:00
Becky Qiu 5b4816a119 Merge "[Toast] Add query_length for launcher latency logging." into tm-dev am: fe83fce489 am: f9dfd06424 am: 9074e97780
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18783028

Change-Id: I2a0888dcd1487533dc0d7c2d18f1384ada177823
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 19:20:35 +00:00
Becky Qiu 9074e97780 Merge "[Toast] Add query_length for launcher latency logging." into tm-dev am: fe83fce489 am: f9dfd06424
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18783028

Change-Id: I339a468a49fc8490154dd0dc4d6266ab6e41f90e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 18:52:38 +00:00
Becky Qiu f9dfd06424 Merge "[Toast] Add query_length for launcher latency logging." into tm-dev am: fe83fce489
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18783028

Change-Id: I95de30e9971e85981814ca5298d1956870720c76
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 18:26:24 +00:00
Becky Qiu fe83fce489 Merge "[Toast] Add query_length for launcher latency logging." into tm-dev 2022-06-08 18:02:07 +00:00
Jerry Chang c04af333f5 Prevent wallpaper flicker while entering split screen from overview
When launching a pair of apps from overview panel, it will perform
cross-fade animations to transit from overview to the split pair. But
wallpaper might be visible for a while when both overveiw and split pair
is transparent during the transition. This updates to not fade-out
overview until the split pair is finishing showing in foregorund to
prevent the flicker of wallpaper.

Bug: 235137249
Test: swipe to home and enter overview panel, select and swipe down to
      enter a split pair, verified there's no flicker.
Change-Id: Iec1dc49e260f6e46640d47295d7f65dad5c24ab5
2022-06-08 15:26:25 +00:00
Winson Chung cd95768e0e Merge "Revert changes waiting for launcher to resume when transitioning to home" into tm-dev am: 46c9c66048 am: 0cf33355a0 am: d3a7d37a57
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18764661

Change-Id: Ice05097acc2736d7c313dc04900e501c4f003191
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 04:00:09 +00:00
Winson Chung d3a7d37a57 Merge "Revert changes waiting for launcher to resume when transitioning to home" into tm-dev am: 46c9c66048 am: 0cf33355a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18764661

Change-Id: I8b0f3b1e6a93f124ba16506872372f6e856dabf2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 03:50:20 +00:00
TreeHugger Robot edd37684ed Merge "Show split option without consider the "Lock task mode"" into tm-qpr-dev am: 34bc21ffb0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18753549

Change-Id: I6b2949fc96d748fc0a6c24f4c6e340927dd82730
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 03:44:55 +00:00
Winson Chung 0cf33355a0 Merge "Revert changes waiting for launcher to resume when transitioning to home" into tm-dev am: 46c9c66048
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18764661

Change-Id: I94743a4cf5b3db0d65e1139c715048b16f9c77a5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 03:20:12 +00:00
Winson Chung 46c9c66048 Merge "Revert changes waiting for launcher to resume when transitioning to home" into tm-dev 2022-06-08 03:11:16 +00:00
TreeHugger Robot 34bc21ffb0 Merge "Show split option without consider the "Lock task mode"" into tm-qpr-dev 2022-06-08 02:35:57 +00:00
TreeHugger Robot df4ac7549c Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev 2022-06-08 02:31:19 +00:00
Jon Miranda 75923f1b6a Merge "Pause expensive view updates before setting hw/sw layers." into tm-dev am: 2dac4f7f4c am: dfe3b8b755 am: 2245de7674
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18673700

Change-Id: I64b5017aa7934117556847d6e723dc44bf249215
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 01:47:39 +00:00
Jon Miranda 2245de7674 Merge "Pause expensive view updates before setting hw/sw layers." into tm-dev am: 2dac4f7f4c am: dfe3b8b755
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18673700

Change-Id: Ib4dd2fdbc93a7ac05e9d141183770cb33db26db6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 01:07:18 +00:00
Jon Miranda 2dac4f7f4c Merge "Pause expensive view updates before setting hw/sw layers." into tm-dev 2022-06-08 00:15:35 +00:00
Vinit Nayak 4ce1da62ef Merge "Rename split classes/variables for consistency" into tm-qpr-dev am: 2339933924
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18639433

Change-Id: I6d251c1f29775d364890da194f8deb11322044b1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-07 22:42:30 +00:00
Vinit Nayak 2339933924 Merge "Rename split classes/variables for consistency" into tm-qpr-dev 2022-06-07 22:36:47 +00:00
Becky Qiu a61a2cc962 [Toast] Add query_length for launcher latency logging.
Bug: 235249335
Test: no test needed.
Change-Id: Ia16c241a2eb3cb50a17713216182192f7902be9e
2022-06-07 14:20:52 -07:00
Bill Yi 774a541d61 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I6b3c69716125ca572ccb9b5cbd35831c60620519
2022-06-07 13:55:30 -07:00
Jerry Chang abd388c2e4 Merge "Fix Flicker of inner corners in split screen when quick switching to" into tm-qpr-dev am: 37d39619fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18706309

Change-Id: Ia8342e6652b3dbeab92bc6c068433ea64dd8715e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-07 01:12:48 +00:00
Jerry Chang 37d39619fa Merge "Fix Flicker of inner corners in split screen when quick switching to" into tm-qpr-dev 2022-06-07 00:55:51 +00:00
Winson Chung 29c68e73dc Revert changes waiting for launcher to resume when transitioning to home
- This was added for Go when they had their own recents implementation
  and isn't necessary for the default implementation

Bug: 229668039
Test: Follow steps using test apk from the bug
Change-Id: I0c36f98683e1bf9a3dc11cde2d1113ed1c4d6448
2022-06-06 22:28:09 +00:00
TreeHugger Robot 1a339394af Merge "Ensure null elements aren't added to TaskView shortcut list" into tm-qpr-dev am: 9307776597
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18759197

Change-Id: I19a2a12de503313067a5516ce401dbbd0fb6c894
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-06 21:59:54 +00:00
TreeHugger Robot 9307776597 Merge "Ensure null elements aren't added to TaskView shortcut list" into tm-qpr-dev 2022-06-06 21:36:43 +00:00
Vinit Nayak 7b3916c550 Merge "Remove old split screen overview related code" into tm-qpr-dev am: 2aa5a816e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638742

Change-Id: Ie15ebcfbe2c1e5dada52b475511278a928beff9e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-06 21:12:54 +00:00
Vinit Nayak 5424fca602 Rename split classes/variables for consistency
* Use "select" when in the split screen
invocation process
* Drop usage of "staged" except when defining
constants

Fixes: 233006032
Change-Id: I809f0e1e9742aa6b6b09ad8731896ad3f0c9deb0
2022-06-06 14:02:15 -07:00
Vinit Nayak 2aa5a816e9 Merge "Remove old split screen overview related code" into tm-qpr-dev 2022-06-06 20:49:45 +00:00
Vinit Nayak da9213791e Ensure null elements aren't added to TaskView shortcut list
Bug: 234874147
Change-Id: I5ed84fdc64128264e5808b7d3b019c47e3740469
2022-06-06 09:18:42 -07:00
Jeff Chang 5ee83f3b5e Show split option without consider the "Lock task mode"
wm-core supports split-screen and lock-task mode work together now.
This CL enables the split-option to allow users to enjoy the
split-screen experience.

Bug: 199342537
Test: Options show up as expected
Change-Id: I38f58dec2985eaaabdbed1fdeeeece2d6e59945f
2022-06-06 14:47:47 +08:00
TreeHugger Robot 71311797b6 Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev am: c012085c6c am: 774c53f919 am: 5b765189e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521352

Change-Id: I3a54c582097c75b9d643b2c2063f02186ad4837a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 02:42:28 +00:00
TreeHugger Robot 5b765189e2 Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev am: c012085c6c am: 774c53f919
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521352

Change-Id: If494d52f37fd556dca2fd6960bb69490c812e5fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 02:26:26 +00:00
TreeHugger Robot c012085c6c Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev 2022-06-04 01:38:29 +00:00
Tony Wickham 8d72018a87 Don't allow swiping to HintState if we're already in HintState
Context: there was a bug where you could get stuck in HintState if you
did the following (timing is critical):
1. Short swipe from nav region towards HintState, but not far enough or
   fast enough to commit before letting go; this cancels the state
   animation, returning towards Normal (but, crucially, StateManager
   still has state set as Hint)
2. While previous animation is animating back to Normal, swipe up again,
   but this time faster/farther to actually reach Hint; this time, the
   animation does go towards Hint, but gets stuck there. The reason it
   gets stuck is because StateManager thinks we're already in Hint from
   step 1, so doesn't call onStateTransitionEnd(Hint) in step 2. Thus,
   we never get QuickstepLauncher#onStateSetEnd(Hint), which is what we
   rely on to return to Normal.

The simple fix is to prevent the second swipe in the first place.

Test: short swipe followed immediately by fast fling from nav region on home successfully stays in Normal state intead of getting stuck in HintState
Test:
NexusLauncherOutOfProcTests: com.google.android.apps.nexuslauncher.TaplTestsNexus
Fixes: 228276181
Change-Id: I54c371c8518a9a220e75c98003331b552d8bf8af
2022-06-03 14:56:04 -07:00
Ats Jenk d2082c8c65 Merge "Enable bubbles home gesture by default" into tm-qpr-dev am: e048af300b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18720602

Change-Id: I902285c63d03346e4edbdfc8863357fc4acc939b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-03 19:38:37 +00:00