Commit Graph

18664 Commits

Author SHA1 Message Date
Treehugger Robot 362050932e Merge "Making some classess accessible in multivalent tests" into main 2024-03-21 10:38:08 +00:00
Tony Wickham 3c58551e12 Cancel animations after reading MotionPauseDetector#isPaused()
Otherwise, it clears MotionPauseDetector so isPaused returns false.

Fixes: 330186943
Flag: none
Test: manual
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:77802d6da48320e5f5cf5c420fe31a1aa14e478e)
Merged-In: I9e0982c18cc5264a1fab53077ac551d2880a6eae
Change-Id: I9e0982c18cc5264a1fab53077ac551d2880a6eae
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
2024-03-21 07:57:56 +00:00
Vinit Nayak 41e0e65bd4 Merge "Call setOverviewDragState() whenever taskbar is recreated" into 24D1-dev 2024-03-21 02:43:11 +00:00
Treehugger Robot 6a8662c560 Merge "Increase IME switcher Left Margins to meet spec" into main 2024-03-21 02:17:05 +00:00
Sukesh Ram aad306396e Increase IME switcher Left Margins to meet spec
Increase IME switcher Left Margins to meet specifications for taskbar. Result: https://screenshot.googleplex.com/5Ab33jnZiDY5tqm

Flag: NONE
Test: Manually tested in Felix Landscape mode.
Bug: 324269623
Change-Id: Ife3714c4d22d96851618a88ed217009c4f9c3929
2024-03-21 01:04:28 +00:00
Jeremy Sim c22b39a319 Prevent Save App Pair from showing up on 3p launcher
This CL adds a check so that app pairs can't be saved on 3p launchers. This affects the Overview icon dropdown menu and the Overview Actions Bar.

Fixes: 326155701
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, option does not show up when Nova Launcher is set as default home app, and shows up again for Pixel Launcher.
Change-Id: I60d6fd3b3eb39921edafb12faace743d16de270f
(cherry picked from commit 2b2d8cc90b)
Merged-In: I60d6fd3b3eb39921edafb12faace743d16de270f
2024-03-20 23:35:29 +00:00
Willie Koomson 2471805414 Handle widgets added with tap-to-add in AppEventProducer
Widgets added with tap-to-add do not emit an ITEM_DROP_COMPELTED event,
so this change updates AppEventProducer to check for
WIDGET_ADD_BUTTON_TAP event so that it can emit an ACTION_PIN
event for these widgets as well.

Also moves the stats logging for tap to add to after
Launcher.addPendingItem is called, so that the PendingAddItem's container
is set to CONTAINER_DESKTOP.

Bug: 323886237
Test: manual, add widget and confirm event is produced through logging,
 and widget no longer appears in suggestions
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add STAGING
Change-Id: Iaf46a408d05f61864a79f87b23160364b6513323
2024-03-20 22:07:02 +00:00
Federico Baron 0584c86ce6 Revert "Add screenrecord for testOverviewDeadzones"
This reverts commit eb65ca1600.

Reason for revert: test fixed with ag/26635495

Change-Id: Ic6b131f7a50e8b4f651b601cdf30304ce587eb5d
2024-03-20 20:55:57 +00:00
Vinit Nayak 5afb093a58 Merge "Add CUJ Jank interactions for App Pair saving and launching" into main 2024-03-20 20:31:01 +00:00
Sunny Goyal 5ca50490a3 Making some classess accessible in multivalent tests
Bug: 297950111
Flag: None
Test: Presubmit
Change-Id: I2e4b18fc279cb96b3f68d64f95703c11bb885b2a
2024-03-20 13:30:40 -07:00
Vinit Nayak 3b63408ad1 Call setOverviewDragState() whenever taskbar is recreated
* Un/Pinning taskbar re-creates controllers which led to
stale state for checking if we are allowing split selection

Test: Crash/immediately going into split no longer repros after
un/pinning taskbar in overview and trying to split
Fixes: 326356246

Change-Id: I06cfc4d1c3c7fe071f04414c3134eaff7960ade6
(cherry picked from commit 0adca26744)
2024-03-20 19:42:03 +00:00
Ats Jenk 259552350e Set bubble bar alpha to 0 and collapse if it bubbles are hidden
Only set bubble bar alpha to 0 and mark it collapsed when bubbles are
hidden.
When bubble bar should be hidden due to system ui state, only update
visibility.

Bug: 324068295
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: trigger a buble from bubbles test app
  - swipe to home screen
  - observe bubble bar is shown
  - swipe notification shade down and away again
  - observe bubble bar is hidden when shade is open, and shown when
    closed
  - expand bubble bar
  - repeat swipe shade down and away, observe expanded bubble is hidden
    while shade is open and bubble is expanded when shade is swiped away
Change-Id: Icc717ab250061f14f02a558eb9f7301fdc08c5c7
2024-03-20 12:12:53 -07:00
Vinit Nayak e0c3403a9a Merge "Call setOverviewDragState() whenever taskbar is recreated" into main 2024-03-20 17:20:48 +00:00
Sihua Ma f0518bb89f Fix out-of-sync updates during grid change
This is a combination of two issues:

1. Widget updates are not passed to the holder when the launcher binding starts
2. Updates from widgetHost.startListening() are overriden by out-of-date info

Fix: 322919716
Test: Manual
Flag: N/A
Change-Id: I9665117412c87b19ed5d98263bb4f9b8da21c5c7
(cherry picked from commit f418b2e16d)
2024-03-20 16:58:00 +00:00
randypfohl c91aad150c When mLastComputedTaskSize is empty we will recalculate and set it before determining scale and pivot
Bug: 326550571

Test: manually set computed task size to 0 simulating unset circumstance, and ran logs verifying infinite, added fix, and verified logs showing the same scale before and after with get tasksize set

Flag: none

(cherry picked from commit fca7ee23ba)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:9c4039e12dbc20dabf1d7e62b06bfd650706eaa7)
Merged-In: I0f928885e2fc6cfc0d6a064d6e9f1c614bf7a5af
Change-Id: I0f928885e2fc6cfc0d6a064d6e9f1c614bf7a5af
2024-03-20 16:37:55 +00:00
Andreas Agvard efbd882a99 Adds new AssistStateManager settings
Flag: NONE
Bug: 326143814
Test: Unit

Merged-In: Ie5cbae55452cf283a0ffde18e5237cebae6ee40e
Change-Id: Ie5cbae55452cf283a0ffde18e5237cebae6ee40e
2024-03-20 12:55:42 +00:00
Eghosa Ewansiha-Vlachavas dc40eeae80 Merge "Disable quickswitch interactions with desktop mode" into main 2024-03-20 12:22:13 +00:00
Alex Chau 4a2c9ae112 Merge "Ignoring a test that was flaky for a too long time" into main 2024-03-20 10:49:53 +00:00
Tiger 425aec696f Let taskbar can trigger insets resize animation
All the system bar can trigger insets resize animation before, but some
sources might not have the resize animation. The framework now will only
trigger insets resize animation for sources which apply
FLAG_ANIMATE_RESIZING. So this CL applies the flag for gesture taskbar
because it can toggle its size via "Always show Taskbar"

Bug: 291562764
Flag: NA
Test: Fold and unfold a foldable device and ensure that won't create
      InsetsResizeAnimationRunner.
Change-Id: I0d915422d160a81f12c3992ffe53200fd957f6d7
2024-03-20 17:45:12 +08:00
Andy Wickham 16cad65a85 Merge "Consolidate settings for Assist." into main 2024-03-20 03:00:08 +00:00
Vinit Nayak 0adca26744 Call setOverviewDragState() whenever taskbar is recreated
* Un/Pinning taskbar re-creates controllers which led to
stale state for checking if we are allowing split selection

Test: Crash/immediately going into split no longer repros after
un/pinning taskbar in overview and trying to split
Fixes: 326356246

Change-Id: I06cfc4d1c3c7fe071f04414c3134eaff7960ade6
2024-03-19 17:30:33 -07:00
Federico Baron 7bd1fa82f6 Merge "Remove logspam for resolved bug" into 24D1-dev 2024-03-19 21:02:29 +00:00
Tony Wickham 86d8386ab6 Merge "Add TaplTestsQuickstep#testExcludeFromRecents" into main 2024-03-19 20:28:58 +00:00
Vadim Tryshev 69e1d97653 Ignoring a test that was flaky for a too long time
Bug: 315376057
Flag: N/A
Test: presubmit
Change-Id: I34576501606eea999379733b4e36fb81cc137ef7
2024-03-19 11:50:23 -07:00
Treehugger Robot 4d22811f76 Merge "Cancel animations after reading MotionPauseDetector#isPaused()" into main 2024-03-18 23:53:17 +00:00
Vinit Nayak 422a634a24 Add CUJ Jank interactions for App Pair saving and launching
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true

Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device

Change-Id: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
2024-03-18 16:27:47 -07:00
Vinit Nayak c2a6055768 Merge "Launch overview instance of app for taskbar in Overview" into main 2024-03-18 23:21:23 +00:00
Brian Isganitis d1af1ec631 Merge "Support toggling Taskbar All Apps with 3P Launcher." into main 2024-03-18 23:17:55 +00:00
Tony Wickham b84b8524a1 Add TaplTestsQuickstep#testExcludeFromRecents
- Add ExcludeFromRecentsTestActivity, and add it to the manifest
  with excludeFromRecents="true"
- Add the test to check the current Overview task content
  description, ensuring that the excludeFromRecents task is
  present directly after a gesture but not after going home.
Bug: 324495241
Flag: None
Test: TaplTestsQuickstep#testExcludeFromRecents

Change-Id: I06be53673f0ac06924f79b44f19744da066cc7ea
2024-03-18 22:30:13 +00:00
Vinit Nayak b761e9834e Launch overview instance of app for taskbar in Overview
* This only works for fullscreen tasks, app pairs aren't
properly launching yet
* We re-layer the leash to be above launcher since live tiles
are originally below
* The new task comes in from TaskAnimationManager#onTaskAppeared

Bug: 316485863
Test: Tested w/ tapping fullscreen apps in overview when
their thumbnail is scrolled off screen. Animation occurs for
both live tile and thumbnail

Change-Id: I5a3c079244a1517becb845ce25ff9f4e671383b1
2024-03-18 14:41:57 -07:00
Tony Wickham 77802d6da4 Cancel animations after reading MotionPauseDetector#isPaused()
Otherwise, it clears MotionPauseDetector so isPaused returns false.

Fixes: 330186943
Flag: none
Test: manual
Change-Id: I9e0982c18cc5264a1fab53077ac551d2880a6eae
2024-03-18 19:11:57 +00:00
Liana Kazanova 7d5531757b Merge "Revert "Add CUJ Jank interactions for App Pair saving and launching"" into main 2024-03-18 18:39:20 +00:00
Liana Kazanova d8d4fb4375 Revert "Add CUJ Jank interactions for App Pair saving and launching"
Revert submission 26567492-appPairsCUJ

Reason for revert: http://b/330185095

Reverted changes: /q/submissionid:26567492-appPairsCUJ

Change-Id: I73d29fe3618a55622e0daa22c9960e3c5783c275
2024-03-18 18:35:02 +00:00
Vinit Nayak 025b06a1a3 Merge "Add CUJ Jank interactions for App Pair saving and launching" into main 2024-03-18 18:06:21 +00:00
Federico Baron 93c58db4c5 Merge "Revert^2 "Add screenrecord for testOverviewDeadzones"" into main 2024-03-18 16:52:24 +00:00
fbaron fe3f542e61 Remove logspam for resolved bug
b/318394698 was fixed so we can now remove these logs.

Fix: 321837497
Test: N/A
Flag: NONE
Change-Id: Ifc8b18238778f6aa2c0ad1be5df627c07cbaf1d8
(cherry picked from commit 7e5d855886)
2024-03-18 16:48:18 +00:00
Eghosa Ewansiha-Vlachavas 6faf846842 Disable quickswitch interactions with desktop mode
Disable quickswitch gestures when in desktop mode enviroment as well as
questures outside desktop mode that will result in the user entering
desktop mode.

Flag: NONE
Test: atest ShowImeOnAppStartWhenLaunchingAppFromQuickSwitchTest
      atest QuickSwitchBetweenTwoAppsForwardTest
      atest QuickSwitchBetweenTwoAppsBackTest
      atest QuickSwitchFromLauncherTest
      atest QuickswitchTest
      atest -c NexusLauncherTests:com.android.quickstep.TaplTestsQuickstep
      atest -c NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar
      atest -c NexusLauncherTests:com.android.quickstep.TaplTestsTrackpad
      atest -c NexusLauncherTests:com.android.quickstep.TaplTestsTransientTaskbar
Fixes: 330148342
Change-Id: If11901e6642036f8b8dda38b3419f6c10980d902
2024-03-18 16:22:32 +00:00
Graciela Wissen Putri 3f46a3d562 Unpin desktop task in overview
Desktop task should behave like any other task in overview and should
not show up as a large tile.

Bug: 309008406
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Test: Swipe fullscreen task into overview
      Open overview from home
      Swipe freeform task into overview
Test: Image test will be added in b/319237536
Change-Id: Iefca85747de7595357813d5ed999df0e4b51120a
2024-03-18 14:20:58 +00:00
Jordan Silva 5669ace402 Merge "Fix overview split task icon and app chips flipped and misaligned in fake orientation" into main 2024-03-18 09:57:03 +00:00
Federico Baron 435084cf0d Revert^2 "Add screenrecord for testOverviewDeadzones"
This reverts commit 4d1fe6b854.

Reason for revert: issue started occurring again

Change-Id: I5a5500c42209afc6b54f7dff60a821093d45294a
2024-03-15 22:58:06 +00:00
Vinit Nayak 7ce42078da Add CUJ Jank interactions for App Pair saving and launching
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true

Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device

Change-Id: I5dce4b7e83fb17cc3a70565bfd5ce100a4cf72bb
2024-03-15 14:10:36 -07:00
Bill Yi 6e5f97b5e5 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-15 20:30:19 +00:00
Jordan Silva c4ec531c9f Fix overview split task icon and app chips flipped and misaligned in fake orientation
This CL fixes the app and icon chip misaligned and wrong positioned in fake landscape and seascape.
The icon chip in seascape are still in RTL and it should be address in a different bug b/326377497.

Fix: 320314835
Fix: 326383211
Fix: 326383010
Bug: 328028913
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: manual. instructions described in the bug report.
Test: atest LandscapePagedViewHandlerTest
Test: atest SeascapePagedViewHandlerTest
Test: atest OverviewTaskSplitImageTest
Change-Id: I9be07cc4f4cf5ee6e1da0d954ed7664d96bd330c
2024-03-15 18:29:22 +00:00
Brian Isganitis 2f9ad4645e Reset stashed in Taskbar All Apps for gestures instead of IME insets.
Test: Manual
Flag: NONE
Fix: 328960039
Change-Id: I62c53c21bf850b7080e12086235cba28164f4d70
(cherry picked from commit 1956246b6e)
2024-03-15 18:13:12 +00:00
Brian Isganitis c113b277e6 Support toggling Taskbar All Apps with 3P Launcher.
Taskbar All Apps exists regardless of the default launcher. Thus, we can
toggle it on large screen devices. This CL ties registering the system
action to default launcher and taskbar's enablement.

Test: adb shell input keyevent 117
Test: AllAppsActionManagerTest
Flag: LEGACY ENABLE_ALL_APPS_SEARCH_IN_TASKBAR ENABLED
Fix: 317259709
Change-Id: I26f0ed9e921beac762f3f9e6aaceb1002ad4801a
2024-03-15 13:42:10 -04:00
Fengjiang Li 00711e68a5 Merge "Enable predictive back in TAPL tests" into main 2024-03-15 14:52:58 +00:00
Shamali Patwa a835a2dc92 Merge "Rename the color attr for paging dot indicator used in launcher." into main 2024-03-15 13:33:40 +00:00
Fengjiang Li e90f098d4f Enable predictive back in TAPL tests
With ag/26349940 we have fixed the bug where back swipe is not working

Fix: 326118348
Test: this is the test
Flag: NONE
Change-Id: I7e826f6ba3022a04d016d4a0a2134e287d85e8be
2024-03-15 00:00:37 -07:00
Bill Yi b71c4de721 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I829da66c3f4180644002ee837e38653f3244dd86
2024-03-14 22:09:28 -07:00
Bill Yi 6cb64e97dd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I80374e1c3d831e5afc0436c95cd6aba8fced52ea
2024-03-14 22:09:01 -07:00