It has never been enabled, and is not plan of record.
Bug: 201446691
Test: local and updated unit tests
Change-Id: I5ac6d40ba1dbcf28de4355cc51fff74cfb37ebc6
We were setting it again for the first child in any recursive call,
which could cause the color to be incorrect.
Test: Arrow always matches menu item below icon.
Fix: 201537864
Change-Id: I8f344bb7bdec4ebc51f8b8de118bec678d71e649
assignMarginsAndBackgrounds updates determines the new arrow color, but
it doesn't actually update it. That is normally done in
updateArrowColor.
Test: Icon menu arrow color changes to content above it after notification
dots dismissed.
Fix: 201458705
Change-Id: I5ee40b420b03c29c197983af5968d4f2902bc59b
This is to show them in ranking order sent by aiai.
Bug: b/201079509
Test: Added unit test in WidgetsTableUtilTest
Change-Id: I366ecaee8bc157aca185f633462d95fbd1dd180b
Fix: 200812841
Fix: 201306660
Test: Long press around QSB, hotseat, inbetween hotseat icons works
Test: Can scroll pages on top of hotseat and QSB
Test: Drag and drop still works in hotseat
Test: Can still press and long press on QSB
Change-Id: I3f6807be08ff2c55644e3bf8f6d05a3954a8ede6
This will improve diagnostics for OOP tests,
like we now have a list of leaked activity classes.
Also some cleanups.
Bug: 187761685
Test: local runs
Change-Id: I8b5711ac727874fd826cfef9c742ea97048763e0
The size returned by getWidgetItemSizePx is used by the widget picker
for the NavigableAppWidgetHostView. We should NOT deduct the padding
applied to NavigableAppWidgetHostView to this size.
If a launcher grid insets NavigableAppWidgetHostView, then we must
add the inset to the NavigableAppWidgetHostView width / height.
Test: Compare the size of widgets in preview and home screen using
layout inspector. See screenshots in the bug
Fix: 200983939
Change-Id: I35022861b65f2624f69940cf3856d9c47f8dbbd9
- Removed mRunningTargetWindowPosition and mSplitOffset, as they countered each other out anyway
- Removed PagedOrientationHandler#setLeashSplitOffset() since it's no longer used
Test: Swipe up from split and non split apps in both orientations on large and small devices, with and without home rotation enabled
Bug: 200817624
Change-Id: I78a80cbc718ee38a8933fa323798fb436710d59f
The previous computation ignored the left/right padding of the cell
layout.
Fix: 200968203
Test: Manually
Change-Id: I5a017b90c11e2cd710f16fece5cdae902ccb1e72
- Uses overscroll damping logic to reduce the velocity
- The start to target rect interpolation can be from the
start, center, or bottom of the rect depending on where the item
is on the workspace. This reduces the amount of distance needed to
travel between, which helps further reduce gesture feedback.
Bug: 173107751
Test: test closing app that is on:
- top row of home screen
- middle of home screen
- in hotseat
Change-Id: I055dd61ca3491807109ff2f6c501bf710c8d340f
* The width of the task menu view for landscape
(both fake and real) is the same as the width
it would be in portrait.
* With the shorter width, we also center the
positioning of the TaskMenuView
* Note this is only for phone, large screen
changes TODO
Bug: 193432925
Test: Tested real/fake landscape + seascape,
view is centered. Portrait same as before.
Change-Id: Ide41e252a3c177c4a911aab544f78930fed2e76f
PackageInstallStateChangedTask had some redundant state handling that could lead to invalid states. Removed state handling (potential fix to b/198924992) along with logging to help debug b/198924992.
Test: Started and canceled an app download
Bug: 198924992
Change-Id: I8b8202ceb62a3265186d8d46a0e1be6afc83c080
(cherry picked from commit fbf4178ab7)
See b/200132426 regarding to the bugs.
Test: manually tested full widgets picker scrolling on phone and 2
panels UI.
Fix: 200132426
Change-Id: I13c7a7262e9357cf0acac1c2c7c069b2118bd527
- Animates into icon/widget location on workspace (when applicable)
- Excludes unlock animation
- Excludes when user goes back to to All Apps state
Bug: 197656197
Bug: 197450256
Bug: 197656915
Test: go in app, swipe back to land on home
Change-Id: Icdf680bd88599f1b6288822a177087283668431c
- Override our insets in LauncherRootView to explicitly only care about nav bar size, ignoring any insets due to taskbar.
- Previously we used nonOverlappingTaskbarInsets to belatedly subtract from measurements in e.g. DeviceProfile, but now we can revert most of those calculations since we effectively subtract taskbar insets at the root.
Test: visual in different orientations and navigation modes, and testPressHomeOnAllAppsContextMenu to ensure REQUEST_WINDOW_INSETS still works for automated tests
Fixes: 200607741
Change-Id: I8de5a268c686a1354b4beaa30e101bab6bed5af9
- Calculate nav bar insets ourselves. Currently when taskbar is going to be present, we use taskbarSize as the nav bar insets. This is consistent with other existing calculations, but going forward we should instead always use the nav bar size instead of taskbar size, given we don't want taskbar to inset launcher (since taskbar is hidden).
- Also update tappable insets to be 0 in gesture mode. Test: Swipe to all apps, ensure there's no background protection at the bottom.
Test: Rotate device, no visual jumps
Test: Stash taskbar, quick switch a couple times without settling, and swipe up to overview; no jank due to reapplyState()
Bug: 198798034
Fixes: 197232424
Fixes: 197212581
Change-Id: I4c2bb5816dbb214846bd9f2a46c6f759c0545911
Zak Cohen
Alina Zaidi
Pat Manning
Brian Isganitis
Steven Ng
Alex Chau
TreeHugger Robot
vadimt
Tony Wickham
Tracy Zhou
Pierre Barbier de Reuille
Hyunyoung Song
Andy Wickham
Jonathan Miranda
Samuel Fufa
Vinit Nayak
Schneider Victor-tulias