Commit Graph

15087 Commits

Author SHA1 Message Date
Hongwei Wang 263aceeeea Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I6d23eca98f12691d3f87af8fedf8049f27125194
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 17:56:29 +00:00
Hongwei Wang ca08d75e4a Merge "Polish home-key from split to pip transition" into udc-dev 2023-06-29 17:17:03 +00:00
Winson Chung b019f371fd Merge "Workaround for handling the restart of an already visible task" into udc-dev am: 0da5208bb3 am: c8a2f9111b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23785437

Change-Id: Ib095560a1ba305ec4150037852caa2d0d58f9121
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 07:48:03 +00:00
Winson Chung 0da5208bb3 Merge "Workaround for handling the restart of an already visible task" into udc-dev 2023-06-28 05:51:59 +00:00
Winson Chung 57c2a79e47 Workaround for handling the restart of an already visible task
- If a task is already visible, then startActivity is a no-op and the
  remote transition that launcher expects to run is not started. As a
  workaround (until restarts are an actual transition), listen for
  the case where a task is restarted and invoke the end callbacks

Fixes: 286016555
Test: Repro steps on the bug
Change-Id: Iec3ab97c8817a5e95399cec90f891d65f369d234
2023-06-28 05:51:54 +00:00
Jerry Chang 3651051182 Polish home-key from split to pip transition
Includes WINDOWING_MODE_MULTI_WINDOW closing target to the condition of
playing fallback animation. So the remaining splitting task won't be
play with iconview animation when home-key to auto-pip consumed another
splitting task in pip transition handler.

Bug: 281476331
Test: repro steps of the bug
Test: pass existing tests
Video: http://recall/-/fLARJNt42LVxc3tt86SneW/eelqATeE1REoOtOEDxeDVR
Change-Id: If05d8841a6a940e61f71683422ef1a3d4e3597c7
2023-06-28 02:10:34 +00:00
Jerry Chang 8017561997 Merge "Prevent exception when quick switching between two split pairs" into udc-dev am: 26d5493e69 am: 71fe404fd1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23792388

Change-Id: I1353ee8448b455e905cab194ea9070d42a72af5f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 19:08:17 +00:00
Jerry Chang 26d5493e69 Merge "Prevent exception when quick switching between two split pairs" into udc-dev 2023-06-27 17:42:42 +00:00
Anvesh Renikindi d8af5abcfd Merge "Update renamed util function M3HCTToColor in launcher code" into udc-dev-plus-aosp 2023-06-27 14:54:49 +00:00
TreeHugger Robot 0093120979 Merge "Restore strong reference to animation runner" into udc-dev am: 1f3c56af5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23793397

Change-Id: Ibc13e029b1d318f501e1cc787f2ee7724b686538
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 03:05:09 +00:00
TreeHugger Robot 1f3c56af5b Merge "Restore strong reference to animation runner" into udc-dev 2023-06-27 02:13:00 +00:00
Winson Chung 6cfe2e6cbe Restore strong reference to animation runner
- The remote animation factory needs to be strongly referenced since
  the only other reference is a weakly held one from
  LauncherAnimationRunner, and if a gc happens in between starting
  the animation and the onAnimationStart() callback, then the
  animation will not play.

Fixes: 284106887
Test: Force a gc after creating a remote app launch animation and ensure
      that the runner still exists when the animation starts

Change-Id: I5f584451b41c666916801b8ea0cb470c7ab9fc51
2023-06-26 23:55:23 +00:00
fbaron ed79206e4b Update renamed util function M3HCTToColor in launcher code
Bug: 288120001
Test: none
Change-Id: If4c6783472d7fa05a1162e2f176a613d28f7bec3
Merged-In: If4c6783472d7fa05a1162e2f176a613d28f7bec3
(cherry picked from commit 911be164b3)
2023-06-26 20:17:17 +00:00
Winson Chung 24fe986f33 Merge "Fix NPE due to invalid RecentsView access" into udc-dev am: fa3434fc37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23810649

Change-Id: I0b9effb60c025ea9708455033c3a8d02e92bb85d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-26 18:25:56 +00:00
Winson Chung fa3434fc37 Merge "Fix NPE due to invalid RecentsView access" into udc-dev 2023-06-26 17:47:49 +00:00
Winson Chung cdf410f134 Fix NPE due to invalid RecentsView access
Fixes: 288829919
Test: N/a, reorganizing code behind null check
Change-Id: I9efe48cab239b521f7e729af06706c352be2499c
2023-06-26 17:47:33 +00:00
Jerry Chang 97eb471f2e Prevent exception when quick switching between two split pairs
When switching in between two split pairs just quick enough, it is
possible to send the second entering split transition while it is
animating the first entering split transition which is merged to a
recents-during-split transition. The split parents might not be
collected into the second transition because the split parents are
already visible at that time, and there is no recents transition to
merge to. So updates to not throwing when there is no split parent when
composing a recents-to-split animation.

Bug: 236226779
Test: repro steps of the bug and the Launcher won't throw
Change-Id: I3a595722721186e8de7d60c9fb8c099ec799804a
2023-06-26 13:49:37 +00:00
Bill Yi d6b0605005 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5696f163e91f140d9d0c941300098ed82ced9ca5
2023-06-22 18:51:47 -07:00
Jagrut Desai 5dc19d8fd4 Merge "Suspend immersive mode autohide while pending transient taskbar timeout" into udc-dev am: 9f566dec6b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23734004

Change-Id: Ia7c5c2101a30d0eaae0fc92801186e66baec449d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-22 18:36:13 +00:00
Jagrut Desai 9f566dec6b Merge "Suspend immersive mode autohide while pending transient taskbar timeout" into udc-dev 2023-06-22 18:06:23 +00:00
Vinit Nayak c0356d73f2 Merge "Add logs to RemoteTargetGluer for index exception" into udc-dev am: 8492177884
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23711381

Change-Id: Iee4887dcae04c0678fccc9b82878a818db17850a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 21:15:30 +00:00
Mateusz Cicheński 4f1a630212 Reparent PiP overlay under task as soon as possible am: e338982c97
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23731681

Change-Id: Ib323bda54ece0a8689ae7f8e9020b27df1ce0cd7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 20:43:31 +00:00
Vinit Nayak 8492177884 Merge "Add logs to RemoteTargetGluer for index exception" into udc-dev 2023-06-21 20:37:53 +00:00
Mateusz Cicheński e338982c97 Reparent PiP overlay under task as soon as possible
For enter PiP animations started from Launcher, we send the signal to
WMShell to reparent the overlay under task as soon as possible.

This avoids flicker issue caused by race condition of cleaning up the
transition leash before the reparenting was done, which made the issue
of overlay being not attached to anything for few frames.

Bug: 281711939
Test: winscope trace from comment#28, leash follows task
Test: after http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/ewrarENSYYOmUCa0b3fdtp

Change-Id: Ia16afd49a94d9ba8456287c2cdffb2a84e5a2bc7
Merged-In: Ia16afd49a94d9ba8456287c2cdffb2a84e5a2bc7
2023-06-21 16:51:36 +00:00
Winson Chung f738809ffa Merge "Restore specific colors for floating rotation button" into udc-dev am: d827387ffd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23755143

Change-Id: I393367d085177514884534f1750b639d84109e4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 16:42:47 +00:00
Winson Chung d827387ffd Merge "Restore specific colors for floating rotation button" into udc-dev 2023-06-21 16:06:19 +00:00
Treehugger Robot 6d9c599521 Merge "Add detailed exception for snappedIndex == -1 when dismissing tasks" into udc-dev am: dcbe9583fb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23535540

Change-Id: If90845908b748ccc8a25eccb54a68a7964fb91f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 11:42:57 +00:00
Treehugger Robot dcbe9583fb Merge "Add detailed exception for snappedIndex == -1 when dismissing tasks" into udc-dev 2023-06-21 11:00:20 +00:00
Bill Yi 5204db1fa2 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5b7ded4d11a74593e2cfa3ddc54e564523c7546d
2023-06-20 20:23:19 -07:00
Winson Chung c27a43ba30 Restore specific colors for floating rotation button
- The rotation button background does not change based on the current
  light/dark mode

Bug: 288126260
Test: Check rotation button color with dark mode enabled/disabled
Change-Id: If4d5edfd4b118e4f16b6d472f206587e7cd61f98
2023-06-20 22:45:25 +00:00
Alex Chau 8f19421a87 Add detailed exception for snappedIndex == -1 when dismissing tasks
Bug: 269956477
Test: manual
Change-Id: Ia95a3b2ffe5c677af34183639ba8a2742626c340
2023-06-20 19:04:55 +01:00
Randy Pfohl ffa30075a1 Merge "Aligning the intialization process with groupedtaskview to set content description Test: built locally, tested against tablet with bluetooth keyboard." into udc-dev am: 6ec21cbe45
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23699415

Change-Id: Id29e58e97afa9bbd7b23bbeb26d9e1ce8584fae7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 23:47:41 +00:00
Randy Pfohl 6ec21cbe45 Merge "Aligning the intialization process with groupedtaskview to set content description Test: built locally, tested against tablet with bluetooth keyboard." into udc-dev 2023-06-16 23:18:02 +00:00
Jagrut Desai 68ca974330 Suspend immersive mode autohide while pending transient taskbar timeout
Test: open Youtube fullscreen video, swipe up on taskbar; ensure taskbar autostashes before immersive mode autohides
Fixes: 260765455
Flag: none
Change-Id: Ic579a20c60949e12ffc7f9548eded52fbdb06e0c
2023-06-16 15:42:57 -07:00
randypfohl 3c2ab1de45 Aligning the intialization process with groupedtaskview to set content description
Test: built locally, tested against tablet with bluetooth keyboard.

Bug: 287287064
Change-Id: I2be667b2a4b0a08f73c3233a05bbaf7eec08c0e4
2023-06-15 15:11:57 -07:00
Vinit Nayak ae6beea07b Add logs to RemoteTargetGluer for index exception
Bug: 286144914
Change-Id: I16a8d22a281903574c282b08c06695e4f0e46168
2023-06-15 19:38:37 +00:00
Jon Miranda 8b1160e484 Merge "Fade in/out taskbar bg alpha when unstash/stashing." into udc-dev am: 613cc95c8a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23696768

Change-Id: I8f094c2072b6a18d721ce6282dd50d0d089a24c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 01:40:56 +00:00
Jon Miranda 613cc95c8a Merge "Fade in/out taskbar bg alpha when unstash/stashing." into udc-dev 2023-06-15 00:02:02 +00:00
Jon Miranda d76713eb08 Fade in/out taskbar bg alpha when unstash/stashing.
This prevents the case where we are drawing both the taskbar bg
renderer and the stashed handle at the same time.

Fixes: 287245176
Test: go home/overview, open/close notif shade, stash/unstash in app
Change-Id: Ib025a0cf1ad5fd8a9afd079aa50210f3b2388d8e
2023-06-14 14:04:27 -07:00
Treehugger Robot 1491801345 Merge "Polish redesgined tutorial home and overview animations" into udc-dev am: 77110f977f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23664031

Change-Id: Ib9f743ee1ad7bb921f7f91f868153d73e355cd7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-14 19:15:54 +00:00
Treehugger Robot 77110f977f Merge "Polish redesgined tutorial home and overview animations" into udc-dev 2023-06-14 18:35:21 +00:00
Treehugger Robot 1a8898f69b Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-06-14 03:32:14 +00:00
Jon Miranda b77d65b5ae Merge "Revert "Suspend immersive mode autohide while pending transient taskbar timeout"" into udc-dev am: 6352c9bc88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23678091

Change-Id: Iad6b6ae704d34de392fd0cbf69a0bfa06ed14e5c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-14 01:41:28 +00:00
Jon Miranda 6352c9bc88 Merge "Revert "Suspend immersive mode autohide while pending transient taskbar timeout"" into udc-dev 2023-06-14 01:10:08 +00:00
Jon Miranda a6653ae660 Revert "Suspend immersive mode autohide while pending transient taskbar timeout"
This reverts commit 0a074648c2.

Reason for revert: caused regression
Bug: 260765455
Fixes: 286808390

Change-Id: I0e017cf8e432f9c36b0ad34154c127c0dbe73504
2023-06-13 20:09:58 +00:00
Randy Pfohl 60985cb40e Merge "switching animation to screenshot to avoid visual jank" into udc-dev am: f5bec7dd30
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23665476

Change-Id: Ieabea68f5cc86798d45a553106c1c6d94cc360d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 06:04:45 +00:00
Saumya Prakash 5954369a9b Merge "Scale the gesture tutorial animation to work on smaller devices" into udc-dev am: cb5e2cfd3e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23632910

Change-Id: I4ba19020436717b581bb7e8c89ea3c87806bfc8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 06:03:56 +00:00
Randy Pfohl f5bec7dd30 Merge "switching animation to screenshot to avoid visual jank" into udc-dev 2023-06-13 05:43:21 +00:00
Saumya Prakash cb5e2cfd3e Merge "Scale the gesture tutorial animation to work on smaller devices" into udc-dev 2023-06-13 05:38:01 +00:00
Saumya Prakash e69de4abbe Merge "Update the strings in the gesture nav tutorial" into udc-dev am: 0d87c4766e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23659350

Change-Id: Idc65c2ae4c5c0b378b0cdcc2295d864951f7d026
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 04:39:39 +00:00