Commit Graph

1627 Commits

Author SHA1 Message Date
Stefan Andonian 253c23b2e8 Close open folders when pausing launcher.
Previously, folders wouldn't close after launching an app and quickly navigating back the launcher.
This is because the onStop state which contains a call to AbstractFloatingView.closeViews() wasn't being called.
This change adds an additional call to specifically close any open folders when the Launcher enters a paused state.

Bug: 227142635
Test: Verified that the issue is fixed after code change.
I logged the Launcher's lifecycle state to ensure my manual testing was reliable.

Change-Id: I838f992f83afdd754672ebbe85d0eb2a7e894417
2022-04-06 21:47:35 +00:00
Abhilasha Chahal dfd154f18d Use numAllAppsColumns to calculate height of all apps icons
Additionally opens up access of some fields to allow them to be overridden.

Test: Manually verified that Launcher3 layout does not change

Launcher3 APKs: https://drive.google.com/drive/folders/1hBcZU9xou4tZJxbTmkya_LyBbD2oYuwV?resourcekey=0-R0I1IQ2rSUIEfPjW8S_ppA&usp=sharing

Bug: 216150572

Change-Id: I4b97a7e9e15973fc5aa70a4b98f0b73dd5bf3c17
2022-03-23 21:09:54 +00:00
Brian Isganitis bde3c8b6bd Move activity starting logic into new ActivityContext extension.
This code branch is needed for taskbar, so needs to be moved from the
activity classes to an interface that both can share.

Test: Manual
Bug: 216683257
Change-Id: I042c0dcf08207d94847b9d7a1783acc14613ef5f
2022-03-16 13:59:03 -07:00
Jon Miranda e8b174482d Merge "Add debug logs for bad launcher state." into tm-dev 2022-03-10 22:03:37 +00:00
Jon Miranda 7ebe209c21 Add debug logs for bad launcher state.
Bug:223498680
Bug:221658803

Test: manual
Change-Id: I138a7ab031269009fa8ca492cd0bd48085aa4e68
2022-03-10 20:25:38 +00:00
Jon Miranda 7db484396a Merge "Never look for matching view in All Apps when swiping up to go home." into tm-dev 2022-03-10 18:46:51 +00:00
Thiru Ramasamy 694407ce08 Make AllAppsEntry and exit events optional.
This change will allow us to skip logging AllApps entry and exit events when entering into AllApps state from QSB.

Bug: 210792253
Test: wwdebug && wwlogcat
Change-Id: I658ff0842c72aa27335d426abaa46435ae312941
2022-03-09 07:14:36 -08:00
Jon Miranda b42e124f5b Never look for matching view in All Apps when swiping up to go home.
The swiping up gesture will never return an app in All Apps,
so we can ignore All Apps state in those cases.

This fixes an edge case where user swipes up and launcher state
is still in All Apps. This causes us to animate the icon to
where it would be in All Apps, even though by the time the
animation starts we are actually in Normal state.

Bug: 222124240
Test: open app from  all apps then quickly swipe up to go home
Change-Id: I756a870660a397d6629aec82e4f5ec4914ed0669
2022-03-08 16:37:35 -08:00
Schneider Victor-tulias 789a6a95cc Add method to pause expensive view updates during the app launch aimation
Fixes: 220922269
Test: Manual
Change-Id: I39066f575c0ddfc4868ab9e27149e2bd9492b39c
2022-03-04 13:59:33 -08:00
TreeHugger Robot 49141ccf2e Merge "Revert "Clear all DragView in onSaveInstanceState"" 2022-02-17 20:45:46 +00:00
Jon Miranda baf1ef55ab Revert "Clear all DragView in onSaveInstanceState"
This reverts commit 14d6771aae
to fix bootline regression.

Bug: 210383463
Test: manual
Change-Id: I5a0dadee59bfd6b5a164fd2ca3ecdd1885cb4134
2022-02-14 20:26:40 -08:00
Brian Isganitis 099945b075 Add predictions row to taskbar all apps.
- We need to listen to DeviceProfile changes in case the number of
  columns changes in the grid. I made an interface/mixin separate from
  ActivityContext to avoid polutting the latter with too many things. I
  also applied this change to existing taskbar A-Z grid.
- Added all apps visited count to onboarding preferences for only
  showing "All Apps" label in place of divider 20 times. Label is also
  tracked on taskbar side and should be kept in sync.

Test: Manual
Fix: 216843395
Bug: 174174514
Change-Id: I97aa91397c334123626caf18251f19e17c7104fb
2022-02-14 11:24:16 -08:00
Alex Chau bf63e9cf2b Merge "Add debug logs for testPromiseIcon_addedFromEligibleSession" 2022-02-14 11:38:57 +00:00
Jon Miranda 701774d021 Add debug logs for testPromiseIcon_addedFromEligibleSession
Bug: 202985412
Test: PromiseIconUiTest
Change-Id: I160b9229bebe07015575f8184ac2d53bcbf2bad0
2022-02-10 17:26:11 -08:00
Kholoud Mohamed 6974d39a44 Merge "Expose action that allows landing on the work tab" 2022-02-08 17:12:18 +00:00
kholoud mohamed ceec31b17c Expose action that allows landing on the work tab
Bug: 217385869
Bug: 203531272
Test: manual
Change-Id: I68a6add9f603105e0a2ee01ebdc3059e18c9a050
2022-02-07 18:53:49 +00:00
Thiru Ramasamy 529fa34650 Merge "[OneSearch] Extract logging event for all apps entry into separate method." 2022-02-04 19:21:16 +00:00
Thiru Ramasamy 5fbac637c6 [OneSearch] Extract logging event for all apps entry into separate method.
Add containerInfo to the AllApps entry events to track from which workspace
user entered into AllApps drawer

Bug: 217583896
Test: Manual http://gpaste/6272522430447616

Change-Id: I77069a350a7b0e88cb321485144e0d8b976c4da9
2022-02-04 19:20:59 +00:00
kholoud mohamed c76b2035aa Allow overriding enterprise related strings in Launcher
Test: manual
Bug: 188414133
Bug: 211422509
Bug: 188410712
Change-Id: I75858cdcf2057e7c270da5893cd9a90c6753f182
2022-01-28 16:33:03 +00:00
Brian Isganitis c19b51e1f3 Merge "Refactor all apps to depend on activity context." 2022-01-25 18:34:30 +00:00
TreeHugger Robot 78cac51636 Merge "Remove ADAPTIVE_ICON_WINDOW_ANIM feature flag." 2022-01-25 14:21:24 +00:00
Jon Miranda 78d0d4f832 Remove ADAPTIVE_ICON_WINDOW_ANIM feature flag.
Has been enabled for past few releases, no longer needed
as a debug flag.

Bug: 209856611
Test: manual
Change-Id: Id25e36522636e5c5d8ee60cdec49b3ee3f4d4251
2022-01-24 18:00:04 -08:00
Brian Isganitis 1664c9f418 Refactor all apps to depend on activity context.
The current AllAppsContainerView has been split into a base class and a
subclass for activities. The base class allows using all apps with an
activity context. A-Z and work profile tabs are supported, but search
and the hotseat still require an Activity.

Test: Manual. All apps should work the same.
Bug: 204696617
Change-Id: I3b146714bc11b3b3555d97623aab5d78ac836482
2022-01-24 20:24:20 -05:00
Josh Tsuji 46728f6481 Merge "Adds Launcher in-window animations, and reworks how the unlock flow works." 2022-01-24 20:34:44 +00:00
Jon Miranda 0aff1151c3 Add log to help debug crash during bindItems.
Bug: 198115560
Test: can't repo, need to catch in wild
Change-Id: I9d457fce4903c5df33833a5e4817f8a32ed260e2
2022-01-21 22:07:48 +00:00
Josh Tsuji 231c9229bf Adds Launcher in-window animations, and reworks how the unlock flow works.
Bug: 197636887
Test: atest SystemUITests
Change-Id: Idab7249e4a761040863578d546f0831794efaf4a
2022-01-21 10:41:00 -05:00
Sunny Goyal 80a071be2b Updating interface name to avoid AS build errors due to name conflict with SysUI
Bug: 152086714
Test: Verified building locally
Change-Id: I348d7672bda76f6cffc975cb44916c5867d9728d
2021-12-27 13:31:40 +05:30
Pinyao Ting 85232a91bf Avoid drawing the first frame in launcher before animation completes
Currently Launcher reports the drawing of the first frame before the
fade-in animation runs to a completion. This CL pauses the pre-draw
until the animation concludes so that the performance metrics matches
what user actually sees.

Bug: 210527498
Test: 1) reboot verify things works 2) sign in to second user, verify
things works.

Change-Id: I0146c0408005c3de75098b9401089ed2bcbcb6d6
2021-12-14 17:31:58 +00:00
Jon Miranda 5902269fed Merge "Clear all DragView in onSaveInstanceState" into sc-v2-dev am: 7ac2a71b94 am: 48d82e2c19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16425110

Change-Id: I8e7d3a99a70a50352ed51674a7aa9e0c4f970cea
2021-12-10 19:11:28 +00:00
Jon Miranda 7ac2a71b94 Merge "Clear all DragView in onSaveInstanceState" into sc-v2-dev 2021-12-10 18:36:15 +00:00
Jon Miranda 14d6771aae Clear all DragView in onSaveInstanceState
Multiple users reports view getting stuck on screen. This CL
clears all DragView when user leaves launcher.

Root cause still undetermined, but happens enough that it warrants
a temp fix.

Bug: 162636845
Test: manual
Change-Id: I532b5274a1308c53f67c23c5c8ca07f2b7f9802c
2021-12-08 17:47:33 -08:00
Jon Miranda 986a447ee2 Merge "Play return to icon animation if user swipes back to All Apps." into sc-v2-dev am: 52ee4ec4aa am: faedc9004c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16194658

Change-Id: If3e72442f3cd3b976d688ffef366a188683247fe
2021-12-06 19:03:41 +00:00
Schneider Victor-tulias bdb0dd8cfb Refactor LauncherAccessibilityDelegate so it can be used outside of Launcher
Bug: 198438631
Test: used talkback on launcher
Change-Id: I991320184ad93816c4ba21fb8fcfe12202bfae25
2021-11-23 12:48:14 -08:00
Jon Miranda c4a99bff04 Play return to icon animation if user swipes back to All Apps.
Bug: 205187702
Test: open app in all apps, swipe back to go back to all apps
Change-Id: I9e79c8365fdf667321343aaac2f8d77cb60a316a
2021-11-23 11:27:42 -08:00
Schneider Victor-tulias 5173fd8090 Add notification dots and popup menu notification support to the taskbar.
- Added support for notification dots
- Added support for notifications in popup menu
- Added support for dismissing notifications from the popup menu

Bug: 198438631
Test: long pressed launcher and taskbar icons, clicked notifications, clicked shortcuts
Change-Id: I7c981e60a82b4d6ce28332d804bbbfb5eb89c6a8
2021-11-15 14:47:36 -08:00
Brian Isganitis 149dbcb137 Allow overriding getOptionsPopup test method.
Test: TAPL
Bug: 205491724
Change-Id: Ib4adfa85df6aa9e52922f76479487c9459535fcd
2021-11-08 18:17:36 -05:00
Yogisha Dixit 7b1d25b251 Fix bug with resize frame in Launcher3.
Also updated the tests to check that the resize frame is shown.

Bug: 192655785
Test: AddWidgetTest, AddConfigWidgetTest, manual
Change-Id: Id348f39cec1bebc8ec9ea9f3068f4bda2159eac4
2021-10-20 19:03:14 +01:00
TreeHugger Robot a246eb4aa5 Merge "Add logging to help debug b/200572078." into sc-v2-dev 2021-09-30 07:01:41 +00:00
TreeHugger Robot 31a0b39daf Merge "Allow icon add animations when user touches the screen." into sc-v2-dev 2021-09-30 01:51:49 +00:00
Alex Chau b830b2d999 Merge "Return mSynchronouslyBoundPages as getPagesToBindSynchronously between onInitialBindCompleteand finishBindingItems" into sc-v2-dev 2021-09-29 08:25:49 +00:00
Schneider Victor-tulias 0021338461 Add logging to help debug b/200572078.
Bug: 200572078
Test: ran launcher and checked logs
Change-Id: If59d850021df226d645aa6a72da2b5bb7ec63782
2021-09-28 12:02:51 -07:00
Brian Isganitis a85ae69c72 Refactor arrow popups to allow easier code overriding and sharing.
Test: Existing menus work as intended.
Bug: 188222480
Change-Id: I7d19b06ce8bb7d765624c64c0042c4efd6faf348
2021-09-24 20:32:14 -04:00
Steven Ng 3bbebe2439 Merge "Add an animation for invalid widget resizing in 2 panel UI" into sc-v2-dev 2021-09-21 09:27:44 +00:00
sfufa@google.com d0a332371d [Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app
Bug: 182937704
Test: Add direct call widget from widget tray on a predicted spot. verify prediction clears space and no overlap.
Change-Id: Ie4977ca71ec0b7c2297ffe1454cb4a1e78518a75
2021-09-20 14:22:25 -07:00
Steven Ng 4b346108d1 Add an animation for invalid widget resizing in 2 panel UI
Test: manual
Fix: 197509872
Change-Id: Ibcfae107e7f4b3bfbc562d4a6436f4b9237db122
2021-09-20 15:33:23 +01:00
Schneider Victor-tulias 68fb416b1a Allow icon add animations when user touches the screen.
Fixes: 199483081
Test: manual, repeatedly tapped screen until and while app icon was added, repeatedly changed pages until and while app icon was added
Change-Id: I286b52527dfe6e5bfdfedbbbf1eed72061fb5599
2021-09-16 13:24:01 -07:00
Schneider Victor-tulias 927d6dcc6c Add tracing to help in launcher load time profiling.
Bug: 195674813
Test: None
Change-Id: I895a64bbba515ce7b7df8d093d40e0a5b6056d2e
2021-09-15 17:08:53 -07:00
TreeHugger Robot fd744975cc Merge "Fix crash when Workspace item is added to two panel home" into sc-v2-dev 2021-09-08 22:09:53 +00:00
Alex Chau 817e0fa812 Fix crash when Workspace item is added to two panel home
Test: Run com.android.launcher3.ui.widgetRequestPinItemTest#testPinShortcut tests
      and com.android.launcher3.ui.TaplTestsLauncher3#testWorkspace
Bug: 199150824
Change-Id: I8550970806eb0b9bfc246d4fb76ffbd0415b7647
2021-09-08 21:01:10 +01:00
TreeHugger Robot 11438429a8 Merge "Prevent NPE when init device profile" into sc-v2-dev 2021-09-08 02:14:31 +00:00