Commit Graph

11698 Commits

Author SHA1 Message Date
TreeHugger Robot f5af5ce11f Merge "Revert "Add haptic feedback to Launcher recent apps scrolling"" into sc-dev 2021-06-01 23:39:39 +00:00
Wale Ogunwale 0e25d2eba8 Revert "Add haptic feedback to Launcher recent apps scrolling"
This reverts commit b1ef5e5c55.

Reason for revert: b/182382085#comment4

Change-Id: I001944da64dc05324b14cc9dd3db5921faf8806c
Bug: 182382085
2021-06-01 22:10:18 +00:00
Steven Ng c58b204926 Merge "Show app widget resize frame after launcher state change" into sc-dev 2021-06-01 21:11:01 +00:00
Steven Ng a45ea6cf33 Merge "Fix add extra empty screen logic" into sc-dev 2021-06-01 21:04:55 +00:00
TreeHugger Robot b13200c6b1 Merge "Cleanup state properly when interacting during gesture nav transition" into sc-dev 2021-06-01 21:02:29 +00:00
TreeHugger Robot 9ccd3c5e12 Merge "Fixing deadlock when surface creation is waiting on surface destroy" into sc-dev 2021-06-01 21:00:19 +00:00
Brian Isganitis d9463fbfdd Merge "Create settings activity layout with explicit toolbar" into sc-dev 2021-06-01 20:15:15 +00:00
Sunny Goyal 4c29af3a6d Fixing deadlock when surface creation is waiting on surface destroy
Bug: 189049869
Test: Manual
Change-Id: I0f92d3666dab81bc381163d93530119d45c4fdbd
2021-06-01 12:36:38 -07:00
Jonathan Miranda d8035e1821 Merge "Turn off app close flag, Revert back to R implementation." into sc-dev 2021-06-01 18:18:38 +00:00
Jonathan Miranda dfde41cf1e Merge "Change folderFillColor to colorBackgroundFloating." into sc-dev 2021-06-01 18:17:17 +00:00
Alina Zaidi 8a8c36cca9 Merge "Add more education tips for widgets. (2/3)" into sc-dev 2021-06-01 17:34:18 +00:00
TreeHugger Robot 04ef35f854 Merge "Further adjust work profile tabs paddings in the widgets picker" into sc-dev 2021-06-01 13:13:03 +00:00
Alina Zaidi f2c79dea0d Add more education tips for widgets. (2/3)
Show education dialog on WidgetsFullSheet.
-Have a button in widget education dialog to intent into PixelTips apps.
-Make sure arrow tip view shows after dismissing education dialog on
WidgetsFullSheet if there is a widget to show it on.
-Update colors and layout for arrow tips.

Test: Tested manually
Bug: 185354491
Change-Id: I5cbdd02fc4f19a49a42dac4451b071e3d604747f
2021-06-01 13:58:18 +01:00
Steven Ng 7e3d96c620 Show app widget resize frame after launcher state change
When this bug occurs, the resize frame coordinate is incorrect because
the launcher state animation has not finished when the drag view
finishes animating back to its original position.

Test: Quickly long press and release a widget from the home screen.
      Observe the resize frame is correctly shown around the widget.

Bug: 186370472
Change-Id: I6bfba2e85e3354a215c26203dd22df13db3b8b83
2021-06-01 12:20:32 +01:00
Steven Ng a0d49dcfb4 Further adjust work profile tabs paddings in the widgets picker
Test: Open widgets picker and observe tabs paddings are correctly set.
Bug: 188872382
Change-Id: Ib6a735bf2b0710f86b8641533cadb27116049341
2021-06-01 11:40:36 +01:00
Steven Ng 755723403b Merge "Don't dismiss keyboard after clicking X button on the widgets search bar" into sc-dev 2021-06-01 10:05:26 +00:00
Sunny Goyal 8a7f973264 Merge "Enabling themed icon feature" into sc-dev 2021-05-28 18:53:40 +00:00
Jon Miranda de907805d1 Change folderFillColor to colorBackgroundFloating.
There seems to be some nuance that prevents me from defining it once in
the base theme, so just updated all of them individually to prevent
any edge case from slipping through.

Bug: 188095988
Test: manual
Change-Id: I1dea639f174fa4ec09bda93a6e2017993b2007a5
2021-05-28 01:21:21 +00:00
Brian Isganitis 08fdf4d269 Create settings activity layout with explicit toolbar
This layout will be overridden to have a collapsible toolbar on API 31.

Test: Settings layout unchanged
Bug: 187732263
Change-Id: I0c098dd0a09a1787a10035a3d3f35ecf461cfc20
2021-05-27 18:41:18 -04:00
Brian Isganitis 8d6ca68786 Merge "Give each preference screen its own activity and toolbar title" into sc-dev 2021-05-27 22:29:28 +00:00
Jon Miranda 62769f10d7 Turn off app close flag, Revert back to R implementation.
Need more time to experiment with interpolated + springs based approach,
will aim for QPR instead.

Bug: 189120868
Bug: 173107751
Test: manual
Change-Id: I5698bd61c92b4fa719d82f2553125fc7f65b5969
2021-05-27 15:14:52 -07:00
Brian Isganitis 890d8d5a91 Give each preference screen its own activity and toolbar title
This change is in preparation for each preference screen having its own collapsible toolbar with its specific title.

Test: Subsettings open with activity transition and title changes
Bug: 187732263
Change-Id: Iac44d688539195ddb6c2aca0a96d737ce7727071
2021-05-27 16:08:22 -04:00
Steven Ng 7a36ad396e Don't dismiss keyboard after clicking X button on the widgets search bar
Test: Enter some queries in the widgets search bar. Click X button. The
      keyboard is still opened after the search queries has been erased.
Bug: 189454318
Change-Id: Icb0501cf36cbf1517e2da24044da44101fa86ed9
2021-05-27 18:42:31 +01:00
Pierre Barbier de Reuille 0bb96c9168 Merge "Update the computation of the widget span from size" into sc-dev 2021-05-27 12:11:27 +00:00
Samuel Fufa bd883ea788 Merge "Remove AllApps prediction edu" into sc-dev 2021-05-27 11:02:49 +00:00
Tony Wickham f8d731a808 Cleanup state properly when interacting during gesture nav transition
When the transition is canceled (e.g. when touching the nav bar during the transition), do the following:
- Abort the RecentsView scroll including the edge effects to ensure we get onSettledOnEndTarget() immediately.
- Jump to the current gesture end target state instead of the default rest state.

Test: Swipe up and to the left and hold to go to overview from an app, then swipe up to home during the transition; ensure that the touch down goes to overview rather than home, and subsequently that the swipe is respected and goes to home
Fixes: 189142339
Change-Id: Ie1d7dd05f45ab48968df7fdfd69fa1e1dda36d06
2021-05-26 15:28:38 -07:00
TreeHugger Robot a07c2efdf6 Merge "Enable unpausing apps from the workspace." into sc-dev 2021-05-26 22:24:40 +00:00
Stevie Kideckel d9abe11b92 Merge "Add the DefaultItemAnimator, without change animations" into sc-dev 2021-05-26 22:21:03 +00:00
Pierre Barbier de Reuille 295a402908 Update the computation of the widget span from size
The new computation takes into account the new cell layout border
spacing.

Change-Id: Ic20e0906bbbaaf1e53475585e2a6ca31c277e09b
Bug: 187461595
Test: Manual testing, varying the sizes in a widget
2021-05-26 22:44:58 +01:00
TreeHugger Robot 96793bdfe1 Merge "Adjust the widgets fitting algorithm to mitigate over packing issue" into sc-dev 2021-05-26 21:06:57 +00:00
Sunny Goyal e85dc514cd Enabling themed icon feature
Bug: 183641907
Test: Manual
Change-Id: I79643803bb50ab2f4b40122258cd1c8bf89b90ad
2021-05-26 12:40:35 -07:00
Steven Ng b7773f93cf Adjust the widgets fitting algorithm to mitigate over packing issue
If we are fitting more than one widgets / shortcuts on the same row,
we will only allow the total width to be n - 1 cells, where n is the
grid width in cells.

Test: Run WidgetsTableUtils robolectric test.
Bug: 189103942
Change-Id: I2f23cb08fe95d68562188cc7b1852d99d7093dc0
2021-05-26 19:27:46 +01:00
TreeHugger Robot b1858afaf2 Merge "Add haptic feedback to Launcher recent apps scrolling" into sc-dev 2021-05-26 18:05:33 +00:00
Stevie Kideckel 47f935dbbe Add the DefaultItemAnimator, without change animations
Change animations cause the addition of another view to be able to
crossfade/interpolate the two. Disabling change animations prevents us
losing the focus when a header row changes due to expanding or
collapsing.

Test: verified locally
Bug: 183378651
Change-Id: I07837b41748b5206936321c08d376069fa81b363
2021-05-26 17:08:18 +00:00
Lais Andrade b1ef5e5c55 Add haptic feedback to Launcher recent apps scrolling
Add light LOW_TICK effects when the scrolling on RecentsView
snaps to a page, and a stronger TICK effect when the edges
absorb the scroll (by scrolling fast towards one of the edges).

Fix: 182382085
Test: manual
Change-Id: Ifb917ae499f73607707773f9870eb39cd6fe16ef
2021-05-26 13:37:30 +01:00
Stevie Kideckel fa7c98ee45 Merge "Remove intrinsic padding from widget previews" into sc-dev 2021-05-26 09:27:11 +00:00
TreeHugger Robot 694b667138 Merge "Update Gesture nav tutorial." into sc-dev 2021-05-26 09:20:18 +00:00
Samuel Fufa 53ec9a4e06 Merge "[Search] Resolve afterimage when closing allapps" into sc-dev 2021-05-26 00:42:58 +00:00
TreeHugger Robot 55060ca7ea Merge "Crossfading splashscreen if icon is themed" into sc-dev 2021-05-26 00:26:22 +00:00
TreeHugger Robot d98a784d0e Merge "Overview - Remove the space withheld for proactive chips" into sc-dev 2021-05-26 00:11:18 +00:00
Vinit Nayak b74b9d2966 Merge "TaskMenu in overview UI polish" into sc-dev 2021-05-25 23:56:00 +00:00
Steven Ng 1ef7e145d2 Fix add extra empty screen logic
The bug occurred when there are two widgets in a CellLayout. When
dragging one of the widget, ShortcutAndWidgetContainer#getChildCount
returns 1 rather than 2 because the LauncherAppWidgetHostView of the
widget in drag has been detached from its parent and reattached to
DragView (introduced in ag/14234627).

Test: Place only two widgets on the last page of the home screen. Drag
      one widget. The new page indicator on the right is shown.
Bug: 188494523
Change-Id: I8255dd1b72ad7f18f4cb35a9e14ac8e61804980c
2021-05-25 23:39:40 +01:00
Samuel Fufa 41f15a107f [Search] Resolve afterimage when closing allapps
Preview: https://drive.google.com/file/d/1AM6WAY4kImCgHueNvH6eXUtnHgK3U6vo/view?usp=sharing&resourcekey=0-3mzBobzFuzQXCNZRUlToYA
Test: Manual
Bug: 184711608
Bug: 188556051
Change-Id: Ib43c71083460c236347dd1f340b1ad95d7d4aa15
2021-05-25 17:34:18 -05:00
zakcohen dad8a80d19 Overview - Remove the space withheld for proactive chips
Remove the space in the ui that was being used for chips.
Centralize some of the logic around calculating the action margins to aid
that.

Bug: 179922117
Test: Local build and flash and run
Change-Id: Icd2f894c858fab475c5411f3f7c412b899d5b220
2021-05-25 15:29:08 -07:00
Steven Ng 530f644788 Merge "Fix tabs abruptly reset during swipe" into sc-dev 2021-05-25 22:21:25 +00:00
TreeHugger Robot 17385ce33e Merge "Fix full widgets picker fast scroller height." into sc-dev 2021-05-25 21:43:40 +00:00
Vinit Nayak 063cb2d892 TaskMenu in overview UI polish
Bug: 188168717
Test: TaskMenuLooks closer to mocks.
Change-Id: I1560b66a48c4c70c7c79f7307b2b76f22e30c653
2021-05-25 14:42:35 -07:00
Schneider Victor-tulias 8a3a857668 Update Gesture nav tutorial.
- Seperated back left and right edge tutorial steps
- updated back left and right tutorial step strings
- Removed feedback view timeout
- Added accessibility focus on title when feedback view appears
- Added logic to show feedback when the tutorial fragment is stopped then resumed

Test: manual

Bug: 169687177
Fixes: 188116424
Fixes: 188115939
Fixes: 188124784
Fixes: 188555152
Fixes: 188972969

Change-Id: I97755a455bf3fa4674955d5cc91ed8b02f484b76
2021-05-25 14:16:41 -07:00
Samuel Fufa 880fc577c0 Remove AllApps prediction edu
Test: Manual
Bug: 183579072
Change-Id: Ibaffc5ac711e35df5256baed8be57159046fbdda
2021-05-25 14:48:14 -05:00
Sunny Goyal c4c3269206 Crossfading splashscreen if icon is themed
Bug: 188840653
Test: Manual
Change-Id: Ibd00bb1a94576a7512872eba39a936c174f9871d
2021-05-25 18:25:18 +00:00