Commit Graph

10088 Commits

Author SHA1 Message Date
Adam Cohen 2438d40607 Merge "Fix issues with drag and drop from All Apps in non-default grids" into ub-launcher3-rvc-dev 2020-05-11 18:38:15 +00:00
Hyunyoung Song e745f50128 Merge "Hookup statsd for workspace layout logging" into ub-launcher3-rvc-dev 2020-05-11 18:18:57 +00:00
vadimt 7b7e62e5eb Additional logging for pause non-detection
Bug: 156044202
Change-Id: I6d7dcdcf73722e66fcbd180c9e309c518766b9b8
2020-05-11 10:10:53 -07:00
Hyunyoung Song 7f7894e3b7 Hookup statsd for workspace layout logging
Bug: 144953948

Change-Id: I81bd42929b2d65a63c610e95e5e01179a3971493
2020-05-10 01:37:42 -07:00
TreeHugger Robot 9506316e21 Merge "More logging for pause non-detection" into ub-launcher3-rvc-dev 2020-05-08 23:12:40 +00:00
Adam Cohen c77bc45fa5 Fix issues with drag and drop from All Apps in non-default grids
=> Also fix the widget tray in these non-default grids, and the external shortcut addition flow. The layout was broken as it was scaling with the icon size. Instead keep it fixed which looks much better, similar to how we maintain all apps.
=> This also fixes a small jump when dragging shortcuts external to Launcher.

issue 154169001

Change-Id: Iad1e3859dd6fedccce9b5c6633e64426a4630c31
2020-05-08 16:00:08 -07:00
vadimt ad87034d1f More logging for pause non-detection
Bug: 156044202
Change-Id: I1c995b6c28f7108b96ff74aa8c3c71f70f8b3fb6
2020-05-08 15:09:37 -07:00
TreeHugger Robot 144f638fa3 Merge "Mitigate 10 minutes delay in launcher restore for work apps." into ub-launcher3-rvc-dev 2020-05-08 21:02:02 +00:00
TreeHugger Robot 4d1203efab Merge "Fixing Fallback recents crashes when going to modal state" into ub-launcher3-rvc-dev 2020-05-08 19:46:35 +00:00
vadimt 2794f563a0 Adding tracing for switching to overview instead of all apps
Bug: 156095088
Change-Id: I1257617192e913d06edd0879396957b1e40524b7
2020-05-08 10:39:29 -07:00
Sunny Goyal 302ecabf2c Fixing Fallback recents crashes when going to modal state
> Adding robo tests to prevent such regressions
Bug: 155570625

Change-Id: I5cfbfc454849116f881322e8785dfdbad6f24d08
2020-05-08 10:12:17 -07:00
vadimt 091794671d Adding tracing for non-detection of Pause
Bug: 156044202
Change-Id: I16f196db6266a0c3a84b59b7cdeb29863a37ff0f
2020-05-07 20:06:58 -07:00
Sunny Goyal f67db3531b Moving animation configuration and definition out of state definition
This removes cross dependency between StateManager and State object so
that it can be easily generalized

Change-Id: I62851fc4b653655cb40f37023db9651055ec7c9c
2020-05-07 01:33:57 -07:00
TreeHugger Robot 7826bf52c7 Merge "Implements LAUNCHER_ITEM_DROP_FOLDER_CREATED event." into ub-launcher3-rvc-dev 2020-05-07 01:38:51 +00:00
James O'Leary ac327df55c Merge "Revert "Compose gesture integrated fully into Launcher"" into ub-launcher3-rvc-dev 2020-05-07 01:14:44 +00:00
thiruram 5a01f0ec51 Implements LAUNCHER_ITEM_DROP_FOLDER_CREATED event.
When item is dropped on a existing item resulting in new folder creation, triggers LAUNCHER_ITEM_DROP_FOLDER_CREATED event with details of the destination package.
This change also introduces new FolderIcon item to launcher_atom.proto to represent folder icon.

Screencast and sample logs: https://docs.google.com/document/d/1CBP2yTcXdFhPdNG5ZmWFKSgd8mDbMevY-akVlUXPLDo/edit#bookmark=id.tmbucd1f44qp

Bug: 152978018

Change-Id: Ib4d343ba9075aa8853652f128457c4638541ec59
2020-05-06 17:24:09 -07:00
James O'Leary 2610bfde05 Revert "Compose gesture integrated fully into Launcher"
Revert "Compose gesture integrated fully into Nexus Launcher"

Revert submission 11035205-compose_gesture_fully_integrated_launcher

Reason for revert: Broke Launcher Android Studio build, quick switch, and home gesture doesn't work if Compose is open.
Reverted Changes:
I2d97b22d5:OverscrollPlugin refactored to use onTouchEvent
Ia19a55f65:Compose gesture integrated fully into Nexus Launch...
I65aa07ac1:Compose gesture integrated fully into Launcher

Change-Id: Ic05c47eb686b3942ba519e76db32977fc568844b
2020-05-07 00:13:47 +00:00
thiruram 261c3a6f6c Adds CONTAINER_ALL_APPS to LauncherSettings.Favorites.
Change-Id: I6ee81ef4e009ee99754545b5c8686dc0f9e261a2
2020-05-06 22:44:37 +00:00
TreeHugger Robot 870ec6a974 Merge "Improve Hybird hotseat cache support" into ub-launcher3-rvc-dev 2020-05-06 22:19:53 +00:00
Samuel Fufa 385e93249e Improve Hybird hotseat cache support
Loads list of cached apps and shows predicted app icons with the rest of workspace items.

-> Extracted prediction caching logic into a model layer

Bug: 155029837
Test: Manual

Change-Id: I6981594a910f5fe4e8e8cf8fe39db0cb856e7acd
2020-05-06 14:14:08 -07:00
James O'Leary d9c86d4b3b Compose gesture integrated fully into Launcher
- Support dismissing Compose via the reverse gesture from the appear
gesture
- Use Tony Wickham's ag/10204761 with some glue code to enable the
app below Compose panning in the same direction as the gesture as
Compose peeks in
- Add feature flag to use Compose hosted in a window (permits underlying
app panning)
- Use InterpolatingVelocityTracker to fix OtherActivityInputConsumer
processing swipes in the wrong direction ~20% of the time due to a bug
in VelocityTracker (see go/quirky-bubbles)

Change-Id: I65aa07ac112db8bd89cec9acfa0ce2b6ebacd43f
2020-05-06 13:40:47 -04:00
Zak Cohen 51e144ff8f Flag - rename SELECT_MODE to OVERVIEW_SELECTIONS
Better reflects what it is for.

Bug: 155806266
Test: toggled locally
Change-Id: Ied3ba04bce5363696e03741e494a1e1507ce38ce
2020-05-05 14:27:12 -07:00
thiruram 59c5f399a6 Duplicating InstanceId and InstanceIdSequence classes from framework internal package to launcher3.
com.android.internal.logging package is not directly accessible from launcher codebase hence making a duplicate classes until they are moved to common package.

Change-Id: I7c8a9bd89a322fc330b58460e6468ccff933ea44
2020-05-05 21:06:58 +00:00
Thiru Ramasamy 36fb598189 Merge "Implements LAUNCHER_ITEM_DROP_COMPLETED event." into ub-launcher3-rvc-dev 2020-05-05 21:06:04 +00:00
TreeHugger Robot 43e789ff9b Merge "Fixing max-zoom-scale not taking into account the the fullScreen scale" into ub-launcher3-rvc-dev 2020-05-05 02:01:00 +00:00
Sunny Goyal 29e7a58f1a Fixing max-zoom-scale not taking into account the the fullScreen scale
Also fixing the issue where display info is is not correctly initialized

Bug: 155257023
Bug: 155682580
Change-Id: Ib2cc981c1900f3d14f158f4dbb60ae77311f339b
2020-05-04 18:11:15 -07:00
thiruram 740e2ab12e Implements LAUNCHER_ITEM_DROP_COMPLETED event.
Assigns InstanceId to match LAUNCHER_ITEM_DROP_COMPLETED, LAUNCHER_ITEM_DRAG_STARTED events.

Sample Log:
2020-05-01 14:07:53.158 18369-18369/com.google.android.apps.nexuslauncher D/StatsLogManager: LAUNCHER_ITEM_DRAG_STARTED(InstanceId:282)
    # com.android.launcher3.logger.LauncherAtom$ItemInfo@c0711fbd
    application {
      component_name: "com.google.android.apps.maps/com.google.android.maps.MapsActivity"
      package_name: "com.google.android.apps.maps"
    }
    container_info {
      workspace {
        grid_x: 2
        grid_y: 1
        page_index: 0
      }
    }
    is_work: false
2020-05-01 14:07:54.308 18369-18369/com.google.android.apps.nexuslauncher D/StatsLogManager: LAUNCHER_ITEM_DROP_COMPLETED(InstanceId:282)
    # com.android.launcher3.logger.LauncherAtom$ItemInfo@90000206
    application {
      component_name: "com.google.android.apps.maps/com.google.android.maps.MapsActivity"
      package_name: "com.google.android.apps.maps"
    }
    container_info {
      workspace {
        grid_x: 0
        grid_y: 4
        page_index: 0
      }
    }
    is_work: false

Bug: 152978018

Change-Id: Ib4fc860e8080edd407ed15b93f7d55ac31328d11
2020-05-04 18:00:07 -07:00
TreeHugger Robot f9ec6f670c Merge "Decouple feature flag and predictions" into ub-launcher3-rvc-dev 2020-05-04 23:12:37 +00:00
Samuel Fufa 49d0f64a9d Decouple feature flag and predictions
- Always default to true for ENABLE_HYBRID_HOTSEAT
- Allow launcher to show predictions anytime regardless of notification and on-boarding.
- Remove past beta specific plans
- Migrate if first screen can accommodate hotseat items otherwise show tip

Bug: 142753423
Test: Manual
Change-Id: I142cd95d779964822da07a96e5884a0c82813742
2020-05-04 15:20:39 -07:00
Vinit Nayak bb55f9e982 Use rotation based on PagedOrientationHandler instead of touch
Fixes: 154928106
Test: Tested overview w/ and w/o
home rotation enabled.

Change-Id: Ib7e91e51b2181824e5520ad69965ed3379302c27
2020-05-04 11:58:11 -07:00
Alex Mang 5c6b320057 Listening to progress of all apps transition.
This will be used to synchronize keyboard popup. Also setting edittext before disabling to allow plugin to perform some cleanup

Change-Id: Ib9b4ab33d4292fe5d827c37f33c546a9fe6cb002
2020-05-01 16:47:22 -07:00
TreeHugger Robot e6843777b0 Merge "[AllAppsSearch] Update AllAppsSearch interface to expose the activity to the plugin" into ub-launcher3-rvc-dev 2020-05-01 23:08:00 +00:00
Hyunyoung Song e180641d38 Merge "Force all apps content to be alpha 0 when plugin is in place Bug: 155114822" into ub-launcher3-rvc-dev 2020-05-01 17:55:56 +00:00
TreeHugger Robot 7a87f953a8 Merge changes from topic "widget-logging" into ub-launcher3-rvc-dev
* changes:
  Fixes missing components info when logging Widget item.
  Implement LAUNCHER_ITEM_DRAG_STARTED event.
2020-05-01 07:54:03 +00:00
Jon Miranda b133a52e86 Fix app open/close animation in landscape.
When we refactored ClipIconView, we never init mIsVerticalBarLayout.
Instead we pass it in along with the rest of the info from FloatingIconView.

Bug: 155039118
Change-Id: Iff93105c512a8e6478dc49d8ab9100fd129af48c
2020-04-30 22:50:59 -07:00
Tony Wickham eb885026ed Fix spring overscroll when there's a min scroll
Test: clear app recent apps, open Calculator, open Clock,
quick switch to Calculator and see no jump

Bug: 154815348
Change-Id: I6289d43efe5d850cb2fd807d15115c5ce38c16dd
2020-04-30 23:27:39 -05:00
TreeHugger Robot 403640c393 Merge "Removing old unused code from PageView" into ub-launcher3-rvc-dev 2020-04-30 22:13:51 +00:00
thiruram 0707f2c702 Fixes missing components info when logging Widget item.
Sample Log:

LAUNCHER_ITEM_DRAG_STARTED
    # com.android.launcher3.logger.LauncherAtom$ItemInfo@5c06a6d1
    container_info {
      workspace {
        grid_x: 3
        grid_y: 3
        page_index: 3
      }
    }
    is_work: false
    widget {
      component_name: "com.google.android.deskclock/com.android.alarmclock.DigitalAppWidgetProvider"
      package_name: "com.google.android.deskclock"
      span_x: 2
      span_y: 1
    }

Change-Id: I3d468c77632c694454fcdca24f9d2ccd1c4f918c
2020-04-30 15:03:43 -07:00
thiruram f81e8b002a Implement LAUNCHER_ITEM_DRAG_STARTED event.
* Fixes null component issue when ItemInfo object copiedFrom.
* Fixes missing container when item is dragged from hybrid hotseat.

Sample Logs:
2020-04-30 14:09:45.499 30472-30472/com.google.android.apps.nexuslauncher D/StatsLogManager: LAUNCHER_ITEM_DRAG_STARTED
    # com.android.launcher3.logger.LauncherAtom$ItemInfo@260f31f8
    application {
      component_name: "com.android.chrome/com.google.android.apps.chrome.Main"
      package_name: "com.android.chrome"
    }
    container_info {
      workspace {
        grid_x: 2
        grid_y: 2
        page_index: 2
      }
    }
    is_work: false

2020-04-30 14:23:15.230 31320-31320/com.google.android.apps.nexuslauncher D/StatsLogManager: LAUNCHER_ITEM_DRAG_STARTED
    # com.android.launcher3.logger.LauncherAtom$ItemInfo@608f101
    application {
      component_name: "com.google.android.gm/.ConversationListActivityGmail"
      package_name: "com.google.android.gm"
    }
    container_info {
      hotseat {
        index: 1
      }
    }
    is_work: false

Bug: 152978018

Change-Id: I3d3ce213fd2fc6eb5ffb239e048ceb7c0fa88b53
2020-04-30 15:03:43 -07:00
TreeHugger Robot 28ad91b01b Merge "Overriding density when initializing device-profile as the app-context may not point to the correct density in multi-display" into ub-launcher3-rvc-dev 2020-04-30 20:25:47 +00:00
Sunny Goyal 1890f67800 Overriding density when initializing device-profile as the app-context may not
point to the correct density in multi-display

Bug: 154665987
Bug: 153293358
Change-Id: I9a95bf314049ce783067f70c735ea29a64388ce5
2020-04-30 12:29:02 -07:00
TreeHugger Robot 0199fa46de Merge "Removing tracking activity start/stop events" into ub-launcher3-rvc-dev 2020-04-30 18:06:00 +00:00
Sunny Goyal 8f96546e79 Generalizing LauncherState definition so that it can be used in RecentsActivity
> Removing 'Launcher' as parameter from state methods called by StateManager
> Converting state properties to methods for easier abstraction
> Moving state handling drom state definition to activity class

Change-Id: I997627df606a7e0bb3bf32688d045a942a47fc94
2020-04-30 01:01:51 -07:00
Sunny Goyal d75c1da9c7 Allow synchronous modification of update listeners list
We create a copy of the listeners before notifying update, so that
the original list can be changed

Bug: 154879110
Change-Id: If9de06682b189d199a40a9171d7d3cfb23eea062
2020-04-29 23:36:54 -07:00
TreeHugger Robot 2d60935e1c Merge "Various multi-window fixes" into ub-launcher3-rvc-dev 2020-04-29 23:43:57 +00:00
vadimt a1f0a10662 Removing tracking activity start/stop events
They were not especially useful in investigations; besides, these events
can be sent by the system asynchronously for actions that happened
before entering TAPL, causing flakes.

Change-Id: I72b5aad5521c6c0969f5b657b3db3e4d855f1d64
2020-04-29 14:23:53 -07:00
Vinit Nayak 3aed7aeb67 Merge "Use appropriate start padding for clear all button" into ub-launcher3-rvc-dev 2020-04-29 19:31:38 +00:00
Sunny Goyal 0addbf0512 Various multi-window fixes
> Fixing scale up calculator for swipe-down
> Offsetting pivot so that the preview is aligned to bottom-right
> Allowing insets to be available in multi-window mode as well
> Offsetting taskViewSimulator appropriately in multi-window mode

Change-Id: I7da4c145efca72ef219a5ffcaf23d726812df270
2020-04-29 11:50:33 -07:00
Jon Miranda db02b11340 Ensure final values are set when StaggeredWorkspaceAnim is cancelled/ended.
Was able to repo the bug reliably when calling cancel() and
end() immediately after starting the StaggeredWorkspaceAnim.

Bug: 153584267
Change-Id: I954d38ad69e72a83535f4dd1ec21dba0f61a3cfb
2020-04-29 15:51:10 +00:00
thiruram acbd7ef70f Updates launcher_atom.proto to support consistent logging for launcher containers.
* Updated default of some fields to invalid values. Because when these fields are not actually set on the client, the default values could lead to misinterpretations on the server side.
* Refactored container messages into a separate oneof message to use it on the client side as interface.

Test: Manual (make NexusLauncherDebug -j100)
Bug: 144124838

Change-Id: I2d2ea05e9d7d043682d8ca1a56a238d9d22174bb
2020-04-29 00:55:28 +00:00