Commit Graph

3906 Commits

Author SHA1 Message Date
Lucas Dupin 33015a7d8f Merge "Revert "Apply depth even when surface is null"" into sc-dev am: 8d43e46261 am: 5ab5faf72e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15341690

Change-Id: Ia49a91dd5e62cf0058b16ba92c9c452f8fbc2c74
2021-07-21 00:50:23 +00:00
Vinit Nayak fc02d3cf4a Merge "Move NavButtons to end of taskbar" into sc-v2-dev am: 6d2dd7a9e4 am: ce6907de48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15329808

Change-Id: I512d85536566883829bd3345c216248b06e00303
2021-07-21 00:44:42 +00:00
Vinit Nayak 6d2dd7a9e4 Merge "Move NavButtons to end of taskbar" into sc-v2-dev 2021-07-21 00:11:31 +00:00
Alex Chau c33b725c35 Merge "Wait for taskbar to become visible after closing launcher in tests" into sc-v2-dev am: 17e9b51e38 am: c8ec28885b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15301470

Change-Id: Ib7dbd2b47dc87e3bbe888af71c7727ca6f6ae3e0
2021-07-20 23:32:53 +00:00
Alex Chau 17e9b51e38 Merge "Wait for taskbar to become visible after closing launcher in tests" into sc-v2-dev 2021-07-20 22:59:31 +00:00
Lucas Dupin ee9099af7f Revert "Apply depth even when surface is null"
This reverts commit a6c38be150.

Fixes: 193333562
Test: manual
Change-Id: I4fae079e0cd056fc800e5a15389f4795c77e17fb
2021-07-20 14:14:50 -07:00
Vinit Nayak 8dcbde87c0 Move NavButtons to end of taskbar
* Layout hotseat icons from the end instead of the start
* IME down and system back arrow are now separate views

Bug: 191399224
Test: Tested w/ RTL + LTR in gesture
and 3 button nav w/ and w/o IME

Change-Id: I4d0ecd0bee0c519892c63eeefef45055b26d349b
2021-07-20 13:55:37 -07:00
Alex Chau a5653a268f Merge "Check if running task is null in onPrepareGestureEndAnimation" into sc-v2-dev am: 1387248378 am: ebea5dd5fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15336930

Change-Id: Ia54d78d7bebbd8b52e36970973a64172463c3ee0
2021-07-20 20:37:44 +00:00
Alex Chau cd791c5c9d Wait for taskbar to become visible after closing launcher in tests
- Taskbar takes some time to appear after closing launcher and launching test app

Bug: 193653850
Test: StartLauncherViaGestureTests
Change-Id: I714e35ee855660ac28bb214386f48ddbea0e834c
2021-07-20 21:11:08 +01:00
Alex Chau de6819a453 Check if running task is null in onPrepareGestureEndAnimation
- The crash happen when swiping to overview from home without any task in recents
- A simple null check fixes the issue

Fix: 194166137
Test: FallbackRecentsTest#goToOverviewFromHome
Change-Id: I9344a96a4a78fcfc88d2ad53e44ecd43b23114d5
2021-07-20 11:07:50 +01:00
Sunny Goyal b08a0deb77 Merge "Fixing quickswitch window not properly aligned in split-screen" into sc-dev am: c3f56d7628 am: e3063ce2ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15331678

Change-Id: I64734e46c241e8200c14bbd9c1d10baf0788e16c
2021-07-20 07:30:21 +00:00
Sunny Goyal be0b070019 Merge "Fixing quickswitch window not properly aligned in split-screen" into sc-dev am: c3f56d7628
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15331678

Change-Id: Icd63f65f52646e638c35229c6069455e9b9cd08e
2021-07-20 07:17:28 +00:00
Sunny Goyal c3f56d7628 Merge "Fixing quickswitch window not properly aligned in split-screen" into sc-dev 2021-07-20 07:03:51 +00:00
Tony Wickham 73c7cfd861 Merge "Add taskbar stashing feedforward, i.e. hint at upcoming stash/unstash" into sc-v2-dev am: 5eb1045cee am: 965a9c9b35
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302021

Change-Id: I27a93f8c244d2d95ccc5aa86b7bd3cbc48cdee03
2021-07-20 03:06:41 +00:00
Tony Wickham 5eb1045cee Merge "Add taskbar stashing feedforward, i.e. hint at upcoming stash/unstash" into sc-v2-dev 2021-07-20 02:44:28 +00:00
TreeHugger Robot f11d64387b Merge "Continue loading visible task data when scrolling recents during anim to home" into sc-v2-dev am: 0cc7f23e91 am: 4512ebc3ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15331672

Change-Id: I00b3da988bb94b5bbb3cae136eee8227375fde95
2021-07-20 00:43:54 +00:00
TreeHugger Robot 0cc7f23e91 Merge "Continue loading visible task data when scrolling recents during anim to home" into sc-v2-dev 2021-07-20 00:17:47 +00:00
Sunny Goyal a1bed5428d Fixing quickswitch window not properly aligned in split-screen
Bug: 193992000
Test: Manual
Change-Id: Ic37cbc561a0299be1a1c05dfb17bd826c173100e
2021-07-19 17:10:12 -07:00
Tony Wickham 8a2c1cbc5a Add taskbar stashing feedforward, i.e. hint at upcoming stash/unstash
Also fix unstashing not working in 3P launchers by moving the unstash call from LauncherTaskbarUIController to TaskbarActivityContext

Test: long press taskbar background and stashed handle, watch it hint towards the new stashed/unstashed state respectively and then complete the animation when the long press is triggered
Fixes: 193926311
Fixes: 192926350
Change-Id: I0e538be9129bf5c600d07f360b8106d7077862ad
2021-07-19 14:09:33 -10:00
Tony Wickham a9f728e57b Continue loading visible task data when scrolling recents during anim to home
When we go from overview to home, we scroll to page 0 so that all tasks end up offscreen. However, since we are already in NORMAL state, we previously ignored loadVisibleTaskData() for the tasks as they scrolled by. Instead, we now continue loading task data while the scroller is unfinished.

Test: swipe to last recent task, swipe up to home, ensure thumbnails are still loaded as they scroll offscreen
Bug: 192522519
Change-Id: Iba770200fc5dbdfc91dccda9a6b9c891ab6c5e3d
2021-07-19 11:34:07 -10:00
TreeHugger Robot 9bd4020134 Merge "Wait for dismiss animation to finish before checking task count" into sc-v2-dev am: b0ef69e886 am: 26db50490a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15312149

Change-Id: I7ee1650a1884c79aab63a42217a1cb18e2e563c7
2021-07-19 19:25:19 +00:00
TreeHugger Robot b0ef69e886 Merge "Wait for dismiss animation to finish before checking task count" into sc-v2-dev 2021-07-19 18:39:18 +00:00
Jonathan Miranda 291cfde1bb Merge "Fix notification dot not always being up to date." into sc-dev am: 8e095ccb05 am: 4e16c6ed22
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302020

Change-Id: Ieae003d368ec8452db75f9e332c0617b168cc44e
2021-07-19 18:14:10 +00:00
Jonathan Miranda 70e8c0b022 Merge "Fix notification dot not always being up to date." into sc-dev am: 8e095ccb05
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302020

Change-Id: I73d52b726f120029edc345a4154e36e734a6ea32
2021-07-19 18:00:49 +00:00
Jonathan Miranda 8e095ccb05 Merge "Fix notification dot not always being up to date." into sc-dev 2021-07-19 17:45:26 +00:00
Alex Chau 97cba26a20 Wait for dismiss animation to finish before checking task count
- See http://b/193440212#comment5, TaskView takes time after swipe gesture to finish dismiss animation, so wait for the animation to finish before checking task count

Bug: 193440212
Test: TaplTestsQuickstep#testOverview
Change-Id: I21397e68f384e956a7c9f2ee8a8161ac784b4d2e
2021-07-19 17:34:57 +01:00
Alex Chau 6403086ec9 Merge "Don't allow stashing in tests for now" into sc-v2-dev am: 0841e93a34 am: 554b9879cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15305566

Change-Id: Ic26a031e139f111c5eaee07b8fc5082a4b65a26f
2021-07-19 12:44:36 +00:00
Alex Chau 0841e93a34 Merge "Don't allow stashing in tests for now" into sc-v2-dev 2021-07-19 12:15:43 +00:00
Jon Miranda f8441cc276 Fix notification dot not always being up to date.
- Prediction row views were never updated when notification changes.
- FloatingIconView set the BubbleTextView to force hide dot, but never restored it.
  BubbleTextView is instanceof IconLabelDotView, so its already handled in the end runnable

Bug: 183360736
Test: 1. swipe up to go home such that the closing app has a notification,
         note that the notification dot is properly updated
      2. have all apps open
         make notification update for a predicted app
         ensure dot is properly updated

Change-Id: I35dacf9b71a3d8b8a857be450690d65ea9199bf6
2021-07-16 17:50:56 -07:00
Tony Wickham 9c84d7f3c3 Don't allow stashing in tests for now
Test: TaplTestsQuickstep#testOverviewActions (arbirarily)
Bug: 193521974
Change-Id: Ic2c5c5f9f37ed3f035ec932b4c96fb51598cf899
2021-07-16 12:27:40 -10:00
Thales Lima 4858427b19 Merge "launcher: enable swipe down to open focused app" into sc-v2-dev am: 2e15dde6b7 am: 63d04c5cd5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15297765

Change-Id: If4dab562459c82869da6c1fd4013f4e795c5b630
2021-07-16 13:44:11 +00:00
TreeHugger Robot 1941276ad7 Merge "Revert "Move focused task to front when attaching RecentsView"" into sc-v2-dev am: c0fe7b1cc4 am: d69d4e9742
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15301504

Change-Id: Iefc7cb0d703614c449c87c0f40affb908b24823b
2021-07-16 13:27:15 +00:00
Thales Lima 2e15dde6b7 Merge "launcher: enable swipe down to open focused app" into sc-v2-dev 2021-07-16 13:23:32 +00:00
TreeHugger Robot c0fe7b1cc4 Merge "Revert "Move focused task to front when attaching RecentsView"" into sc-v2-dev 2021-07-16 12:54:51 +00:00
Alex Chau a6451fc640 Revert "Move focused task to front when attaching RecentsView"
This reverts commit 86ac825061.

Reason for revert: Causes crash in fallback recents

Bug: 192471181
Change-Id: I41d2b5c87259568f21e6417be3a6dea5dd1a0864
2021-07-16 12:54:34 +00:00
Thales Lima fb5ba04c6a launcher: enable swipe down to open focused app
Fixes 192437421
Test: manual testing

Change-Id: Ife8e53cf4d7542525736e7b93ac92f9a2ddcd068
2021-07-16 10:55:38 +00:00
TreeHugger Robot 935ca32b3c Merge "Fixing regression from animation not starting while in overview" into sc-dev am: f054bf5681
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15305446

Change-Id: I4c4162c0734b9a3feaaf25eadca47f11e1887b8a
2021-07-16 02:04:42 +00:00
Cyrus Boadway d7573be527 Merge "Keep transparent drawable for clipping outline during launch animation" into sc-dev am: 66f1b57815
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15284080

Change-Id: I065ddc6049008b0a2db9767ab4d1e49e1537efac
2021-07-16 02:04:30 +00:00
TreeHugger Robot fd90e7e101 Merge "Fixing regression from animation not starting while in overview" into sc-dev am: f054bf5681 am: 60779dc5ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15305446

Change-Id: I74052fe8178c097cf567e14976c91340d8c9fe0b
2021-07-16 02:01:26 +00:00
TreeHugger Robot 3559798fba Merge "Removing support for change listeners from feature flags" into sc-v2-dev am: 4aac62110e am: fdbabc6be4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302089

Change-Id: I9bb74727ab64325944f2d01e4fcc7aebfda144fd
2021-07-16 01:56:33 +00:00
TreeHugger Robot fdbabc6be4 Merge "Removing support for change listeners from feature flags" into sc-v2-dev am: 4aac62110e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302089

Change-Id: Ib53f78f1badbf62661b96ad9b7f6455f596704e8
2021-07-16 01:30:55 +00:00
TreeHugger Robot f054bf5681 Merge "Fixing regression from animation not starting while in overview" into sc-dev 2021-07-16 01:27:02 +00:00
TreeHugger Robot 4aac62110e Merge "Removing support for change listeners from feature flags" into sc-v2-dev 2021-07-16 01:20:32 +00:00
Winson Chung 558b18eb12 Fixing regression from animation not starting while in overview
Bug: 193830420
Test: Open an app in overview, tap on a notification
Change-Id: Ifd9797dc40d9fffbf9603bca98fcb4a4119e0444
2021-07-15 16:17:51 -07:00
Sunny Goyal d3af716ca4 Binding Taskbar directly from Launcher model am: 711c596c86 am: c18cdf7c9d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15082875

Change-Id: I847ff8821328118761279cced5f6a642de8fd382
2021-07-15 22:40:12 +00:00
Sunny Goyal c18cdf7c9d Binding Taskbar directly from Launcher model am: 711c596c86
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15082875

Change-Id: I3c0247dc339993ecb9d6c740a064231a06857c22
2021-07-15 22:25:28 +00:00
Sunny Goyal 8cbefe2086 Removing support for change listeners from feature flags
FeatureFlags are supposed to work as static values and change
listeners can cause leaks if not handled properly at every place.

Bug: 193825269
Test: Manual
Change-Id: I54f9113bc01025da781a420154829d80ffa6a084
2021-07-15 15:07:04 -07:00
Sunny Goyal 711c596c86 Binding Taskbar directly from Launcher model
This allows taskbar to be loaded even in case of 3P Launchers
and removes dependency on LauncherActivity lifecycle

Bug: 187353581
Bug: 188788621
Test: Manual
Change-Id: I5a0988e0697b41677d4c58f0213aef14ec0c0972
2021-07-15 12:43:11 -07:00
Cyrus Boadway 1db10e2a3a Merge "Keep transparent drawable for clipping outline during launch animation" into sc-dev am: 66f1b57815 am: e08c377a72
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15284080

Change-Id: If16f06c6aa4d615df865a64f9327dcae9c131eaa
2021-07-15 18:56:08 +00:00
Cyrus Boadway 1df813a13e Merge "Keep transparent drawable for clipping outline during launch animation" into sc-dev am: 66f1b57815 am: eec4833b22
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15284080

Change-Id: I8af5f490e5e4325f5034177b9eef249207c85301
2021-07-15 18:55:44 +00:00