Commit Graph

9076 Commits

Author SHA1 Message Date
Pinyao Ting d88f63bbed add null check when accessing target component from iteminfo
Bug: 139540363
Change-Id: I25d0100077de67b085c27b5ef91e22c6ac1ad959
Merged-In: I25d0100077de67b085c27b5ef91e22c6ac1ad959
2019-08-16 21:50:21 +00:00
Hyunyoung Song 96eba3aea6 Merge "Make TogglableFlag backed by DeviceConfig for e2e testing" into ub-launcher3-qt-qpr1-dev 2019-08-15 22:25:33 +00:00
Hyunyoung Song d4204437de Make TogglableFlag backed by DeviceConfig for e2e testing
Bug: 138964490

TL;DR;; need this to be part of QQ1 or QD1 to verify if DeviceConfig
can be supported for launcher toggleableFlags.

Not handled in this CL:
- When flag is locally modified, that will override the flag value
How that scenario is handled should be discussed separately and is not
within scope of this CL.

Change-Id: I2e6694a40bee9202ed0b0d559e3b5607634071bf
2019-08-15 14:02:28 -07:00
TreeHugger Robot 46463f6a19 Merge "Adding support for storing keywords in iconCache" into ub-launcher3-qt-qpr1-dev 2019-08-14 23:08:43 +00:00
TreeHugger Robot 4c19f94181 Merge "Adding app search improvement flag" into ub-launcher3-qt-qpr1-dev 2019-08-14 23:08:43 +00:00
Sunny Goyal 934ebd087b Adding support for storing keywords in iconCache
Change-Id: I1183e63a6556ebfb3eee5df23d149e09728193a9
Merged-In: I1183e63a6556ebfb3eee5df23d149e09728193a9
(cherry picked from commit e529a86fbd)
2019-08-14 22:12:49 +00:00
Alex Mang 713cd6fd56 Adding app search improvement flag
Bug: 125027540
Change-Id: I68fd7710b108e9f2fa1f5ff335326585a92deb23
Merged-In: I68fd7710b108e9f2fa1f5ff335326585a92deb23
(cherry picked from commit d27e31995b)
2019-08-14 21:58:57 +00:00
yingleiw 02cc848896 Add directional accessibility page actions to PagedView
For PagedView, when isPageOrderFlipped is true, it means the LTR mode is
flipped. For the "recents" in launcher, isPageOrderFlipped is true.
However, this doesn't affect the directional page operations since
scrollLeft()/Right() already has correct Rtl considerations. See
b/78788182 for more information on the LTR mode.

Test: Tested with the "recents" in launcher. Verified that page left
action always move pages to the right (so that the next page from the
left side shows), and page right actions always move pages to the left
(so that the next page from the right side shows). Also tested with the
home screen 1/2, 2/2 paging.
Bug: 136277517

Change-Id: I965d651c37d258eaa8ea347d1ad6f698f9b590bf
2019-08-14 18:05:08 +00:00
Becky Qiu 22edac9bf5 Merge "Log the event for swiping up to dismiss a task in Overview." into ub-launcher3-qt-qpr1-dev 2019-08-14 17:48:45 +00:00
Becky Qiu 90ea00b399 Log the event for swiping up to dismiss a task in Overview.
Test: manual
Bug: 137777105

Demo logging for dismissing a task:
  data {
    elapsed_timestamp_nanos: 70772067228810
    atom {
      launcher_event {
        action: DISMISS_TASK
        src_state: OVERVIEW
        dst_state: BACKGROUND
        is_swipe_up_enabled: true
      }
    }
  }

Change-Id: I5569b80e2e1f35661bc5e9e343c6c298791a1ec1
2019-08-09 10:57:05 -07:00
vadimt c1a2764a6e Support for memory tests
Change-Id: I867a232a293f7bddbc630f563f18c0db94ac4b6e
2019-08-08 12:03:09 -07:00
Pinyao Ting e4061fc931 show dot in deep shortcuts when notification contains exactly identical
set of person

Bug: 132336512
Change-Id: I975524e28168c10a186cdc24b188c161faf433cf
Merged-In: I975524e28168c10a186cdc24b188c161faf433cf
2019-08-05 23:31:35 -07:00
Sunny Goyal 2c848d029c Merge "Fix DEFER_UPDATES_NEXT_DRAW flag is not unset when binging happens twice" into ub-launcher3-qt-r1-dev
am: 0a9e91b6e4

Change-Id: Iad5027f7925981de0720ca960e5a8ffdd2a1463c
2019-08-05 17:39:41 -07:00
TreeHugger Robot 0a9e91b6e4 Merge "Fix DEFER_UPDATES_NEXT_DRAW flag is not unset when binging happens twice" into ub-launcher3-qt-r1-dev 2019-08-06 00:33:31 +00:00
Sunny Goyal 6b6d0a3972 Fix DEFER_UPDATES_NEXT_DRAW flag is not unset when binging happens twice
Bug: 138646754
Change-Id: I76eccdb812013299e18f197ba17ff858a01a6338
2019-08-05 17:20:10 -07:00
Vadim Tryshev f4a1814c3f Merge "Adding debug tracing to catch non-dragging to workspace" into ub-launcher3-qt-qpr1-dev 2019-08-05 23:30:13 +00:00
Jon Miranda ccf108c5f3 Fix launcher crash when trying to open work profile promise icon.
am: 0121d466ec

Change-Id: I40272f5061cea59b846d6633cd60217a263eb454
2019-08-05 14:55:12 -07:00
Jon Miranda 0121d466ec Fix launcher crash when trying to open work profile promise icon.
Bug: 138609751
Change-Id: Ifb1c4628ce6307a19a2bb696e4771d5cd5810a90
2019-08-05 14:36:04 -07:00
vadimt f1726290d4 Adding debug tracing to catch non-dragging to workspace
Bug: 138729456
Change-Id: I28f1eaeb17a75cbc6f52b259d0226deaff42e0bb
2019-08-05 13:52:36 -07:00
Jon Miranda b1d8ad6be5 Merge "Bandage fix for bitmap fatal exception where width / height !> 0." into ub-launcher3-qt-r1-dev
am: cf92f3edb0

Change-Id: Iea9db807ebc65bcb612294a4283346e714b25f63
2019-08-01 16:50:56 -07:00
TreeHugger Robot cf92f3edb0 Merge "Bandage fix for bitmap fatal exception where width / height !> 0." into ub-launcher3-qt-r1-dev 2019-08-01 23:27:31 +00:00
Jon Miranda 40bce3efe4 Bandage fix for bitmap fatal exception where width / height !> 0.
Bug: 135558924
Change-Id: I0a22ba849b50eee87abd52ab9ec3211294a6c40b
2019-08-01 16:17:37 -07:00
Becky Qiu bfc2da1fd8 Log the right workspace id for -1 screen for stop and resume.
Test: manual
Bug: 137952354

Logs after this fix:
08-01 12:01:36.220 17105 17105 D UserEvent: action:STOP
08-01 12:01:36.220 17105 17105 D UserEvent:  Source child:WORKSPACE id=-1
08-01 12:01:36.220 17105 17105 D UserEvent:  Elapsed container 5511 ms, session 5511 ms, action 0 ms
08-01 12:01:36.220 17105 17105 D UserEvent:
08-01 12:01:38.042 17105 17105 D UserEvent:
08-01 12:01:38.042 17105 17105 D UserEvent: -----------------------------------------------------
08-01 12:01:38.042 17105 17105 D UserEvent: action:RESUME
08-01 12:01:38.042 17105 17105 D UserEvent:  Source child:WORKSPACE id=-1
08-01 12:01:38.042 17105 17105 D UserEvent:  Elapsed container 7334 ms, session 7334 ms, action 0 ms
08-01 12:01:38.042 17105 17105 D UserEvent:

Change-Id: Ic2d88eee3ff7a0e28d5c7e4cab8ee61952ed95ee
2019-08-01 22:55:42 +00:00
Becky Qiu 84fa94e2fc Fill the log container as hotseat or workspace based on position.
Test: manual
Bug: 137953006

Swipe from workspace:
07-30 15:15:44.031  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:44.031  9779  9779 D UserEvent:  Source child:WORKSPACE id=0 span(951,1313)	parent:WORKSPACE id=0
07-30 15:15:44.031  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:44.031  9779  9779 D UserEvent:  Elapsed container 826 ms, session 9361 ms, action 0 ms

Swipe from hotseat:
07-30 15:15:46.010  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:46.010  9779  9779 D UserEvent:  Source child:HOTSEAT id=0 span(786,1908)	parent:WORKSPACE id=0
07-30 15:15:46.010  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:46.010  9779  9779 D UserEvent:  Elapsed container 1139 ms, session 11339 ms, action 0 ms

Change-Id: I959528889fda778efc569bb59e7f44d3bd5b81bc
2019-08-01 22:24:44 +00:00
Pinyao Ting 9447e887db Merge "Ensure each dot contains only relevant notification to the shortcut and displays system shortcut when long click on deep shortcut." into ub-launcher3-qt-qpr1-dev 2019-08-01 16:51:57 +00:00
Pinyao Ting bf608722b9 Ensure each dot contains only relevant notification to the shortcut
and displays system shortcut when long click on deep shortcut.

In this CR we
1) for each shortcut, we filters the notifications to ensure we only
 get notifications with identical shortcutId.
2) allow system shortcut to be displayed when user long click on a
DeepShortcut

Bug: 132336512
Change-Id: Idc9eaed55e900ed4027a43ee9c3fd7dc6f4480b2
Merged-In: Idc9eaed55e900ed4027a43ee9c3fd7dc6f4480b2
2019-07-31 23:56:54 +00:00
Tony Wickham 70f539cd45 Merge changes Ib3e373c2,Ia5d6f545 into ub-launcher3-qt-r1-dev
am: 1343f03e2e

Change-Id: Ie3f4c2c15e331c84f0f048c6337ae4e58111ec56
2019-07-31 15:36:50 -07:00
Tony Wickham 1343f03e2e Merge changes Ib3e373c2,Ia5d6f545 into ub-launcher3-qt-r1-dev
* changes:
  Tie prediction text to all apps interpolator
  Add OverviewScrim to show below overview but above workspace
2019-07-31 22:12:54 +00:00
Tony Wickham 35a4e0eec9 Tie prediction text to all apps interpolator
Now floating headers get 2 interpolators: one for the header content
itselt, and one for the all apps content that follows. That way, they
can choose to intperolate part of their content as if it were part of
all apps instead of the header. Currently, we do this to animate
predicted icons quickly, followed by the all apps icons, predictions
text, all apps scrollbar, and all apps divider as you continue swiping.

Bug: 132455160
Change-Id: Ib3e373c291e174e1306a53854d0ad4dc29eb4b76
2019-07-31 14:45:18 -07:00
Tony Wickham c088051c29 Add OverviewScrim to show below overview but above workspace
- Refactor some basic scrim logic to Scrim class and have
  WorkspaceAndHotseatScrim and OverviewScrim extend it
- Draw OverviewScrim under recents unless predictions are disabled, in
  which case draw it under hotseat (since that is in recents)
- Remove sysui scrim (behind status bar and nav bar) when overview is
  peeking

Bug: 132455160
Change-Id: Ia5d6f54582a4c5a70e3b2d4a98281567edd68519
2019-07-31 14:44:28 -07:00
Sunny Goyal 20f56a7c9a Merge "Fixing multi-window DnD getting cancelled when starting a new activity in the middle" into ub-launcher3-qt-r1-dev
am: 5e1658a188

Change-Id: I849c337f45395692dc547ee2e9c82f61ff1b4efa
2019-07-31 13:17:32 -07:00
TreeHugger Robot 5e1658a188 Merge "Fixing multi-window DnD getting cancelled when starting a new activity in the middle" into ub-launcher3-qt-r1-dev 2019-07-31 19:51:07 +00:00
Pinyao Ting 6d09a7770f Merge "show dot on shortcut when incoming notification contains exactly the same shortcut id" into ub-launcher3-qt-qpr1-dev 2019-07-30 19:40:45 +00:00
Pinyao Ting 4d1a0e2a7b show dot on shortcut when incoming notification contains exactly the
same shortcut id

Bug: 132336512
Change-Id: Iddf4cfe8ad60c12e8de8b171bed392f1bb0a6761
Merged-In: Iddf4cfe8ad60c12e8de8b171bed392f1bb0a6761
2019-07-30 19:39:10 +00:00
Jon Miranda 1767e9e537 Fix bug where work profile widgets are restored with main profile provider.
am: 3e90b4c7ae

Change-Id: Ied93479e1ef4bc08fd8187a55d505024df2c9e0f
2019-07-30 11:45:40 -07:00
vadimt 647d5014d8 Unconditionally logging RemoteActionShortcut events
To help investigating DWB performance issues.

Bug: 138273985
Change-Id: I15d7b220ac47f514c223ba6876549a0b0e9ca95b
2019-07-30 10:36:31 -07:00
Jon Miranda 3e90b4c7ae Fix bug where work profile widgets are restored with main profile provider.
* Platform bug causes work profile widgets to be restored with main profile
  provider.
* If we skip restore the widgets under the work profile during restore, then
  launcher will re-create the widget but with the correct profile provider.
* Needs to be fixed in platform, but this launcher side change will work for
  now.

Bug: 135926478
Change-Id: I80300c83e82cea9da84fdcdf7ad03188769b6cac
2019-07-30 09:03:12 -07:00
Sunny Goyal 9eb96c5811 Fixing multi-window DnD getting cancelled when starting a new activity in the middle
Bug: 133472746
Change-Id: I868f2bc5f1db4a7fa22df212122317bfef27a282
2019-07-29 11:27:56 -07:00
TreeHugger Robot 2cccb134a4 Merge "Add several missing swipe logging Enable swipe down to open noti shade from landscape" into ub-launcher3-qt-r1-dev 2019-07-25 21:55:16 +00:00
Hyunyoung Song e299a45944 Add several missing swipe logging
Enable swipe down to open noti shade from landscape

Bug: 137137090
Bug: 137954767
Bug: 134181439

Change-Id: I47b4d17c9ae0586565fce101eb478e33ed8f7e3d
2019-07-25 13:18:48 -07:00
TreeHugger Robot b7094fcf36 Merge "Using the first frame delay based on the display refresh rate instead of hardcoding it to 16ms" into ub-launcher3-qt-r1-dev 2019-07-24 19:32:17 +00:00
Sunny Goyal 4e6c45bcd3 Using the first frame delay based on the display refresh rate instead of
hardcoding it to 16ms

> Creating a utility class for caching display property changes

Bug: 128940249
Change-Id: I6f9a214548de65bd1c8530508d665ee88312da4a
2019-07-24 10:12:37 -07:00
Anna Wasewicz 064cba4560 Changing ENABLE_HINTS_IN_OVERVIEW flag to be true in qt-r1-dev. It
should be false in qt-dev and true in qt-r1-dev.

Bug: 138252347
Change-Id: If9de47ef937ecb3da9c8d43eea8ad4b6e6885582
2019-07-23 17:34:34 -07:00
Tony Wickham b2e6a77b0d Merge "Set FastBitmapDrawable scale=1 before drawing it in DragView" into ub-launcher3-qt-r1-dev 2019-07-24 00:07:18 +00:00
vadimt cd7b00853b Adding debug tracing
Bug: 138251824
Change-Id: Ibe3de964aeacbf83fd46cc53fda7d15c9401fe4d
2019-07-23 16:49:48 -07:00
Tony Wickham d418f3c3fa Set FastBitmapDrawable scale=1 before drawing it in DragView
When we draw the icon to the DragView, we draw it
with the current scale, which is > 1 when animating
the icon down. Instead, we should always draw the
icon with scale 1 since the DragView itself is scaled.

Bug: 138236583
Change-Id: I6bca5cf28c54d58476240e0e68900a8f08ffe60b
2019-07-23 13:48:08 -07:00
Tony Wickham b6841ac630 Revert the changes that prevented touch on RecentsView during animation
The original bug that was solving seems to be fixed by other changes,
and this allows users to scroll, dismiss, etc on recent tasks before
fully reaching overview from an app.

Bug: 137487381
Change-Id: I28a708811bba3ce739ce261f19eb29558d8f0e7d
2019-07-22 12:39:59 -07:00
Tony Wickham 6670435c14 Merge "Allow TouchControllers to override shouldDisableGestures" into ub-launcher3-qt-r1-dev 2019-07-18 22:27:54 +00:00
Tony Wickham f33b6d4378 Allow TouchControllers to override shouldDisableGestures
Currently only StatusBarTouchController overrides this to always return
false, so that you can swipe down for notifications during transition to
home screen from an app (in gesture nav).

Bug: 137161198
Change-Id: I803c37937d5294810cbe0c1bbffcd5dddcc5ca3b
2019-07-18 15:10:21 -07:00
vadimt 2f7d1fa4a8 Using correct gesture margins in overview
Change-Id: I0108858279559e10633825f7de22211515f0e9b7
2019-07-17 15:18:21 -07:00