Commit Graph

2224 Commits

Author SHA1 Message Date
Hyunyoung Song 226cfa10fe Merging ub-launcher3-qt-r1-dev, build 5642992
Test: Manual

Bug:122345781 P1 Inflation happens and a binder call during swipe up gesture, that may cause jank
Bug:123900446 P1 App to home animation should zoom into the app icon
Bug:132209249 P1 Gesture bar interferes with Messenger chat heads.
Bug:132815672 P1 -1 to home swipe up gesture
Bug:132886768 P1 Swipe home animation sometimes drops frames
Bug:132900132 P1 Apparently, tests start running while provisioning is still in progress
Bug:133009122 P2 Rare flake: dragged launchable to workspace, but the current state is not WORKSPACE; Can't find a launcher object; selector: BySelector [RES='\Qcom.google.android.apps.nexuslauncher:id/apps_view\E']
Bug:133226418 P1 [Gesture Nav] App launch animation has has incorrect origin when launched in Overview
Bug:133508173 P1 App switching is very janky on QT
Bug:133765434 P1 [Flaky test] Launching task didn't open a new window
Bug:133871965 P1 (V35 20190528.00_RC00):Unable to unlock/minimize phone app during ongoing call
Bug:134095068 P1 Shouldn't use seamless rotation in another case
Bug:134164918 P1 STOPSHIP: Disable chips hard-coded value in qt_dev Launcher
Bug:134166337 P1 3P Launcher Breaks Overview (Standalone)
Bug:134172603 P1 Tracing for lab-only flakes
Bug:134517106 P1 Swipe up to home should fade out scrim
Bug:134532571 P1 Launcher flake: java.lang.AssertionError: http://go/tapl : want to switch from background to overview, but the current state is not BASE_OVERVIEW; Can't find a launcher object; selector: BySelector [RES='\Qcom.google.android.apps.nexuslauncher:id/overview_panel\E']
Bug:134674880 P1 App group name in expanded view is invisible with white wallpaper
Bug:issue priority summary
Change-Id: I223b838725803cc7c7e00cd33794145fcbf0a414
2019-06-07 16:50:16 -07:00
vadimt 51d2cf913c Merge "Add tracing for b/134532571" into ub-launcher3-qt-dev
am: bfe171f9cb

Change-Id: I86539398e74beb527cbede66143ff1c61990cca8
2019-06-06 17:31:41 -07:00
TreeHugger Robot bfe171f9cb Merge "Add tracing for b/134532571" into ub-launcher3-qt-dev 2019-06-07 00:10:30 +00:00
vadimt 0f08db5eeb Add tracing for b/134532571
Bug: 134172603
Bug: 134532571
Change-Id: I75c8e0212a9b35d33842d5380fbe733b486be932
2019-06-06 17:00:57 -07:00
Sunny Goyal bbbfc62c63 Merge "Disable seamless rotation for 3 and 2 button mode" into ub-launcher3-qt-dev
am: 19f7c6fefb

Change-Id: Iec2636f14a157e9a9b5e9c47e1c258b9158dc942
2019-06-06 15:58:04 -07:00
TreeHugger Robot 19f7c6fefb Merge "Disable seamless rotation for 3 and 2 button mode" into ub-launcher3-qt-dev 2019-06-06 22:45:47 +00:00
Sunny Goyal 0b1cb75ee8 Disable seamless rotation for 3 and 2 button mode
Bug: 134095068
Change-Id: I8603e49a85b5524a02c9085485a180b022e3f91e
2019-06-06 15:35:45 -07:00
Vadim Tryshev 9788fbda66 Merge "Test: using RuleChain to create a correct order of rules." into ub-launcher3-qt-dev
am: 8278148e41

Change-Id: I764fef9315039c1272b63495c261a5ec83839220
2019-06-06 14:31:43 -07:00
Vadim Tryshev 8278148e41 Merge "Test: using RuleChain to create a correct order of rules." into ub-launcher3-qt-dev 2019-06-06 21:20:50 +00:00
vadimt 44e9a873fc Test: using RuleChain to create a correct order of rules.
Change-Id: I2eeb933eab8e5f19b1f80d47566a511ddbdeb28b
2019-06-06 14:02:33 -07:00
Jon Miranda 9c078a6b99 Merge "Reduce alpha delay 25ms to reduce flashy feeling of appearing large." into ub-launcher3-qt-dev
am: 256762251e

Change-Id: I99bd2383244e0b753ee18cb8657efe0bd0b676d0
2019-06-06 12:58:20 -07:00
TreeHugger Robot 256762251e Merge "Reduce alpha delay 25ms to reduce flashy feeling of appearing large." into ub-launcher3-qt-dev 2019-06-06 19:48:42 +00:00
Sunny Goyal f95a845924 Merge "Using a separate InputConsumer when Launcher is resumed but not focused" into ub-launcher3-qt-dev
am: 7183795ff8

Change-Id: Idafa9bc76dc8d22b3f69388824859d86e0737a81
2019-06-06 12:13:57 -07:00
Tony Wickham d5270da80d Merge "Fix flicker to OVERVIEW state during quick switch" into ub-launcher3-qt-dev
am: 215ab0ca87

Change-Id: I04e1068111893c41a6ade925daf3f37259e0591f
2019-06-06 12:07:54 -07:00
TreeHugger Robot 7183795ff8 Merge "Using a separate InputConsumer when Launcher is resumed but not focused" into ub-launcher3-qt-dev 2019-06-06 19:06:30 +00:00
Sunny Goyal 6f479ff9de Using a separate InputConsumer when Launcher is resumed but not focused
When Launcher is not focused and we try to dispatch events to Launcher, it
can lead to a inconsistent state. For eg, NavBarTouchController was trying
to take launcher from NORMAL to NORMAL state causing the endCallback to be
called immediately, which in turn didn't clear Swipedetetor state

Bug: 132209249
Bug: 132815672
Change-Id: I82e4fdcb8fd5339e82fc8551f3a6e0b046d906f8
2019-06-06 11:57:54 -07:00
Tony Wickham 215ab0ca87 Merge "Fix flicker to OVERVIEW state during quick switch" into ub-launcher3-qt-dev 2019-06-06 18:55:14 +00:00
vadimt 77d4204544 Temporarily not using RuleChain as it mysteriously breaks tests
am: 63013c5e57

Change-Id: I0e105abbf0f3a52124f40a44ba4c5f0cc2bc2fc8
2019-06-05 19:55:38 -07:00
Sunny Goyal 5db7cb9c2d Merge "Fixing wrong origin when launching new task from overview" into ub-launcher3-qt-dev
am: bfaabbea81

Change-Id: Ie0939ae8c5286631da3ef08ffaf0151bdc81c7e6
2019-06-05 19:54:59 -07:00
vadimt 63013c5e57 Temporarily not using RuleChain as it mysteriously breaks tests
Change-Id: I8bdd9a8ea12cfdbd92fe724181e7479cadcb26fe
2019-06-05 18:34:23 -07:00
Tony Wickham df4727e8ee Fix flicker to OVERVIEW state during quick switch
Here's what was happening:
- When animating to a new task, the launcher controller ends first (when
  quick switching it likely ends immediately since we're already scaled up).
- Then we get onApplyWindowInsets(), which re-builds the launcher controller.
- Finally, the window animation ends, invalidating the handler and ending
  the new controller, which sets the state to OVERVIEW.

To fix this, never create a new controller if it has ever been started.

Bug: 133508173
Change-Id: Ibd0e18e488353df73159ffbdd9a3b335bed57d98
2019-06-05 17:19:20 -07:00
Sunny Goyal bfaabbea81 Merge "Fixing wrong origin when launching new task from overview" into ub-launcher3-qt-dev 2019-06-06 00:16:29 +00:00
Vadim Tryshev be8f7d2845 Merge "Taking local screenshot before navigation state is restored" into ub-launcher3-qt-dev
am: e7f313dc0c

Change-Id: I210029248261971df07524e7836a54bd721daa4e
2019-06-05 16:48:56 -07:00
Vadim Tryshev e7f313dc0c Merge "Taking local screenshot before navigation state is restored" into ub-launcher3-qt-dev 2019-06-05 23:34:05 +00:00
vadimt 7a38854284 Taking local screenshot before navigation state is restored
Change-Id: Id8003b17c68af5b4882bdbf5e14a142875791cbc
2019-06-05 16:18:55 -07:00
Tony Wickham dd31cda247 Merge "Fade out scrim when swiping to home" into ub-launcher3-qt-dev
am: be1fde798c

Change-Id: I490a890b122a87a42e21b2dda30abb32c209a717
2019-06-05 15:36:30 -07:00
Tony Wickham be1fde798c Merge "Fade out scrim when swiping to home" into ub-launcher3-qt-dev 2019-06-05 22:27:49 +00:00
Sunny Goyal 17ccea1ec9 Merge "Adding some state for fallback recents View" into ub-launcher3-qt-dev
am: 4ab6254bdc

Change-Id: I6a4e56565114a30b9b98c640b54fb55c6ea10e15
2019-06-05 14:49:45 -07:00
TreeHugger Robot 4ab6254bdc Merge "Adding some state for fallback recents View" into ub-launcher3-qt-dev 2019-06-05 21:40:38 +00:00
Sunny Goyal bda6b45341 Fixing wrong origin when launching new task from overview
> Also removing some unnecessary layout passes during launch animation

Bug: 133226418
Change-Id: I36fe69827853366deb7c56ca25f39e20c1a0b825
2019-06-05 12:25:28 -07:00
Winson Chung 4934b6f89f Merge "Use device locked input consumer when an activity is showing when locked" into ub-launcher3-qt-dev
am: ff9fe09b3f

Change-Id: Ife915a7d822a865da477979bb3ca290949843c69
2019-06-05 11:32:52 -07:00
Zak Cohen 8d19146b7b Remove unused hints code.
This layout is handled by the provider of the hints now.

Bug: 132886768
Test: manual
Change-Id: Ifc0db2395a7503b1b03dcb796961ef6647c0413b
(cherry picked from commit f3231f417d)
2019-06-05 11:18:09 -07:00
Jon Miranda 88dd84254c Reduce alpha delay 25ms to reduce flashy feeling of appearing large.
Bug: 123900446
Change-Id: Ia8ff74eb6b65affbf5c6c1599f4d168b459f324e
2019-06-05 11:07:17 -07:00
Sunny Goyal 87c8a511cd resolve merge conflicts of f17eb616a8 to ub-launcher3-qt-r1-dev
Bug: None
Test: I solemnly swear I tested this conflict resolution.
Change-Id: I4e177dfb7ba3bde6eb53f63c2f2df273feef90ee
2019-06-05 10:44:02 -07:00
Tony ae087dc9b8 Fade out scrim when swiping to home
Bug: 134517106
Change-Id: Ica725e3a327c1c069e3859732ea6a878d361a3d8
2019-06-04 19:25:03 -07:00
Winson Chung ff9fe09b3f Merge "Use device locked input consumer when an activity is showing when locked" into ub-launcher3-qt-dev 2019-06-04 21:42:44 +00:00
Sunny Goyal 1b52c7e5de Some RecentsView layout fixes
> Only creating task overlay for one view at a time
> Fixing setOverviewStateEnabled called twice when going
  between OVERVIEW and BACKGROUND state

Bug: 132815672
Bug: 122345781
Change-Id: I51ac5b0744af87194eca08e07fd2c75b8fa0d3e0
2019-06-04 14:17:30 -07:00
Winson Chung a3ed49d566 Merging ub-launcher3-qt-dev, build 5633311
Test: Manual

Bug:119330044 P1 [STOPSHIP] Add back shape detection in Launcher icons
Bug:123900446 P1 App to home animation should zoom into the app icon
Bug:132298752 P1 Adding widget locks home screen page
Bug:132757019 P1 Swipe up twice quickly from app in 2 button mode; can't access all apps
Bug:133518678 P1 In 2 button mode, flinging up strongly favours quickswitch
Bug:133806285 P1 All apps causes overview to peek in
Bug:133844237 P1 Respect limited width Exclusion Rects in bottom area?
Bug:133867119 P2 Lab-only flake: want to switch from workspace to all apps; Swipe failed to receive an event for the swipe end
Bug:134062513 P1 Quickswitch sends lifecycle events to -1
Bug:134094839 P1 Launcher kept crashing on OTA update
Bug:134096917 P1 Launcher animation component gets stuck during swipe up
Bug:134164918 P1 STOPSHIP: Disable chips hard-coded value in qt_dev Launcher
Bug:134172603 P1 Tracing for lab-only flakes
Bug:134442147 P1 Sometimes All Apps won't update on app install/uninstall/update
Change-Id: Ia530fbf9bb5fa67b602ce44aef0cc4a1d1494e13
2019-06-04 12:20:05 -07:00
Winson Chung ed6a3eada7 Use device locked input consumer when an activity is showing when locked
Bug: 133871965
Change-Id: I51a32a99990813e510c757e5e295a09f041c0514
2019-06-04 10:40:31 -07:00
Sunny Goyal 9d8b1376e8 Adding some state for fallback recents View
Maintaining a boolean corresponding to overview or QuickSwitch which
updates the visuals for RecentsView accordingly

Bug: 134166337
Change-Id: If1aec99257de4db1796335f2cf39d2d35789915b
2019-06-03 16:00:06 -07:00
Zak Cohen f3231f417d Remove unused hints code.
This layout is handled by the provider of the hints now.

Test: manual
Change-Id: Ifc0db2395a7503b1b03dcb796961ef6647c0413b
2019-06-03 14:58:18 -07:00
Tony Wickham dcff2f1875 Merge "Fix getting stuck in BackgroundAppState for 2-button mode" into ub-launcher3-qt-dev
am: 72c6e7b736

Change-Id: I6ab2194d50a6d7dfb7bd7c13bab776331c426c23
2019-05-31 16:26:39 -07:00
Sunny Goyal 3695646987 Merge "Fixing overview scrim not initialized properly when launcher starts" into ub-launcher3-qt-dev
am: 061c43eb4f

Change-Id: I58aa5801e698c8e8b2e0133f6995d77b341cc76f
2019-05-31 16:26:05 -07:00
TreeHugger Robot 72c6e7b736 Merge "Fix getting stuck in BackgroundAppState for 2-button mode" into ub-launcher3-qt-dev 2019-05-31 23:22:30 +00:00
Tony Wickham a04e746e84 Fix getting stuck in BackgroundAppState for 2-button mode
When ending in recents, we reapply the state - therefore, it's important
to make sure we are in OverviewState before onSwipeUpComplete(). This is
done by mLauncherTransitionController, which sets OverviewState on end.
We already force mLauncherTransitionController to end before calling
onSwipeUpComplete(), but in this case we were calling cancel() and
setting mLauncherTransitionController = null, which meant we could never
call end() on it. Instead, we should always call end() if we set it to
null.

Also ensure mLauncherTransitionController is created even if the gesture
is completed, if an existing controller isn't already running. This can
happen if you swipe up quickly enough that we get onGestureEnd before
launcher is drawn, and in that case we still want the launcher component
to animate once its ready. This is even more important for 2-button
mode, because again, we rely on mLauncherTransitionController to set the
state to OverviewState before we reapply it.

Finally, clarified some methods by renaming "swipeUp" to
"swipeUpToRecents".

Bug: 132757019
Change-Id: Ieb24a4f36a39780e5d64d7bc312791608db474d1
2019-05-31 16:11:40 -07:00
TreeHugger Robot 061c43eb4f Merge "Fixing overview scrim not initialized properly when launcher starts" into ub-launcher3-qt-dev 2019-05-31 23:01:36 +00:00
Govinda Wasserman c985c6e563 Merge "Adds trigger for new gesture entrypoint to Assistant bundle" into ub-launcher3-qt-dev
am: 164ebb2e8c

Change-Id: I43d6d72765b6d7aa69dce40a3350001a18c6ac63
2019-05-31 11:33:11 -07:00
Govinda Wasserman 164ebb2e8c Merge "Adds trigger for new gesture entrypoint to Assistant bundle" into ub-launcher3-qt-dev 2019-05-31 18:09:53 +00:00
Sunny Goyal 03d32ddb23 Fixing overview scrim not initialized properly when launcher starts
State UI depends on visible content, which can change due to predicitons.
Reapplying the state whenever then happens ensures that we are in correct
start UI

Change-Id: I9f195a92b747fda8a5b217dc960f230d7a695255
2019-05-31 11:00:35 -07:00
Tony Wickham ab384404b1 Merge "Don't recreate the launcher animation controller if gesture ended" into ub-launcher3-qt-dev
am: 8765e262c2

Change-Id: Ieb53126643d9f41a5ba5b85ca0d8b02ef2f6eb47
2019-05-31 10:55:54 -07:00