Commit Graph

6847 Commits

Author SHA1 Message Date
Vinit Nayak 5e27c021ac Check if RemoteAnimationTargets apps are present
* Before the refactor to use RemoteTargetGluer,
we only set the preview if the runningTaskTarget wasn't
null, that check got removed during the refactor.
* Why that check was there to begin with is a bit
of a mystery, sadly

Fixes: 199658495
Change-Id: I053fac0fa0eee0979dff651c01287d04d06298e6
2021-10-28 11:41:43 -07:00
bquezada e12b321d5f Change AppTargetId for launcher events to align with other AppTargetId's.
Bug: 202535375
Test: Manual
Change-Id: I0c28f7f64935fdaf08edb7781e4e7378a068e8e6
2021-10-28 17:52:02 +00:00
Alina Zaidi 3623756dcd Merge "Send widget added and removed events to AiAi." into sc-v2-dev am: 29c3f23be5 am: 5c09d7e4cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16006577

Change-Id: I68a7562ec2dd9ee355dcf5dda10e6481092024df
2021-10-28 17:00:29 +00:00
Alina Zaidi 29c3f23be5 Merge "Send widget added and removed events to AiAi." into sc-v2-dev 2021-10-28 16:45:22 +00:00
TreeHugger Robot 6fef5f8579 Merge "Prevent launching app in split if task split is unsupported" into sc-v2-dev am: ce597d786f am: 9531506a3a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16124504

Change-Id: I08a3f1b2aa478bf1439c67e011f59ac9492517e8
2021-10-28 11:41:25 +00:00
TreeHugger Robot ce597d786f Merge "Prevent launching app in split if task split is unsupported" into sc-v2-dev 2021-10-28 11:19:39 +00:00
Bill Lin 5e203171b9 Merge "Allow One-handed gesture when densityDpi > 600" into sc-v2-dev am: 497d08aa01 am: e3cb7533b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16113733

Change-Id: Iad355a2f94720775ef2b7b5e1542dfa32376ddbc
2021-10-28 03:01:24 +00:00
Bill Lin 497d08aa01 Merge "Allow One-handed gesture when densityDpi > 600" into sc-v2-dev 2021-10-28 02:20:24 +00:00
Tony Wickham 4f91ae9b2b Merge "Fix testStressSwipeToOverview" into sc-v2-dev am: c1cdadf6ea am: 46575af511
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16132969

Change-Id: I3385c009f05ce96990302e7186735ab75e635b56
2021-10-27 22:02:29 +00:00
Schneider Victor-tulias 66b2aa07fd Update the hotseat edu layout for foldable devices. am: 9188b6b993 am: 494de979db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16125840

Change-Id: I3c022d1727679b23d80eb5e158b65b0d900538fe
2021-10-27 22:02:21 +00:00
Tony Wickham c1cdadf6ea Merge "Fix testStressSwipeToOverview" into sc-v2-dev 2021-10-27 21:39:45 +00:00
Tony Wickham ce6bf7dd7f Fix testStressSwipeToOverview
- Finish recents controller to app rather than to launcher, to ensure taskbar state uses in-app configuration
- Also fix an issue when a gesture completes before onLauncherStart, which happens in 3 button mode. The error I saw in the test was:
java.lang.AssertionError: http://go/tapl test failure: Failed to receive an event for the state change: expected [Overview], actual: [Background, Normal];
Context: want to switch from background to overview, clicking Recents button; now visible state is Background
(This also accurately describes what I saw on the device, where the LauncherState went to Normal but the task was still running in the live tile)

Test: testStressSwipeToOverview
Fixes: 203577620
Change-Id: I19616f7921c9821f1b45a90a3e4bec4fb3b8a9d3
2021-10-27 12:35:31 -07:00
TreeHugger Robot 90db092f3e Merge "Add mock animated taskbar to gesture nav tutorial for foldable devices." into sc-v2-dev am: 3edb8de094 am: 19fbe33337
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15954044

Change-Id: Ida8d9d27084f85271f51d71f6a23c75c0cf8407a
2021-10-27 18:20:41 +00:00
Schneider Victor-tulias 9188b6b993 Update the hotseat edu layout for foldable devices.
Test: ran the hotseat edu on folded and unfolded foldable device in portrait and landscape mode and in three-button and gesture nav mode. ran hotseat edu on regular phone
Fixes: 203734732
Change-Id: Iea2140c8241cdea60cb5db37fbfb7f7701d63bd6
2021-10-27 17:48:46 +00:00
TreeHugger Robot 3edb8de094 Merge "Add mock animated taskbar to gesture nav tutorial for foldable devices." into sc-v2-dev 2021-10-27 17:45:38 +00:00
Tracy Zhou 387c3fb2c8 Merge "Delete TaskbarStateHander" into sc-v2-dev am: c6bdd9243a am: 6b9f78e34a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16124697

Change-Id: I2b90d34e7d6ac375c67810784999969d4973a385
2021-10-27 02:48:00 +00:00
Tracy Zhou c6bdd9243a Merge "Delete TaskbarStateHander" into sc-v2-dev 2021-10-27 02:11:12 +00:00
Pablo Gamito dbf20d09bd Merge "Set custom task transition spec when taskbar is visible" into sc-v2-dev am: aae8a2a2a5 am: 75a4280b49
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15972977

Change-Id: I4475a1661a2abeee5a0dac5de29667c8f34b78e5
2021-10-26 22:25:39 +00:00
Pablo Gamito aae8a2a2a5 Merge "Set custom task transition spec when taskbar is visible" into sc-v2-dev 2021-10-26 21:32:16 +00:00
TreeHugger Robot 6f758ff59f Merge "Using a different transition for All-set activity" into sc-v2-dev am: 3cbee2d1d7 am: ebe19c9517
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15960463

Change-Id: Iac047c8ac675ad5cae9213e53e5a907e327f89a5
2021-10-26 20:40:05 +00:00
Tracy Zhou 72f1afcf02 Delete TaskbarStateHander
Bug: 204220602
Test: N/A
Change-Id: I6c26b4d3b8acb35750be56986555350e84f31ecb
2021-10-26 13:26:27 -07:00
TreeHugger Robot 3cbee2d1d7 Merge "Using a different transition for All-set activity" into sc-v2-dev 2021-10-26 20:00:21 +00:00
TreeHugger Robot d16a1ec9fb Merge "Make sure distinct widgets items are used when mapping widget component names to widget items." into sc-v2-dev am: 3bd6b8bf81 am: ddefceae62
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16116819

Change-Id: I9633178a5b1404604cae743b05484bbaed3c26fd
2021-10-26 18:45:38 +00:00
Sunny Goyal eed4bbfb49 Using a different transition for All-set activity
Bug: 201797003
Test: Manual
Change-Id: I33b342ca224ab283e2ac475d4defe2eac6a87bb8
2021-10-26 11:25:32 -07:00
Vinit Nayak 3e9bd87ca9 Prevent launching app in split if task split is unsupported
Bug: 204026157
Change-Id: Ie13ac74e0c1d357db242d49083be97f0f45e6ca5
2021-10-26 11:10:23 -07:00
TreeHugger Robot 3bd6b8bf81 Merge "Make sure distinct widgets items are used when mapping widget component names to widget items." into sc-v2-dev 2021-10-26 18:01:48 +00:00
Pablo Gamito 77d3cab287 Set custom task transition spec when taskbar is visible
This is to ensure that the task to task animations look good when the
taskbar is visible (the transition background is the same as the taskbar
color, the taskbar overlay rounded corners are hidden, and the task
animates above the taskbar so it's rounded corners are visible during
the animation and not hidden behind the taskbar).

Test: Open tasks from other tasks to trigger task to task animations and
see if they look good
Bug: 200675009
Bug: 196387647

Change-Id: I8e46718829c0e6541a5c1b1a3a156285aeecd30a
2021-10-26 14:56:27 +02:00
Alina Zaidi 987221a1cc Send widget added and removed events to AiAi.
-Pass the widgets on workspace as an extra List<AppTargetEvents> while
 creating prediction session.
-Notify the session about widget added/removed events after creation.

Bug: 186648032
Test: Manually checked events are received
Change-Id: I4de6c011a1e24c129a3e995ddba16bfc55074939
2021-10-26 12:29:48 +01:00
Tony Wickham 5a2f61da23 Merge "Hide taskbar background when notification shade is expanded" into sc-v2-dev am: add188f339 am: d6123537c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16102657

Change-Id: I68306fb21825ab94cd8aa46b35ffb0e49bc5a6ac
2021-10-26 03:21:00 +00:00
Tony Wickham add188f339 Merge "Hide taskbar background when notification shade is expanded" into sc-v2-dev 2021-10-26 02:56:47 +00:00
TreeHugger Robot 17f5239620 Merge "Fix launching window bounds for immersive apps" into sc-v2-dev am: c6649763a7 am: d9a4c9b03f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16049085

Change-Id: Ia29cf8a50e9152dbef024b307cb0c2ee5fe0579b
2021-10-25 23:54:42 +00:00
TreeHugger Robot c6649763a7 Merge "Fix launching window bounds for immersive apps" into sc-v2-dev 2021-10-25 23:20:47 +00:00
Tony Wickham 232e9a4631 Hide taskbar background when notification shade is expanded
- In 3 button mode, don't hide the background but do ensure nav buttons are translated down when swiping to notificaitons from the home screen

Test: swipe down notifications, background hides in 0 button mode but not in 3 button mode
Fixes: 199163951
Change-Id: Ic70adc7d67b2ab7c92a2d5d846b9b259d1bd7bfc
2021-10-25 13:44:09 -07:00
Alex Chau 948d9fb223 Fix TaskView jumping caused by split select am: 39da1f78da am: 6b465023e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16095449

Change-Id: I2c0075c9228de998f8bd97492924663a5c662649
2021-10-25 18:03:00 +00:00
Alina Zaidi fa37c6742e Make sure distinct widgets items are used when mapping widget component
names to widget items.

This is to prevent a crash on duplicate key when creating map.

Bug: 204065759
Test: Enabled flag and got no crash
Change-Id: Ice9f93af76c02eeba53c934687358ed806c60b60
2021-10-25 16:10:45 +01:00
Alex Chau 39da1f78da Fix TaskView jumping caused by split select
- Never apply split select translation to grid overview, instead use dismiss translation to make space to split placeholder to minimize motion and avoid janky double movement
- Ensures snapping to last task for end of grid split cases
- Adjust mCurrentPageScrollDiff due to coordinate shift
- Use longGridRowWidthDiff to shift all task to make space for split placeholder
- Also fixed a bug that split translation isn't reset if entering overview immediately after exit

Bug: 200537815
Test: manual
Change-Id: Ie1b57c34ce4bb079f898ba5b7c3464a714021847
2021-10-25 15:38:34 +01:00
Bill Lin 2745327c5e Allow One-handed gesture when densityDpi > 600
This logic was aim to prevent tablet device enable One-handed gesture
so added displayInfo.densityDpi < DisplayMetrics.DENSITY_600 before.

However, it seems this densityDpi=600 does not able to represent to
tablet device, instead we already have system property
"ro.support_one_handed_mode" which provides feasibility to config false
on tablet project, as the reason we can safe to remove this condition.

Bug: 203936659
Test: adb shell wm density 600 , and observe OHM gesture is available
Test: atest WMShellUnitTests
Change-Id: Ic7ae10e8a47d26b9bb39ab80e22d591d74f89ae5
2021-10-25 06:47:13 +00:00
TreeHugger Robot 24191683bb Merge changes Id9fdcd71,Ic4d69d73 into sc-v2-dev am: b4ce5c1b36 am: 9b884ee9b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16092005

Change-Id: I4d9bdd14b8f30a3b869d6b07b8e44d776ccb67f0
2021-10-21 20:28:53 +00:00
Tony Wickham 3f6e3f0650 Stash taskbar in fallback recents
Test: Swipe to Overview with 3P launcher as default, watch taskbar stash
Fixes: 188790554
Change-Id: Id9fdcd715fc50872e3a96f102053a9a99859b482
2021-10-21 10:53:48 -07:00
Tony Wickham 8791e7de11 Add FallbackTaskbarUIController
- Refactor TaskbarManager to accept StatefulActivity instead of BaseQuickstepLauncher
- Update the new StatefulActivity in onOverviewTargetChange()
- Cleanup LauncherTaskbarUIController a bit to avoid initializing TaskbarActivityContext, TaskbarDragLayer, and TaskbarViewController in the constructor, and instead get these from mControllers after init()

Test: No change in behavior
Bug: 188790554
Change-Id: Ic4d69d73deb6dada416876eb265db57803c3adfd
2021-10-21 10:53:46 -07:00
TreeHugger Robot e864cb28d1 Merge "Update TaskView corner radius as RecentsView scale changes" into sc-v2-dev am: d238074c39 am: a41dbd3204
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16101499

Change-Id: Ia3e15aab8905ec0d05284b4de072ee00f95f18da
2021-10-21 15:40:01 +00:00
TreeHugger Robot d238074c39 Merge "Update TaskView corner radius as RecentsView scale changes" into sc-v2-dev 2021-10-21 15:12:16 +00:00
Alex Chau 3c6795e355 Update TaskView corner radius as RecentsView scale changes
Fix: 192253697
Test: manual
Change-Id: I45825c955b759163792d704408e348c198830fc8
2021-10-21 14:23:11 +01:00
Nick Chameyev d3d43cc392 Merge "Do not animate statusbar unfold when in portrait orientation" into sc-v2-dev am: 8523412470 am: 9790455748
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16057110

Change-Id: Ieee1d02232f6b6b7588e51b68ad02a16e90b4115
2021-10-21 10:24:01 +00:00
Nick Chameyev 8523412470 Merge "Do not animate statusbar unfold when in portrait orientation" into sc-v2-dev 2021-10-21 10:02:00 +00:00
TreeHugger Robot f0c43eac90 Merge "Cache TISBinder for multiple onBind() calls" into sc-v2-dev am: 6409130f29 am: a62931ebb4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16093822

Change-Id: I3f63577fe88715e33634ed656d8c21a1d50b4242
2021-10-20 23:59:07 +00:00
TreeHugger Robot 6409130f29 Merge "Cache TISBinder for multiple onBind() calls" into sc-v2-dev 2021-10-20 23:34:49 +00:00
Schneider Victor-tulias e61fd5f316 Add mock animated taskbar to gesture nav tutorial for foldable devices.
Bug: 198434693
Test: launched and completed tutorial on regular phone and foldable device.
Change-Id: Id378e9bdd21fdfbc880ef528cb040b6390699d43
2021-10-20 16:16:10 -07:00
Vinit Nayak 45fbe5b563 Cache TISBinder for multiple onBind() calls
Bug: 202986128
Change-Id: I29a0963ff2880c9970859bc1437c7624bc7f0aea
2021-10-20 13:51:40 -07:00
Schneider Victor-tulias c1a99b8712 Merge "Generalize the icon popup menu types." into sc-v2-dev am: e9bd364390 am: e650a048fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16065857

Change-Id: Ibef5acdb235ff1b0f30dd18e90330584ec037fa1
2021-10-20 19:23:18 +00:00