Commit Graph

6847 Commits

Author SHA1 Message Date
Winson Chung 4485125350 Merge "Fix NPE from null thumbnail data when canceling recents animation" into sc-v2-dev am: eb4b2d0147 am: 401558e396
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16333426

Change-Id: Ib2a7deeb645ab059c035e61ccceea30d0b22fbcc
2021-12-02 20:18:25 +00:00
Tony Wickham 34a5ec9f1c Merge "Remove TaskbarLauncherStateController#setIconAlpha()" into sc-v2-dev am: 3d2a1a7368 am: a14fd14c65
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16374169

Change-Id: Id60002f4dc45aff2c6a721ae0c8a480d32a228e4
2021-12-02 19:02:43 +00:00
Winson Chung eb4b2d0147 Merge "Fix NPE from null thumbnail data when canceling recents animation" into sc-v2-dev 2021-12-02 19:01:40 +00:00
Tony Wickham 3d2a1a7368 Merge "Remove TaskbarLauncherStateController#setIconAlpha()" into sc-v2-dev 2021-12-02 17:39:08 +00:00
Nick Chameyev 4283c6bc05 Do not animate QSB and hotseat when portrait am: c5d3a0d891 am: fc73f74271
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16343607

Change-Id: I0efa62d2047a287bcc35c182f12361b8ce46dd91
2021-12-02 17:12:09 +00:00
Nick Chameyev c5d3a0d891 Do not animate QSB and hotseat when portrait
Disables fold/unfold animation for QSB and hotseat
icons when in portrait orientation. Launcher workspace
icons and widgets are still animated intentionally.
Reuses NaturalOrientationRotationProvider which is currently
used to disable fold/unfold animation in the status bar when
in non-natural orientation.

Bug: 201518277
Test: fold/unfold on launcher in landscape =>
 QSB and hotseat animated;
 rotate screen during fold/unfold animation =>
 translation reset after rotating to portrait,
 animated after returning to landscape;
 rotate after fold/unfold animation => no changes
Change-Id: I8ed405b09f445f554d7638ab44393c90773e0bb6
2021-12-02 14:39:08 +00:00
Tony Wickham 488bca7934 Remove TaskbarLauncherStateController#setIconAlpha()
Instead use setTaskbarViewVisible directly. Now that we stash when going to overview, we shouldn't have any launcher state where we need to fade out TaskbarView icons

Test: quick switch from home (follow up CL)
Bug: 194728611
Change-Id: I03e1fa4037b7e8a08494f6b7e065d144c4bc4e1b
2021-12-01 15:27:44 -08:00
Vinit Nayak 455197bf41 Add icons for staged split
Fixes: 208649953
Change-Id: I8b7bb3a650e836608ebe6aa50631026f5f6a7c63
2021-12-01 14:58:53 -08:00
TreeHugger Robot eba2a6aa8a Merge "Animate right icon of app pair" into sc-v2-dev am: 2bede2dbf2 am: 64b80cb75d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16371722

Change-Id: I336948ccd6ada2c96a12d5deb9213e740595c6de
2021-12-01 20:47:12 +00:00
TreeHugger Robot b7323164bf Merge "Apply/reset split scroll offset regardless of previous state" into sc-v2-dev am: 87f010f3bd am: 8c427dd750
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16371720

Change-Id: Ia04b10a8fc9e55ca46bb80bdacd38b458b84b2e8
2021-12-01 20:41:24 +00:00
TreeHugger Robot 2bede2dbf2 Merge "Animate right icon of app pair" into sc-v2-dev 2021-12-01 20:06:56 +00:00
TreeHugger Robot 87f010f3bd Merge "Apply/reset split scroll offset regardless of previous state" into sc-v2-dev 2021-12-01 19:34:51 +00:00
Schneider Victor-tulias 63a061fff3 Merge "Implement AccessibilityDelegateImpl for the Taskbar" 2021-12-01 19:33:06 +00:00
TreeHugger Robot cdeb234b5b Merge "Removed onBackPressed handling in SplitSCreenSelectState" into sc-v2-dev am: e7e3d6ad31 am: 3c519248b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16371718

Change-Id: Iebe599ce37b3d8f101fc14f284c4886d98d0ead7
2021-12-01 18:49:09 +00:00
TreeHugger Robot e7e3d6ad31 Merge "Removed onBackPressed handling in SplitSCreenSelectState" into sc-v2-dev 2021-12-01 18:21:05 +00:00
Alex Chau e81af3570b Animate right icon of app pair
Fix: 208647365
Test: Swipe up and observe right icon of app pair
Change-Id: I37a716c156d64c312d132bea80540ce922f3f709
2021-12-01 17:45:08 +00:00
Alex Chau 4536c2fc30 Apply/reset split scroll offset regardless of previous state
- Also do the same in setState without animation

Fix: 208605204
Test: Exit split screen and enter overview
Change-Id: I34dd102527dffa90925b6f0fd22465f1fe6e819c
2021-12-01 17:23:46 +00:00
Vinit Nayak 7834925992 Merge "Treat RTL split placeholder animation same as LTR" into sc-v2-dev am: b15d3cfe73 am: 298ebbef7c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16368980

Change-Id: I128a586d65d5564bd066a705f395ee9f4624eaf8
2021-12-01 16:38:23 +00:00
Alex Chau a307492525 Removed onBackPressed handling in SplitSCreenSelectState
- So it'll have exact same behavior as OverviewState to exit overview when going back
- Also removed RecentsView.cancelSplitSelect as it's longer needed

Fix: 181707736
Test: manual
Change-Id: Ide4dfc64680ecc9adfe245ae2de1463735b0490e
2021-12-01 16:24:10 +00:00
Vinit Nayak b15d3cfe73 Merge "Treat RTL split placeholder animation same as LTR" into sc-v2-dev 2021-12-01 16:01:36 +00:00
Fedor Kudasov d6a28fe202 Merge "Separate getTaskViewAt usage" into sc-v2-dev 2021-12-01 10:08:06 +00:00
wilsonshih aa79e68759 Fixes BinderTests when enable shell transition.
Post startActivity to UI_HELPER_EXECUTOR
There will do Resumed the launcher's activity when goes to Overview,
skip the isStarted != isResumed check while shell transition is enabled

Bug: 207297486
Test: atest BinderTests
Change-Id: Id3220b89bfac212062f389879549627a88d93a04
2021-12-01 17:52:01 +08:00
TreeHugger Robot 8bc0314ab4 Merge "Schedule OverviewCommandHelper callbacks for GroupedTaskView" into sc-v2-dev am: f7518d42eb am: 89fe31ef0e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16346762

Change-Id: I5e737afc44e1ae398b82f3dfb4799934b3fa5697
2021-12-01 07:03:08 +00:00
Schneider Victor-tulias a3fe68dcb1 Implement AccessibilityDelegateImpl for the Taskbar
- Added accessibility actions to open pop up menu
- Added accessibility actions to open an app/shortcut to the top/left or bottom/right

Fixes: 204453506
Bug: 198438631
Test: attempted all actions individually, attempted combinations of actions (eg. open pop up menu -> move to left/right)
Change-Id: I76a4237035a0ebfe88b8b5f147b574bb2629f20c
2021-11-30 23:02:55 -08:00
TreeHugger Robot f7518d42eb Merge "Schedule OverviewCommandHelper callbacks for GroupedTaskView" into sc-v2-dev 2021-12-01 06:35:35 +00:00
Vinit Nayak 1144fa8c3d Merge "Add task unpinning support for 3 button taskbar" into sc-v2-dev am: f198f6e492 am: b3f069e06c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16339859

Change-Id: Ifb1a086f3a93f14ee7a8889c110b991c7b7701d9
2021-12-01 05:06:34 +00:00
Vinit Nayak f198f6e492 Merge "Add task unpinning support for 3 button taskbar" into sc-v2-dev 2021-12-01 04:34:06 +00:00
Vinit Nayak 09a822a6fe Schedule OverviewCommandHelper callbacks for GroupedTaskView
* Schedule runnables to clear pending queue in
OverviewCommandHelper similar to how TaskView does it.
* End callbacks get run when recents animation finishes in
RecentsView in the case of live tile when recents animation
is still running
OR
in directly when the split remote animation finishes

Bug: 207845542
Change-Id: I7e858ce55b08cde6436d44f2e857e28b73458f0b
2021-11-30 20:18:50 -08:00
Vinit Nayak b997930afc Treat RTL split placeholder animation same as LTR
* Since we're doing all transformations in screen
coordinates we don't need to account for RTL.

Bug: 202156862
Change-Id: Ibcbf698dbc5b8fabf2647949de6d2718937832d5
2021-11-30 19:58:00 -08:00
Vinit Nayak 570653346f Add task unpinning support for 3 button taskbar
Bug: 199544447
Test: Tested on small and large screen
Change-Id: Ib7785992ef11825cd07a929e2cb623d02ef246f1
2021-11-30 17:18:09 -08:00
TreeHugger Robot cc5f08b080 Merge "Fix potential memory leak by setting mControllers = null" into sc-v2-dev am: 96f3f2214c am: e9dcc967cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16367281

Change-Id: I0df1213a585102c484e1456cdf21c8a017d76189
2021-12-01 00:55:30 +00:00
Jon Miranda 5040335e35 Remove keepWindowOpaque and have the window always fade out.
We built this method so that the window would have
something to fade out on top of. But with longer icon loading times,
this causes a buggy experience since the window is opaque
for the entire duration of the animation.

Having the window always fade out is a better UX for now.
Next step is to always init the FloatingIconView with the
in-memory icon, and then possibly caching both layers
of AdaptiveIcon.

Test: restart phone, swipe up to home
      restart phone, back swipe to home (This flow never called keepWindowOpaque)
Bug: 207389002

Change-Id: Ida64829c60881786ed91e8641cdf7a278b37e201
2021-11-30 16:55:07 -08:00
Jerry Chang 319e2a3eee Merge "Remove stage type from split screen APIs" into sc-v2-dev am: 36eb818600 am: b1b74d4f63
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16362386

Change-Id: Idbdf735630347e8b181cf567f58dc2ab1f92cca5
2021-12-01 00:54:41 +00:00
TreeHugger Robot 96f3f2214c Merge "Fix potential memory leak by setting mControllers = null" into sc-v2-dev 2021-12-01 00:49:56 +00:00
Jerry Chang 36eb818600 Merge "Remove stage type from split screen APIs" into sc-v2-dev 2021-12-01 00:41:10 +00:00
Tracy Zhou d1f9fde371 Merge "[DO NOT MERGE] Make the cutout slightly smaller" into sc-v2-dev 2021-12-01 00:34:00 +00:00
Vinit Nayak 6e906f3436 Align OverviewActionsView for 3 button taskbar
Bug: 189807374
Change-Id: I3c7ec5f8c7b588032ff83ca7ab461d2aac7bfa35
2021-11-30 16:24:12 -08:00
TreeHugger Robot d55644d3af Merge "Add shortcut drag/drop support to the taskbar." 2021-12-01 00:17:59 +00:00
TreeHugger Robot 6269a7aedb Merge "Refactor LauncherAccessibilityDelegate so it can be used outside of Launcher" 2021-11-30 23:29:43 +00:00
Tony Wickham f6c28a4381 Fix potential memory leak by setting mControllers = null
Test: N/A
Bug: 202511986
Change-Id: Iad7cc89e0e68ce09ebe4ca3ab89392b50b6a82c7
2021-11-30 14:37:36 -08:00
Schneider Victor-tulias 5e91cbe069 Add shortcut drag/drop support to the taskbar.
- Added support for shortcut drag/drop
- Added support for popup menu shortcut drag/drop

Test: long pressed taskbar and launcher icons. long pressed taskbar and launcher shortcuts and popup menu shortcuts.
Fixes: 204453506
Bug: 198438631
Change-Id: I09cab335dcbb3a2bfa3020b21f4bcffff9c53e61
2021-11-30 13:52:55 -08:00
TreeHugger Robot ab6732640c Merge "Possible fix for NullPointerException b/206040100." into sc-v2-dev am: b78cbf29e5 am: 7684d31b8e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16331687

Change-Id: I0f0f5a6fbcb1731c1d2eb1f3d7aef8317bac1430
2021-11-30 20:46:50 +00:00
Schneider Victor-tulias c817dac4cd Merge ag/16307859 into master without bug fix.
- Copied ag/16307859, with a modification to QuickstepModelDelegate#getContainer. This allows the crash from b/173838775 to continue occuring with additional debuging logs.

Bug: 173838775
Test: manual
Change-Id: Ic96a25665457c80f5c9ab45a896fada34a3a68ff
2021-11-30 12:08:23 -08:00
TreeHugger Robot b78cbf29e5 Merge "Possible fix for NullPointerException b/206040100." into sc-v2-dev 2021-11-30 19:58:24 +00:00
TreeHugger Robot 2fd047f193 Merge "Close task menu scrim when pressing home button" into sc-v2-dev am: 2280f3d5fc am: a9e6748ea4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16365179

Change-Id: I63dea1516d6853ddc9d9ee0ebd343f1bbed6dfdf
2021-11-30 19:35:10 +00:00
Sebastian Franco 8afeba605a Possible fix for NullPointerException b/206040100.
There is a NullPointerException when trying to get the
length of the array.

Test: Manually tested
Fix: 206040100
Change-Id: I69a03fd3658094655eaf97fa21039fd373ee37d5
2021-11-30 10:09:02 -06:00
Alex Chau a8fc7e03fd Close task menu scrim when pressing home button
- Generally close all floating view when starting home from Recents

Bug: 193432925
Test: with 3 button, open task menu, then press home
Change-Id: Ic99c50333c797f222fc8e682fd0f3fcc4d641d47
2021-11-30 14:27:36 +00:00
Jerry Chang 8176366f54 Remove stage type from split screen APIs
Bug: 198438631
Test: manual check
Change-Id: Ic4f41e39013e4d49585da4cda9b28151c549357a
2021-11-30 17:15:40 +08:00
Tracy Zhou 755b0e30d7 Merge "Reset live tile params along with resetTaskVisuals" into sc-v2-dev am: 260b90c7ad am: 2862aecc40
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16360392

Change-Id: I1e500d12e536fcf00eb7ad746e30e5e8fd75ecc9
2021-11-30 05:13:23 +00:00
Tracy Zhou 260b90c7ad Merge "Reset live tile params along with resetTaskVisuals" into sc-v2-dev 2021-11-30 04:41:40 +00:00